[Bug 31965] New: Put OpenID discovery doc URL in a system preference
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31965 Bug ID: 31965 Summary: Put OpenID discovery doc URL in a system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: dpavlin@rot13.org Theoretically we could authenticate with OpenID Connect and any other identity provider than Google using the existing googleopenidconnect script, this would be helped if the discovery doc URL could be provided with a system preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31965 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31965 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- I think that the community are planning to replace this functionality soon with Bug 31378. I'm not a fan of the googleopenidconnect script myself (for lots of reasons), but I suppose there is no harm in updating it. You'd need to add a system preference for the "issuer" as well, and to rewrite with a patch or with JS anything in the OPAC that says Google I suppose... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31965 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31378 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31965 --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Thanks David, I wasn't aware of Bug 31378. I do know that $issuer needs a system preference too, I was going to do that separately. We have a partner library that needs to use OpenID Connect with Azure so perhaps this could be the interim fix while Bug 31378 gets over the line? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31965 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to Aleisha Amohia from comment #2)
Thanks David, I wasn't aware of Bug 31378.
I do know that $issuer needs a system preference too, I was going to do that separately.
We have a partner library that needs to use OpenID Connect with Azure so perhaps this could be the interim fix while Bug 31378 gets over the line?
I suppose that's up to the RM, so best to send him an email. If he's OK with it, I could QA it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31965 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Aleisha Amohia <aleisha@catalyst.net.nz> --- If Bug 31378 isn't far away I will wait for that and help you on that ticket. If we can't get that into Koha 22.11 then I'll revisit this. *** This bug has been marked as a duplicate of bug 31378 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31965 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Aleisha Amohia from comment #4)
If Bug 31378 isn't far away I will wait for that and help you on that ticket.
If we can't get that into Koha 22.11 then I'll revisit this.
Sounds like a plan to me. At the moment, I'm waiting on updated patches from Agustin. Hoping that he provides something ASAP, as I'm keen to see this get in. (I wrote a local generic OIDC client back in 2014 which I've carried all these years. If Bug 31378 doesn't get in, I'll just keep using it. That said, I have been thinking about implementing it as a Koha plugin. I wasn't planning on working on that until Feb/March 2023, but perhaps I could move up my schedule on that...) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31965 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #5)
(I wrote a local generic OIDC client back in 2014 which I've carried all these years. If Bug 31378 doesn't get in, I'll just keep using it. That said, I have been thinking about implementing it as a Koha plugin. I wasn't planning on working on that until Feb/March 2023, but perhaps I could move up my schedule on that...)
The one thing a Koha plugin can't do is an OIDC logout, but I don't think the googleopenidconnect can handle that either anyway. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org