[Bug 17909] New: Add unit tests for authority merge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Bug ID: 17909 Summary: Add unit tests for authority merge Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt@gmail.com Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17908 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17908 [Bug 17908] Authority merge omnibus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli@cineca.it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59005&action=edit Bug 17909: Add unit tests for C4::AuthoritiesMarc::merge Original patch from Julian Maurice on bug 11700. With sign offs by: Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Amended by Marcel de Rooy on report 17909. EDIT (January 2017): Removed some tests not related to merge. Put remaining tests in a subtest, made them working on current merge. Slightly revised the mocking. Note: I plan to move the zebra retrieval stuff outside merge in one of the next stages, and replace it by calling Koha::SearchEngine. This will reduce mocking complexity here. Test plan: Just run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59006&action=edit Bug 17909: Adding tests from bug 11315 Based on original patch from Maxime Beaulieu on bug 11315. Amended by Marcel de Rooy on report 17909. EDIT: Original tests have been adjusted in view of: [1] Test on bug 11315 heavily leaned on DBD::Mock. Since we are using Test::DBIx::Class on such tests now, this would need attention. Moreover, the advantage of mocking the database in this case is at least arguable. [2] Matching the first (somewhat older) subtest of 11700. [3] Simplification and readability. Look e.g. at the use of $MARCto and $MARCfrom on 11315. This made me merge them in the db_dependent counterpart. Also note that this subtest adds another needed test case: the merge from auth1 to modified auth1, while 11700 tested auth1 to auth2. Test plan: Just run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59007&action=edit Bug 17909: Add tests for merging with another authtype Originally aimed for bug 9988. Adjusted in line with other subtests. Will polish the three subtests a little more on a follow-up. Test plan: Run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59008&action=edit Bug 17909: Additional polishing No spectacular things: [1] Move the framework modifications to a sub. Use same style to create auth types and linked fields. [2] Change some new Object occurrences to Object->new. [3] Add tests for field count and field order in the first two subsets. [4] Few whitespace changes (sorry) and comment lines. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Might be interesting for backporting if we manage to backport the fixes for merge too.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59005|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 59011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59011&action=edit [SIGNED-OFF] Bug 17909: Add unit tests for C4::AuthoritiesMarc::merge Original patch from Julian Maurice on bug 11700. With sign offs by: Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Amended by Marcel de Rooy on report 17909. EDIT (January 2017): Removed some tests not related to merge. Put remaining tests in a subtest, made them working on current merge. Slightly revised the mocking. Note: I plan to move the zebra retrieval stuff outside merge in one of the next stages, and replace it by calling Koha::SearchEngine. This will reduce mocking complexity here. Test plan: Just run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59006|0 |1 is obsolete| | --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 59012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59012&action=edit [SIGNED-OFF] Bug 17909: Adding tests from bug 11315 Based on original patch from Maxime Beaulieu on bug 11315. Amended by Marcel de Rooy on report 17909. EDIT: Original tests have been adjusted in view of: [1] Test on bug 11315 heavily leaned on DBD::Mock. Since we are using Test::DBIx::Class on such tests now, this would need attention. Moreover, the advantage of mocking the database in this case is at least arguable. [2] Matching the first (somewhat older) subtest of 11700. [3] Simplification and readability. Look e.g. at the use of $MARCto and $MARCfrom on 11315. This made me merge them in the db_dependent counterpart. Also note that this subtest adds another needed test case: the merge from auth1 to modified auth1, while 11700 tested auth1 to auth2. Test plan: Just run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59007|0 |1 is obsolete| | --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 59013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59013&action=edit [SIGNED-OFF] Bug 17909: Add tests for merging with another authtype Originally aimed for bug 9988. Adjusted in line with other subtests. Will polish the three subtests a little more on a follow-up. Test plan: Run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59008|0 |1 is obsolete| | --- Comment #9 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 59014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59014&action=edit [SIGNED-OFF] Bug 17909: Additional polishing No spectacular things: [1] Move the framework modifications to a sub. Use same style to create auth types and linked fields. [2] Change some new Object occurrences to Object->new. [3] Add tests for field count and field order in the first two subsets. [4] Few whitespace changes (sorry) and comment lines. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 --- Comment #10 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 59015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59015&action=edit [SIGNED-OFF] Bug 17909: Followup - fix typo Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Thanks Josef for this very fast signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Note for QA: I am adding a linked field 612 as well as 712 on bug 17913 when refining the test on changed order. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Sorry, Josef. But while working on bug 17913 I came across two annoying typos that I want to correct here after all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59077&action=edit Bug 17909: Followup - fix typos Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> EDIT: Adjusted three small typos that did not disturb the test in its current form, but do when we are fixing bugs on bug 17913. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #13)
Sorry, Josef. But while working on bug 17913 I came across two annoying typos that I want to correct here after all.
Even three. Could you repeat your signoff? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59015|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17913 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17913 [Bug 17913] Merge three authority merge fixes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #16 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Marcel de Rooy from comment #15)
(In reply to Marcel de Rooy from comment #13)
Sorry, Josef. But while working on bug 17913 I came across two annoying typos that I want to correct here after all.
Even three. Could you repeat your signoff?
No problem, working on it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59077|0 |1 is obsolete| | --- Comment #17 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 59088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59088&action=edit [SIGNED-OFF] Bug 17909: Followup - fix typos Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> EDIT: Adjusted three small typos that did not disturb the test in its current form, but do when we are fixing bugs on bug 17913. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59323&action=edit Bug 17909: [Follow-up] Quick fix for UNIMARC UNIMARC inserts field 100. This interferes the field count and order in the test. Note: This is a quick fix. Will polish it after bug 17913. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59323|0 |1 is obsolete| | --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 59324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59324&action=edit Bug 17909: [Follow-up] Quick fix for UNIMARC UNIMARC inserts field 100. This interferes the field count and order in the test. Note: This is a quick fix. Will polish it after bug 17913. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59011|0 |1 is obsolete| | --- Comment #20 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 59334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59334&action=edit Bug 17909: Add unit tests for C4::AuthoritiesMarc::merge Original patch from Julian Maurice on bug 11700. With sign offs by: Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Amended by Marcel de Rooy on report 17909. EDIT (January 2017): Removed some tests not related to merge. Put remaining tests in a subtest, made them working on current merge. Slightly revised the mocking. Note: I plan to move the zebra retrieval stuff outside merge in one of the next stages, and replace it by calling Koha::SearchEngine. This will reduce mocking complexity here. Test plan: Just run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59012|0 |1 is obsolete| | --- Comment #21 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 59335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59335&action=edit Bug 17909: Adding tests from bug 11315 Based on original patch from Maxime Beaulieu on bug 11315. Amended by Marcel de Rooy on report 17909. EDIT: Original tests have been adjusted in view of: [1] Test on bug 11315 heavily leaned on DBD::Mock. Since we are using Test::DBIx::Class on such tests now, this would need attention. Moreover, the advantage of mocking the database in this case is at least arguable. [2] Matching the first (somewhat older) subtest of 11700. [3] Simplification and readability. Look e.g. at the use of $MARCto and $MARCfrom on 11315. This made me merge them in the db_dependent counterpart. Also note that this subtest adds another needed test case: the merge from auth1 to modified auth1, while 11700 tested auth1 to auth2. Test plan: Just run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59013|0 |1 is obsolete| | --- Comment #22 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 59336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59336&action=edit Bug 17909: Add tests for merging with another authtype Originally aimed for bug 9988. Adjusted in line with other subtests. Will polish the three subtests a little more on a follow-up. Test plan: Run t/db_dependent/Authorities/Merge.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59014|0 |1 is obsolete| | --- Comment #23 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 59337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59337&action=edit Bug 17909: Additional polishing No spectacular things: [1] Move the framework modifications to a sub. Use same style to create auth types and linked fields. [2] Change some new Object occurrences to Object->new. [3] Add tests for field count and field order in the first two subsets. [4] Few whitespace changes (sorry) and comment lines. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59088|0 |1 is obsolete| | --- Comment #24 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 59338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59338&action=edit Bug 17909: Followup - fix typos Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> EDIT: Adjusted three small typos that did not disturb the test in its current form, but do when we are fixing bugs on bug 17913. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59324|0 |1 is obsolete| | --- Comment #25 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 59339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59339&action=edit Bug 17909: [Follow-up] Quick fix for UNIMARC UNIMARC inserts field 100. This interferes the field count and order in the test. Note: This is a quick fix. Will polish it after bug 17913. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 --- Comment #26 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 59340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59340&action=edit Bug 17909: QA followup: remove unused var and move global var Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |julian.maurice@biblibre.com |y.org | --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Thanks, Julian -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Julian, Maxime, Marcel, Josef! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |katrin.fischer@bsz-bw.de --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These patches have been pushed to 16.11.x and will be in 16.11.02. . -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #30 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.08 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17909 --- Comment #31 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x for 3.22.17 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org