[Bug 20133] New: "Hide patron information" feature should not affect all library groups
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 Bug ID: 20133 Summary: "Hide patron information" feature should not affect all library groups Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: System Administration Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 18403 The feature added by bug 18403 should not apply to all library groups. We should add the ability to enable/disable it only for specific hierarchies. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71156&action=edit Bug 20133: Add new column library_groups.ft_hide_patron_info -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71157&action=edit Bug 20133: DBIC Schema changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71158&action=edit Bug 20133: UI Changes Add a checkbox to enable/disable the feature for given group of libraries. Important note: Only the top level node can turn the feature, the idea is to avoid confusion, ease testing (by limiting the number of cases) and force libraries to define one tree per feature (Maybe this is wrong, but maybe good to start) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 71159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71159&action=edit Bug 20133: Enable/disable the "Hide patron information" feature per group of libraries In order to control this feature correctly it needs to be enabled for group of libraries and not for all groups defined in the system. Groups will be used for different usages and so the feature must not be enabled by default for all of them. Test plan: Retest bug 18403 with the feature turned on/off for a given tree -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71296&action=edit Bug 20133 [QA Followup] - Tweak new 'group features' section -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20157 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20157 [Bug 20157] Use group 'features' to decide which groups to use for group searching functionality -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71156|0 |1 is obsolete| | Attachment #71157|0 |1 is obsolete| | Attachment #71158|0 |1 is obsolete| | Attachment #71159|0 |1 is obsolete| | Attachment #71296|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71368&action=edit Bug 20133: Add new column library_groups.ft_hide_patron_info Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71368|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71369&action=edit Bug 20133: Add new column library_groups.ft_hide_patron_info Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71370&action=edit Bug 20133: DBIC Schema changes Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71371&action=edit Bug 20133: UI Changes Add a checkbox to enable/disable the feature for given group of libraries. Important note: Only the top level node can turn the feature, the idea is to avoid confusion, ease testing (by limiting the number of cases) and force libraries to define one tree per feature (Maybe this is wrong, but maybe good to start) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71372&action=edit Bug 20133: Enable/disable the "Hide patron information" feature per group of libraries In order to control this feature correctly it needs to be enabled for group of libraries and not for all groups defined in the system. Groups will be used for different usages and so the feature must not be enabled by default for all of them. Test plan: Retest bug 18403 with the feature turned on/off for a given tree Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 71373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71373&action=edit Bug 20133 [QA Followup] - Tweak new 'group features' section Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am going to push this change along with bug 18403. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 Bug 20133 depends on bug 18403, which changed state. Bug 18403 Summary: Hide patron information if not part of the logged in user library group https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20133 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |nick@bywatersolutions.com Status|Pushed to Master |RESOLVED --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Enhancement, not backported to stable. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org