[Bug 40836] New: Credit and debit types are not shown in patron account on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40836 Bug ID: 40836 Summary: Credit and debit types are not shown in patron account on OPAC Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Blocks: 40256 In the patron account on the OPAC, the Type column is meant to show the description value for the associated credit or debit type (account_credit_types.description or account_debit_types.description). But the Type column is empty for any credit or debit type that's defined locally. All of the system-defined credit and debit types have this value hardcoded in the accounts.inc file, rather than actually fetching the value from the database. To recreate: - create a credit type that can be applied manually - create a debit type that can be applied manually - apply both a credit and debit to your patron (make sure auto-reconcile is off) - look at your patron's account in the staff interface, see values in the "account type" column - look at your patron's account in the OPAC, see the "Type" column is blank Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40256 [Bug 40256] System defined MANUAL debit type description is hard coded but the description can be changed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40836 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40836 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40836 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 189349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189349&action=edit Bug 40836: OPAC Type column should show local debit/credit type descriptions To test: 1. create a credit type that can be applied manually 2. create a debit type that can be applied manually 3. apply both a credit and debit to your patron (make sure auto-reconcile is off) 4. look at your patron's account in the staff interface, see values in the "account type" column 5. look at your patron's account in the OPAC, see the "Type" column is blank 6. Apply the patch - restart_all 7. Refresh the patron’s account in the OPAC — clear browser cache if necessary. The Type columns should now be populated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40836 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |Laura.escamilla@bywatersolu | |tions.com CC| |Laura.escamilla@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40836 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189349|0 |1 is obsolete| | --- Comment #2 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Created attachment 189366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189366&action=edit Bug 40836: OPAC Type column should show local debit/credit type descriptions To test: 1. create a credit type that can be applied manually 2. create a debit type that can be applied manually 3. apply both a credit and debit to your patron (make sure auto-reconcile is off) 4. look at your patron's account in the staff interface, see values in the "account type" column 5. look at your patron's account in the OPAC, see the "Type" column is blank 6. Apply the patch - restart_all 7. Refresh the patron’s account in the OPAC — clear browser cache if necessary. The Type columns should now be populated. Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40836 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |cj.lynce@westlakelibrary.or | |g --- Comment #3 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Patch works to restore show of custom defined credit and debit types in the OPAC interface. No issues testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40836 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliothek@th-wildau.de QA Contact|testopia@bugs.koha-communit |bibliothek@th-wildau.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40836 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40836 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189366|0 |1 is obsolete| | --- Comment #4 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 189672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189672&action=edit Bug 40836: OPAC Type column should show local debit/credit type descriptions To test: 1. create a credit type that can be applied manually 2. create a debit type that can be applied manually 3. apply both a credit and debit to your patron (make sure auto-reconcile is off) 4. look at your patron's account in the staff interface, see values in the "account type" column 5. look at your patron's account in the OPAC, see the "Type" column is blank 6. Apply the patch - restart_all 7. Refresh the patron’s account in the OPAC — clear browser cache if necessary. The Type columns should now be populated. Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40836 --- Comment #5 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 189673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189673&action=edit Bug 40836: (QA follow-up) Reduce params Reduce params given to process method. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40836 --- Comment #6 from Jan Kissig <bibliothek@th-wildau.de> --- Everything worked as described. I removed debit_type_code and credit_type_code from the params as they are part of account. And I forgot to put my sign off under the patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40836 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40836 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40836 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40836 --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40836 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00,25.05.06 |25.11.00,25.05.06,24.11.11 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40836 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #10 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org