[Bug 41199] New: Advanced Search fields could use more visible label options
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41199 Bug ID: 41199 Summary: Advanced Search fields could use more visible label options Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Accessibility Assignee: koha-bugs@lists.koha-community.org Reporter: jake.deery@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@openfifth.co.uk, matt.blenkinsop@openfifth.co.uk, oleonard@myacpl.org The advanced search & search masthead could both do with more visible labels. This aids users in navigating the system, and also helps to provide screen readers with more context about an input field. We should offer a syspref that controls the number of visible labels, so libraries can have greater control over the extent of these labels. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41199 --- Comment #1 from Jake Deery <jake.deery@openfifth.co.uk> --- Created attachment 189147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189147&action=edit Bug 41199: Add optional labels to search fields This patch adds the OPACShowLabelsForSearchInputs, which, when enabled, will add numerous additional labels to the OPAC's advanced search and masthead search regions. When disabled, this syspref will exhibit the same behaviour we see now. == TO TEST == a) visually look at the OPAC's mainpage, and advanced search page *) notice the input fields lack visual labels == APPLY PATCH == b) repeat step a) *) observe how nothing has visually changed c) set the OPACShowLabelsForSearchInputs syspref to Show d) repeat step a) again *) notice how there are now visual labels associated with each of the input fields e) revert the OPACShowLabelsForSearchInputs syspref to Don't show f) repeat step a) again *) notice how there are again no visual labels == SIGN OFF == -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41199 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41199 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41199 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jake.deery@openfifth.co.uk |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41199 Irene <i.tortorella@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |i.tortorella@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41199 Ray Delahunty <raymund.delahunty@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |raymund.delahunty@outlook.c | |om --- Comment #2 from Ray Delahunty <raymund.delahunty@outlook.com> --- Created attachment 192523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192523&action=edit On refresh of OPAC advanced search Signoff failed. Patch log file below shows error, and OPAC refresh fails (error trace attached). The new system parameter is present after the patch was applied, set to Don't show. Bug 41199 - Advanced Search fields could use more visible label options 189147 - Bug 41199: Add optional labels to search fields Apply? [(y)es, (n)o, (i)nteractive] Applying: Bug 41199: Add optional labels to search fields Using index info to reconstruct a base tree... M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss M koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc Auto-merging koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss Auto-merging installer/data/mysql/mandatory/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/mandatory/sysprefs.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 41199: Add optional labels to search fields [33mhint: Use 'git am --show-current-patch=diff' to see the failed patch[m When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-41199-Add-optional-labels-to-search-fields-nb2qu_jx.patch DEV atomic update /kohadevbox/koha/installer/data/mysql/atomicupdate/bug_41199_add_labels_to_advsearch.pl [08:53:29]: Bug 41199 - Add a way to enable/disable search input field labels [32mAdded new system preference 'OPACShowLabelsForSearchInputs'[0m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41199 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41199 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189147|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41199 --- Comment #3 from Jake Deery <jake.deery@openfifth.co.uk> --- Created attachment 193628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193628&action=edit Bug 41199: Add optional labels to search fields This patch adds the OPACShowLabelsForSearchInputs, which, when enabled, will add numerous additional labels to the OPAC's advanced search and masthead search regions. When disabled, this syspref will exhibit the same behaviour we see now. == TO TEST == a) visually look at the OPAC's mainpage, and advanced search page *) notice the input fields lack visual labels == APPLY PATCH == b) repeat step a) *) observe how nothing has visually changed c) set the OPACShowLabelsForSearchInputs syspref to Show d) repeat step a) again *) notice how there are now visual labels associated with each of the input fields e) revert the OPACShowLabelsForSearchInputs syspref to Don't show f) repeat step a) again *) notice how there are again no visual labels == SIGN OFF == -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41199 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41199 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41199 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193628|0 |1 is obsolete| | --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 194016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194016&action=edit Bug 41199: Add optional labels to search fields This patch adds the OPACShowLabelsForSearchInputs, which, when enabled, will add numerous additional labels to the OPAC's advanced search and masthead search regions. When disabled, this syspref will exhibit the same behaviour we see now. == TO TEST == a) visually look at the OPAC's mainpage, and advanced search page *) notice the input fields lack visual labels == APPLY PATCH == b) repeat step a) *) observe how nothing has visually changed c) set the OPACShowLabelsForSearchInputs syspref to Show d) repeat step a) again *) notice how there are now visual labels associated with each of the input fields e) revert the OPACShowLabelsForSearchInputs syspref to Don't show f) repeat step a) again *) notice how there are again no visual labels == SIGN OFF == Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41199 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41199 Jake Deery (kwenoch) <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194016|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41199 --- Comment #5 from Jake Deery (kwenoch) <jake.deery@openfifth.co.uk> --- Created attachment 207770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207770&action=edit Bug 41199: Add optional labels to search fields This patch adds the OPACShowLabelsForSearchInputs, which, when enabled, will add numerous additional labels to the OPAC's advanced search and masthead search regions. When disabled, this syspref will exhibit the same behaviour we see now. == TO TEST == a) visually look at the OPAC's mainpage, and advanced search page *) notice the input fields lack visual labels == APPLY PATCH == b) repeat step a) *) observe how nothing has visually changed c) set the OPACShowLabelsForSearchInputs syspref to Show d) repeat step a) again *) notice how there are now visual labels associated with each of the input fields e) revert the OPACShowLabelsForSearchInputs syspref to Don't show f) repeat step a) again *) notice how there are again no visual labels == SIGN OFF == -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41199 Jake Deery (kwenoch) <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207770|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41199 --- Comment #6 from Jake Deery (kwenoch) <jake.deery@openfifth.co.uk> --- Created attachment 207771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207771&action=edit Bug 41199: Add optional labels to search fields This patch adds the OPACShowLabelsForSearchInputs, which, when enabled, will add numerous additional labels to the OPAC's advanced search and masthead search regions. When disabled, this syspref will exhibit the same behaviour we see now. == TO TEST == a) visually look at the OPAC's mainpage, and advanced search page *) notice the input fields lack visual labels == APPLY PATCH == b) repeat step a) *) observe how nothing has visually changed c) set the OPACShowLabelsForSearchInputs syspref to Show d) repeat step a) again *) notice how there are now visual labels associated with each of the input fields e) revert the OPACShowLabelsForSearchInputs syspref to Don't show f) repeat step a) again *) notice how there are again no visual labels == SIGN OFF == Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41199 Jake Deery (kwenoch) <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41199 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41199 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am a bit torn about this patch. For me the additional labels feel a bit too much, which makes me think most libraries would not turn on the pref. But if this is for better accessibility.. shouldn't we make sure people will make use of it? I also wonder about this one: Enter search here In other context WCAG tells us to avoid things like "click here" etc. as it should be obvious that it's an input field already. Could we: - Make the additional labels visible just for screen readers? - Improve on the label formatting maybe? I'd like some more eyes on this. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org