https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15486 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) Translations in mind, I suggest to make the message a bit more specific: Daily limit reached for patron > Daily hold limit reached for patron 2) If nothing is entered, it appears to default to 0 (instead of unlimited). So I think this will break existing installations. I'd suggest to copy the max holds total into max holds daily. 3) The tests are giving me trouble: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Holds.t t/db_dependent/Holds.t .. 26/59 # Looks like you planned 59 tests but ran 56. t/db_dependent/Holds.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 3/59 subtests Test Summary Report ------------------- t/db_dependent/Holds.t (Wstat: 65280 Tests: 56 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 59 tests but ran 56. Files=1, Tests=56, 2 wallclock secs ( 0.02 usr 0.01 sys + 1.70 cusr 0.34 csys = 2.07 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.