[Bug 17691] New: Add serial subscriptions info on vendor profile page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 Bug ID: 17691 Summary: Add serial subscriptions info on vendor profile page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org Discovered when testing 13726 - count of subscriptions passed from supplier.pl to template, but template does not use it. Moreover, it would be useful to have even more information or at least count info + link to subscriptions on vendor profile page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13726 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 [Bug 13726] Koha::Acquisition::Bookseller should use Koha::Object -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It is used in includes/acquisitions-toolbar.inc -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Jonathan Druart from comment #1)
It is used in includes/acquisitions-toolbar.inc
Ah, I see, thanks. But still think that more detailed info about subscriptions could be useful on vendor page... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 Bug 17691 depends on bug 13726, which changed state. Bug 13726 Summary: Koha::Acquisition::Bookseller should use Koha::Object https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 Gracie <grace.mcky@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 --- Comment #3 from Gracie <grace.mcky@gmail.com> --- Created attachment 59137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59137&action=edit Bug 17691 - add serial subscription Adding some subscription information to the vendor page To test - Search for a vendor, access profile - Under Contact, Subscription details -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I really like the idea! Looking at this from the view of translators, I'd like to make a suggestion: + <h2>Subscription Details</h2> + <p><strong>This vender has: </strong>[% subscriptioncount %] + [% IF subscriptioncount == 1 %] subscription [% ELSE %] subscriptions [% END %] + </p> + The h2 is cool, but capitalization should be: Subscription details The paragraph will be turned into 2 strings by the translation tools: - This vendor has - subscription subscriptions (with some additional markup %s in between) Strings show up out of context for translators and in alphabetical order - so that makes it really hard to 'get it right' - depending on the language it's also often hard to predict, what the right sequence of words/grammar should be like. My suggestion would be to make it: Number of subscriptions: [% subscriptioncount %] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 Gracie <grace.mcky@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |grace.mcky@gmail.com Assignee|koha-bugs@lists.koha-commun |grace.mcky@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 Gracie <grace.mcky@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 Gracie <grace.mcky@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59137|0 |1 is obsolete| | --- Comment #5 from Gracie <grace.mcky@gmail.com> --- Created attachment 59139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59139&action=edit Bug 17691 - add serial subscription Adding some subscription information to the vendor page To test - Search for a vendor, access profile - Under Contact, Subscription details -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59139|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 59178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59178&action=edit [SIGNED OFF] Bug 17691 - add serial subscription Adding some subscription information to the vendor page To test - Search for a vendor, access profile - Under Contact, Subscription details Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Fixed a missing </div> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59178|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59244&action=edit Bug 17691 - add serial subscription Adding some subscription information to the vendor page To test - Search for a vendor, access profile - Under Contact, Subscription details Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Fixed a missing </div> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59245&action=edit Bug 17691: Does not repeat "subscriptions" Number of subscriptions: X subscriptions Sound like we repeat "subscriptions" Replaced with Number of subscriptions: X Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Grace! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17691 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org