[Bug 5883] New: UTF-8 characters in items (952) get encoded wrong when the record is modified.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5883 Bug #: 5883 Summary: UTF-8 characters in items (952) get encoded wrong when the record is modified. Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Cataloging AssignedTo: gmcharlt@gmail.com ReportedBy: fcapovilla@live.ca QAContact: koha-bugs@lists.koha-community.org CC: ian.walls@bywatersolutions.com If a record already contains contains items with UTF-8 characters (accented characters for example), those characters become garbled when the record is modified. Example : "méthode" in field 952$3 becomes "méthode" after the record is saved. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5883 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|gmcharlt@gmail.com |fcapovilla@live.ca -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5883 --- Comment #1 from Frédérick Capovilla <fcapovilla@live.ca> 2011-03-21 17:11:31 UTC --- Additionnal informations : The problem seems to happen when the character at offset 17 of the leader is a space. Koha puts a '7' there by default on new records. Example leader where the problem applies : 26489nam a2203769 a 4500 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5883 --- Comment #2 from Frédérick Capovilla <fcapovilla@live.ca> 2011-03-21 18:13:34 UTC --- (In reply to comment #1)
Additionnal informations : The problem seems to happen when the character at offset 17 of the leader is a space. Koha puts a '7' there by default on new records.
Example leader where the problem applies : 26489nam a2203769 a 4500
After doing more tests, it seems the leader isn't the cause of the problem. I found that using accented characters in the record when modifying it can cause the encoding problem on the items. Still investigating... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5883 --- Comment #3 from Frédérick Capovilla <fcapovilla@live.ca> 2011-03-21 18:45:29 UTC --- Created attachment 3384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3384 Prevent re-encoding the items if they are already in UTF-8 in ModBiblio. I think I have found the source of the problem : In ModBiblio, the items were re-encoded in UTF-8 to fix some possible encoding mixing problems, but there was no check to see if the items were already in utf-8 before doing the re-encoding. This might have caused some encoding mixing problems in the case where the record and the item each contained utf-8 characters. Patch attached. Please test. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5883 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5883 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Patch Status|Needs Signoff |Signed Off --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> 2011-03-23 14:19:38 UTC --- Signed off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5883 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Version|rel_3_2 |rel_3_4 Patch Status|Signed Off |Patch Pushed --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> 2011-03-24 00:26:41 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5883 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #6 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-04-01 09:42:30 UTC --- This bug is mentioned in: Bug 5883 : Prevent re-encoding the items if they are already in UTF-8 in ModBiblio. http://lists.koha-community.org/pipermail/koha-patches/2011-March/014204.htm... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5883 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #7 from Frédérick Capovilla <fcapovilla@live.ca> 2011-06-07 18:55:47 UTC --- I think I made a mistake on this patch : Encode::encode DEACTIVATES the utf-8 flag on a string, so checking if the flag is deactivated before doing the Encode::encode doesn't make any sense. I guess the problem was solved on my Koha instances because the re-encoding is never done. Reopening this bug so a good solution to this problem may be found. Maybe remove the subfield re-encoding altogether? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org