[Bug 30731] New: Noise from about script coming from Test::MockTime
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 Bug ID: 30731 Summary: Noise from about script coming from Test::MockTime Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org Run about. CHeck your staff log. [2022/05/11 13:40:29] [WARN] Subroutine CORE::GLOBAL::time redefined at /usr/share/perl5/Test/MockTime.pm line 20, <DATA> line 755. [2022/05/11 13:40:29] [WARN] Prototype mismatch: sub CORE::GLOBAL::time () vs none at /usr/share/perl5/Test/MockTime.pm line 20, <DATA> line 755. [2022/05/11 13:40:29] [WARN] Subroutine CORE::GLOBAL::localtime redefined at /usr/share/perl5/Test/MockTime.pm line 21, <DATA> line 755. [2022/05/11 13:40:29] [WARN] Prototype mismatch: sub CORE::GLOBAL::localtime (;$) vs none at /usr/share/perl5/Test/MockTime.pm line 21, <DATA> line 755. [2022/05/11 13:40:29] [WARN] Subroutine CORE::GLOBAL::gmtime redefined at /usr/share/perl5/Test/MockTime.pm line 22, <DATA> line 755. [2022/05/11 13:40:29] [WARN] Prototype mismatch: sub CORE::GLOBAL::gmtime (;$) vs none at /usr/share/perl5/Test/MockTime.pm line 22, <DATA> line 755. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|About |Architecture, internals, | |and plumbing Severity|minor |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20103 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- The changes from the change of PerlDependencies to cpanfile make the Readonly::XS::MAGIC_COOKIE no longer needed too. See also bug 20103. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 134913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134913&action=edit Bug 30731: Unit tests Installer_pm.t can safely be discarded, having Installer_PerlModules.t. Note: Without the second patch, the test about versions_info being silent might fail. With the second patch, it should pass. Note that since the order of requiring the cpan modules varies (without the second patch), the results (potential warnings) vary too. Test plan: Run t/Installer_PerlModules.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 134914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134914&action=edit Bug 30731: Silence noisy CPAN modules in C4::Installer::PerlModules Main change is replacing 'no warnings' by local $SIG{__WARN__}. The modules are sorted now too. This will make results of requiring them one after the other a more predictable experience and improves the output of koha_perl_deps. Test plan: Run about. Check plack intranet log. Run koha_perl_deps.pl -a Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 134915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134915&action=edit Bug 30731: Remove Readonly::XS::MAGIC_COOKIE This variable does not make sense anymore, since the Readonly::XS module is not listed in the cpanfile. So it will not be required the versions_info loop. Test plan: Run t/Installer_PerlModules.t again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Noise from about script |Noise from about script |coming from Test::MockTime |coming from Test::MockTime | |(or other CPAN modules) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134913|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 134917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134917&action=edit Bug 30731: Unit tests Installer_pm.t can safely be discarded, having Installer_PerlModules.t. Note: Without the second patch, the test about versions_info being silent might fail. With the second patch, it should pass. Note that since the order of requiring the cpan modules varies (without the second patch), the results (potential warnings) vary too. Test plan: Run t/Installer_PerlModules.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134914|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 134918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134918&action=edit Bug 30731: Silence noisy CPAN modules in C4::Installer::PerlModules Main change is replacing 'no warnings' by local $SIG{__WARN__}. The modules are sorted now too. This will make results of requiring them one after the other a more predictable experience and improves the output of koha_perl_deps. Test plan: Run about. Check plack intranet log. Run koha_perl_deps.pl -a Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134915|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 134919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134919&action=edit Bug 30731: Remove Readonly::XS::MAGIC_COOKIE This variable does not make sense anymore, since the Readonly::XS module is not listed in the cpanfile. So it will not be required the versions_info loop. Test plan: Run t/Installer_PerlModules.t again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looking here now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134917|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134960&action=edit Bug 30731: Unit tests Installer_pm.t can safely be discarded, having Installer_PerlModules.t. Note: Without the second patch, the test about versions_info being silent might fail. With the second patch, it should pass. Note that since the order of requiring the cpan modules varies (without the second patch), the results (potential warnings) vary too. Test plan: Run t/Installer_PerlModules.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134918|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134961&action=edit Bug 30731: Silence noisy CPAN modules in C4::Installer::PerlModules Main change is replacing 'no warnings' by local $SIG{__WARN__}. The modules are sorted now too. This will make results of requiring them one after the other a more predictable experience and improves the output of koha_perl_deps. Test plan: Run about. Check plack intranet log. Run koha_perl_deps.pl -a Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134919|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134962&action=edit Bug 30731: Remove Readonly::XS::MAGIC_COOKIE This variable does not make sense anymore, since the Readonly::XS module is not listed in the cpanfile. So it will not be required the versions_info loop. Test plan: Run t/Installer_PerlModules.t again. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Keywords| |rel_21_11_candidate --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- I prefer not to push in this release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_21_11_candidate |rel_22_11_candidate --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Fridolin Somers from comment #12)
I prefer not to push in this release
21.11 => 22.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25515 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 [Bug 25515] [OMNIBUS] Remove warnings and errors from tests output -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master Keywords|rel_22_11_candidate | --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.01 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Pushed to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|22.11.00, 22.05.01 |22.11.00, 22.05.01, released in| |21.11.07 CC| |arthur.suzuki@biblibre.com --- Comment #16 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- thx, pushed to 21.11.x for 21.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |victor@tuxayo.net --- Comment #17 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25515 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 [Bug 25515] [OMNIBUS] Remove warnings and errors from tests output -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30731 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40444 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40444 [Bug 40444] Add a test to ensure all Perl test files use Test::NoWarnings -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org