[Bug 33758] New: Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Bug ID: 33758 Summary: Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs@lists.koha-community.org Reporter: nicolas.giraud@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: caroline.cyr-la-rose@inlibro.com, philippe.blouin@inlibro.com I have one plugin who have to know the biblionumber to add a custom button in the toolbar in the page details.pl But currently, the method is called without parameter so the plugin doesn't know in which biblionumber details page it adds the new button. The parameter allows to create custom with the biblionumber link to the button. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Nicolas Giraud <nicolas.giraud@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nicolas.giraud@inlibro.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Nicolas Giraud <nicolas.giraud@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 --- Comment #1 from Nicolas Giraud <nicolas.giraud@inlibro.com> --- Created attachment 151426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151426&action=edit Bug 33758 - Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook This patch adds a parameter to call the method intranet_catalog_biblio_enhancements_toolbar_button with a biblionumber in the page catalogue/detail.pl. Modification of cat-toolbar.inc to display new buttons correctly. To test : 1. Apply the patch 2. Take a plugin who implements the method intranet_catalog_biblio_enhancements_toolbar_button 3. Check if the parameter "biblionumber" is passed correctly at this method 4. Create the new button in HTML in the plugin method (button must be like the ones that are in the toolbar of the page detail.pl) 5. Go to the page in browser and check if the new button is displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Nicolas Giraud <nicolas.giraud@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Nicolas Giraud <nicolas.giraud@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 --- Comment #2 from Nicolas Giraud <nicolas.giraud@inlibro.com> --- Created attachment 151434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151434&action=edit Simple plugin to test the patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151426|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 151473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151473&action=edit Bug 33758 - Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook This patch adds a parameter to call the method intranet_catalog_biblio_enhancements_toolbar_button with a biblionumber in the page catalogue/detail.pl. Modification of cat-toolbar.inc to display new buttons correctly. To test : 1. Apply the patch 2. Take a plugin who implements the method intranet_catalog_biblio_enhancements_toolbar_button 3. Check if the parameter "biblionumber" is passed correctly at this method 4. Create the new button in HTML in the plugin method (button must be like the ones that are in the toolbar of the page detail.pl) 5. Go to the page in browser and check if the new button is displayed Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk Status|Needs Signoff |Signed Off --- Comment #4 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Test plan works as described, thanks for the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Couple of thing: * Please update the unit tests * Couldn't you just modify the template and pass the biblionumber from there? It seems much simpler as a solution: [% p.intranet_catalog_biblio_enhancements_toolbar_button | $raw %] becomes [% p.intranet_catalog_biblio_enhancements_toolbar_button(biblionumber) | $raw %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151473|0 |1 is obsolete| | --- Comment #6 from Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> --- Created attachment 158160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158160&action=edit Bug 33758 - Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook This patch calls the method "intranet_catalog_biblio_enhancements_toolbar_button" with the parameter "biblionumber" in "cat-toolbar.inc". I also updated the unit tests. A plugin is in the attachments to help you test the patch. When the patch is applied, the plugin displays a button with the text "Test - [biblionumber]" in the catalogue/detail.pl toolbar. To test: 1. Apply the patch 2. Use a plugin that implements the "intranet_catalog_biblio_enhancements_toolbar_button method" (you can use the plugin in the attachments) 3. Check if the parameter "biblionumber" is passed correctly to this method 4. Create the new button in the plugin method (button must be like the ones that are in the toolbar of the page catalogue/detail.pl) 5. In a browser, go to the detail page of a record (catalogue/detail.pl) 6. Check if the new button is displayed 7. In a terminal, run the unit tests (prove ./t/db_dependent/Koha/Plugins/Plugins.t) 8. Check that all the tests passed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily-rose.francoeur@inLibr | |o.com Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Phan Tung Bui <phan-tung.bui@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phan-tung.bui@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158160|0 |1 is obsolete| | --- Comment #7 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 163798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163798&action=edit Bug 33758 - Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook This patch calls the method "intranet_catalog_biblio_enhancements_toolbar_button" with the parameter "biblionumber" in "cat-toolbar.inc". I also updated the unit tests. A plugin is in the attachments to help you test the patch. When the patch is applied, the plugin displays a button with the text "Test - [biblionumber]" in the catalogue/detail.pl toolbar. To test: 1. Apply the patch 2. Use a plugin that implements the "intranet_catalog_biblio_enhancements_toolbar_button method" (you can use the plugin in the attachments) 3. Check if the parameter "biblionumber" is passed correctly to this method 4. Create the new button in the plugin method (button must be like the ones that are in the toolbar of the page catalogue/detail.pl) 5. In a browser, go to the detail page of a record (catalogue/detail.pl) 6. Check if the new button is displayed 7. In a terminal, run the unit tests (prove ./t/db_dependent/Koha/Plugins/Plugins.t) 8. Check that all the tests passed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hammat.wele@inlibro.com --- Comment #8 from Hammat wele <hammat.wele@inlibro.com> --- patch rebased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Some QA tool failures: FAIL t/db_dependent/Koha/Plugins/Plugins.t FAIL valid Global symbol "$biblionumber" requires explicit package name (did you forget to declare "my $biblionumber"?) Global symbol "$biblionumber" requires explicit package name (did you forget to declare "my $biblionumber"?) Type of arg 1 to Test::Warn::warnings_like must be block or sub {} (not reference constructor) Type of arg 1 to Test::Warn::warnings_like must be block or sub {} (not reference constructor) t/db_dependent/Koha/Plugins/Plugins.t had compilation errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163798|0 |1 is obsolete| | --- Comment #10 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 178342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178342&action=edit Bug 33758 - Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook This patch calls the method "intranet_catalog_biblio_enhancements_toolbar_button" with the parameter "biblionumber" in "cat-toolbar.inc". I also updated the unit tests. A plugin is in the attachments to help you test the patch. When the patch is applied, the plugin displays a button with the text "Test - [biblionumber]" in the catalogue/detail.pl toolbar. To test: 1. Apply the patch 2. Use a plugin that implements the "intranet_catalog_biblio_enhancements_toolbar_button method" (you can use the plugin in the attachments) 3. Check if the parameter "biblionumber" is passed correctly to this method 4. Create the new button in the plugin method (button must be like the ones that are in the toolbar of the page catalogue/detail.pl) 5. In a browser, go to the detail page of a record (catalogue/detail.pl) 6. Check if the new button is displayed 7. In a terminal, run the unit tests (prove ./t/db_dependent/Koha/Plugins/Plugins.t) 8. Check that all the tests passed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 --- Comment #11 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 178354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178354&action=edit Bug 33758: Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook This patch adds a parameter to call the method intranet_catalog_biblio_enhancements_toolbar_button with a biblionumber in the page catalogue/detail.pl. Modification of cat-toolbar.inc to display new buttons correctly. To test : 1. Apply the patch 2. Take a plugin who implements the method intranet_catalog_biblio_enhancements_toolbar_button 3. Check if the parameter biblionumber is passed correctly at this method 4. Create the new button in HTML in the plugin method (button must be like the ones that are in the toolbar of the page detail.pl) 5. Go to the page in browser and check if the new button is displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 --- Comment #12 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 178355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178355&action=edit Bug 33758: (follow-up) Fix tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178342|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nicolas.giraud@inlibro.com |hammat.wele@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roman.dolny@jezuici.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Roman Dolny <roman.dolny@jezuici.pl> --- kohadev-koha@kohadevbox:koha(bug_33758)$ prove t/db_dependent/Koha/Plugins/Plugins.t t/db_dependent/Koha/Plugins/Plugins.t .. 12/19 # Failed test 'no warnings' # at /usr/share/perl/5.36/Test/Builder.pm line 193. # There were 1 warning(s) # Previous test 4 'Test can_load' # Plugin error (Test Plugin): Exception 'Koha::Exception' thrown 'after_biblio_action called with action: create, ref: Koha::Biblio' # at /kohadevbox/koha/Koha/Plugins.pm line 97. # Koha::Plugins::call("Koha::Plugins", "after_biblio_action", HASH(0x558debadc578)) called at /kohadevbox/koha/C4/Biblio.pm line 3325 # C4::Biblio::_after_biblio_action_hooks(HASH(0x558debadc140)) called at /kohadevbox/koha/C4/Biblio.pm line 314 # C4::Biblio::__ANON__() called at /usr/share/perl5/DBIx/Class/Storage/BlockRunner.pm line 130 # DBIx::Class::Storage::BlockRunner::try {...} () called at /usr/share/perl5/Try/Tiny.pm line 102 # eval {...} called at /usr/share/perl5/Try/Tiny.pm line 93 # Try::Tiny::try(CODE(0x558deba887f0), Try::Tiny::Catch=REF(0x558deb9022b8)) called at /usr/share/perl5/DBIx/Class/Storage/BlockRunner.pm line 134 # DBIx::Class::Storage::BlockRunner::__ANON__() called at /usr/share/perl5/Context/Preserve.pm line 23 # Context::Preserve::preserve_context(CODE(0x558deba91928), "replace", CODE(0x558deba91e20)) called at /usr/share/perl5/DBIx/Class/Storage/BlockRunner.pm line 213 # DBIx::Class::Storage::BlockRunner::_run(DBIx::Class::Storage::BlockRunner=HASH(0x558deba98290), CODE(0x558deb9238d0)) called at /usr/share/perl5/DBIx/Class/Storage/BlockRunner.pm line 105 # DBIx::Class::Storage::BlockRunner::run(DBIx::Class::Storage::BlockRunner=HASH(0x558deba98290), CODE(0x558deb9238d0)) called at /usr/share/perl5/DBIx/Class/Storage.pm line 187 # DBIx::Class::Storage::txn_do(DBIx::Class::Storage::DBI::mysql=HASH(0x558deb0d3830), CODE(0x558deb9238d0)) called at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 861 # DBIx::Class::Storage::DBI::txn_do(DBIx::Class::Storage::DBI::mysql=HASH(0x558deb0d3830), CODE(0x558deb9238d0)) called at /usr/share/perl5/DBIx/Class/Schema.pm line 654 # DBIx::Class::Schema::txn_do(Koha::Schema=HASH(0x558de0c90670), CODE(0x558deb9238d0)) called at /kohadevbox/koha/C4/Biblio.pm line 319 # C4::Biblio::try {...} () called at /usr/share/perl5/Try/Tiny.pm line 102 # eval {...} called at /usr/share/perl5/Try/Tiny.pm line 93 # Try::Tiny::try(CODE(0x558deb9160b8), Try::Tiny::Catch=REF(0x558deba88da8)) called at /kohadevbox/koha/C4/Biblio.pm line 329 # C4::Biblio::AddBiblio(MARC::Record=HASH(0x558deb84f958), "") called at /kohadevbox/koha/t/lib/TestBuilder.pm line 191 # t::lib::TestBuilder::build_sample_biblio(t::lib::TestBuilder=HASH(0x558de0c648f0)) called at t/db_dependent/Koha/Plugins/Plugins.t line 264 # main::__ANON__() called at /usr/share/perl/5.36/Test/Builder.pm line 374 # eval {...} called at /usr/share/perl/5.36/Test/Builder.pm line 374 # Test::Builder::subtest(Test::Builder=HASH(0x558de149f768), "Koha::Plugin::Test", CODE(0x558deb283d60)) called at /usr/share/perl/5.36/Test/More.pm line 809 # Test::More::subtest("Koha::Plugin::Test", CODE(0x558deb283d60)) called at t/db_dependent/Koha/Plugins/Plugins.t line 342 # # Looks like you failed 1 test of 19. t/db_dependent/Koha/Plugins/Plugins.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/19 subtests Test Summary Report ------------------- t/db_dependent/Koha/Plugins/Plugins.t (Wstat: 256 (exited 1) Tests: 19 Failed: 1) Failed test: 19 Non-zero exit status: 1 Files=1, Tests=19, 4 wallclock secs ( 0.04 usr 0.00 sys + 3.19 cusr 0.40 csys = 3.63 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178355|0 |1 is obsolete| | --- Comment #14 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 185236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185236&action=edit Bug 33758: (follow-up) Fix tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 --- Comment #15 from Hammat wele <hammat.wele@inlibro.com> --- Note(In reply to Roman Dolny from comment #13)
kohadev-koha@kohadevbox:koha(bug_33758)$ prove t/db_dependent/Koha/Plugins/Plugins.t t/db_dependent/Koha/Plugins/Plugins.t .. 12/19 # Failed test 'no warnings' # at /usr/share/perl/5.36/Test/Builder.pm line 193.
Note: This error occurs when $builder->build_sample_biblio is used together with Test::NoWarnings. Without applying the patch, running: prove t/db_dependent/Koha/Plugins/Holds_hooks.t produces the same error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178354|0 |1 is obsolete| | --- Comment #16 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 185287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185287&action=edit Bug 33758: Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook This patch adds a parameter to call the method intranet_catalog_biblio_enhancements_toolbar_button with a biblionumber in the page catalogue/detail.pl. Modification of cat-toolbar.inc to display new buttons correctly. To test : 1. Apply the patch 2. Take a plugin who implements the method intranet_catalog_biblio_enhancements_toolbar_button 3. Check if the parameter biblionumber is passed correctly at this method 4. Create the new button in HTML in the plugin method (button must be like the ones that are in the toolbar of the page detail.pl) 5. Go to the page in browser and check if the new button is displayed Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185236|0 |1 is obsolete| | --- Comment #17 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 185288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185288&action=edit Bug 33758: (follow-up) Fix tests Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185287|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185288|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 --- Comment #18 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 191057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191057&action=edit Bug 33758: Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook This patch adds a parameter to call the method intranet_catalog_biblio_enhancements_toolbar_button with a biblionumber in the page catalogue/detail.pl. Modification of cat-toolbar.inc to display new buttons correctly. To test : 1. Apply the patch 2. Take a plugin who implements the method intranet_catalog_biblio_enhancements_toolbar_button 3. Check if the parameter biblionumber is passed correctly at this method 4. Create the new button in HTML in the plugin method (button must be like the ones that are in the toolbar of the page detail.pl) 5. Go to the page in browser and check if the new button is displayed Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 --- Comment #19 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 191058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191058&action=edit Bug 33758: (follow-up) Fix tests Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 --- Comment #20 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 191059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191059&action=edit Bug 33758: (QA follow-up) Tidy test file Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #21 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Can we avoid tidy commits? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191059|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191058|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191057|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 --- Comment #22 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 196518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196518&action=edit Bug 33758: Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook This patch adds a parameter to call the method intranet_catalog_biblio_enhancements_toolbar_button with a biblionumber in the page catalogue/detail.pl. Modification of cat-toolbar.inc to display new buttons correctly. To test : 1. Apply the patch 2. Take a plugin who implements the method intranet_catalog_biblio_enhancements_toolbar_button 3. Check if the parameter biblionumber is passed correctly at this method 4. Create the new button in HTML in the plugin method (button must be like the ones that are in the toolbar of the page detail.pl) 5. Go to the page in browser and check if the new button is displayed Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196518|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 --- Comment #23 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 201386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201386&action=edit Bug 33758: Add a parameter to use the intranet_catalog_biblio_enhancements_toolbar_button Plugin hook This patch adds a parameter to call the method intranet_catalog_biblio_enhancements_toolbar_button with a biblionumber in the page catalogue/detail.pl. Modification of cat-toolbar.inc to display new buttons correctly. To test : 1. Apply the patch 2. Take a plugin who implements the method intranet_catalog_biblio_enhancements_toolbar_button 3. Check if the parameter biblionumber is passed correctly at this method 4. Create the new button in HTML in the plugin method (button must be like the ones that are in the toolbar of the page detail.pl) 5. Go to the page in browser and check if the new button is displayed Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 --- Comment #24 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33758 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED --- Comment #25 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Enhancement, no 26.05.x backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org