[Bug 29525] New: Privacy settings for patrons should also affect holds history
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Bug ID: 29525 Summary: Privacy settings for patrons should also affect holds history Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Adjust Patron Privacy preferences to include holds history into privacy considerations. If patron privacy setting is set to never, never retain holds history (anonymize it). If privacy is set to keep, keep holds history for the patron forever. If privacy is set to default, keep it until library chooses to anonymize hold history. (add holds history functionality or option to batch_anonymise cronjob) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 [Bug 20936] Holds history for patrons in OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org --- Comment #1 from George Williams (NEKLS) <george@nekls.org> --- +1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29780 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 [Bug 29780] Add Koha::Old::Holds->anonymize -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128975&action=edit Bug 29525: Add Koha::Old::Holds->filter_by_anonymizable This patch adds the 'filter_by_anonymizable' method, and tests for it. A new DBIC relationship is added as well to the OldReserve schema file. To test: 1. Apply this patch 2. Run: $ kshell k$ t/db_dependent/Koha/Old/Holds.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
UPDATE old_reserves SET timestamp=ADDDATE(NOW(), INTERVAL -4 DAY);
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128976&action=edit Bug 29525: Make batch_anonymise.pl deal with holds This patch makes the batch_anonymise.pl script handle holds too. It does so by leveraging on the newly introduced method 'filter_by_anonymizable' and also 'anonymize'. To test: 1. Have a patron with two past holds. 2. Make sure they are a few days back: $ koha-mysql kohadev 3. Run: $ kshell k$ perl misc/cronjobs/batch_anonymise.pl --days 2 -v => SUCCESS: You see something like: Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 2 holds anonymised. 4. Repeat 3 => SUCCESS: They are already anonymized. You see Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 0 holds anonymised. 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128977&action=edit Bug 29525: (follow-up) Adapt OPAC text to mention holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128976|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128977|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128975|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129258&action=edit Bug 29525: Add Koha::Old::Holds->filter_by_anonymizable This patch adds the 'filter_by_anonymizable' method, and tests for it. A new DBIC relationship is added as well to the OldReserve schema file. To test: 1. Apply this patch 2. Run: $ kshell k$ t/db_dependent/Koha/Old/Holds.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
UPDATE old_reserves SET timestamp=ADDDATE(NOW(), INTERVAL -4 DAY);
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129259&action=edit Bug 29525: Make batch_anonymise.pl deal with holds This patch makes the batch_anonymise.pl script handle holds too. It does so by leveraging on the newly introduced method 'filter_by_anonymizable' and also 'anonymize'. To test: 1. Have a patron with two past holds. 2. Make sure they are a few days back: $ koha-mysql kohadev 3. Run: $ kshell k$ perl misc/cronjobs/batch_anonymise.pl --days 2 -v => SUCCESS: You see something like: Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 2 holds anonymised. 4. Repeat 3 => SUCCESS: They are already anonymized. You see Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 0 holds anonymised. 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129260&action=edit Bug 29525: (follow-up) Adapt OPAC text to mention holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Sorry for the noise, just learnt about Koha::Objects->filter_by_last_update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129258|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129259|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129260|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129265&action=edit Bug 29525: Add Koha::Old::Holds->filter_by_anonymizable This patch adds the 'filter_by_anonymizable' method, and tests for it. A new DBIC relationship is added as well to the OldReserve schema file. To test: 1. Apply this patch 2. Run: $ kshell k$ t/db_dependent/Koha/Old/Holds.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
UPDATE old_reserves SET timestamp=ADDDATE(NOW(), INTERVAL -4 DAY);
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129266&action=edit Bug 29525: Make batch_anonymise.pl deal with holds This patch makes the batch_anonymise.pl script handle holds too. It does so by leveraging on the newly introduced method 'filter_by_anonymizable' and also 'anonymize'. To test: 1. Have a patron with two past holds. 2. Make sure they are a few days back: $ koha-mysql kohadev 3. Run: $ kshell k$ perl misc/cronjobs/batch_anonymise.pl --days 2 -v => SUCCESS: You see something like: Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 2 holds anonymised. 4. Repeat 3 => SUCCESS: They are already anonymized. You see Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 0 holds anonymised. 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129267&action=edit Bug 29525: (follow-up) Adapt OPAC text to mention holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29843 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts -- You are receiving this mail because: You are watching all bug changes.
UPDATE old_reserves SET timestamp=ADDDATE(NOW(), INTERVAL -4 DAY);
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129266|0 |1 is obsolete| | --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129268&action=edit Bug 29525: Make batch_anonymise.pl deal with holds This patch makes the batch_anonymise.pl script handle holds too. It does so by leveraging on the newly introduced method 'filter_by_anonymizable' and also 'anonymize'. To test: 1. Have a patron with two past holds. 2. Make sure they are a few days back: $ koha-mysql kohadev 3. Run: $ kshell k$ perl misc/cronjobs/batch_anonymise.pl --days 2 -v => SUCCESS: You see something like: Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 2 holds anonymised. 4. Repeat 3 => SUCCESS: They are already anonymized. You see Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 0 holds anonymised. 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129265|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129267|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129268|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129273&action=edit Bug 29843: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129266|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129267|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129268|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129273|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129266|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129267|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129268|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129321&action=edit Bug 29525: Add Koha::Old::Holds->filter_by_anonymizable This patch adds the 'filter_by_anonymizable' method, and tests for it. A new DBIC relationship is added as well to the OldReserve schema file. To test: 1. Apply this patch 2. Run: $ kshell k$ t/db_dependent/Koha/Old/Holds.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
UPDATE old_reserves SET timestamp=ADDDATE(NOW(), INTERVAL -4 DAY);
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129322&action=edit Bug 29525: Make batch_anonymise.pl deal with holds This patch makes the batch_anonymise.pl script handle holds too. It does so by leveraging on the newly introduced method 'filter_by_anonymizable' and also 'anonymize'. To test: 1. Have a patron with two past holds. 2. Make sure they are a few days back: $ koha-mysql kohadev 3. Run: $ kshell k$ perl misc/cronjobs/batch_anonymise.pl --days 2 -v => SUCCESS: You see something like: Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 2 holds anonymised. 4. Repeat 3 => SUCCESS: They are already anonymized. You see Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 0 holds anonymised. 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129323&action=edit Bug 29525: (follow-up) Adapt OPAC text to mention holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |andrew@bywatersolutions.com --- Comment #17 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- We're not fully mirroring circ history behavior. For checkout history, if a patron is set to Never they get anonymized as soon as the item is returned. Here, if a patron is set to Never we're still waiting for the cron to anonymize them. We should anonymize their holds as soon as they move to old_reserves. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Andrew Fuerste-Henry from comment #17)
We're not fully mirroring circ history behavior. For checkout history, if a patron is set to Never they get anonymized as soon as the item is returned. Here, if a patron is set to Never we're still waiting for the cron to anonymize them. We should anonymize their holds as soon as they move to old_reserves.
This is getting complex: if we anonymize same-day holds... we are gonna break the max holds per day circ rule calculation! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Ok, the current behavior is that only 'active' holds count towards the max: my $today_holds = Koha::Holds->search({ borrowernumber => $borrowernumber, reservedate => dt_from_string->date }); if (!$params->{ignore_hold_counts} && defined $holds_per_day && $holds_per_day ne '' && $today_holds->count() >= $holds_per_day ) { return { status => 'tooManyReservesToday', limit => $holds_per_day }; } so moving on with this, with no behavior change on the calculation. Phew. Should the whole feature have an on/off switch? Something like OPACHoldsPrivacy on/off? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #20 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Right now these sysprefs come into play: OPACPrivacy determines whether or not patrons can access the My Privacy tab on which these settings are changed. OPACHoldsHistory determines whether or not patrons can see their hold history, if it is kept. (opacreadinghitory, a separate syspref, determines whether or not they can see checkout history). intranetreadinghistory determines whether or not staff members can see BOTH checkout and hold history on that staff side, if kept. I don't feel these *need* changes for this bug to move forward, but in the long run I'd like to see a new IntranetHoldsHistory syspref to split staff interface holds visibility out of intranetreadinghistory. If we want to give patrons the ability to control holds history without controlling checkout history (or vice versa), I'd be inclined to accomplish that by adding options to OPACPrivacy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29868 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 [Bug 29868] Add Koha::Old::Hold->anonymize -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129363&action=edit Bug 29525: Make Koha::Hold->cancel anonymize if required -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129363|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129364&action=edit Bug 29525: Make Koha::Hold->cancel anonymize if required This patch makes cancelling a hold anonymize it on the same call, if settings require it (i.e. if borrowers.privacy is set to 2). To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: The code actually does what it is meant to 3. Try on the UI, cancelling a hold, noticing it gets anonymized if the patron has privacy == always/2. 4. Sign off :-D Note: AnonymousPatron should be set. Otherwise it would set NULL. But that's fine, that's what Koha does already. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Andrew and testers, this follow-up patch covers the 'cancelling a hold' use case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29869 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 [Bug 29869] Add Koha::Hold->fulfill -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Ok, bug adds Koha::Hold->fill with tests, bells and whistles. I will now make it anonymize the same way we did with Koha:Hold->cancel. And we are done :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129321|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129322|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129323|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129364|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129424&action=edit Bug 29525: Add Koha::Old::Holds->filter_by_anonymizable This patch adds the 'filter_by_anonymizable' method, and tests for it. A new DBIC relationship is added as well to the OldReserve schema file. To test: 1. Apply this patch 2. Run: $ kshell k$ t/db_dependent/Koha/Old/Holds.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
UPDATE old_reserves SET timestamp=ADDDATE(NOW(), INTERVAL -4 DAY);
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129425&action=edit Bug 29525: Make batch_anonymise.pl deal with holds This patch makes the batch_anonymise.pl script handle holds too. It does so by leveraging on the newly introduced method 'filter_by_anonymizable' and also 'anonymize'. To test: 1. Have a patron with two past holds. 2. Make sure they are a few days back: $ koha-mysql kohadev 3. Run: $ kshell k$ perl misc/cronjobs/batch_anonymise.pl --days 2 -v => SUCCESS: You see something like: Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 2 holds anonymised. 4. Repeat 3 => SUCCESS: They are already anonymized. You see Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 0 holds anonymised. 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #27 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129426&action=edit Bug 29525: (follow-up) Adapt OPAC text to mention holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #28 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129427&action=edit Bug 29525: Make Koha::Hold->cancel anonymize if required This patch makes cancelling a hold anonymize it on the same call, if settings require it (i.e. if borrowers.privacy is set to 2). To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: The code actually does what it is meant to 3. Try on the UI, cancelling a hold, noticing it gets anonymized if the patron has privacy == always/2. 4. Sign off :-D Note: AnonymousPatron should be set. Otherwise it would set NULL. But that's fine, that's what Koha does already. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129428&action=edit Bug 29525: Make Koha::Hold->fill anonymize if required This patch makes filling a hold anonymize it on the same call, if settings require it (i.e. if borrowers.privacy is set to 2). To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: The code actually does what it is meant to 3. Try on the UI, notice it gets anonymized if the patron has privacy == always/2. 4. Sign off :-D Note: AnonymousPatron should be set. Otherwise it would set NULL. But that's fine, that's what Koha does already. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29879 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29879 [Bug 29879] Make sure objects moved to old_* is not tried to be saved again -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129424|0 |1 is obsolete| | --- Comment #30 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 129432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129432&action=edit Bug 29525: Add Koha::Old::Holds->filter_by_anonymizable This patch adds the 'filter_by_anonymizable' method, and tests for it. A new DBIC relationship is added as well to the OldReserve schema file. To test: 1. Apply this patch 2. Run: $ kshell k$ t/db_dependent/Koha/Old/Holds.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
UPDATE old_reserves SET timestamp=ADDDATE(NOW(), INTERVAL -4 DAY);
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129425|0 |1 is obsolete| | --- Comment #31 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 129433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129433&action=edit Bug 29525: Make batch_anonymise.pl deal with holds This patch makes the batch_anonymise.pl script handle holds too. It does so by leveraging on the newly introduced method 'filter_by_anonymizable' and also 'anonymize'. To test: 1. Have a patron with two past holds. 2. Make sure they are a few days back: $ koha-mysql kohadev 3. Run: $ kshell k$ perl misc/cronjobs/batch_anonymise.pl --days 2 -v => SUCCESS: You see something like: Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 2 holds anonymised. 4. Repeat 3 => SUCCESS: They are already anonymized. You see Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 0 holds anonymised. 5. Sign off :-D Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129426|0 |1 is obsolete| | --- Comment #32 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 129434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129434&action=edit Bug 29525: (follow-up) Adapt OPAC text to mention holds Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129427|0 |1 is obsolete| | --- Comment #33 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 129435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129435&action=edit Bug 29525: Make Koha::Hold->cancel anonymize if required This patch makes cancelling a hold anonymize it on the same call, if settings require it (i.e. if borrowers.privacy is set to 2). To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: The code actually does what it is meant to 3. Try on the UI, cancelling a hold, noticing it gets anonymized if the patron has privacy == always/2. 4. Sign off :-D Note: AnonymousPatron should be set. Otherwise it would set NULL. But that's fine, that's what Koha does already. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129428|0 |1 is obsolete| | --- Comment #34 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 129436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129436&action=edit Bug 29525: Make Koha::Hold->fill anonymize if required This patch makes filling a hold anonymize it on the same call, if settings require it (i.e. if borrowers.privacy is set to 2). To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: The code actually does what it is meant to 3. Try on the UI, notice it gets anonymized if the patron has privacy == always/2. 4. Sign off :-D Note: AnonymousPatron should be set. Otherwise it would set NULL. But that's fine, that's what Koha does already. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29869 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29869 [Bug 29869] Add Koha::Hold->fill -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- hmm.. 'Make Koha::Hold->cancel' claims there's nothing to apply here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129435|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129436|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #36 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129544&action=edit Bug 29525: Make Koha::Hold->cancel anonymize if required This patch makes cancelling a hold anonymize it on the same call, if settings require it (i.e. if borrowers.privacy is set to 2). To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: The code actually does what it is meant to 3. Try on the UI, cancelling a hold, noticing it gets anonymized if the patron has privacy == always/2. 4. Sign off :-D Note: AnonymousPatron should be set. Otherwise it would set NULL. But that's fine, that's what Koha does already. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #37 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129545&action=edit Bug 29525: Make Koha::Hold->fill anonymize if required This patch makes filling a hold anonymize it on the same call, if settings require it (i.e. if borrowers.privacy is set to 2). To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: The code actually does what it is meant to 3. Try on the UI, notice it gets anonymized if the patron has privacy == always/2. 4. Sign off :-D Note: AnonymousPatron should be set. Otherwise it would set NULL. But that's fine, that's what Koha does already. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #38 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Same remarks than bug 29843 comment 30 apply here "In MarkIssueReturned we crash if AnonymousPatron is not set to a valid borrowernumber. Here we are setting it to NULL. Both behaviours must be identical." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #39 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Andrew Fuerste-Henry from comment #20) [...]
I don't feel these *need* changes for this bug to move forward, but in the long run I'd like to see a new IntranetHoldsHistory syspref to split staff interface holds visibility out of intranetreadinghistory.
If we want to give patrons the ability to control holds history without controlling checkout history (or vice versa), I'd be inclined to accomplish that by adding options to OPACPrivacy.
+1 - I think we should file those as separate bug reports. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29526 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #40 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #38)
Same remarks than bug 29843 comment 30 apply here "In MarkIssueReturned we crash if AnonymousPatron is not set to a valid borrowernumber. Here we are setting it to NULL. Both behaviours must be identical."
Moved this bit to bug 30007. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129432|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130254&action=edit Bug 29525: Add Koha::Old::Holds->filter_by_anonymizable This patch adds the 'filter_by_anonymizable' method, and tests for it. A new DBIC relationship is added as well to the OldReserve schema file. To test: 1. Apply this patch 2. Run: $ kshell k$ t/db_dependent/Koha/Old/Holds.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
UPDATE old_reserves SET timestamp=ADDDATE(NOW(), INTERVAL -4 DAY);
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129433|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130255&action=edit Bug 29525: Make batch_anonymise.pl deal with holds This patch makes the batch_anonymise.pl script handle holds too. It does so by leveraging on the newly introduced method 'filter_by_anonymizable' and also 'anonymize'. To test: 1. Have a patron with two past holds. 2. Make sure they are a few days back: $ koha-mysql kohadev 3. Run: $ kshell k$ perl misc/cronjobs/batch_anonymise.pl --days 2 -v => SUCCESS: You see something like: Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 2 holds anonymised. 4. Repeat 3 => SUCCESS: They are already anonymized. You see Checkouts and holds before 2022-01-01 will be anonymised. 0 checkouts anonymised. 0 holds anonymised. 5. Sign off :-D Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129434|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130256&action=edit Bug 29525: (follow-up) Adapt OPAC text to mention holds Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129544|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130257&action=edit Bug 29525: Make Koha::Hold->cancel anonymize if required This patch makes cancelling a hold anonymize it on the same call, if settings require it (i.e. if borrowers.privacy is set to 2). To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: The code actually does what it is meant to 3. Try on the UI, cancelling a hold, noticing it gets anonymized if the patron has privacy == always/2. 4. Sign off :-D Note: AnonymousPatron should be set. Otherwise it would set NULL. But that's fine, that's what Koha does already. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129545|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130258&action=edit Bug 29525: Make Koha::Hold->fill anonymize if required This patch makes filling a hold anonymize it on the same call, if settings require it (i.e. if borrowers.privacy is set to 2). To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Hold.t => SUCCESS: The code actually does what it is meant to 3. Try on the UI, notice it gets anonymized if the patron has privacy == always/2. 4. Sign off :-D Note: AnonymousPatron should be set. Otherwise it would set NULL. But that's fine, that's what Koha does already. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All works as described, new methods work and are well tested and the QA scripts are happy. QA feedback is being addressed in a distinct bug to catch all cases. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29843 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 --- Comment #47 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Bug 29525 depends on bug 29780, which changed state. Bug 29780 Summary: Add Koha::Old::Holds->anonymize https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Bug 29525 depends on bug 29868, which changed state. Bug 29868 Summary: Add Koha::Old::Hold->anonymize https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29868 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #48 from Fridolin Somers <fridolin.somers@biblibre.com> --- This is important for GDPR, can it be backported to 21.11.x ? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org