[Bug 23506] New: Sound icon displaying wrong in MARC21slim2intranetDetail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Bug ID: 23506 Summary: Sound icon displaying wrong in MARC21slim2intranetDetail Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When the leader6 is set to 'i' the MARC21slim2intranetDetail.xsl attempts to display 'SO.png' which does not exist. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Correction: MARC21slim2OPACDetail.xsl NOT MARC21slim2intranetDetail.xsl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Sound icon displaying wrong |Sound material type |in |displays wrong icon in OPAC |MARC21slim2intranetDetail |details -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 92478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92478&action=edit Bug 23506: Sound material type displays wrong icon in OPAC details TEST PLAN: 1. Find or create a record with an 'i' as the 6th position in the 000 leader. 2. Do to the OPAC detail page for an item in that record. 3. Notice the material type icon does not display because SO.png does not exist. 4. Apply patch 5. Look at the opac detail page again after clearning the browser cache. 6. The material type icon now displays (MU.png), this is the same icon used on the OPAC results page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Sound material type |Sound material type |displays wrong icon in OPAC |displays wrong icon in |details |OPAC/Staff details -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92478|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 93162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93162&action=edit Bug 23506: Sound material type displays wrong icon in OPAC/Staff details TEST PLAN: 1. Find or create a record with an 'i' as the 6th position in the 000 leader. 2. Do to the OPAC detail page for an item in that record. 3. Notice the material type icon does not display because SO.png does not exist. 4. Apply patch 5. Look at the opac detail page again after clearning the browser cache. 6. The material type icon now displays (MU.png), this is the same icon used on the OPAC results page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Eric Bégin <eric.begin@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eric.begin@inLibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Lucas, can you please fix staff as well? This only includes pictures for the OPAC (also, why do they need to be doubled up?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Kait, When you say double up I assume on mean the presence of two .png's (SO.png and MU.png). I am going to instead use a single .png and direct both Music and Sound to that image. I will also include both the staff and OPAC changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93162|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 94840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94840&action=edit display correct icon in staff client and OPAC TEST PLAN: 1. Find or create a record with an 'i' as the 6th position in the 000 leader. 2. Do to the OPAC detail page and staff detail for an item in that record. 3. Notice the material type icon does not display because SO.png does not exist. 4. Apply patch and restart_all 5. Look at the opac detail and staff detail page again after clearning the browser cache. 6. The material type icon now displays (MU.png), this is the same icon used on the OPAC results page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94840|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 94973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94973&action=edit Bug 23506: Display correct icon in staff client and OPAC When the leader6 is set to 'i' the MARC21slim2intranetDetail.xsl attempts to display 'SO.png' which does not exist. TEST PLAN: 1. Find or create a record with an 'i' as the 6th position in the 000 leader. 2. Do to the OPAC detail page and staff detail for an item in that record. 3. Notice the material type icon does not display because SO.png does not exist. 4. Apply patch and restart_all 5. Look at the opac detail and staff detail page again after clearning the browser cache. 6. The material type icon now displays (MU.png), this is the same icon used on the OPAC results page. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I fixed the Bug description and commit message. Moving to PQA as it's a really simple fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|19.11.00 |19.11.00, 18.11.12 released in| | CC| |hayleymapley@catalyst.net.n | |z --- Comment #11 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Backported to 18.11.x for 18.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00, 18.11.12 |19.11.00, 19.05.06, released in| |18.11.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org