[Bug 13471] New: When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471 Bug ID: 13471 Summary: When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: olli-antti.kivilahti@jns.fi QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com This issue causes loss of data when the subscription length type (SLT) is other than issues. TO REPLICATE: We make an subscription with SLT of months = 12. Later make an arbitrary edit to the subscription, and miss out the fact that the SLT selection is set to issues. Save the changes. Serial subscription end date is set to 12 issues since the start date, instead of 12 months which it used to be. This causes a myriad of issues :=) AFTER THIS PATCH: SLT defaults to the value initially saved instead of always being issues. Now the selection can be translated! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471 --- Comment #1 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 34454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34454&action=edit Bug 13471 - When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. This issue causes loss of data when the subscription length type (SLT) is other than issues. TO REPLICATE: We make an subscription with SLT of months = 12. Later make an arbitrary edit to the subscription, and miss out the fact that the SLT selection is set to issues. Save the changes. Serial subscription end date is set to 12 issues since the start date, instead of 12 months which it used to be. This causes a myriad of issues :=) AFTER THIS PATCH: SLT defaults to the value initially saved instead of always being issues. Now the selection can be translated! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |olli-antti.kivilahti@jns.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34454|0 |1 is obsolete| | --- Comment #2 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 34455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34455&action=edit Bug 13471 - When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. This issue causes loss of data when the subscription length type (SLT) is other than issues. TO REPLICATE: We make an subscription with SLT of months = 12. Later make an arbitrary edit to the subscription, and miss out the fact that the SLT selection is set to issues. Save the changes. Serial subscription end date is set to 12 issues since the start date, instead of 12 months which it used to be. This causes a myriad of issues :=) AFTER THIS PATCH: SLT defaults to the value initially saved instead of always being issues. Now the selection can be translated! HOTFIX 1: Added <span> elements to showSubscriptionLengthType.inc so the translation tool can catch them. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34455|0 |1 is obsolete| | --- Comment #3 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 34506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34506&action=edit Bug 13471 - When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. This issue causes loss of data when the subscription length type (SLT) is other than issues. TO REPLICATE: We make an subscription with SLT of months = 12. Later make an arbitrary edit to the subscription, and miss out the fact that the SLT selection is set to issues. Save the changes. Serial subscription end date is set to 12 issues since the start date, instead of 12 months which it used to be. This causes a myriad of issues :=) AFTER THIS PATCH: SLT defaults to the value initially saved instead of always being issues. Now the selection can be translated! HOTFIX 1: Added <span> elements to showSubscriptionLengthType.inc so the translation tool can catch them. HOTFIX 2: Fixed serials/showpredictionpattern.pl to use the db columns instead of issues,weeks,months. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471 Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34506|0 |1 is obsolete| | --- Comment #4 from Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> --- Created attachment 34661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34661&action=edit Bug 13471 - When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. This issue causes loss of data when the subscription length type (SLT) is other than issues. TO REPLICATE: We make an subscription with SLT of months = 12. Later make an arbitrary edit to the subscription, and miss out the fact that the SLT selection is set to issues. Save the changes. Serial subscription end date is set to 12 issues since the start date, instead of 12 months which it used to be. This causes a myriad of issues :=) AFTER THIS PATCH: SLT defaults to the value initially saved instead of always being issues. Now the selection can be translated! HOTFIX 1: Added <span> elements to showSubscriptionLengthType.inc so the translation tool can catch them. HOTFIX 2: Fixed serials/showpredictionpattern.pl to use the db columns instead of issues,weeks,months. HOTFIX 3: Fixed serials/subscription-numberpatterns.pl to use the db columns instead of issues,weeks,months. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34661|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 34765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34765&action=edit Bug 13471 - When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable. This issue causes loss of data when the subscription length type (SLT) is other than issues. TO REPLICATE: We make an subscription with SLT of months = 12. Later make an arbitrary edit to the subscription, and miss out the fact that the SLT selection is set to issues. Save the changes. Serial subscription end date is set to 12 issues since the start date, instead of 12 months which it used to be. This causes a myriad of issues :=) AFTER THIS PATCH: SLT defaults to the value initially saved instead of always being issues. Now the selection can be translated! HOTFIX 1: Added <span> elements to showSubscriptionLengthType.inc so the translation tool can catch them. HOTFIX 2: Fixed serials/showpredictionpattern.pl to use the db columns instead of issues,weeks,months. HOTFIX 3: Fixed serials/subscription-numberpatterns.pl to use the db columns instead of issues,weeks,months. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Olli-Antti, the problem in the bug description is a real one, but I am uncomfortable with the number of changes in this patch. The more changes, the more suspicious I get! I see like 3 different bugs here: 1) Translation problem, introduction of a new include - I think the include should be in the includes directory, starting with serials-... to match the existing includes. Pleaes fix. 2) STL is not saved correctly. - Problem seems to be fixed by this patch, but I want to test more for side effects of the variable changes after a follow-up. 3) Changes to serials/subscription-numberpatterns.pl/tt - I don't understand why those have been made - maybe it's too late tonight. Please include an explanation and amend test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14022 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
We make an subscription with SLT of months = 12. Later make an arbitrary edit to the subscription, and miss out the fact that the SLT selection is set to issues. Save the changes. Serial subscription end date is set to 12 issues since the start date, instead of 12 months which it used to be. This causes a myriad of issues :=)
AFTER THIS PATCH:
SLT defaults to the value initially saved instead of always being issues. Now the selection can be translated!
This has been fixed by bug 14022 now - as this patch includes some more changes, I am not closing it yet. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471 Janet McGowan <janet.mcgowan@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org