[Bug 39035] New: CookieConsentBar message prints on slip when cookies aren’t accepted
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39035 Bug ID: 39035 Summary: CookieConsentBar message prints on slip when cookies aren’t accepted Change sponsored?: --- Product: Koha Version: 24.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: marie-luce.laflamme@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Hey everyone, I ran into a small issue with the CookieConsent system in Koha. If you forget to accept Koha’s consent cookies on a computer, the CookieConsentBar message shows up on every printed slip from that computer. The behaviour affect 24.05+ and main. Steps to reproduce: Before testing, make sure: - set the CookieConsent system preference to enable - set a CookieConsentBar message (configured in HTML personnalisations > Additional content > CookieConsentBar) Test plan: 1. Open a different web browser that hasn’t accepted Koha’s cookies yet. 2. Log into the staff interface (do not accept cookies yet). 3. Find a patron account. 4. Click on "Print" and choose any slip. 5. Check the printed slip. ---> Koha is printing the CookieConsentBar message at the bottom, which shouldn’t be there. 6. Now, accept the cookies at the bottom of the screen. 7. Print another slip. 8. Check the new slip. ---> This time, the CookieConsentBar message is gone (as expected). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39035 --- Comment #1 from William Lavoie <william.lavoie@inLibro.com> --- Created attachment 177557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177557&action=edit Bug 39035: CookieConsentBar message prints on slip when cookies aren’t accepted I added a print media query in moremember-print.tt to avoid displaying the cookies when printing a slip. Before testing, make sure: - set the CookieConsent system preference to enable - set a CookieConsentBar message (configured in HTML personnalisations > Additional content > CookieConsentBar) Test plan: 1. Open a different web browser that hasn’t accepted Koha’s cookies yet. 2. Log into the staff interface (do not accept cookies yet). 3. Find a patron account. 4. Click on "Print" and choose any slip. 5. Check the printed slip. ---> Koha is printing the CookieConsentBar message at the bottom, which shouldn’t be there. 6. Now, accept the cookies at the bottom of the screen. 7. Print another slip. 8. Check the new slip. ---> This time, the CookieConsentBar message is gone (as expected). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39035 William Lavoie <william.lavoie@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |william.lavoie@inLibro.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39035 William Lavoie <william.lavoie@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |william.lavoie@inLibro.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39035 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Could you please put this change in print.css instead? Even if the problem has only been spotted with slips I think it's a change that should be made globally. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39035 William Lavoie <william.lavoie@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177557|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39035 William Lavoie <william.lavoie@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39035 --- Comment #3 from William Lavoie <william.lavoie@inLibro.com> --- Created attachment 177570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177570&action=edit Bug 39035: Adding print media query to hide CookieConsentBar Hi Owen, You're right, thank you for the feedback. I have updated the patch and the test plan. Test plan: 1. Set the CookieConsent system preference to enable 2. Set a CookieConsentBar message (configured in HTML personnalisations > Additional content > CookieConsentBar) 3. Open a different web browser that hasn’t accepted Koha’s cookies yet. 4. Log into the staff interface (do not accept cookies yet). 5. Find a patron account. 6. Click on "Print" and choose any slip. 7. Check the printed slip. ---> Koha is printing the CookieConsentBar message at the bottom, which shouldn’t be there. 8. Apply the patch 9. Print another slip. 10. Check the new slip. ---> This time, the CookieConsentBar message is gone (as expected). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39035 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39035 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177570|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177650&action=edit Bug 39035: Adding print media query to hide cookie permissions Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39035 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Shouldnt this be a bug ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39035 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.05 |Main CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39035 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Patrons |Staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39035 William Lavoie <william.lavoie@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39035 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39035 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39035 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177650|0 |1 is obsolete| | --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 178698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178698&action=edit Bug 39035: Adding print media query to hide cookie permissions Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39035 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch fixes a bug release notes| |where CookieConsent | |information would show up | |on printed material in the | |staff interface. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39035 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- PQA but we should file another bug to do this same treatment to the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39035 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39035 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39035 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39035 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|25.05.00 |25.05.00,24.11.07 released in| | --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- I see it is in 24.11.x in release 24.11.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39035 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #10 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org