[Bug 7169] New: Change booksellers search results display
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 Bug #: 7169 Summary: Change booksellers search results display Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: julian.maurice@biblibre.com QAContact: ian.walls@bywatersolutions.com Created attachment 6231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6231 booksellers.pl Change appearance of booksellers and add more basket informations. It will look like in the screenshot attached. BibLibre infos: Repository: git://git.biblibre.com/koha_biblibre.git Branch: stetiennes/ft/MT5504 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7163 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om Change sponsored?|--- |Sponsored AssignedTo|henridamien@koha-fr.org |julian.maurice@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Version|master |rel_3_8 Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P5 - low -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |--- -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> 2012-01-13 11:18:42 UTC --- Created attachment 7134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7134 Patch Bug 7169: Change booksellers search results display - Replace vendor table by a div (avoid table in a table) - Add two columns in basket tables: biblio count and expected (not received) items) - Replace tablesorter by datatables - Add a list of all returned bookseller names in top of the page (easier to find a bookseller in a large list of results) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6836 --- Comment #2 from Julian Maurice <julian.maurice@biblibre.com> 2012-01-13 11:19:31 UTC --- This patch depends on bug 6836 (datatables) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Blocks| |5336 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-17 14:39:06 UTC --- The script devel/misc/testbugzillapatches.pl has detected that this bug does not apply anymore, so i'm marking this bug as "does not apply". The script is supposed to handle conflicts related to updatedatabase, but no other cases of merge conflict. So the conflict may be trivial to fix. If it happens that the patch attached does apply cleanly, please send me an email, there's something wrong in the script. It's possible, as it's a recent script. If the patch applies does not apply as I think, please rebase and resubmit, thanks -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 Bug 7169 depends on bug 6836, which changed state. Bug 6836 Summary: jQuery plugin Datatables integration http://wiki.koha-community.org/wiki/DataTables_HowTo http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6836 What |Old Value |New Value ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7134|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> 2012-02-24 16:00:17 UTC --- Created attachment 7858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7858 Bug 7169: Change booksellers search results display Patch rebased on master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Patch doesn't apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-26 09:46:37 UTC --- Hi Julian, I tested the changes and I think the display is cleaner this way. I especially like the buttons for adding baskets and receiving shipments. The single entries make take up a bit more space though. I think it would be nice to get some more opinions on the display. Some notes: I am wondering a bit about the list of vendors on top, perhaps this could go into a filter box on the left side instead? Perhaps we could also make the columns on the result page match the descriptions on the order receive page (/acqui/parcels.pl?booksellerid=3). Item Count Biblio count Items expected For functionality I only found one small thing: I noticed there is a warning in the logs when searching booksellers. Perhaps you could fix this in a follow-up? [Sun Feb 26 10:24:22 2012] [error] [client 127.0.0.1] [Sun Feb 26 10:24:22 2012] booksellers.pl: Argument "user" isn't numeric in numeric eq (==) at /home/katrin/kohaclone/acqui/booksellers.pl line 121., referer: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl There is also an error when checking for XHTML validity: Line 304, Column 151: cannot generate system identifier for general entity "op" -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7858|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-26 10:01:46 UTC --- Created attachment 7885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7885 [SIGNED-OFF] Bug 7169: Change booksellers search results display - Replace vendor table by a div (avoid table in a table) - Add two columns in basket tables: biblio count and expected (not received) items) - Replace tablesorter by datatables - Add a list of all returned bookseller names in top of the page (easier to find a bookseller in a large list of results) Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-26 10:10:19 UTC --- Created attachment 7886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7886 screenshot showing changes -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain@biblibre.com --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-27 15:58:59 UTC --- QA comment: * remove some SQL code in .sql, that's good ! * switch from tableSorter to datatable, that's good * cleanly add a sub in C4/Acquisition * perlcritic is OK Marking failed QA because small/trivial follow-up suggested by katrin would be cool: (In reply to comment #5)
make take up a bit more space though. I think it would be nice to get some more opinions on the display. Usually the library enter at least a part of the supplier, so it's OK to have a wider list. The gain for having non-nested <table> is worth it !
Some notes: I am wondering a bit about the list of vendors on top, perhaps this could go into a filter box on the left side instead? Good idea. And another option would be to have a select instead of <a href>. The librarian want to find just 1 vendor usually. What is interesting with the idea is that all booksellers are on the top of the page. With dozens of suppliers, the list will be long. With a select, it will solve this problem. (select with auto-submit, no need to select THEN click OK) julian a small follow-up possible ?
Perhaps we could also make the columns on the result page match the descriptions on the order receive page (/acqui/parcels.pl?booksellerid=3). Item Count Biblio count Items expected good catch, will also easy translatability ! Julian, follow-up required
For functionality I only found one small thing: I noticed there is a warning in the logs when searching booksellers. Perhaps you could fix this in a follow-up? I couldn't reproduce it. Where you testing with "mysql" user or any specific thing ?
There is also an error when checking for XHTML validity: Line 304, Column 151: cannot generate system identifier for general entity "op"
Katrin, how did you get this ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-27 16:18:12 UTC --- Hi Paul and Julian, List of vendors: I really like the idea of a select box over the long list of links! XHTML: I used http://validator.w3.org/ direct input option. Warning in logs: I was logged in as a normal user. I think it was a warning for an unitialized variable. I can try to reproduce later. I often use an 'empty' search to get all vendors in the system. Perhaps this makes a difference in testing. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-02-27 16:20:20 UTC --- Ah, I see I copied the warning into the bug. Not sure what went wrong there, I will retest. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> 2012-03-01 08:51:25 UTC --- Created attachment 7956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7956 Bug 7169: Follow-up: Change booksellers search results display - List of booksellers changed to a drop-down list - Baskets columns renamed and reordered to make them consistent with acqui/parcels.pl - warning in log removed - changed a '&' to '&' to pass W3 validator -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jean-manuel.broust@univ-lyo | |n2.fr --- Comment #12 from jmbroust <jean-manuel.broust@univ-lyon2.fr> --- Applying: Bug 7169: Change booksellers search results display Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging acqui/booksellers.pl CONFLICT (content): Merge conflict in acqui/booksellers.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css Failed to merge in the changes. Patch failed at 0001 Bug 7169: Change booksellers search results display -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7885|0 |1 is obsolete| | --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 8294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8294&action=edit Bug 7169: Change booksellers search results display Rebased on master since it does not apply anymore, but already signed off by Katrin, but the "Signed-off-by:" is not in this commit message. How can we avoid to ask for a new sign-off in this case? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7956|0 |1 is obsolete| | --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 8295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8295&action=edit Follow-up: Change booksellers search results display Rebased on master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |koha@univ-lyon3.fr --- Comment #15 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Appearence OK. Count of items and biblio in the commande and items still expected OK. Select box OK. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #16 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * removes a sub from a .pl, which is good (for plack compliance) * better display * perlcritic OK * valid_template.t OK (there is a warning on (xt/author/valid-templates.t .. 414/? Argument "" isn't numeric in numeric lt (<) at /home/paul/koha.dev/koha-community/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt line 226. that is not related to this patch passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #17 from Julian Maurice <julian.maurice@biblibre.com> --- Ok in master, marked as resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org