https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18582 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 63391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63391&action=edit Bug 18582 - Hide empty rows in detailed suggestion view This patch adds a check for the existence of various template variables before showing the row containing that data. This will prevent the display of rows containing labels but no data in the suggestions detailed view. To test, apply the patch and go to Acquisitions -> Suggestions. View the detail page of various suggestions and confirm that only fields with data are displaying. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18582 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63391|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63422&action=edit [SIGNED-OFF] Bug 18582 - Hide empty rows in detailed suggestion view This patch adds a check for the existence of various template variables before showing the row containing that data. This will prevent the display of rows containing labels but no data in the suggestions detailed view. To test, apply the patch and go to Acquisitions -> Suggestions. View the detail page of various suggestions and confirm that only fields with data are displaying. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18582 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63422|0 |1 is obsolete| | --- Comment #3 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 64419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64419&action=edit Bug 18582 - Hide empty rows in detailed suggestion view This patch adds a check for the existence of various template variables before showing the row containing that data. This will prevent the display of rows containing labels but no data in the suggestions detailed view. To test, apply the patch and go to Acquisitions -> Suggestions. View the detail page of various suggestions and confirm that only fields with data are displaying. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18582 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.