[Bug 37954] New: Unable to hide barcode column in holdings table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 Bug ID: 37954 Summary: Unable to hide barcode column in holdings table Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 32447 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32447 [Bug 32447] In items table barcode column can not be filtered -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171659&action=edit Bug 37954: Fix barcode column name Patch https://github.com/Koha-Community/Koha/commit/6cbbfa2 changed holdings_barcode to holdings_barcodes I believe this caused the configuration from the table to no longer work (barcodes!=barcode) Test plan: 1) Access any bibllio: <staff_url>/cgi-bin/koha/catalogue/detail.pl?biblionumber=76 2) On the top right of the table, click 'Configure' 3) Expand 'Catalog', search for 'holdings_barcode'. Tick 'is hidden by default'. Save. 4) Visit the biblio again, notice the column is still showing. 5) Apply patch. Restart all + flush_memcached. Repeat. 6) Bonus: On the table, click 'Show filters'. Make sure barcode filtering still works. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com, | |julian.maurice@biblibre.com | |, katrin.fischer@bsz-bw.de, | |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171659|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171662&action=edit Bug 37954: Fix barcode column name Patch https://github.com/Koha-Community/Koha/commit/6cbbfa2 changed holdings_barcode to holdings_barcodes I believe this caused the configuration from the table to no longer work (barcodes!=barcode) Test plan: 1) Access any bibllio: <staff_url>/cgi-bin/koha/catalogue/detail.pl?biblionumber=76 2) On the top right of the table, click 'Configure' 3) Expand 'Catalog', search for 'holdings_barcode'. Tick 'is hidden by default'. Save. 4) Visit the biblio again, notice the column is still showing. 5) Apply patch. Restart all + flush_memcached. Repeat. 6) Bonus: On the table, click 'Show filters'. Make sure barcode filtering still works. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171662|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 171698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171698&action=edit Bug 37954: Fix barcode column name Patch https://github.com/Koha-Community/Koha/commit/6cbbfa2 changed holdings_barcode to holdings_barcodes I believe this caused the configuration from the table to no longer work (barcodes!=barcode) Test plan: 1) Access any bibllio: <staff_url>/cgi-bin/koha/catalogue/detail.pl?biblionumber=76 2) On the top right of the table, click 'Configure' 3) Expand 'Catalog', search for 'holdings_barcode'. Tick 'is hidden by default'. Save. 4) Visit the biblio again, notice the column is still showing. 5) Apply patch. Restart all + flush_memcached. Repeat. 6) Bonus: On the table, click 'Show filters'. Make sure barcode filtering still works. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 --- Comment #4 from David Nind <david@davidnind.com> --- I've added my sign off - maybe Owen could do the QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes hiding the release notes| |barcode column on the staff | |interface for a record's | |holdings table. You can now | |turn on or off hiding the | |barcode by default, and | |select the display of the | |barcode column using the | |'Columns' setting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171698|0 |1 is obsolete| | --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 171713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171713&action=edit Bug 37954: Fix barcode column name Patch https://github.com/Koha-Community/Koha/commit/6cbbfa2 changed holdings_barcode to holdings_barcodes I believe this caused the configuration from the table to no longer work (barcodes!=barcode) Test plan: 1) Access any bibllio: <staff_url>/cgi-bin/koha/catalogue/detail.pl?biblionumber=76 2) On the top right of the table, click 'Configure' 3) Expand 'Catalog', search for 'holdings_barcode'. Tick 'is hidden by default'. Save. 4) Visit the biblio again, notice the column is still showing. 5) Apply patch. Restart all + flush_memcached. Repeat. 6) Bonus: On the table, click 'Show filters'. Make sure barcode filtering still works. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 171714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171714&action=edit Bug 37954: Atomic update Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 --- Comment #7 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- I think we need to address existing data here - we shouldn't make the users need to update again. I suspect the changes happened in bug 33568 as bug 32447 was fixing the issue of barcode filters not working. Leaving as SO to get QA on the update -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171713|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172561&action=edit Bug 37954: Fix barcode column name Patch https://github.com/Koha-Community/Koha/commit/6cbbfa2 changed holdings_barcode to holdings_barcodes I believe this caused the configuration from the table to no longer work (barcodes!=barcode) Test plan: 1) Access any bibllio: <staff_url>/cgi-bin/koha/catalogue/detail.pl?biblionumber=76 2) On the top right of the table, click 'Configure' 3) Expand 'Catalog', search for 'holdings_barcode'. Tick 'is hidden by default'. Save. 4) Visit the biblio again, notice the column is still showing. 5) Apply patch. Restart all + flush_memcached. Repeat. 6) Bonus: On the table, click 'Show filters'. Make sure barcode filtering still works. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171714|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 172562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172562&action=edit Bug 37954: Atomic update Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Update tested and I'm happy that it achieves the desired effects. Adding PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 --- Comment #11 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172563&action=edit [23.11] Bug 37954: Atomc update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 --- Comment #12 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Adding 23.11 version of the atomic update here if RMaint decides to backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172563|0 |1 is obsolete| | --- Comment #13 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 172564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172564&action=edit [23.11] Bug 37954: Atomic update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Pedro Amorim from comment #12)
Adding 23.11 version of the atomic update here if RMaint decides to backport.
What is the difference? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 --- Comment #15 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #14)
(In reply to Pedro Amorim from comment #12)
Adding 23.11 version of the atomic update here if RMaint decides to backport.
What is the difference?
use Koha::Installer::Output qw(say_warning say_failure say_success say_info); Addded in bug 35681, pushed to 24.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Pedro Amorim from comment #15)
(In reply to Katrin Fischer from comment #14)
(In reply to Pedro Amorim from comment #12)
Adding 23.11 version of the atomic update here if RMaint decides to backport.
What is the difference?
use Koha::Installer::Output qw(say_warning say_failure say_success say_info);
Addded in bug 35681, pushed to 24.05.
Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.06 released in| | Status|Pushed to main |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|24.11.00,24.05.06 |24.11.00,24.05.06,23.11.11 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #19 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 --- Comment #20 from Fridolin Somers <fridolin.somers@biblibre.com> --- Small question about atomic update : INSERT IGNORE INTO columns_settings VALUES ('catalogue', 'detail', 'holdings_table', 'holdings_barcode', $cannot_be_toggled, $is_hidden ) Should we always name the columns in an insert ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 Angela Berrett <angela.berrett@familysearch.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |angela.berrett@familysearch | |.org --- Comment #21 from Angela Berrett <angela.berrett@familysearch.org> --- We just got updated to 24.05.06 and now any columns I have configured to be hidden by default are showing in the Holdings tables. Have undone and redone them several times. Did this break something? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 --- Comment #22 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Angela Berrett from comment #21)
We just got updated to 24.05.06 and now any columns I have configured to be hidden by default are showing in the Holdings tables. Have undone and redone them several times. Did this break something?
Hi Angela, This seems to be a separate bug which I have filed today: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=38978 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 --- Comment #23 from Angela Berrett <angela.berrett@familysearch.org> --- (In reply to Lucas Gass (lukeg) from comment #22)
(In reply to Angela Berrett from comment #21)
We just got updated to 24.05.06 and now any columns I have configured to be hidden by default are showing in the Holdings tables. Have undone and redone them several times. Did this break something?
Hi Angela,
This seems to be a separate bug which I have filed today:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38978
Yep! Thank you! I'll watch that one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |jesse@bywatersolutions.com Status|Pushed to oldoldstable |RESOLVED --- Comment #24 from Jesse Maseto <jesse@bywatersolutions.com> --- Not pushed to LTS(23.11.x). Backport only major critical and security issues. Marked Resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37954 --- Comment #25 from Jesse Maseto <jesse@bywatersolutions.com> --- Not pushed to LTS(22.11.x). Backport only major critical and security issues. Marked Resolved -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org