[Bug 16806] New: "Too soon" renewal error generates no alert for user
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16806 Bug ID: 16806 Summary: "Too soon" renewal error generates no alert for user Change sponsored?: --- Product: Koha Version: 16.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: ephetteplace@cca.edu QA Contact: testopia@bugs.koha-community.org Created attachment 52773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52773&action=edit example of error Steps to recreate: - for a particular item type & patron category, configure a non-zero "no renewal before" date i.e. make it so items cannot be immediately renewed - sign in as a patron in aforementioned patron category - check out an item of aforementioned item type - go to your renewals page in OPAC /cgi-bin/koha/opac-user.pl Actual results: - note that under the "Renew" column a message prints indicating you cannot renew, due to lines 244-249 of /koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt - https://github.com/Koha-Community/Koha/blob/87dbed0abd67e88ae85f633d9f4c63c3... - however, the logic above on lines 77-85 doesn't match, the "too_soon" error isn't being tested for - https://github.com/Koha-Community/Koha/blob/87dbed0abd67e88ae85f633d9f4c63c3... The end result is undesirable: because the error loop triggers, the patron sees a message, but *there's no reason given*! See attached screenshot. Expected results: - a message prints indicating the reason why you cannot renew the item I'll add a patch to opac-user.tt for this shortly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16806 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ephetteplace@cca.edu Assignee|oleonard@myacpl.org |ephetteplace@cca.edu Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16806 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16806 --- Comment #1 from Eric Phetteplace <ephetteplace@cca.edu> --- Created attachment 52774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52774&action=edit patch for opac-user.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16806 Eric Phetteplace <ephetteplace@cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16806 Brendon Ford <brendon.ford@manhattan.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16806 Brendon Ford <brendon.ford@manhattan.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52774|0 |1 is obsolete| | --- Comment #2 from Brendon Ford <brendon.ford@manhattan.edu> --- Created attachment 54085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54085&action=edit Bug 16806: no error message for 'too_soon' renewal To test: - for a particular item type & patron category, configure a non-zero "no renewal before" date so items can't be immediately renewed - sign in as a patron in aforementioned patron category - check out an item of aforementioned item type - go to your renewals page in OPAC /cgi-bin/koha/opac-user.pl - an error messages appears in the div.alert.dialog up top Sponsored-by: California College of the Arts Signed-off-by: Brendon Ford <brendon.ford@manhattan.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16806 Irma Birchall <irma@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54085|0 |1 is obsolete| | --- Comment #3 from Irma Birchall <irma@calyx.net.au> --- Created attachment 54087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54087&action=edit Bug 16806: no error message for 'too_soon' renewal To test: - for a particular item type & patron category, configure a non-zero "no renewal before" date so items can't be immediately renewed - sign in as a patron in aforementioned patron category - check out an item of aforementioned item type - go to your renewals page in OPAC /cgi-bin/koha/opac-user.pl - an error messages appears in the div.alert.dialog up top Sponsored-by: California College of the Arts Signed-off-by: Brendon Ford <brendon.ford@manhattan.edu> Signed-off-by: Irma Birchall <irma@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16806 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16806 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54087|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 54116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54116&action=edit [PASSED QA] Bug 16806: no error message for 'too_soon' renewal To test: - for a particular item type & patron category, configure a non-zero "no renewal before" date so items can't be immediately renewed - sign in as a patron in aforementioned patron category - check out an item of aforementioned item type - go to your renewals page in OPAC /cgi-bin/koha/opac-user.pl - an error messages appears in the div.alert.dialog up top Sponsored-by: California College of the Arts Signed-off-by: Brendon Ford <brendon.ford@manhattan.edu> Signed-off-by: Irma Birchall <irma@calyx.net.au> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16806 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Eric, Brendon and Irma! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16806 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Eric! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16806 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #7 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.03. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16806 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x, will be in 3.22.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org