[Bug 16499] New: circulation.pl logs warnings about Use of uninitialized value
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16499 Bug ID: 16499 Summary: circulation.pl logs warnings about Use of uninitialized value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 14015 If you search for a patron in the circulation module, you get: Use of uninitialized value $barcode in string eq at /home/koha/src/circ/circulation.pl line 84. Use of uninitialized value $restoreduedatespec in string eq at /home/koha/src/circ/circulation.pl line 170. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14015 [Bug 14015] Checkout: Fix software error if barcode '0' is given -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16499 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16499 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51436&action=edit Bug 16499: Remove "Use of uninitialized value" warnings in circulation.pl If you search for a patron in the circulation module, you get: Use of uninitialized value $barcode in string eq at /home/koha/src/circ/circulation.pl line 84. Use of uninitialized value $restoreduedatespec in string eq at /home/koha/src/circ/circulation.pl line 170. Test plan: - Search for a patron and confirm the warnings are not displayed anymore - Make sure this patch does not introduce regression on bug 14015 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16499 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16499 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51436|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 51440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51440&action=edit [SIGNED-OFF] Bug 16499: Remove "Use of uninitialized value" warnings in circulation.pl If you search for a patron in the circulation module, you get: Use of uninitialized value $barcode in string eq at /home/koha/src/circ/circulation.pl line 84. Use of uninitialized value $restoreduedatespec in string eq at /home/koha/src/circ/circulation.pl line 170. Test plan: - Search for a patron and confirm the warnings are not displayed anymore - Make sure this patch does not introduce regression on bug 14015 Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16499 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16499 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 51635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51635&action=edit Bug 16499: Remove "Use of uninitialized value" warnings in circulation.pl If you search for a patron in the circulation module, you get: Use of uninitialized value $barcode in string eq at /home/koha/src/circ/circulation.pl line 84. Use of uninitialized value $restoreduedatespec in string eq at /home/koha/src/circ/circulation.pl line 170. Test plan: - Search for a patron and confirm the warnings are not displayed anymore - Make sure this patch does not introduce regression on bug 14015 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16499 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16499 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51440|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16499 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51635|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 51721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51721&action=edit Bug 16499: Remove "Use of uninitialized value" warnings in circulation.pl If you search for a patron in the circulation module, you get: Use of uninitialized value $barcode in string eq at /home/koha/src/circ/circulation.pl line 84. Use of uninitialized value $restoreduedatespec in string eq at /home/koha/src/circ/circulation.pl line 170. Test plan: - Search for a patron and confirm the warnings are not displayed anymore - Make sure this patch does not introduce regression on bug 14015 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16499 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 51722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51722&action=edit Bug 16499 [QA Followup] - Improve readability -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16499 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16499 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org