[Bug 39473] New: Confusing behavior in drop-down filters on item holdings table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 Bug ID: 39473 Summary: Confusing behavior in drop-down filters on item holdings table Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: emily.lamancusa@montgomerycountymd.gov QA Contact: testopia@bugs.koha-community.org To reproduce: 0. If not using default KTD data, create an item type with the following settings: Item type: BK Description: Books leave all other values on their defaults 1. Create a new item type with the following settings: Item type: BKA Description: Other type of book leave all other values on their defaults 2. Add or edit items on a bib record so that the record has at least one item of type "Books" and at least one item of type "Another type of book" 3. Go to Normal View for that bib record 4. Click "Show filters" above the item holdings table 5. In the Item type column, filter by "Books" --> Both "Books" and "Another type of book" items show in the table --> The drop-down is set to "Other type of book", even though you selected "Books" The table and drop-down appear matching on item type codes that contain the string "BK", rather than matching on the exact string. I was able to reproduce the bug with branchcodes as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33568 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 [Bug 33568] Use the REST API to display items on the staff biblio detail view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181258&action=edit Bug 39473: Add Cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181259&action=edit Bug 39473: Use exact search for column filtering with dropdown We need to use an exact search when using the id of an option. Test plan: 0. If not using default KTD data, create an item type with the following settings: Item type: BK Description: Books leave all other values on their defaults 1. Create a new item type with the following settings: Item type: BKA Description: Other type of book leave all other values on their defaults 2. Add or edit items on a bib record so that the record has at least one item of type "Books" and at least one item of type "Another type of book" 3. Go to Normal View for that bib record 4. Click "Show filters" above the item holdings table 5. In the Item type column, filter by "Books" Only "Books" items show in the table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Assignee|oleonard@myacpl.org |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181258|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 181268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181268&action=edit Bug 39473: Add Cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #3)
Created attachment 181268 [details] [review] Bug 39473: Add Cypress tests
This is not really nice code but I failed to make it pretty. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181259|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 181570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181570&action=edit Bug 39473: Use exact search for column filtering with dropdown We need to use an exact search when using the id of an option. Test plan: 0. If not using default KTD data, create an item type with the following settings: Item type: BK Description: Books leave all other values on their defaults 1. Create a new item type with the following settings: Item type: BKA Description: Other type of book leave all other values on their defaults 2. Add or edit items on a bib record so that the record has at least one item of type "Books" and at least one item of type "Another type of book" 3. Go to Normal View for that bib record 4. Click "Show filters" above the item holdings table 5. In the Item type column, filter by "Books" Only "Books" items show in the table Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181268|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 181571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181571&action=edit Bug 39473: Add Cypress tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Confusing behavior in |Confusing behavior in |drop-down filters on item |dropdown filters on item |holdings table |holdings table CC| |david@davidnind.com Text to go in the| |This fixes the dropdown release notes| |filters for the holdings | |table in the staff | |interface. The filters now | |use an exact match. | | | |Example: Items with an item | |type of BK (Books) and BKA | |(Other type of book) would | |both be shown if either was | |selected in the dropdown | |list, instead of just the | |items for the specific item | |type. --- Comment #7 from David Nind <david@davidnind.com> --- Testing notes (using KTD) 1. Tests pass before and after the patch: yarn cypress run --spec t/cypress/integration/KohaTable/Holdings_spec.ts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181570|0 |1 is obsolete| | --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 182109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182109&action=edit Bug 39473: Use exact search for column filtering with dropdown We need to use an exact search when using the id of an option. Test plan: 0. If not using default KTD data, create an item type with the following settings: Item type: BK Description: Books leave all other values on their defaults 1. Create a new item type with the following settings: Item type: BKA Description: Other type of book leave all other values on their defaults 2. Add or edit items on a bib record so that the record has at least one item of type "Books" and at least one item of type "Another type of book" 3. Go to Normal View for that bib record 4. Click "Show filters" above the item holdings table 5. In the Item type column, filter by "Books" Only "Books" items show in the table Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #181571|0 |1 is obsolete| | --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 182110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182110&action=edit Bug 39473: Add Cypress tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Confusing behavior in |Drop-down filters on item |dropdown filters on item |holdings table should match |holdings table |codes exactly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40118 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40118 [Bug 40118] 'Holds to pull' library filters don't work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.08 released in| | --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- (without patch on Cypress tests) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 Bug 39473 depends on bug 33568, which changed state. Bug 33568 Summary: Use the REST API to display items on the staff biblio detail view https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #13 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- 39987 - Batch item deletion breadcrumb uses wrong link -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 --- Comment #15 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39473 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #16 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org