[Bug 36922] New: Correct hint on date patron attributes not being repeatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36922 Bug ID: 36922 Summary: Correct hint on date patron attributes not being repeatable Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 32610 Date attributes can now be repeated, so we should update the hint on the administration page: If checked, attribute will be a date. Date attributes cannot be repeatable or linked to an authorised value category. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610 [Bug 32610] Add ability to specify patron attribute as a date -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36922 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch CC| |pedro.amorim@ptfs-europe.co | |m Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36922 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36922 --- Comment #1 from David Nind <david@davidnind.com> --- Created attachment 167319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167319&action=edit Bug 36922: Patron attributes - update hint text for "Is a date" The date field for patron attributes is now repeatable (enhancement made in Koha 24.05 with bug 32610). This updates the hint text to reflect the change. Test plan: 1. Go to add a patron attribute (Administration > Patrons and circulation > Patron attribute types > + New patron attribute type ) 2. Note that the hint for the "Is a date" field says "...Date attributes cannot be repeatable or linked to an authorised value category.". 3. Apply the patch. 4. Reload the page. 5. Note that the hint now says "...Date attributes are repeatable, but cannot be linked to an authorised value category." 6. Sign off D: Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36922 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main CC| |david@davidnind.com Text to go in the| |This updates the hint text release notes| |for "Is a date" when adding | |a patron attribute - date | |fields are now repeatable | |(an enhancement added to | |Koha 24.05 by bug 32610). Assignee|koha-bugs@lists.koha-commun |david@davidnind.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36922 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36922 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167319|0 |1 is obsolete| | --- Comment #2 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 167337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167337&action=edit Bug 36922: Patron attributes - update hint text for "Is a date" The date field for patron attributes is now repeatable (enhancement made in Koha 24.05 with bug 32610). This updates the hint text to reflect the change. Test plan: 1. Go to add a patron attribute (Administration > Patrons and circulation > Patron attribute types > + New patron attribute type ) 2. Note that the hint for the "Is a date" field says "...Date attributes cannot be repeatable or linked to an authorised value category.". 3. Apply the patch. 4. Reload the page. 5. Note that the hint now says "...Date attributes are repeatable, but cannot be linked to an authorised value category." 6. Sign off D: PA amended: 'are repeatable' -> 'can be repeatable' Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36922 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- @David I changed the text slightly: 'are repeatable' -> 'can be repeatable' Date fields are optionally repeatable, so it may or may not be repeatable. Do you agree with this? Thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36922 --- Comment #4 from David Nind <david@davidnind.com> --- (In reply to Pedro Amorim from comment #3)
@David I changed the text slightly: 'are repeatable' -> 'can be repeatable'
Date fields are optionally repeatable, so it may or may not be repeatable. Do you agree with this? Thanks.
Thanks Pedro. I generally try to write things in the active voice, but I'm OK with the change. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36922 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36922 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167337|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 167400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167400&action=edit Bug 36922: Patron attributes - update hint text for "Is a date" The date field for patron attributes is now repeatable (enhancement made in Koha 24.05 with bug 32610). This updates the hint text to reflect the change. Test plan: 1. Go to add a patron attribute (Administration > Patrons and circulation > Patron attribute types > + New patron attribute type ) 2. Note that the hint for the "Is a date" field says "...Date attributes cannot be repeatable or linked to an authorised value category.". 3. Apply the patch. 4. Reload the page. 5. Note that the hint now says "...Date attributes are repeatable, but cannot be linked to an authorised value category." 6. Sign off D: PA amended: 'are repeatable' -> 'can be repeatable' Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36922 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36922 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36922 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36922 Bug 36922 depends on bug 32610, which changed state. Bug 32610 Summary: Add ability to specify patron attribute as a date https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32610 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36922 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.11.00 |24.11.00,24.05.02 released in| | Status|Pushed to main |Pushed to stable --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36922 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 32610 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36922 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36922 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #9 from David Nind <david@davidnind.com> --- No change required to the manual - screenshot is up-to-date (added by manual changes for bug 32610), no changes to the text required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org