[Bug 28854] New: [ALTERNATIVE] Add ability to create bundles of items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Bug ID: 28854 Summary: [ALTERNATIVE] Add ability to create bundles of items Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: andrew@bywatersolutions.com, bwsdonna@gmail.com, cecile.joyet@biblibre.com, dcook@prosentient.com.au, e.betemps@gmail.com, fiona.borthwick@ptfs-europe.com, george@nekls.org, jonathan.field@ptfs-europe.com, julian.maurice@biblibre.com, m.de.rooy@rijksmuseum.nl, martin.renvoize@ptfs-europe.com, severine.queune@bulac.fr, testopia@bugs.koha-community.org, tomascohen@gmail.com +++ This bug was initially created as a clone of Bug #24023 +++ This bug started as a rebase of bug 24023, but as time went on and I tested that bug I found bits of it lacking and felt enough time had passed that we could try a more modern approach. To keep the work distinct, I created this bug to encompass my alternative approach. This new feature will add the ability to bundle existing items together into loanable sets linked to a new collection bibliographic record. Items will be withdrawn from their original bib and take on the circulation rules of the collection record. We update the display for items attached to a collection to show what collection they are linked to and we added the ability to expand a collection item to list it's content items. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.com/mrenvoiz | |e/Koha/-/commits/bug_28854 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- See branch for work in progress: https://gitlab.com/mrenvoize/Koha/-/commits/bug_28854 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24857 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124319&action=edit Bug 28854: Add ability to create and circulate item bundles This patch adds the ability to attach item bundles to biblio records. Item bundles can then be circulated as with normal items. Upon attaching an item to one of these item bundles, the item is automatically marked as not for loan at it's original host biblio record. When returning a bundle, the list of items that are part of this bundle will be displayed, and a verification form is exposed requireing the librarian to scan item barcodes to verify their presence. Should a bundle be found to have items missing they will be marked as lost. Bundles can also be used in the inventory tool as a filter. Test plan: 0. Apply the patch, run updatedatabase + update_dbix_class_files 1. Create a new bundle record. 1a. Create a biblio record with leader position 7 set to 'c' for collection. 1b. Create an item for this biblio record. 1c. You should now see a new 'Bundle' button next to the item in the holdings table. Test: Verify that this 'Bundle' button only appears for biblio's where leader position 7 is not 'c' for collection 1d. Use the new 'Bundle' button to trigger a modal allowing you to attach items to the bundle. Test: Enter a non-existant barcode, submit and confirm you recieve an error message. Test: Enter an existing barcode, submit and note the success message. Test: Enter the same barcode as above, submit and note the warning message. Test: Add a second item to the bib and try bundling one of the above items into this second item, note the error message. 2. Open a new tab and look at the holdings data for one of the items you attached to a bundle in step 1. Test: Verify that the holdings status displays 'Not for loan'. Test: Verify that the holdings status show which bundle the item has been attached to. 3. Perform a checkout on the first bundle item. Test: Checkout should proceed as normal, obeying the circulation rules for the item type you chose to convert into a bundle. 4. Perform a checkin on the first bundle item. Test: You should be presented with a modal that contains a list of items contained in the bundle and a test box for entering item barcodes. Test: Enter some of the barcodes for items in the bundle into the box and submit. The bundle item should have been marked as returned, you should also have been notified of missing items and have the ability to print an updated contents list. Test: Verify that the items you did not enter barcodes for are now marked as lost. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I wanted to start getting feedback for this so have uploaded a patch for testing. It includes a basic test plan, but I'm sure I've missed some area's :( so would appreciate feedback. I also realise it still needs unit tests adding for the various object methods introduced before it'll go through QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This new feature adds the release notes| |ability to create item | |bundles for loans. | | | |One can | |create a new collection | |level biblio record and add | |items to it as normal. | |Those items can then be | |converted to bundles by | |adding existing items to | |them using their barcodes. | |The items will be marked as | |'not for loan' in their | |original parent records. | | | |Bundle items follow normal | |circulation rules for | |checkout. Upon check-in a | |new verification step is | |added where by the | |librarian is expected to | |scan each constituent item | |to varify it's presence in | |the bundle. If an item is | |missing from the bundle it | |is marked as lost with a | |new lost - Missing from | |bundle value. If an item | |is found that is not | |expected to be in the | |bundle it it highlighted to | |the librarian after | |check-in so it can be | |placed to one side. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |kyle@bywatersolutions.com, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucy.vaux-harvey@ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124319|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124498&action=edit Bug 28854: Add ability to create and circulate item bundles This patch adds the ability to attach item bundles to biblio records. Item bundles can then be circulated as with normal items. Upon attaching an item to one of these item bundles, the item is automatically marked as not for loan at it's original host biblio record. When returning a bundle, the list of items that are part of this bundle will be displayed, and a verification form is exposed requireing the librarian to scan item barcodes to verify their presence. Should a bundle be found to have items missing they will be marked as lost. Bundles can also be used in the inventory tool as a filter. Test plan: 0. Apply the patch, run updatedatabase + update_dbix_class_files 1. Create a new bundle record. 1a. Create a biblio record with leader position 7 set to 'c' for collection. 1b. Create an item for this biblio record. 1c. You should now see a new 'Bundle' button next to the item in the holdings table. Test: Verify that this 'Bundle' button only appears for biblio's where leader position 7 is not 'c' for collection 1d. Use the new 'Bundle' button to trigger a modal allowing you to attach items to the bundle. Test: Enter a non-existant barcode, submit and confirm you recieve an error message. Test: Enter an existing barcode, submit and note the success message. Test: Enter the same barcode as above, submit and note the warning message. Test: Add a second item to the bib and try bundling one of the above items into this second item, note the error message. 2. Open a new tab and look at the holdings data for one of the items you attached to a bundle in step 1. Test: Verify that the holdings status displays 'Not for loan'. Test: Verify that the holdings status show which bundle the item has been attached to. 3. Perform a checkout on the first bundle item. Test: Checkout should proceed as normal, obeying the circulation rules for the item type you chose to convert into a bundle. 4. Perform a checkin on the first bundle item. Test: You should be presented with a modal that contains a list of items contained in the bundle and a test box for entering item barcodes. Test: Enter some of the barcodes for items in the bundle into the box and submit. The bundle item should have been marked as returned, you should also have been notified of missing items and have the ability to print an updated contents list. Test: Verify that the items you did not enter barcodes for are now marked as lost. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20447 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124498|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 124616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124616&action=edit Bug 28854: Add ability to create and circulate item bundles This patch adds the ability to attach item bundles to biblio records. Item bundles can then be circulated as with normal items. Upon attaching an item to one of these item bundles, the item is automatically marked as not for loan at it's original host biblio record. When returning a bundle, the list of items that are part of this bundle will be displayed, and a verification form is exposed requireing the librarian to scan item barcodes to verify their presence. Should a bundle be found to have items missing they will be marked as lost. Bundles can also be used in the inventory tool as a filter. Test plan: 0. Apply the patch, run updatedatabase + update_dbix_class_files 1. Create a new bundle record. 1a. Create a biblio record with leader position 7 set to 'c' for collection. 1b. Create an item for this biblio record. 1c. You should now see a new 'Bundle' button next to the item in the holdings table. Test: Verify that this 'Bundle' button only appears for biblio's where leader position 7 is not 'c' for collection 1d. Use the new 'Bundle' button to trigger a modal allowing you to attach items to the bundle. Test: Enter a non-existant barcode, submit and confirm you recieve an error message. Test: Enter an existing barcode, submit and note the success message. Test: Enter the same barcode as above, submit and note the warning message. Test: Add a second item to the bib and try bundling one of the above items into this second item, note the error message. 2. Open a new tab and look at the holdings data for one of the items you attached to a bundle in step 1. Test: Verify that the holdings status displays 'Not for loan'. Test: Verify that the holdings status show which bundle the item has been attached to. 3. Perform a checkout on the first bundle item. Test: Checkout should proceed as normal, obeying the circulation rules for the item type you chose to convert into a bundle. 4. Perform a checkin on the first bundle item. Test: You should be presented with a modal that contains a list of items contained in the bundle and a test box for entering item barcodes. Test: Enter some of the barcodes for items in the bundle into the box and submit. The bundle item should have been marked as returned, you should also have been notified of missing items and have the ability to print an updated contents list. Test: Verify that the items you did not enter barcodes for are now marked as lost. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Looking good so far :) I've followed the test plan and everything works as expected. There are some things that are in bug 24023 that are missing here, but they can be re-added on top of it later. The big difference between both bugs is that, in bug 24023 the biblio record is the bundle (its item is only there for circulation), whereas in bug 28854 the item record is the bundle. It means that you can do completely different bundles under the same name (the biblio title). Is that intended ? About the UI, I find the "tables in table" idea confusing. There are just too much table controls in there :) What do you think of moving the list of bundled items inside the popup that opens when you click on the "Bundle" button ? qa tool reports a weird error: FAIL Koha/Item/Bundle.pm FAIL valid Inconsistent hierarchy during C3 merge of class 'Koha::Item::Bundle': current merge results [ Koha::Item::Bundle, ] merging failed on 'Koha::Item' but it doesn't break koha, which is even more weird :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29095 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29095 [Bug 29095] Add re-usable item-status include -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29095 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29095 [Bug 29095] Add re-usable item-status include -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29095 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125200&action=edit Bug 28854: Database update https://bugs.koha-community.org/show_bug.cgi?id=24454 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125201&action=edit Bug 28854: DBIC Schema Updates https://bugs.koha-community.org/show_bug.cgi?id=24454 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125202&action=edit Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point 1) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 2) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 3) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. TODO: Add Object Tests + API Tests https://bugs.koha-community.org/show_bug.cgi?id=24454 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125203&action=edit Bug 28854: Add bundle content display to OPAC TODO: Switch to /public api route TODO: Move expand button to right like staff client https://bugs.koha-community.org/show_bug.cgi?id=24454 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125204&action=edit Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. https://bugs.koha-community.org/show_bug.cgi?id=24454 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125205&action=edit Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that the patron who lost the item is displayed 4) Checkin the lost item * The item should be marked as found and the items_lost_issue table should no longer contain a link to the issue https://bugs.koha-community.org/show_bug.cgi?id=24454 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125206&action=edit Bug 28854: Respect WhenLostChargeReplacementFee https://bugs.koha-community.org/show_bug.cgi?id=24454 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124616|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29099 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29099 [Bug 29099] Add support for item bundles in the inventory tool -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Julian Maurice from comment #6)
Looking good so far :) I've followed the test plan and everything works as expected.
Thanks for testing and your comments Julian, very helpful. In reverse order... * Weird, I didn't see that QA failure, but will look into it.. C3 Merge always confuses me when I see it. * UI, I was thinking similar thoughts. I'm not sure whether to move it into the modal, or just try to somehow highlight the dropdown row background more to distinguish between the tables. The customer I have suggested they would like to be able to expand multiple rows so they can see two bundles together.. but I do agree at the moment it's a bit confusing. * Regarding the different level, I was also a bit confused by this. They are certainly keen to have it at the item level but I had thought it would be 'pick list at the biblio level' and then create bundles from that pick list at the item level. The didn't want the pick list at all?! I still temped to make that an option, allowing bib->bib constructs at the bib level and then when adding a bundle at the item level displaying the pick list of linked bibs for one to go and build the bundle up from the shelves. The main thing that I struggled with was finding a sensible marc field. * I'm aware the inventory side of this is missing and intend to do that in the next bug (It was already getting big here so I was trying to be pragmatic.. are there any other functions I've missed.. more than happy to accommodate them). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125200|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126103&action=edit Bug 28854: Database update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125201|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126104&action=edit Bug 28854: DBIC Schema Updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125202|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126105&action=edit Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point 1) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 2) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 3) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. TODO: Add Object Tests + API Tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125203|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126106&action=edit Bug 28854: Add bundle content display to OPAC TODO: Switch to /public api route TODO: Move expand button to right like staff client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125204|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126107&action=edit Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125205|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126108&action=edit Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that the patron who lost the item is displayed 4) Checkin the lost item * The item should be marked as found and the items_lost_issue table should no longer contain a link to the issue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125206|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126109&action=edit Bug 28854: Respect WhenLostChargeReplacementFee -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126110&action=edit Bug 28854: Highlight bundle rows to clarify UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28948 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948 [Bug 28948] Add a /public counterpart for the libraries REST endpoints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126103|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126148&action=edit Bug 28854: Database update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126104|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126149&action=edit Bug 28854: DBIC Schema Updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126105|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126150&action=edit Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point 1) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 2) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 3) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. TODO: Add Object Tests + API Tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126106|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126151&action=edit Bug 28854: Add bundle content display to OPAC TODO: Move expand button to right like staff client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126107|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126152&action=edit Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126108|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126153&action=edit Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that the patron who lost the item is displayed 4) Checkin the lost item * The item should be marked as found and the items_lost_issue table should no longer contain a link to the issue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126109|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126154&action=edit Bug 28854: Respect WhenLostChargeReplacementFee -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126110|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126155&action=edit Bug 28854: Highlight bundle rows to clarify UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|28948 |27358 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 [Bug 27358] Add GET /public/biblios/:biblio_id/items https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948 [Bug 28948] Add a /public counterpart for the libraries REST endpoints -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126148|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126166&action=edit Bug 28854: Database update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126149|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126167&action=edit Bug 28854: DBIC Schema Updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126150|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126168&action=edit Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point 1) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 2) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 3) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. TODO: Add Object Tests + API Tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126151|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126169&action=edit Bug 28854: Add bundle content display to OPAC TODO: Move expand button to right like staff client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126152|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126170&action=edit Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126153|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126171&action=edit Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that the patron who lost the item is displayed 4) Checkin the lost item * The item should be marked as found and the items_lost_issue table should no longer contain a link to the issue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126154|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126172&action=edit Bug 28854: Respect WhenLostChargeReplacementFee -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126155|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 126173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126173&action=edit Bug 28854: Highlight bundle rows to clarify UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Bug 28854 depends on bug 27358, which changed state. Bug 27358 Summary: Add GET /public/biblios/:biblio_id/items https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27358 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126166|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127498&action=edit Bug 28854: Database update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126167|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127499&action=edit Bug 28854: DBIC Schema Updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126168|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127500&action=edit Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point 1) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 2) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 3) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. TODO: Add Object Tests + API Tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126169|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127501&action=edit Bug 28854: Add bundle content display to OPAC TODO: Move expand button to right like staff client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126170|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127502&action=edit Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126171|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127503&action=edit Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that the patron who lost the item is displayed 4) Checkin the lost item * The item should be marked as found and the items_lost_issue table should no longer contain a link to the issue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126172|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127504&action=edit Bug 28854: Respect WhenLostChargeReplacementFee -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126173|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127505&action=edit Bug 28854: Highlight bundle rows to clarify UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127498|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127659&action=edit Bug 28854: Database update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127499|0 |1 is obsolete| | --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127660&action=edit Bug 28854: DBIC Schema Updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127500|0 |1 is obsolete| | --- Comment #49 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127661&action=edit Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point 1) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 2) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 3) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. TODO: Add Object Tests + API Tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127501|0 |1 is obsolete| | --- Comment #50 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127662&action=edit Bug 28854: Add bundle content display to OPAC TODO: Move expand button to right like staff client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127502|0 |1 is obsolete| | --- Comment #51 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127663&action=edit Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127503|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127664&action=edit Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that the patron who lost the item is displayed 4) Checkin the lost item * The item should be marked as found and the items_lost_issue table should no longer contain a link to the issue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127504|0 |1 is obsolete| | --- Comment #53 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127665&action=edit Bug 28854: Respect WhenLostChargeReplacementFee -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127505|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127666&action=edit Bug 28854: Highlight bundle rows to clarify UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29408 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 [Bug 29408] The datatables api wrapper is ambiguously named -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #55 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Just another rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29495 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29519 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 [Bug 29519] One should be able to resolve a return claim at checkin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29495 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127659|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127829&action=edit Bug 28854: Database update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127660|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127830&action=edit Bug 28854: DBIC Schema Updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127661|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127831&action=edit Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point 1) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 2) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 3) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. TODO: Add Object Tests + API Tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127662|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127832&action=edit Bug 28854: Add bundle content display to OPAC TODO: Move expand button to right like staff client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127663|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127833&action=edit Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127664|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127834&action=edit Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that it is marked as lost. 4) Navigate to the biblio for the collection and expand the collection item that contains the lost item. Note the item is marked as lost and checkout details are listed. 5) Checkin the lost item * The item should be marked as found and the return_claims line should be marked as resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #62 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127835&action=edit Bug 28854: Drop unique index on issue_id in return claims With the introduction of circulating items within a bundle set, we can now loose multiple items from the bundle from the same issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127836&action=edit Bug 28854: DBIC Update ReturnClaim Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127666|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127837&action=edit Bug 28854: Highlight bundle rows to clarify UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127838&action=edit Bug 28854: Simplified status handling for bundle inventory check -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com, | |kyle.m.hall@gmail.com Component|Cataloging |Circulation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29560 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29560 [Bug 29560] Add option to create MARC links when adding items to bundles -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29566 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29566 [Bug 29566] Convert bundle contents modal to a notice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29575 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 [Bug 29575] Add a JS render function equivalent of the patron-title.inc TT include -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127665|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127829|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127830|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127831|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127832|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127833|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127834|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127835|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127836|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127838|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127837|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL|https://gitlab.com/mrenvoiz |https://gitlab.com/mrenvoiz |e/Koha/-/commits/bug_28854 |e/Koha/-/merge_requests/6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #66 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Please see the linked branch/merge request on gitlab for the patchset.. uploading rebases here was getting a bit obscene. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Bug 28854 depends on bug 29408, which changed state. Bug 29408 Summary: The datatables api wrapper is ambiguously named https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29408 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Bug 28854 depends on bug 29575, which changed state. Bug 29575 Summary: Add a JS render function equivalent of the patron-title.inc TT include https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29575 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #67 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130313&action=edit Bug 28854: Database update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #68 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130314&action=edit Bug 28854: DBIC Schema Updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #69 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130315&action=edit Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point and run the database update 1) Configuration: `BundleNotLoanValue` should have been set by the database update and point to a newly added AV value. 2) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 3) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 4) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. 5) The bundles feature can be disabled by unsetting the `BundleNotLoanValue` system preference. TODO: Add Object Tests + API Tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #70 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130316&action=edit Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #71 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130317&action=edit Bug 28854: Highlight bundle rows to clarify UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #72 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130318&action=edit Bug 28854: Drop unique index on issue_id in return claims With the introduction of circulating items within a bundle set, we can now loose multiple items from the bundle from the same issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #73 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130319&action=edit Bug 28854: DBIC Update ReturnClaim Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #74 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130320&action=edit Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that it is marked as lost. 4) Navigate to the biblio for the collection and expand the collection item that contains the lost item. Note the item is marked as lost and checkout details are listed. 5) Checkin the lost item * The item should be marked as found and the return_claims line should be marked as resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #75 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130321&action=edit Bug 28854: Simplified status handling for bundle inventory check -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #76 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130322&action=edit Bug 28854: Add option to print content list after verification We already allowed the user to view and print an updated content list after a varification showed that items were missing from the bundle. This patch adds the option to view and print the list even if the content has been varified to have not changed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #77 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130323&action=edit Bug 28854: Add ordering to checkin validation modal This enhancement adds simple dataTable ordering to the verification modal table at bundle checkin time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #78 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130324&action=edit Bug 28854: Improve lost details display for bundle items This patch adds the return claim details to the bundle item status display on the catalogue details page. Test plan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #79 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130325&action=edit Bug 28854: Enable claims return view when BundleLostValue is set This patch adds the alternation of BundleLostValue to enable the return claims functionality when Bundles are enbled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #80 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130326&action=edit Bug 28854: Highlight when a scanned item is unexpected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #81 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130327&action=edit Bug 28854: Add count of scanned items to verification modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #82 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130328&action=edit Bug 28854: Add 'Remove from bundle' dialogue to details display This patch adds the counterpart of the 'Add to bundle' modal prompt for adding items to bundles from the catalogue details display. It allows for scanning barcodes to remove them from a bundle. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #83 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130329&action=edit Bug 28854: Add modal after checkin to print missing items list This patch adds a further modal to the post checkin alert to allow the user to print a view and print a list of items that went missing at this checkin to allow for replacements to be picked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #84 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130330&action=edit Bug 28854: (follow-up) Only count rows in the body This patch fixes the count to only include table rows in the body, i.e. skip the header row. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #85 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130331&action=edit Bug 28854: Make barcode comparison case insensative -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #86 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130332&action=edit Bug 28854: (follow-up) Fix rebase re-indroduction of .json The API schema's all changed to .yaml but a rebase here re-introduced the .json links -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #87 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We wrote some documentation for this, but bugzilla doesn't want to allow me to attach it.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #88 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130456&action=edit Documentation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #89 from David Nind <david@davidnind.com> --- Thanks Martin for creating the documentation! I will have a go at testing over the weekend, unless someone beats me to it! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130313|0 |1 is obsolete| | --- Comment #90 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 132703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132703&action=edit Bug 28854: Database update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #91 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 132704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132704&action=edit Bug 28854: Rename atomicupdate (.perl -> .pl) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130314|0 |1 is obsolete| | --- Comment #92 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 132705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132705&action=edit Bug 28854: DBIC Schema Updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130315|0 |1 is obsolete| | --- Comment #93 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 132706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132706&action=edit Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point and run the database update 1) Configuration: `BundleNotLoanValue` should have been set by the database update and point to a newly added AV value. 2) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 3) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 4) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. 5) The bundles feature can be disabled by unsetting the `BundleNotLoanValue` system preference. TODO: Add Object Tests + API Tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130316|0 |1 is obsolete| | --- Comment #94 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 132707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132707&action=edit Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130317|0 |1 is obsolete| | --- Comment #95 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 132708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132708&action=edit Bug 28854: Highlight bundle rows to clarify UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130318|0 |1 is obsolete| | --- Comment #96 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 132709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132709&action=edit Bug 28854: Drop unique index on issue_id in return claims With the introduction of circulating items within a bundle set, we can now loose multiple items from the bundle from the same issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130319|0 |1 is obsolete| | --- Comment #97 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 132710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132710&action=edit Bug 28854: DBIC Update ReturnClaim Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130320|0 |1 is obsolete| | --- Comment #98 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 132711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132711&action=edit Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that it is marked as lost. 4) Navigate to the biblio for the collection and expand the collection item that contains the lost item. Note the item is marked as lost and checkout details are listed. 5) Checkin the lost item * The item should be marked as found and the return_claims line should be marked as resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130321|0 |1 is obsolete| | --- Comment #99 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 132712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132712&action=edit Bug 28854: Simplified status handling for bundle inventory check -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130322|0 |1 is obsolete| | --- Comment #100 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 132713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132713&action=edit Bug 28854: Add option to print content list after verification We already allowed the user to view and print an updated content list after a varification showed that items were missing from the bundle. This patch adds the option to view and print the list even if the content has been varified to have not changed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130323|0 |1 is obsolete| | --- Comment #101 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 132714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132714&action=edit Bug 28854: Add ordering to checkin validation modal This enhancement adds simple dataTable ordering to the verification modal table at bundle checkin time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130324|0 |1 is obsolete| | --- Comment #102 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 132715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132715&action=edit Bug 28854: Improve lost details display for bundle items This patch adds the return claim details to the bundle item status display on the catalogue details page. Test plan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130325|0 |1 is obsolete| | --- Comment #103 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 132716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132716&action=edit Bug 28854: Enable claims return view when BundleLostValue is set This patch adds the alternation of BundleLostValue to enable the return claims functionality when Bundles are enbled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130326|0 |1 is obsolete| | --- Comment #104 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 132717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132717&action=edit Bug 28854: Highlight when a scanned item is unexpected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130327|0 |1 is obsolete| | --- Comment #105 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 132718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132718&action=edit Bug 28854: Add count of scanned items to verification modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130328|0 |1 is obsolete| | --- Comment #106 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 132719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132719&action=edit Bug 28854: Add 'Remove from bundle' dialogue to details display This patch adds the counterpart of the 'Add to bundle' modal prompt for adding items to bundles from the catalogue details display. It allows for scanning barcodes to remove them from a bundle. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130329|0 |1 is obsolete| | --- Comment #107 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 132720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132720&action=edit Bug 28854: Add modal after checkin to print missing items list This patch adds a further modal to the post checkin alert to allow the user to print a view and print a list of items that went missing at this checkin to allow for replacements to be picked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130330|0 |1 is obsolete| | --- Comment #108 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 132721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132721&action=edit Bug 28854: (follow-up) Only count rows in the body This patch fixes the count to only include table rows in the body, i.e. skip the header row. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130331|0 |1 is obsolete| | --- Comment #109 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 132722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132722&action=edit Bug 28854: Make barcode comparison case insensative -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130332|0 |1 is obsolete| | --- Comment #110 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 132723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132723&action=edit Bug 28854: (follow-up) Fix rebase re-indroduction of .json The API schema's all changed to .yaml but a rebase here re-introduced the .json links -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #111 from Julian Maurice <julian.maurice@biblibre.com> --- All patches rebased on master + a tiny fix for the name of the atomicupdate file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Amanda Campbell <acampbell@hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acampbell@hmcpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132703|0 |1 is obsolete| | --- Comment #112 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135019&action=edit Bug 28854: Database update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132705|0 |1 is obsolete| | --- Comment #113 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135020&action=edit Bug 28854: DBIC Schema Updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132706|0 |1 is obsolete| | --- Comment #114 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135021&action=edit Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point and run the database update 1) Configuration: `BundleNotLoanValue` should have been set by the database update and point to a newly added AV value. 2) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 3) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 4) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. 5) The bundles feature can be disabled by unsetting the `BundleNotLoanValue` system preference. TODO: Add Object Tests + API Tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132707|0 |1 is obsolete| | --- Comment #115 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135022&action=edit Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132708|0 |1 is obsolete| | --- Comment #116 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135023&action=edit Bug 28854: Highlight bundle rows to clarify UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132709|0 |1 is obsolete| | --- Comment #117 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135024&action=edit Bug 28854: Drop unique index on issue_id in return claims With the introduction of circulating items within a bundle set, we can now loose multiple items from the bundle from the same issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132710|0 |1 is obsolete| | --- Comment #118 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135025&action=edit Bug 28854: DBIC Update ReturnClaim Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132711|0 |1 is obsolete| | --- Comment #119 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135026&action=edit Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that it is marked as lost. 4) Navigate to the biblio for the collection and expand the collection item that contains the lost item. Note the item is marked as lost and checkout details are listed. 5) Checkin the lost item * The item should be marked as found and the return_claims line should be marked as resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132712|0 |1 is obsolete| | --- Comment #120 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135027&action=edit Bug 28854: Simplified status handling for bundle inventory check -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132713|0 |1 is obsolete| | --- Comment #121 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135028&action=edit Bug 28854: Add option to print content list after verification We already allowed the user to view and print an updated content list after a varification showed that items were missing from the bundle. This patch adds the option to view and print the list even if the content has been varified to have not changed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132714|0 |1 is obsolete| | --- Comment #122 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135029&action=edit Bug 28854: Add ordering to checkin validation modal This enhancement adds simple dataTable ordering to the verification modal table at bundle checkin time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132715|0 |1 is obsolete| | --- Comment #123 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135030&action=edit Bug 28854: Improve lost details display for bundle items This patch adds the return claim details to the bundle item status display on the catalogue details page. Test plan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132716|0 |1 is obsolete| | --- Comment #124 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135031&action=edit Bug 28854: Enable claims return view when BundleLostValue is set This patch adds the alternation of BundleLostValue to enable the return claims functionality when Bundles are enbled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132717|0 |1 is obsolete| | --- Comment #125 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135032&action=edit Bug 28854: Highlight when a scanned item is unexpected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132718|0 |1 is obsolete| | --- Comment #126 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135033&action=edit Bug 28854: Add count of scanned items to verification modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132719|0 |1 is obsolete| | --- Comment #127 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135034&action=edit Bug 28854: Add 'Remove from bundle' dialogue to details display This patch adds the counterpart of the 'Add to bundle' modal prompt for adding items to bundles from the catalogue details display. It allows for scanning barcodes to remove them from a bundle. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132720|0 |1 is obsolete| | --- Comment #128 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135035&action=edit Bug 28854: Add modal after checkin to print missing items list This patch adds a further modal to the post checkin alert to allow the user to print a view and print a list of items that went missing at this checkin to allow for replacements to be picked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132721|0 |1 is obsolete| | --- Comment #129 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135036&action=edit Bug 28854: (follow-up) Only count rows in the body This patch fixes the count to only include table rows in the body, i.e. skip the header row. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132722|0 |1 is obsolete| | --- Comment #130 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 135037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135037&action=edit Bug 28854: Make barcode comparison case insensative -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|[ALTERNATIVE] Add ability |Add ability to create |to create bundles of items |bundles of items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132704|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132723|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #131 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Another rebase after testing and finding some subtle issues with the last rebase. All seems to be working as expected now for me... ready for testing. I've squashed Julians two follow-ups, and my own rebase fixes all into the original patchset.. it was getting hard to track it all ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #132 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 24023 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25503 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25503 [Bug 25503] Add option to export items bundle contents in checkouts table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #133 from Owen Leonard <oleonard@myacpl.org> --- This looks like it's working pretty well in the staff interface. Is there a plan to make the contents of bundles visible in the OPAC? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #134 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good question Owen, the original sponsor for this has moved in now, but they weren't sure how they wanted things to display in the OPAC so in the end I dropped those patches from here. Biblibre used MARC linking in their original implementation and there's a bug followup submitted on this tree that allows for that too, optionally; That would allow for the display of a contents list at the bib level in effect then the box items just appear as usual.. so you get the contents list from the bib rather than having the specifics of each box (this obviously assumes each box attached to the bib is intended to include the same set of materials ) Alternatively my original implementation gave the same row expansion type display as the staff client, but without the management options. The original sponsor decided that felt confusing for the end user. I'm happy to be guided and submit something either here or as another follow-up bug like I have for the Marc linking option. Do you have any thoughts? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135019|0 |1 is obsolete| | --- Comment #135 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136226&action=edit Bug 28854: Database update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135020|0 |1 is obsolete| | --- Comment #136 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136227&action=edit Bug 28854: DBIC Schema Updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135021|0 |1 is obsolete| | --- Comment #137 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136228&action=edit Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point and run the database update 1) Configuration: `BundleNotLoanValue` should have been set by the database update and point to a newly added AV value. 2) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 3) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 4) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. 5) The bundles feature can be disabled by unsetting the `BundleNotLoanValue` system preference. TODO: Add Object Tests + API Tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135022|0 |1 is obsolete| | --- Comment #138 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136229&action=edit Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135023|0 |1 is obsolete| | --- Comment #139 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136230&action=edit Bug 28854: Highlight bundle rows to clarify UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135024|0 |1 is obsolete| | --- Comment #140 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136231&action=edit Bug 28854: Drop unique index on issue_id in return claims With the introduction of circulating items within a bundle set, we can now loose multiple items from the bundle from the same issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135025|0 |1 is obsolete| | --- Comment #141 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136232&action=edit Bug 28854: DBIC Update ReturnClaim Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135026|0 |1 is obsolete| | --- Comment #142 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136233&action=edit Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that it is marked as lost. 4) Navigate to the biblio for the collection and expand the collection item that contains the lost item. Note the item is marked as lost and checkout details are listed. 5) Checkin the lost item * The item should be marked as found and the return_claims line should be marked as resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135027|0 |1 is obsolete| | --- Comment #143 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136234&action=edit Bug 28854: Simplified status handling for bundle inventory check -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135028|0 |1 is obsolete| | --- Comment #144 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136235&action=edit Bug 28854: Add option to print content list after verification We already allowed the user to view and print an updated content list after a varification showed that items were missing from the bundle. This patch adds the option to view and print the list even if the content has been varified to have not changed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135029|0 |1 is obsolete| | --- Comment #145 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136236&action=edit Bug 28854: Add ordering to checkin validation modal This enhancement adds simple dataTable ordering to the verification modal table at bundle checkin time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135030|0 |1 is obsolete| | --- Comment #146 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136237&action=edit Bug 28854: Improve lost details display for bundle items This patch adds the return claim details to the bundle item status display on the catalogue details page. Test plan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135031|0 |1 is obsolete| | --- Comment #147 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136238&action=edit Bug 28854: Enable claims return view when BundleLostValue is set This patch adds the alternation of BundleLostValue to enable the return claims functionality when Bundles are enbled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135032|0 |1 is obsolete| | --- Comment #148 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136239&action=edit Bug 28854: Highlight when a scanned item is unexpected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135033|0 |1 is obsolete| | --- Comment #149 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136240&action=edit Bug 28854: Add count of scanned items to verification modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135034|0 |1 is obsolete| | --- Comment #150 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136241&action=edit Bug 28854: Add 'Remove from bundle' dialogue to details display This patch adds the counterpart of the 'Add to bundle' modal prompt for adding items to bundles from the catalogue details display. It allows for scanning barcodes to remove them from a bundle. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135035|0 |1 is obsolete| | --- Comment #151 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136242&action=edit Bug 28854: Add modal after checkin to print missing items list This patch adds a further modal to the post checkin alert to allow the user to print a view and print a list of items that went missing at this checkin to allow for replacements to be picked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135036|0 |1 is obsolete| | --- Comment #152 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136243&action=edit Bug 28854: (follow-up) Only count rows in the body This patch fixes the count to only include table rows in the body, i.e. skip the header row. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135037|0 |1 is obsolete| | --- Comment #153 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136244&action=edit Bug 28854: Make barcode comparison case insensative -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #154 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136249&action=edit Bug 28854: (QA follow-up) Fix QA tool complaints * Typo in code comment * Permissions on atomicupdate * Missing TT filter in template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #155 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Working on this one :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136249|0 |1 is obsolete| | --- Comment #156 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136253&action=edit Bug 28854: (QA follow-up) Fix QA tool complaints * Typo in code comment * Permissions on atomicupdate * Missing TT filter in template * Spelling in template Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #157 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136254&action=edit Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136226|0 |1 is obsolete| | --- Comment #158 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136264&action=edit Bug 28854: Database update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136227|0 |1 is obsolete| | --- Comment #159 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136265&action=edit Bug 28854: DBIC Schema Updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136228|0 |1 is obsolete| | --- Comment #160 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136266&action=edit Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point and run the database update 1) Configuration: `BundleNotLoanValue` should have been set by the database update and point to a newly added AV value. 2) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 3) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 4) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. 5) The bundles feature can be disabled by unsetting the `BundleNotLoanValue` system preference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136229|0 |1 is obsolete| | --- Comment #161 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136267&action=edit Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136230|0 |1 is obsolete| | --- Comment #162 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136268&action=edit Bug 28854: Highlight bundle rows to clarify UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136231|0 |1 is obsolete| | --- Comment #163 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136269&action=edit Bug 28854: Drop unique index on issue_id in return claims With the introduction of circulating items within a bundle set, we can now loose multiple items from the bundle from the same issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136232|0 |1 is obsolete| | --- Comment #164 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136270&action=edit Bug 28854: DBIC Update ReturnClaim Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136233|0 |1 is obsolete| | --- Comment #165 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136271&action=edit Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that it is marked as lost. 4) Navigate to the biblio for the collection and expand the collection item that contains the lost item. Note the item is marked as lost and checkout details are listed. 5) Checkin the lost item * The item should be marked as found and the return_claims line should be marked as resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136234|0 |1 is obsolete| | --- Comment #166 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136272&action=edit Bug 28854: Simplified status handling for bundle inventory check -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136235|0 |1 is obsolete| | --- Comment #167 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136273&action=edit Bug 28854: Add option to print content list after verification We already allowed the user to view and print an updated content list after a varification showed that items were missing from the bundle. This patch adds the option to view and print the list even if the content has been varified to have not changed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136236|0 |1 is obsolete| | --- Comment #168 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136274&action=edit Bug 28854: Add ordering to checkin validation modal This enhancement adds simple dataTable ordering to the verification modal table at bundle checkin time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136237|0 |1 is obsolete| | --- Comment #169 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136275&action=edit Bug 28854: Improve lost details display for bundle items This patch adds the return claim details to the bundle item status display on the catalogue details page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136238|0 |1 is obsolete| | --- Comment #170 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136276&action=edit Bug 28854: Enable claims return view when BundleLostValue is set This patch adds the alternation of BundleLostValue to enable the return claims functionality when Bundles are enbled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136239|0 |1 is obsolete| | --- Comment #171 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136277&action=edit Bug 28854: Highlight when a scanned item is unexpected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136240|0 |1 is obsolete| | --- Comment #172 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136278&action=edit Bug 28854: Add count of scanned items to verification modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136241|0 |1 is obsolete| | --- Comment #173 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136279&action=edit Bug 28854: Add 'Remove from bundle' dialogue to details display This patch adds the counterpart of the 'Add to bundle' modal prompt for adding items to bundles from the catalogue details display. It allows for scanning barcodes to remove them from a bundle. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136242|0 |1 is obsolete| | --- Comment #174 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136280&action=edit Bug 28854: Add modal after checkin to print missing items list This patch adds a further modal to the post checkin alert to allow the user to print a view and print a list of items that went missing at this checkin to allow for replacements to be picked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136243|0 |1 is obsolete| | --- Comment #175 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136281&action=edit Bug 28854: (follow-up) Only count rows in the body This patch fixes the count to only include table rows in the body, i.e. skip the header row. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136244|0 |1 is obsolete| | --- Comment #176 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136282&action=edit Bug 28854: Make barcode comparison case insensative -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136253|0 |1 is obsolete| | --- Comment #177 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136283&action=edit Bug 28854: (QA follow-up) Fix QA tool complaints * Typo in code comment * Permissions on atomicupdate * Missing TT filter in template * Spelling in template Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136254|0 |1 is obsolete| | --- Comment #178 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136284&action=edit Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #179 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136285&action=edit Bug 28854: Unit test for Koha::Item additions This patch adds unit tests for the new methods added to Koha::Item including: * return_claim * return_claims * is_bundle * in_bundle * bundle_host * bundle_items * add_to_bundle * remove_from_bundle Test plan 1) Run t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #180 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136287&action=edit Bug 28854: Unit test for AddReturn addition This patch adds tests for the AddReturn change that adds an 'InBundle' message to the return. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #181 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 0) Documentation Read the documentation, really helpful! (comment :) ) 1) Unit tests (question) Unit tests pass. Changes marked with . have new unit tests added, but we might be missing some for the changes to checkout and holds? Hope I didn't miss them: Koha/Item checkout . return_claims (new) . return_claim (new) holds . bundle_items (new) . is_bundle (new) . bundle_host (new) . in_bundle (new) . add_to_bundle (new) . remove_from_bundle (new) C4/Circulation . AddReturn 2) Database update, installer a) The new table has the columns host and item, I was wondering if they should not have _id added to match conventions on the API etc. (question) b) I like the 'trick' on adding the LOST and NOT_LOAN values. (comment) c) installer/data/mysql/en/optional/auth_val.yml requires updating for the new system preference values (blocker) d) Changes to sysprefs.sql are missing. We can use the values from d) to pre-set the preferences for new installations correctly. (blocker) 3) Translatability, spelling, terminology a) detail.pl - buttons and other text in js (blocker) bundle_toolbar.append('<a class="btn btn-default" data-toggle="modal" data-target="#addToBundleModal" data-item="' + itemnumber + '"><i class="fa fa-plus"></i> Add to bundle</a>'); bundle_toolbar.append('<a class="btn btn-default" data-toggle="modal" data-target="#removeFromBundleModal" data-item="' + itemnumber + '"><i class="fa fa-minus"></i> Remove from bundle</a>'); $('#addResult').replaceWith('<div id="addResult" class="alert alert-success">Success: Added '+barcode+'</div>'); $('#addResult').replaceWith('<div id="addResult" class="alert alert-warning">Warning: Item '+barcode+' already attached</div>'); } else { $('#addResult').replaceWith('<div id="addResult" class="alert alert-danger">Failure: Item '+barcode+' belongs to another bundle</div>'); } } else { $('#addResult').replaceWith('<div id="addResult" class="alert alert-danger">Failure: Check the logs for details</div>'); b) detail.pl - JSON titles, this and following (blocker): { "data": "biblio.author", "title": "Author", "searchable": true, "orderable": true, }, c) detail.pl - Capitalization (blocker) "title": "Item Type", d) detail.pl - Terminology (blocker) "title": "Collection code", should be just Collection e) circ/returns.tt: Why the use of i18n here? (question) <th>[% t('Title') | html %]</th> Isn't it the same as: <th>Title</th> ? Same here, .tt file with text inside a div element, should have been parsed the same without using t(). [% t('Scan all barcodes of items found in the items bundle. If any items are missing, they will be marked as lost') | html %] And here: <button type="submit" class="btn btn-default"><i class="fa fa-check"></i> [% t('Confirm checkin and mark missing items as lost') | html %]</button> 4) GUI - Configuration a) In table configuration, there is one option named external_id - while this makes sense to the API, I think it's hard on users. Why not update to barcode instead? (normal) b) The system preferences are currently spread on 2 different tabs (circulation and cataloguing). I think we should add a new sub heading 'Item bundles' to group them on the circulation tab instead. It will make setup smoother and I can imagine the section might grow in the future. (normal) 5) Permissions a) Who should be able to create item bundles? At the moment anyone with catalogue permission should be able to. (question) 5) GUI - Functionality a) As barcodes are unique, how could this happen? Should the message maybe be adjusted? (question) $('#removeResult').replaceWith('<div id="removeResult" class="alert alert-danger">'+_("Failed: Barcode matched more than one item ")+barcode+'</div>'); More functionality testing to come. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #182 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) Unit tests Update: we are only missing chargelostitem! (blocker) Koha/Item . return_claims (new) . return_claim (new) . holds (only a comment change) . bundle_items (new) . is_bundle (new) . bundle_host (new) . in_bundle (new) . add_to_bundle (new) . remove_from_bundle (new) C4/Circulation . AddReturn C4/Accounts chargelostitem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #183 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136340&action=edit Bug 28854: Unit tests - chargelostitem This patch adds unit tests for the changes to chargelositem to ensure bundle charging works as expected setting the correct issue_id. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #184 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #182)
1) Unit tests
Update: we are only missing chargelostitem! (blocker)
Done and attached :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #185 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136341&action=edit Bug 28854: Add default AV and Syspref values This patch adds the new AV and System Preferences to the installer. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #186 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #181)
c) installer/data/mysql/en/optional/auth_val.yml requires updating for the new system preference values (blocker)
d) Changes to sysprefs.sql are missing. We can use the values from d) to pre-set the preferences for new installations correctly. (blocker)
Done and attached :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #187 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136342&action=edit Bug 28854: (follow-up) Translations fixes This patch wraps and unwraps strings appropriately for trasnlation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #188 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #181)
3) Translatability, spelling, terminology
Done and attached :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136342|0 |1 is obsolete| | --- Comment #189 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136343&action=edit Bug 28854: (follow-up) Translations fixes This patch wraps and unwraps strings appropriately for trasnlation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136264|0 |1 is obsolete| | --- Comment #190 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136344&action=edit Bug 28854: Database update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136265|0 |1 is obsolete| | --- Comment #191 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136345&action=edit Bug 28854: DBIC Schema Updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136266|0 |1 is obsolete| | --- Comment #192 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136346&action=edit Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point and run the database update 1) Configuration: `BundleNotLoanValue` should have been set by the database update and point to a newly added AV value. 2) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 3) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 4) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. 5) The bundles feature can be disabled by unsetting the `BundleNotLoanValue` system preference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136267|0 |1 is obsolete| | --- Comment #193 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136347&action=edit Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136268|0 |1 is obsolete| | --- Comment #194 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136348&action=edit Bug 28854: Highlight bundle rows to clarify UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136269|0 |1 is obsolete| | --- Comment #195 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136349&action=edit Bug 28854: Drop unique index on issue_id in return claims With the introduction of circulating items within a bundle set, we can now loose multiple items from the bundle from the same issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136270|0 |1 is obsolete| | --- Comment #196 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136350&action=edit Bug 28854: DBIC Update ReturnClaim Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136271|0 |1 is obsolete| | --- Comment #197 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136351&action=edit Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that it is marked as lost. 4) Navigate to the biblio for the collection and expand the collection item that contains the lost item. Note the item is marked as lost and checkout details are listed. 5) Checkin the lost item * The item should be marked as found and the return_claims line should be marked as resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136272|0 |1 is obsolete| | --- Comment #198 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136352&action=edit Bug 28854: Simplified status handling for bundle inventory check -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136273|0 |1 is obsolete| | --- Comment #199 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136353&action=edit Bug 28854: Add option to print content list after verification We already allowed the user to view and print an updated content list after a varification showed that items were missing from the bundle. This patch adds the option to view and print the list even if the content has been varified to have not changed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136274|0 |1 is obsolete| | --- Comment #200 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136354&action=edit Bug 28854: Add ordering to checkin validation modal This enhancement adds simple dataTable ordering to the verification modal table at bundle checkin time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136275|0 |1 is obsolete| | --- Comment #201 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136355&action=edit Bug 28854: Improve lost details display for bundle items This patch adds the return claim details to the bundle item status display on the catalogue details page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136276|0 |1 is obsolete| | --- Comment #202 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136356&action=edit Bug 28854: Enable claims return view when BundleLostValue is set This patch adds the alternation of BundleLostValue to enable the return claims functionality when Bundles are enbled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136277|0 |1 is obsolete| | --- Comment #203 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136357&action=edit Bug 28854: Highlight when a scanned item is unexpected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136278|0 |1 is obsolete| | --- Comment #204 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136358&action=edit Bug 28854: Add count of scanned items to verification modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136279|0 |1 is obsolete| | --- Comment #205 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136359&action=edit Bug 28854: Add 'Remove from bundle' dialogue to details display This patch adds the counterpart of the 'Add to bundle' modal prompt for adding items to bundles from the catalogue details display. It allows for scanning barcodes to remove them from a bundle. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136280|0 |1 is obsolete| | --- Comment #206 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136360&action=edit Bug 28854: Add modal after checkin to print missing items list This patch adds a further modal to the post checkin alert to allow the user to print a view and print a list of items that went missing at this checkin to allow for replacements to be picked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136281|0 |1 is obsolete| | --- Comment #207 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136361&action=edit Bug 28854: (follow-up) Only count rows in the body This patch fixes the count to only include table rows in the body, i.e. skip the header row. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136282|0 |1 is obsolete| | --- Comment #208 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136362&action=edit Bug 28854: Make barcode comparison case insensative -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136283|0 |1 is obsolete| | --- Comment #209 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136363&action=edit Bug 28854: (QA follow-up) Fix QA tool complaints * Typo in code comment * Permissions on atomicupdate * Missing TT filter in template * Spelling in template Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136284|0 |1 is obsolete| | --- Comment #210 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136364&action=edit Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136285|0 |1 is obsolete| | --- Comment #211 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136365&action=edit Bug 28854: Unit test for Koha::Item additions This patch adds unit tests for the new methods added to Koha::Item including: * return_claim * return_claims * is_bundle * in_bundle * bundle_host * bundle_items * add_to_bundle * remove_from_bundle Test plan 1) Run t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136287|0 |1 is obsolete| | --- Comment #212 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136366&action=edit Bug 28854: Unit test for AddReturn addition This patch adds tests for the AddReturn change that adds an 'InBundle' message to the return. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136340|0 |1 is obsolete| | --- Comment #213 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136367&action=edit Bug 28854: Unit tests - chargelostitem This patch adds unit tests for the changes to chargelositem to ensure bundle charging works as expected setting the correct issue_id. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136341|0 |1 is obsolete| | --- Comment #214 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136368&action=edit Bug 28854: Add default AV and Syspref values This patch adds the new AV and System Preferences to the installer. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136343|0 |1 is obsolete| | --- Comment #215 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136369&action=edit Bug 28854: (follow-up) Translations fixes This patch wraps and unwraps strings appropriately for trasnlation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #216 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136370&action=edit Bug 28854: (follow-up) Rename column configuration to barcode This patch updates the column configuration from 'external_id' to 'barcode' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #217 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Something moved.. yet another rebase was required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #218 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #181)
4) GUI - Configuration
a) In table configuration, there is one option named external_id - while this makes sense to the API, I think it's hard on users. Why not update to barcode instead? (normal)
Done and attached :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #219 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136371&action=edit Bug 28854: (follow-up) Move preferences to "Item bundles" Move the preferences into a section under 'Circulation' called 'Item bundles' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #220 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #181)
4) GUI - Configuration
. . .
b) The system preferences are currently spread on 2 different tabs (circulation and cataloguing). I think we should add a new sub heading 'Item bundles' to group them on the circulation tab instead. It will make setup smoother and I can imagine the section might grow in the future. (normal)
Done and attached, :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #221 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #181)
5) Permissions
a) Who should be able to create item bundles? At the moment anyone with catalogue permission should be able to. (question)
I think Cataloguers should be able to, but maybe those with circulation permission too? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #222 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #181)
6) GUI - Functionality
a) As barcodes are unique, how could this happen? Should the message maybe be adjusted? (question)
$('#removeResult').replaceWith('<div id="removeResult" class="alert alert-danger">'+_("Failed: Barcode matched more than one item ")+barcode+'</div>');
Fair question.. I think I was just being cautious. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #223 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136498&action=edit Bug 28854: (follow-up) Fix typo in templates and test plan * aready > already * 61 > 62 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #224 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Taking things for a test run now :) 1) Adding to bundle and removing from bundle a) When adding a non-existing barcode like "eee", I get an unspecific error message: Failure: Check the logs for details (blocker) b) The contrast is not really good on those errors I feel, maybe black text would be better on the colored background if that is an easy option. The light red background + red font is a little hard to read. (Accessibility) c) If you have a leading space in front of the barcode, it won't be recognized. This can happen easily if you copy and paste when forming the bundle and we deal with it in other places - I think we should do it here too for consistency (see also bug 30409) (normal) d) Should we be able to change contents of a bundle while it is checked out? At the moment it's possible. Maybe a 'safety question'? (question/suggestion) 2) Detail view of bundle Staff: a) From the bundle, there is no way to access the record that holds the bundled item. It would be nice if the Title could be linked in the table to allow for that. (suggestion) b) Collection is not resolved into the description in the table. (blocker) c) The item type column is empty, although the bundled item has an itemtype (blocker) d) If an item is lost, the date is formatted 'database' style. DateFormat is not applied: Last seen: 2022-06-24. DateFormat was set to DD.MM.YYYY. (blocker) e) As all items on collections now show the "Manage bundle" button, there is no way to see which item actually has bundled items. An idea here would be to add the number of bundled items to the button text. (strong suggestion?) * Empty: Manage bundle * 3 items bundled in: Manage bundle (3) f) If you have 2 items on a bundle record and "Manage bundle" the first, the button appearance changes and looks a bit 'pushed'. Now push the second "Manage bundle link". Both bundles are open now, but only the second button appears 'pushed'. Close the first bundle - the button looks pushed now... close the second, now you have a detail page with the second button looking pushed. This seems a bit of a confusing UI message. Maybe it was supposed to close the first when the second was opened? (question) 3) Detail view of bundled items a) Staff - bundled: I like the link from the status to the record there, although it makes the column quite wide for a longer one. It all has nice class mark-up, so would be easy to play with if needed. (comment) b) OPAC - bundled: We show "Added to bundle" but there is no way for the OPAC user to figure out "how to get it". I'd really like to see a way to navigate this here. Maybe we could link the status on the detail page to the bundle? (normal) 4) Checkout - nothing found there :) 5) Checkin - nothing to complain about here either. I like the new modal and its functionality. 6) Lost/return claims Checked in a bundle of 3 items, but one was 'lost'. a) Details tab: The return claim was created and in the patron account it shows Claims ( 0 1 ) on the tab. But when I click on the tab, there is nothing below. (blocker) b) Checkouts tab: The claim shows here, but also shows a little issue: In the notes column, it shows the text 'null'. And when I edit the note the text is there as well. c) When trying to resolve the checkout claim to "(Not lost)", I see an "Uncaught ReferenceError" in the console and the display of the claims table is not refreshed. When I reload the page, I can see that the claim was actually resolved. (blocker?) d) When the claim return is resolved to another lost status, like "Lost", the bundle view will show: Lost: 1. It should resolve to the description instead. (blocker) 7) Inventory on checkin feature - no complaints 8) Wish/suggestion list a) Some items are really similar if you don't see the subtitle, part_name and part_number. The bundle display and the modals in circulation only show title. I think it would make a lot of sense to add the other fields here to display as well. The use case here would be language materials for us. They often match on title ($a) and the important bit is in the other fields (work book, DVD, etc.9. They would also lend themselves to be 'bundled up'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #225 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136529&action=edit Bug 28854: (follow-up) Improve error for item not found -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #226 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136530&action=edit Bug 28854: (follow-up) Use barcodedecode in Koha::REST::V1::Items This removes any leading or trailing whitespace from the external id passed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #227 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #224)
1) Adding to bundle and removing from bundle
a) When adding a non-existing barcode like "eee", I get an unspecific error message: Failure: Check the logs for details (blocker)
Fixed in follow-up attached
b) The contrast is not really good on those errors I feel, maybe black text would be better on the colored background if that is an easy option. The light red background + red font is a little hard to read. (Accessibility)
I stick to the bookstrap standard alerts here, I'll defer to Owen for guidance.. it's an area I've felt we're really inconsistent all over the place for ages and aught to improve... but I'd rather do a consistent job everywhere in a distinct bug.
c) If you have a leading space in front of the barcode, it won't be recognized. This can happen easily if you copy and paste when forming the bundle and we deal with it in other places - I think we should do it here too for consistency (see also bug 30409) (normal)
Fixed in a follow-up attached.. but it felt a bit wrong to use barcodedecode here.. we should perhaps use JS instead on input.
d) Should we be able to change contents of a bundle while it is checked out? At the moment it's possible. Maybe a 'safety question'? (question/suggestion)
Really good point.. I think it probably shouldn't be possible.. I'll have a go at that next week and then continue with your review. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #228 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #227)
(In reply to Katrin Fischer from comment #224)
1) Adding to bundle and removing from bundle
a) When adding a non-existing barcode like "eee", I get an unspecific error message: Failure: Check the logs for details (blocker)
Fixed in follow-up attached
Will test later when you have gone through that pile of comments :)
b) The contrast is not really good on those errors I feel, maybe black text would be better on the colored background if that is an easy option. The light red background + red font is a little hard to read. (Accessibility)
I stick to the bookstrap standard alerts here, I'll defer to Owen for guidance.. it's an area I've felt we're really inconsistent all over the place for ages and aught to improve... but I'd rather do a consistent job everywhere in a distinct bug.
That's fair, not a blocker for me.
c) If you have a leading space in front of the barcode, it won't be recognized. This can happen easily if you copy and paste when forming the bundle and we deal with it in other places - I think we should do it here too for consistency (see also bug 30409) (normal)
Fixed in a follow-up attached.. but it felt a bit wrong to use barcodedecode here.. we should perhaps use JS instead on input.
I am not stuck on a specific technical solution, just wanted to show that we try to make this behaviour consistent as an argument why we should ignore spaces here too :)
d) Should we be able to change contents of a bundle while it is checked out? At the moment it's possible. Maybe a 'safety question'? (question/suggestion)
Really good point.. I think it probably shouldn't be possible.. I'll have a go at that next week and then continue with your review.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136344|0 |1 is obsolete| | --- Comment #229 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136613&action=edit Bug 28854: Database update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136345|0 |1 is obsolete| | --- Comment #230 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136614&action=edit Bug 28854: DBIC Schema Updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136346|0 |1 is obsolete| | --- Comment #231 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136615&action=edit Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point and run the database update 1) Configuration: `BundleNotLoanValue` should have been set by the database update and point to a newly added AV value. 2) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 3) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 4) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. 5) The bundles feature can be disabled by unsetting the `BundleNotLoanValue` system preference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136347|0 |1 is obsolete| | --- Comment #232 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136616&action=edit Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136348|0 |1 is obsolete| | --- Comment #233 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136617&action=edit Bug 28854: Highlight bundle rows to clarify UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136349|0 |1 is obsolete| | --- Comment #234 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136618&action=edit Bug 28854: Drop unique index on issue_id in return claims With the introduction of circulating items within a bundle set, we can now loose multiple items from the bundle from the same issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136350|0 |1 is obsolete| | --- Comment #235 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136619&action=edit Bug 28854: DBIC Update ReturnClaim Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136351|0 |1 is obsolete| | --- Comment #236 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136620&action=edit Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that it is marked as lost. 4) Navigate to the biblio for the collection and expand the collection item that contains the lost item. Note the item is marked as lost and checkout details are listed. 5) Checkin the lost item * The item should be marked as found and the return_claims line should be marked as resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136352|0 |1 is obsolete| | --- Comment #237 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136621&action=edit Bug 28854: Simplified status handling for bundle inventory check -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136353|0 |1 is obsolete| | --- Comment #238 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136622&action=edit Bug 28854: Add option to print content list after verification We already allowed the user to view and print an updated content list after a varification showed that items were missing from the bundle. This patch adds the option to view and print the list even if the content has been varified to have not changed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136354|0 |1 is obsolete| | --- Comment #239 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136623&action=edit Bug 28854: Add ordering to checkin validation modal This enhancement adds simple dataTable ordering to the verification modal table at bundle checkin time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136355|0 |1 is obsolete| | --- Comment #240 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136624&action=edit Bug 28854: Improve lost details display for bundle items This patch adds the return claim details to the bundle item status display on the catalogue details page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136356|0 |1 is obsolete| | --- Comment #241 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136625&action=edit Bug 28854: Enable claims return view when BundleLostValue is set This patch adds the alternation of BundleLostValue to enable the return claims functionality when Bundles are enbled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136357|0 |1 is obsolete| | --- Comment #242 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136626&action=edit Bug 28854: Highlight when a scanned item is unexpected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136358|0 |1 is obsolete| | --- Comment #243 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136627&action=edit Bug 28854: Add count of scanned items to verification modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136359|0 |1 is obsolete| | --- Comment #244 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136628&action=edit Bug 28854: Add 'Remove from bundle' dialogue to details display This patch adds the counterpart of the 'Add to bundle' modal prompt for adding items to bundles from the catalogue details display. It allows for scanning barcodes to remove them from a bundle. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136360|0 |1 is obsolete| | --- Comment #245 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136629&action=edit Bug 28854: Add modal after checkin to print missing items list This patch adds a further modal to the post checkin alert to allow the user to print a view and print a list of items that went missing at this checkin to allow for replacements to be picked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136361|0 |1 is obsolete| | --- Comment #246 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136630&action=edit Bug 28854: (follow-up) Only count rows in the body This patch fixes the count to only include table rows in the body, i.e. skip the header row. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136362|0 |1 is obsolete| | --- Comment #247 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136631&action=edit Bug 28854: Make barcode comparison case insensative -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136363|0 |1 is obsolete| | --- Comment #248 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136632&action=edit Bug 28854: (QA follow-up) Fix QA tool complaints * Typo in code comment * Permissions on atomicupdate * Missing TT filter in template * Spelling in template Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136364|0 |1 is obsolete| | --- Comment #249 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136633&action=edit Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136365|0 |1 is obsolete| | --- Comment #250 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136634&action=edit Bug 28854: Unit test for Koha::Item additions This patch adds unit tests for the new methods added to Koha::Item including: * return_claim * return_claims * is_bundle * in_bundle * bundle_host * bundle_items * add_to_bundle * remove_from_bundle Test plan 1) Run t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136366|0 |1 is obsolete| | --- Comment #251 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136635&action=edit Bug 28854: Unit test for AddReturn addition This patch adds tests for the AddReturn change that adds an 'InBundle' message to the return. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136367|0 |1 is obsolete| | --- Comment #252 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136636&action=edit Bug 28854: Unit tests - chargelostitem This patch adds unit tests for the changes to chargelositem to ensure bundle charging works as expected setting the correct issue_id. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136368|0 |1 is obsolete| | --- Comment #253 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136637&action=edit Bug 28854: Add default AV and Syspref values This patch adds the new AV and System Preferences to the installer. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136369|0 |1 is obsolete| | --- Comment #254 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136638&action=edit Bug 28854: (follow-up) Translations fixes This patch wraps and unwraps strings appropriately for trasnlation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136370|0 |1 is obsolete| | --- Comment #255 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136639&action=edit Bug 28854: (follow-up) Rename column configuration to barcode This patch updates the column configuration from 'external_id' to 'barcode' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136371|0 |1 is obsolete| | --- Comment #256 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136640&action=edit Bug 28854: (follow-up) Move preferences to "Item bundles" Move the preferences into a section under 'Circulation' called 'Item bundles' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136498|0 |1 is obsolete| | --- Comment #257 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136641&action=edit Bug 28854: (follow-up) Fix typo in templates and test plan * aready > already * 61 > 62 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136529|0 |1 is obsolete| | --- Comment #258 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136642&action=edit Bug 28854: (follow-up) Improve error for item not found -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136530|0 |1 is obsolete| | --- Comment #259 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136643&action=edit Bug 28854: (follow-up) Use barcodedecode in Koha::REST::V1::Items This removes any leading or trailing whitespace from the external id passed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #260 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136644&action=edit Bug 28854: (follow-up) Disable bundle editing for checked out This patch disables the add and remove options under bundle management when the bundled item in question is checked out. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #261 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136645&action=edit Bug 28854: (follow-up) Link bundle items to thier biblios This patch splits out the title formatting from the bundle item title display into it's own new js-biblio-format include file and adds biblio linking options. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #262 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136646&action=edit Bug 28854: (follow-up) Restore last seen date formatting We lost the date formatting somewhere along the line with rebases, this patch restores the call to $date for last seen date. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #263 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136647&action=edit Bug 28854: (follow-up) Expand itemtype [WIP] WIP: -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #264 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136648&action=edit Bug 28854: (follow-up) Add bundle item status to manage button This patch adds the item counts (Present|Lost) to the 'Manage bundle' button in the catalogue details page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #265 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136649&action=edit Bug 28854: (follow-up) Make 'Manage bundle' button a 'toggle' This patch adds and removes the 'active' class to the 'Manage bundle' button such that it correctly reflects whether the manage area is expanded or not for the bundle item. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #266 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136650&action=edit Bug 28854: (follow-up) Restore block styling on bundled span This patch restores a css rule that we lost during rebases that makes the 'bundled' span that appears for bundled items on their respective details pages so that the 'In bundle: ' text in the status field of the table appears beneath the 'Not for loan (Added to bundle)' text. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #267 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136651&action=edit Bug 28854: (follow-up) Link to 'In bundle' on OPAC This patch adds the 'In bundle: Link' to the OPAC to mirror what we have on the staff client. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #268 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136652&action=edit Bug 28854: (follow-up) Add handling for part_numbers/names This patch adds part number/name handling to the new biblio-format js include. This will add such details to bundle management tables. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #269 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #224)
Taking things for a test run now :)
c) If you have a leading space in front of the barcode, it won't be recognized. This can happen easily if you copy and paste when forming the bundle and we deal with it in other places - I think we should do it here too for consistency (see also bug 30409) (normal)
Decided to stick with barcodedecode as it does more than just whitespace depending on some koha settings.
d) Should we be able to change contents of a bundle while it is checked out? At the moment it's possible. Maybe a 'safety question'? (question/suggestion)
Fixed in follow-up.
2) Detail view of bundle
Staff:
a) From the bundle, there is no way to access the record that holds the bundled item. It would be nice if the Title could be linked in the table to allow for that. (suggestion)
Fixed in follow-up
b) Collection is not resolved into the description in the table. (blocker)
I'm tempted to drop this column from the display entirely.. is it useful? Pulling through descriptions is not yet easily supported on the API and there's ongoing discussions around it.
c) The item type column is empty, although the bundled item has an itemtype (blocker)
As above; However, I felt this one probably was a more useful field.. I started (see WIP patch) but decided perhaps it should be done as it's own bug as it really involves adding a whole new set of API routes and js handling.
d) If an item is lost, the date is formatted 'database' style. DateFormat is not applied: Last seen: 2022-06-24. DateFormat was set to DD.MM.YYYY. (blocker)
Restored in a follow-up.. it got lost somewhere during rebases.
e) As all items on collections now show the "Manage bundle" button, there is no way to see which item actually has bundled items. An idea here would be to add the number of bundled items to the button text. (strong suggestion?) * Empty: Manage bundle * 3 items bundled in: Manage bundle (3)
Fixed in follow-up. Opted to go for (X|Y) where 'X' is "Present items attached" and Y is "Lost items attached". Might seem Owens thoughts on how this displays inside a button, I'm not entirely sure about the approach of using plain text.
f) If you have 2 items on a bundle record and "Manage bundle" the first, the button appearance changes and looks a bit 'pushed'. Now push the second "Manage bundle link". Both bundles are open now, but only the second button appears 'pushed'. Close the first bundle - the button looks pushed now... close the second, now you have a detail page with the second button looking pushed. This seems a bit of a confusing UI message. Maybe it was supposed to close the first when the second was opened? (question)
Enhanced in follow-up.. I wasn't actually doing anything to the button but perhaps your browser was.. I've not assigned an 'active' class to the button when the management UI is expanded and then remove it again if we collapse.
3) Detail view of bundled items
a) Staff - bundled: I like the link from the status to the record there, although it makes the column quite wide for a longer one. It all has nice class mark-up, so would be easy to play with if needed. (comment)
Restored styling that was lost in rebases again.. we use 'block' display to make it go directly underneath the not for loan status.
b) OPAC - bundled: We show "Added to bundle" but there is no way for the OPAC user to figure out "how to get it". I'd really like to see a way to navigate this here. Maybe we could link the status on the detail page to the bundle? (normal)
This wasn't at all trivial given how our item status include is written.. I took the simple approach in the end of embedding the data in the controller.. but this is unlikely to work everwhere the include is called. I think we should take this as-is now and work together with NatFi and Tomas to make status's work via the API's.
4) Checkout - nothing found there :)
Awesome.
5) Checkin - nothing to complain about here either. I like the new modal and its functionality.
Awesome.
6) Lost/return claims
Checked in a bundle of 3 items, but one was 'lost'.
a) Details tab: The return claim was created and in the patron account it shows Claims ( 0 1 ) on the tab. But when I click on the tab, there is nothing below. (blocker)
I couldn't replicate this, but will have another go sometime this week with cleared-down data.
b) Checkouts tab: The claim shows here, but also shows a little issue: In the notes column, it shows the text 'null'. And when I edit the note the text is there as well.
Hmm, not sure where the 'null' text is coming from yet.. still working on this one.
c) When trying to resolve the checkout claim to "(Not lost)", I see an "Uncaught ReferenceError" in the console and the display of the claims table is not refreshed. When I reload the page, I can see that the claim was actually resolved. (blocker?)
Oop.. missed this one whilst working through the comments.. will have to revisit as above.
d) When the claim return is resolved to another lost status, like "Lost", the bundle view will show: Lost: 1. It should resolve to the description instead. (blocker)
As above.
7) Inventory on checkin feature - no complaints
Awesome.
8) Wish/suggestion list
a) Some items are really similar if you don't see the subtitle, part_name and part_number. The bundle display and the modals in circulation only show title. I think it would make a lot of sense to add the other fields here to display as well. The use case here would be language materials for us. They often match on title ($a) and the important bit is in the other fields (work book, DVD, etc.9. They would also lend themselves to be 'bundled up'.
We use the standard biblio-title.inc include for the check-in modal so that should already contain all the details you mention. I've added a follow-up to include handling for part numbers and part names in the manage bundle UI now. Thanks for reviewing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #270 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136654&action=edit Bug 28854: (follow-up) Prevent stringification of null in return claims The return claims table was stringifying 'null'. This patch updates the code to check for definition so we don't stringify incorrectly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #271 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Martin Renvoize from comment #269)
(In reply to Katrin Fischer from comment #224)
6) Lost/return claims
Checked in a bundle of 3 items, but one was 'lost'.
b) Checkouts tab: The claim shows here, but also shows a little issue: In the notes column, it shows the text 'null'. And when I edit the note the text is there as well.
Hmm, not sure where the 'null' text is coming from yet.. still working on this one.
This was a pre-existing bug in recalls.. I've fixed it in a follow-up attached.. but perhaps it should be on it's own bug report really.. Feel free to grab the patch and submit it distinctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #272 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136655&action=edit Bug 28854: (follow-up) Reload return claims table on resolve This is another fix for a bug in return claims. We now test for the initialised datatable and call an ajax reload directly on it if we find one instead of calling a undefined function (the function is out of scope here). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #273 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Martin Renvoize from comment #269)
(In reply to Katrin Fischer from comment #224)
c) When trying to resolve the checkout claim to "(Not lost)", I see an "Uncaught ReferenceError" in the console and the display of the claims table is not refreshed. When I reload the page, I can see that the claim was actually resolved. (blocker?)
Oop.. missed this one whilst working through the comments.. will have to revisit as above.
Another pre-existing bug in return claims. Fixed in a follow-up here, but may be better served moved to another bug.. I'm reluctant as I don't really want to hold this one up any further... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #274 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136806&action=edit Bug 28854: (QA follow-up) Add missing TT filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136613|0 |1 is obsolete| | --- Comment #275 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136809&action=edit Bug 28854: Database update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136614|0 |1 is obsolete| | --- Comment #276 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136811&action=edit Bug 28854: DBIC Schema Updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136615|0 |1 is obsolete| | --- Comment #277 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136814&action=edit Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point and run the database update 1) Configuration: `BundleNotLoanValue` should have been set by the database update and point to a newly added AV value. 2) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 3) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 4) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. 5) The bundles feature can be disabled by unsetting the `BundleNotLoanValue` system preference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136616|0 |1 is obsolete| | --- Comment #278 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136817&action=edit Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136617|0 |1 is obsolete| | --- Comment #279 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136821&action=edit Bug 28854: Highlight bundle rows to clarify UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136618|0 |1 is obsolete| | --- Comment #280 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136824&action=edit Bug 28854: Drop unique index on issue_id in return claims With the introduction of circulating items within a bundle set, we can now loose multiple items from the bundle from the same issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136619|0 |1 is obsolete| | --- Comment #281 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136826&action=edit Bug 28854: DBIC Update ReturnClaim Schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136620|0 |1 is obsolete| | --- Comment #282 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136829&action=edit Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that it is marked as lost. 4) Navigate to the biblio for the collection and expand the collection item that contains the lost item. Note the item is marked as lost and checkout details are listed. 5) Checkin the lost item * The item should be marked as found and the return_claims line should be marked as resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136621|0 |1 is obsolete| | --- Comment #283 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136832&action=edit Bug 28854: Simplified status handling for bundle inventory check -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136622|0 |1 is obsolete| | --- Comment #284 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136835&action=edit Bug 28854: Add option to print content list after verification We already allowed the user to view and print an updated content list after a varification showed that items were missing from the bundle. This patch adds the option to view and print the list even if the content has been varified to have not changed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136623|0 |1 is obsolete| | --- Comment #285 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136838&action=edit Bug 28854: Add ordering to checkin validation modal This enhancement adds simple dataTable ordering to the verification modal table at bundle checkin time. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136624|0 |1 is obsolete| | --- Comment #286 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136841&action=edit Bug 28854: Improve lost details display for bundle items This patch adds the return claim details to the bundle item status display on the catalogue details page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136625|0 |1 is obsolete| | --- Comment #287 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136843&action=edit Bug 28854: Enable claims return view when BundleLostValue is set This patch adds the alternation of BundleLostValue to enable the return claims functionality when Bundles are enbled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136626|0 |1 is obsolete| | --- Comment #288 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136846&action=edit Bug 28854: Highlight when a scanned item is unexpected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136627|0 |1 is obsolete| | --- Comment #289 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136849&action=edit Bug 28854: Add count of scanned items to verification modal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136628|0 |1 is obsolete| | --- Comment #290 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136850&action=edit Bug 28854: Add 'Remove from bundle' dialogue to details display This patch adds the counterpart of the 'Add to bundle' modal prompt for adding items to bundles from the catalogue details display. It allows for scanning barcodes to remove them from a bundle. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136629|0 |1 is obsolete| | --- Comment #291 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136851&action=edit Bug 28854: Add modal after checkin to print missing items list This patch adds a further modal to the post checkin alert to allow the user to print a view and print a list of items that went missing at this checkin to allow for replacements to be picked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136630|0 |1 is obsolete| | --- Comment #292 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136852&action=edit Bug 28854: (follow-up) Only count rows in the body This patch fixes the count to only include table rows in the body, i.e. skip the header row. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136631|0 |1 is obsolete| | --- Comment #293 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136853&action=edit Bug 28854: Make barcode comparison case insensative -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136632|0 |1 is obsolete| | --- Comment #294 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136854&action=edit Bug 28854: (QA follow-up) Fix QA tool complaints * Typo in code comment * Permissions on atomicupdate * Missing TT filter in template * Spelling in template Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136633|0 |1 is obsolete| | --- Comment #295 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136855&action=edit Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136634|0 |1 is obsolete| | --- Comment #296 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136856&action=edit Bug 28854: Unit test for Koha::Item additions This patch adds unit tests for the new methods added to Koha::Item including: * return_claim * return_claims * is_bundle * in_bundle * bundle_host * bundle_items * add_to_bundle * remove_from_bundle Test plan 1) Run t/db_dependent/Koha/Item.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136635|0 |1 is obsolete| | --- Comment #297 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136857&action=edit Bug 28854: Unit test for AddReturn addition This patch adds tests for the AddReturn change that adds an 'InBundle' message to the return. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136636|0 |1 is obsolete| | --- Comment #298 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136858&action=edit Bug 28854: Unit tests - chargelostitem This patch adds unit tests for the changes to chargelositem to ensure bundle charging works as expected setting the correct issue_id. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136637|0 |1 is obsolete| | --- Comment #299 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136859&action=edit Bug 28854: Add default AV and Syspref values This patch adds the new AV and System Preferences to the installer. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136638|0 |1 is obsolete| | --- Comment #300 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136860&action=edit Bug 28854: (follow-up) Translations fixes This patch wraps and unwraps strings appropriately for trasnlation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136639|0 |1 is obsolete| | --- Comment #301 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136861&action=edit Bug 28854: (follow-up) Rename column configuration to barcode This patch updates the column configuration from 'external_id' to 'barcode' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136640|0 |1 is obsolete| | --- Comment #302 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136862&action=edit Bug 28854: (follow-up) Move preferences to "Item bundles" Move the preferences into a section under 'Circulation' called 'Item bundles' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136641|0 |1 is obsolete| | --- Comment #303 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136863&action=edit Bug 28854: (follow-up) Fix typo in templates and test plan * aready > already * 61 > 62 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136642|0 |1 is obsolete| | --- Comment #304 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136864&action=edit Bug 28854: (follow-up) Improve error for item not found -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136643|0 |1 is obsolete| | --- Comment #305 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136865&action=edit Bug 28854: (follow-up) Use barcodedecode in Koha::REST::V1::Items This removes any leading or trailing whitespace from the external id passed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136644|0 |1 is obsolete| | --- Comment #306 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136866&action=edit Bug 28854: (follow-up) Disable bundle editing for checked out This patch disables the add and remove options under bundle management when the bundled item in question is checked out. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136645|0 |1 is obsolete| | --- Comment #307 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136867&action=edit Bug 28854: (follow-up) Link bundle items to thier biblios This patch splits out the title formatting from the bundle item title display into it's own new js-biblio-format include file and adds biblio linking options. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136646|0 |1 is obsolete| | --- Comment #308 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136868&action=edit Bug 28854: (follow-up) Restore last seen date formatting We lost the date formatting somewhere along the line with rebases, this patch restores the call to $date for last seen date. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136648|0 |1 is obsolete| | --- Comment #309 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136869&action=edit Bug 28854: (follow-up) Add bundle item status to manage button This patch adds the item counts (Present|Lost) to the 'Manage bundle' button in the catalogue details page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136649|0 |1 is obsolete| | --- Comment #310 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136870&action=edit Bug 28854: (follow-up) Make 'Manage bundle' button a 'toggle' This patch adds and removes the 'active' class to the 'Manage bundle' button such that it correctly reflects whether the manage area is expanded or not for the bundle item. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136650|0 |1 is obsolete| | --- Comment #311 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136871&action=edit Bug 28854: (follow-up) Restore block styling on bundled span This patch restores a css rule that we lost during rebases that makes the 'bundled' span that appears for bundled items on their respective details pages so that the 'In bundle: ' text in the status field of the table appears beneath the 'Not for loan (Added to bundle)' text. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136651|0 |1 is obsolete| | --- Comment #312 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136872&action=edit Bug 28854: (follow-up) Link to 'In bundle' on OPAC This patch adds the 'In bundle: Link' to the OPAC to mirror what we have on the staff client. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136652|0 |1 is obsolete| | --- Comment #313 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136873&action=edit Bug 28854: (follow-up) Add handling for part_numbers/names This patch adds part number/name handling to the new biblio-format js include. This will add such details to bundle management tables. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136654|0 |1 is obsolete| | --- Comment #314 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136874&action=edit Bug 28854: (follow-up) Prevent stringification of null in return claims The return claims table was stringifying 'null'. This patch updates the code to check for definition so we don't stringify incorrectly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136655|0 |1 is obsolete| | --- Comment #315 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136875&action=edit Bug 28854: (follow-up) Reload return claims table on resolve This is another fix for a bug in return claims. We now test for the initialised datatable and call an ajax reload directly on it if we find one instead of calling a undefined function (the function is out of scope here). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136806|0 |1 is obsolete| | --- Comment #316 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136876&action=edit Bug 28854: (QA follow-up) Add missing TT filters -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #317 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136877&action=edit Bug 28854: (follow-up) Remove fields from from bundle items This patch removes the itemtype and collection code fields from the bundle items table. We will add the itemtype back in at a later date with a new bug as the display code needs some careful consideration and we felt that doing that work inline here would be an unrequired blocker. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136647|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31077 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31078 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31078 [Bug 31078] Lost status different to 1 don't show with description in bundle detail view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31079 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31079 [Bug 31079] Entering an empty line on checking of an item bundle, gives "Unexpected:" error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31080 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31080 [Bug 31080] Block adding the bundle item to its own bundle -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31081 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31081 [Bug 31081] Improve display of 'Manage bundle' button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31082 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31082 [Bug 31082] Add tooltip to buttons when item bundles cannot be changed while checked out -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31083 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31083 [Bug 31083] Display subtitle, part name and part number in item bundle detail view -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136809|0 |1 is obsolete| | --- Comment #318 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136905&action=edit Bug 28854: Database update Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136811|0 |1 is obsolete| | --- Comment #319 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136906&action=edit Bug 28854: DBIC Schema Updates Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136814|0 |1 is obsolete| | --- Comment #320 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136907&action=edit Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point and run the database update 1) Configuration: `BundleNotLoanValue` should have been set by the database update and point to a newly added AV value. 2) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 3) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 4) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. 5) The bundles feature can be disabled by unsetting the `BundleNotLoanValue` system preference. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136817|0 |1 is obsolete| | --- Comment #321 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136908&action=edit Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136821|0 |1 is obsolete| | --- Comment #322 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136909&action=edit Bug 28854: Highlight bundle rows to clarify UI Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136824|0 |1 is obsolete| | --- Comment #323 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136910&action=edit Bug 28854: Drop unique index on issue_id in return claims With the introduction of circulating items within a bundle set, we can now loose multiple items from the bundle from the same issue. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136826|0 |1 is obsolete| | --- Comment #324 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136911&action=edit Bug 28854: DBIC Update ReturnClaim Schema Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136829|0 |1 is obsolete| | --- Comment #325 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136912&action=edit Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that it is marked as lost. 4) Navigate to the biblio for the collection and expand the collection item that contains the lost item. Note the item is marked as lost and checkout details are listed. 5) Checkin the lost item * The item should be marked as found and the return_claims line should be marked as resolved. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136832|0 |1 is obsolete| | --- Comment #326 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136913&action=edit Bug 28854: Simplified status handling for bundle inventory check Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136835|0 |1 is obsolete| | --- Comment #327 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136914&action=edit Bug 28854: Add option to print content list after verification We already allowed the user to view and print an updated content list after a varification showed that items were missing from the bundle. This patch adds the option to view and print the list even if the content has been varified to have not changed. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136838|0 |1 is obsolete| | --- Comment #328 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136915&action=edit Bug 28854: Add ordering to checkin validation modal This enhancement adds simple dataTable ordering to the verification modal table at bundle checkin time. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136841|0 |1 is obsolete| | --- Comment #329 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136916&action=edit Bug 28854: Improve lost details display for bundle items This patch adds the return claim details to the bundle item status display on the catalogue details page. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136843|0 |1 is obsolete| | --- Comment #330 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136917&action=edit Bug 28854: Enable claims return view when BundleLostValue is set This patch adds the alternation of BundleLostValue to enable the return claims functionality when Bundles are enbled. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136846|0 |1 is obsolete| | --- Comment #331 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136918&action=edit Bug 28854: Highlight when a scanned item is unexpected Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136849|0 |1 is obsolete| | --- Comment #332 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136919&action=edit Bug 28854: Add count of scanned items to verification modal Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136850|0 |1 is obsolete| | --- Comment #333 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136920&action=edit Bug 28854: Add 'Remove from bundle' dialogue to details display This patch adds the counterpart of the 'Add to bundle' modal prompt for adding items to bundles from the catalogue details display. It allows for scanning barcodes to remove them from a bundle. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136851|0 |1 is obsolete| | --- Comment #334 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136921&action=edit Bug 28854: Add modal after checkin to print missing items list This patch adds a further modal to the post checkin alert to allow the user to print a view and print a list of items that went missing at this checkin to allow for replacements to be picked. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136852|0 |1 is obsolete| | --- Comment #335 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136922&action=edit Bug 28854: (follow-up) Only count rows in the body This patch fixes the count to only include table rows in the body, i.e. skip the header row. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136853|0 |1 is obsolete| | --- Comment #336 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136923&action=edit Bug 28854: Make barcode comparison case insensative Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136854|0 |1 is obsolete| | --- Comment #337 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136924&action=edit Bug 28854: (QA follow-up) Fix QA tool complaints * Typo in code comment * Permissions on atomicupdate * Missing TT filter in template * Spelling in template Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136855|0 |1 is obsolete| | --- Comment #338 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136925&action=edit Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469 Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136856|0 |1 is obsolete| | --- Comment #339 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136926&action=edit Bug 28854: Unit test for Koha::Item additions This patch adds unit tests for the new methods added to Koha::Item including: * return_claim * return_claims * is_bundle * in_bundle * bundle_host * bundle_items * add_to_bundle * remove_from_bundle Test plan 1) Run t/db_dependent/Koha/Item.t Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136857|0 |1 is obsolete| | --- Comment #340 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136927&action=edit Bug 28854: Unit test for AddReturn addition This patch adds tests for the AddReturn change that adds an 'InBundle' message to the return. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136858|0 |1 is obsolete| | --- Comment #341 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136928&action=edit Bug 28854: Unit tests - chargelostitem This patch adds unit tests for the changes to chargelositem to ensure bundle charging works as expected setting the correct issue_id. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136859|0 |1 is obsolete| | --- Comment #342 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136929&action=edit Bug 28854: Add default AV and Syspref values This patch adds the new AV and System Preferences to the installer. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136860|0 |1 is obsolete| | --- Comment #343 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136930&action=edit Bug 28854: (follow-up) Translations fixes This patch wraps and unwraps strings appropriately for trasnlation. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136861|0 |1 is obsolete| | --- Comment #344 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136931&action=edit Bug 28854: (follow-up) Rename column configuration to barcode This patch updates the column configuration from 'external_id' to 'barcode' Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136862|0 |1 is obsolete| | --- Comment #345 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136932&action=edit Bug 28854: (follow-up) Move preferences to "Item bundles" Move the preferences into a section under 'Circulation' called 'Item bundles' Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136863|0 |1 is obsolete| | --- Comment #346 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136933&action=edit Bug 28854: (follow-up) Fix typo in templates and test plan * aready > already * 61 > 62 Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136864|0 |1 is obsolete| | --- Comment #347 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136934&action=edit Bug 28854: (follow-up) Improve error for item not found Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136865|0 |1 is obsolete| | --- Comment #348 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136935&action=edit Bug 28854: (follow-up) Use barcodedecode in Koha::REST::V1::Items This removes any leading or trailing whitespace from the external id passed Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136866|0 |1 is obsolete| | --- Comment #349 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136936&action=edit Bug 28854: (follow-up) Disable bundle editing for checked out This patch disables the add and remove options under bundle management when the bundled item in question is checked out. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136867|0 |1 is obsolete| | --- Comment #350 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136937&action=edit Bug 28854: (follow-up) Link bundle items to thier biblios This patch splits out the title formatting from the bundle item title display into it's own new js-biblio-format include file and adds biblio linking options. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136868|0 |1 is obsolete| | --- Comment #351 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136938&action=edit Bug 28854: (follow-up) Restore last seen date formatting We lost the date formatting somewhere along the line with rebases, this patch restores the call to $date for last seen date. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136869|0 |1 is obsolete| | --- Comment #352 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136939&action=edit Bug 28854: (follow-up) Add bundle item status to manage button This patch adds the item counts (Present|Lost) to the 'Manage bundle' button in the catalogue details page. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136870|0 |1 is obsolete| | --- Comment #353 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136940&action=edit Bug 28854: (follow-up) Make 'Manage bundle' button a 'toggle' This patch adds and removes the 'active' class to the 'Manage bundle' button such that it correctly reflects whether the manage area is expanded or not for the bundle item. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136871|0 |1 is obsolete| | --- Comment #354 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136941&action=edit Bug 28854: (follow-up) Restore block styling on bundled span This patch restores a css rule that we lost during rebases that makes the 'bundled' span that appears for bundled items on their respective details pages so that the 'In bundle: ' text in the status field of the table appears beneath the 'Not for loan (Added to bundle)' text. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136872|0 |1 is obsolete| | --- Comment #355 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136942&action=edit Bug 28854: (follow-up) Link to 'In bundle' on OPAC This patch adds the 'In bundle: Link' to the OPAC to mirror what we have on the staff client. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136873|0 |1 is obsolete| | --- Comment #356 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136943&action=edit Bug 28854: (follow-up) Add handling for part_numbers/names This patch adds part number/name handling to the new biblio-format js include. This will add such details to bundle management tables. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136874|0 |1 is obsolete| | --- Comment #357 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136944&action=edit Bug 28854: (follow-up) Prevent stringification of null in return claims The return claims table was stringifying 'null'. This patch updates the code to check for definition so we don't stringify incorrectly Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136875|0 |1 is obsolete| | --- Comment #358 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136945&action=edit Bug 28854: (follow-up) Reload return claims table on resolve This is another fix for a bug in return claims. We now test for the initialised datatable and call an ajax reload directly on it if we find one instead of calling a undefined function (the function is out of scope here). Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136876|0 |1 is obsolete| | --- Comment #359 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136946&action=edit Bug 28854: (QA follow-up) Add missing TT filters Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136877|0 |1 is obsolete| | --- Comment #360 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 136947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136947&action=edit Bug 28854: (follow-up) Remove fields from from bundle items This patch removes the itemtype and collection code fields from the bundle items table. We will add the itemtype back in at a later date with a new bug as the display code needs some careful consideration and we felt that doing that work inline here would be an unrequired blocker. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #361 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am quite happy with this now with this at 43 commits :) I have filed separate bugs for some of the enhancement ideas remaining that I don't consider blocker so we can track those. No need to grow this further. They are all bite-size things that should be easy to test later on, but no need to grow this further. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #362 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136949&action=edit Bug 28854: (follow-up) Prevent bundles from being nested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31084 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31084 [Bug 31084] Display item type in bundle management table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31085 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31085 [Bug 31085] The return claims table no longer reloads on resolution -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29519 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29519 [Bug 29519] Add option to resolve a return claim at checkin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31087 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31087 [Bug 31087] Undefined notes in returns claims get stringified to 'null' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136905|0 |1 is obsolete| | --- Comment #363 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136978&action=edit Bug 28854: Database update Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136906|0 |1 is obsolete| | --- Comment #364 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136979&action=edit Bug 28854: DBIC Schema Updates Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136907|0 |1 is obsolete| | --- Comment #365 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136980&action=edit Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point and run the database update 1) Configuration: `BundleNotLoanValue` should have been set by the database update and point to a newly added AV value. 2) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 3) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 4) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. 5) The bundles feature can be disabled by unsetting the `BundleNotLoanValue` system preference. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136908|0 |1 is obsolete| | --- Comment #366 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136981&action=edit Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136909|0 |1 is obsolete| | --- Comment #367 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136982&action=edit Bug 28854: Highlight bundle rows to clarify UI Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136910|0 |1 is obsolete| | --- Comment #368 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136985&action=edit Bug 28854: Drop unique index on issue_id in return claims With the introduction of circulating items within a bundle set, we can now loose multiple items from the bundle from the same issue. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136911|0 |1 is obsolete| | --- Comment #369 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136988&action=edit Bug 28854: DBIC Update ReturnClaim Schema Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136912|0 |1 is obsolete| | --- Comment #370 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136989&action=edit Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that it is marked as lost. 4) Navigate to the biblio for the collection and expand the collection item that contains the lost item. Note the item is marked as lost and checkout details are listed. 5) Checkin the lost item * The item should be marked as found and the return_claims line should be marked as resolved. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136913|0 |1 is obsolete| | --- Comment #371 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136990&action=edit Bug 28854: Simplified status handling for bundle inventory check Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136914|0 |1 is obsolete| | --- Comment #372 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136991&action=edit Bug 28854: Add option to print content list after verification We already allowed the user to view and print an updated content list after a varification showed that items were missing from the bundle. This patch adds the option to view and print the list even if the content has been varified to have not changed. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136915|0 |1 is obsolete| | --- Comment #373 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136992&action=edit Bug 28854: Add ordering to checkin validation modal This enhancement adds simple dataTable ordering to the verification modal table at bundle checkin time. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136916|0 |1 is obsolete| | --- Comment #374 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136993&action=edit Bug 28854: Improve lost details display for bundle items This patch adds the return claim details to the bundle item status display on the catalogue details page. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136917|0 |1 is obsolete| | --- Comment #375 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136994&action=edit Bug 28854: Enable claims return view when BundleLostValue is set This patch adds the alternation of BundleLostValue to enable the return claims functionality when Bundles are enbled. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136918|0 |1 is obsolete| | --- Comment #376 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136995&action=edit Bug 28854: Highlight when a scanned item is unexpected Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136919|0 |1 is obsolete| | --- Comment #377 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136996&action=edit Bug 28854: Add count of scanned items to verification modal Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136920|0 |1 is obsolete| | --- Comment #378 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136997&action=edit Bug 28854: Add 'Remove from bundle' dialogue to details display This patch adds the counterpart of the 'Add to bundle' modal prompt for adding items to bundles from the catalogue details display. It allows for scanning barcodes to remove them from a bundle. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136921|0 |1 is obsolete| | --- Comment #379 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136998&action=edit Bug 28854: Add modal after checkin to print missing items list This patch adds a further modal to the post checkin alert to allow the user to print a view and print a list of items that went missing at this checkin to allow for replacements to be picked. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136922|0 |1 is obsolete| | --- Comment #380 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136999&action=edit Bug 28854: (follow-up) Only count rows in the body This patch fixes the count to only include table rows in the body, i.e. skip the header row. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136923|0 |1 is obsolete| | --- Comment #381 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137000&action=edit Bug 28854: Make barcode comparison case insensative Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136924|0 |1 is obsolete| | --- Comment #382 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137001&action=edit Bug 28854: (QA follow-up) Fix QA tool complaints * Typo in code comment * Permissions on atomicupdate * Missing TT filter in template * Spelling in template Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136925|0 |1 is obsolete| | --- Comment #383 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137002&action=edit Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469 Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136926|0 |1 is obsolete| | --- Comment #384 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137003&action=edit Bug 28854: Unit test for Koha::Item additions This patch adds unit tests for the new methods added to Koha::Item including: * return_claim * return_claims * is_bundle * in_bundle * bundle_host * bundle_items * add_to_bundle * remove_from_bundle Test plan 1) Run t/db_dependent/Koha/Item.t Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136927|0 |1 is obsolete| | --- Comment #385 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137004&action=edit Bug 28854: Unit test for AddReturn addition This patch adds tests for the AddReturn change that adds an 'InBundle' message to the return. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136928|0 |1 is obsolete| | --- Comment #386 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137005&action=edit Bug 28854: Unit tests - chargelostitem This patch adds unit tests for the changes to chargelositem to ensure bundle charging works as expected setting the correct issue_id. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136929|0 |1 is obsolete| | --- Comment #387 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137006&action=edit Bug 28854: Add default AV and Syspref values This patch adds the new AV and System Preferences to the installer. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136930|0 |1 is obsolete| | --- Comment #388 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137007&action=edit Bug 28854: (follow-up) Translations fixes This patch wraps and unwraps strings appropriately for trasnlation. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136931|0 |1 is obsolete| | --- Comment #389 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137008&action=edit Bug 28854: (follow-up) Rename column configuration to barcode This patch updates the column configuration from 'external_id' to 'barcode' Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136932|0 |1 is obsolete| | --- Comment #390 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137009&action=edit Bug 28854: (follow-up) Move preferences to "Item bundles" Move the preferences into a section under 'Circulation' called 'Item bundles' Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136933|0 |1 is obsolete| | --- Comment #391 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137010&action=edit Bug 28854: (follow-up) Fix typo in templates and test plan * aready > already * 61 > 62 Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136934|0 |1 is obsolete| | --- Comment #392 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137011&action=edit Bug 28854: (follow-up) Improve error for item not found Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136935|0 |1 is obsolete| | --- Comment #393 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137012&action=edit Bug 28854: (follow-up) Use barcodedecode in Koha::REST::V1::Items This removes any leading or trailing whitespace from the external id passed Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136936|0 |1 is obsolete| | --- Comment #394 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137013&action=edit Bug 28854: (follow-up) Disable bundle editing for checked out This patch disables the add and remove options under bundle management when the bundled item in question is checked out. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136937|0 |1 is obsolete| | --- Comment #395 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137014&action=edit Bug 28854: (follow-up) Link bundle items to thier biblios This patch splits out the title formatting from the bundle item title display into it's own new js-biblio-format include file and adds biblio linking options. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136938|0 |1 is obsolete| | --- Comment #396 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137015&action=edit Bug 28854: (follow-up) Restore last seen date formatting We lost the date formatting somewhere along the line with rebases, this patch restores the call to $date for last seen date. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136939|0 |1 is obsolete| | --- Comment #397 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137016&action=edit Bug 28854: (follow-up) Add bundle item status to manage button This patch adds the item counts (Present|Lost) to the 'Manage bundle' button in the catalogue details page. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136940|0 |1 is obsolete| | --- Comment #398 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137017&action=edit Bug 28854: (follow-up) Make 'Manage bundle' button a 'toggle' This patch adds and removes the 'active' class to the 'Manage bundle' button such that it correctly reflects whether the manage area is expanded or not for the bundle item. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136941|0 |1 is obsolete| | --- Comment #399 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137018&action=edit Bug 28854: (follow-up) Restore block styling on bundled span This patch restores a css rule that we lost during rebases that makes the 'bundled' span that appears for bundled items on their respective details pages so that the 'In bundle: ' text in the status field of the table appears beneath the 'Not for loan (Added to bundle)' text. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136942|0 |1 is obsolete| | --- Comment #400 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137019&action=edit Bug 28854: (follow-up) Link to 'In bundle' on OPAC This patch adds the 'In bundle: Link' to the OPAC to mirror what we have on the staff client. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136943|0 |1 is obsolete| | --- Comment #401 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137020&action=edit Bug 28854: (follow-up) Add handling for part_numbers/names This patch adds part number/name handling to the new biblio-format js include. This will add such details to bundle management tables. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136946|0 |1 is obsolete| | --- Comment #402 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137021&action=edit Bug 28854: (QA follow-up) Add missing TT filters Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136947|0 |1 is obsolete| | --- Comment #403 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137022&action=edit Bug 28854: (follow-up) Remove fields from from bundle items This patch removes the itemtype and collection code fields from the bundle items table. We will add the itemtype back in at a later date with a new bug as the display code needs some careful consideration and we felt that doing that work inline here would be an unrequired blocker. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136944|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136945|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136949|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #404 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Final rebase done and commits we agreed to split out into their own bugs have now been split out and added to the bugzilla tree. All ready for a final QA run. Thanks so much for the thorough and vigilent testing Katrin.. it's been really helpful putting this new feature through it's paces and I think we've come out with a much more polished piece overall. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 MichaelaSieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136978|0 |1 is obsolete| | --- Comment #405 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137461&action=edit Bug 28854: Database update Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136979|0 |1 is obsolete| | --- Comment #406 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137462&action=edit Bug 28854: DBIC Schema Updates Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136980|0 |1 is obsolete| | --- Comment #407 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137463&action=edit Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point and run the database update 1) Configuration: `BundleNotLoanValue` should have been set by the database update and point to a newly added AV value. 2) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 3) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 4) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. 5) The bundles feature can be disabled by unsetting the `BundleNotLoanValue` system preference. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136981|0 |1 is obsolete| | --- Comment #408 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137464&action=edit Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136982|0 |1 is obsolete| | --- Comment #409 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137465&action=edit Bug 28854: Highlight bundle rows to clarify UI Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136985|0 |1 is obsolete| | --- Comment #410 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137466&action=edit Bug 28854: Drop unique index on issue_id in return claims With the introduction of circulating items within a bundle set, we can now loose multiple items from the bundle from the same issue. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136988|0 |1 is obsolete| | --- Comment #411 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137467&action=edit Bug 28854: DBIC Update ReturnClaim Schema Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136989|0 |1 is obsolete| | --- Comment #412 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137468&action=edit Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that it is marked as lost. 4) Navigate to the biblio for the collection and expand the collection item that contains the lost item. Note the item is marked as lost and checkout details are listed. 5) Checkin the lost item * The item should be marked as found and the return_claims line should be marked as resolved. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136990|0 |1 is obsolete| | --- Comment #413 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137469&action=edit Bug 28854: Simplified status handling for bundle inventory check Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136991|0 |1 is obsolete| | --- Comment #414 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137470&action=edit Bug 28854: Add option to print content list after verification We already allowed the user to view and print an updated content list after a varification showed that items were missing from the bundle. This patch adds the option to view and print the list even if the content has been varified to have not changed. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136992|0 |1 is obsolete| | --- Comment #415 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137471&action=edit Bug 28854: Add ordering to checkin validation modal This enhancement adds simple dataTable ordering to the verification modal table at bundle checkin time. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136993|0 |1 is obsolete| | --- Comment #416 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137472&action=edit Bug 28854: Improve lost details display for bundle items This patch adds the return claim details to the bundle item status display on the catalogue details page. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136994|0 |1 is obsolete| | --- Comment #417 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137473&action=edit Bug 28854: Enable claims return view when BundleLostValue is set This patch adds the alternation of BundleLostValue to enable the return claims functionality when Bundles are enbled. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136995|0 |1 is obsolete| | --- Comment #418 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137474&action=edit Bug 28854: Highlight when a scanned item is unexpected Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136996|0 |1 is obsolete| | --- Comment #419 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137475&action=edit Bug 28854: Add count of scanned items to verification modal Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136997|0 |1 is obsolete| | --- Comment #420 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137476&action=edit Bug 28854: Add 'Remove from bundle' dialogue to details display This patch adds the counterpart of the 'Add to bundle' modal prompt for adding items to bundles from the catalogue details display. It allows for scanning barcodes to remove them from a bundle. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136998|0 |1 is obsolete| | --- Comment #421 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137477&action=edit Bug 28854: Add modal after checkin to print missing items list This patch adds a further modal to the post checkin alert to allow the user to print a view and print a list of items that went missing at this checkin to allow for replacements to be picked. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136999|0 |1 is obsolete| | --- Comment #422 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137478&action=edit Bug 28854: (follow-up) Only count rows in the body This patch fixes the count to only include table rows in the body, i.e. skip the header row. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137000|0 |1 is obsolete| | --- Comment #423 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137479&action=edit Bug 28854: Make barcode comparison case insensative Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137001|0 |1 is obsolete| | --- Comment #424 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137480&action=edit Bug 28854: (QA follow-up) Fix QA tool complaints * Typo in code comment * Permissions on atomicupdate * Missing TT filter in template * Spelling in template Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137002|0 |1 is obsolete| | --- Comment #425 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137481&action=edit Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469 Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137003|0 |1 is obsolete| | --- Comment #426 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137482&action=edit Bug 28854: Unit test for Koha::Item additions This patch adds unit tests for the new methods added to Koha::Item including: * return_claim * return_claims * is_bundle * in_bundle * bundle_host * bundle_items * add_to_bundle * remove_from_bundle Test plan 1) Run t/db_dependent/Koha/Item.t Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137004|0 |1 is obsolete| | --- Comment #427 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137483&action=edit Bug 28854: Unit test for AddReturn addition This patch adds tests for the AddReturn change that adds an 'InBundle' message to the return. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137005|0 |1 is obsolete| | --- Comment #428 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137484&action=edit Bug 28854: Unit tests - chargelostitem This patch adds unit tests for the changes to chargelositem to ensure bundle charging works as expected setting the correct issue_id. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137006|0 |1 is obsolete| | --- Comment #429 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137485&action=edit Bug 28854: Add default AV and Syspref values This patch adds the new AV and System Preferences to the installer. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137007|0 |1 is obsolete| | --- Comment #430 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137486&action=edit Bug 28854: (follow-up) Translations fixes This patch wraps and unwraps strings appropriately for trasnlation. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137008|0 |1 is obsolete| | --- Comment #431 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137487&action=edit Bug 28854: (follow-up) Rename column configuration to barcode This patch updates the column configuration from 'external_id' to 'barcode' Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137009|0 |1 is obsolete| | --- Comment #432 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137488&action=edit Bug 28854: (follow-up) Move preferences to "Item bundles" Move the preferences into a section under 'Circulation' called 'Item bundles' Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137010|0 |1 is obsolete| | --- Comment #433 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137489&action=edit Bug 28854: (follow-up) Fix typo in templates and test plan * aready > already * 61 > 62 Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137011|0 |1 is obsolete| | --- Comment #434 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137490&action=edit Bug 28854: (follow-up) Improve error for item not found Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137012|0 |1 is obsolete| | --- Comment #435 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137491&action=edit Bug 28854: (follow-up) Use barcodedecode in Koha::REST::V1::Items This removes any leading or trailing whitespace from the external id passed Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137013|0 |1 is obsolete| | --- Comment #436 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137492&action=edit Bug 28854: (follow-up) Disable bundle editing for checked out This patch disables the add and remove options under bundle management when the bundled item in question is checked out. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137014|0 |1 is obsolete| | --- Comment #437 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137493&action=edit Bug 28854: (follow-up) Link bundle items to thier biblios This patch splits out the title formatting from the bundle item title display into it's own new js-biblio-format include file and adds biblio linking options. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137015|0 |1 is obsolete| | --- Comment #438 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137494&action=edit Bug 28854: (follow-up) Restore last seen date formatting We lost the date formatting somewhere along the line with rebases, this patch restores the call to $date for last seen date. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137016|0 |1 is obsolete| | --- Comment #439 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137495&action=edit Bug 28854: (follow-up) Add bundle item status to manage button This patch adds the item counts (Present|Lost) to the 'Manage bundle' button in the catalogue details page. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137017|0 |1 is obsolete| | --- Comment #440 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137496&action=edit Bug 28854: (follow-up) Make 'Manage bundle' button a 'toggle' This patch adds and removes the 'active' class to the 'Manage bundle' button such that it correctly reflects whether the manage area is expanded or not for the bundle item. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137018|0 |1 is obsolete| | --- Comment #441 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137497&action=edit Bug 28854: (follow-up) Restore block styling on bundled span This patch restores a css rule that we lost during rebases that makes the 'bundled' span that appears for bundled items on their respective details pages so that the 'In bundle: ' text in the status field of the table appears beneath the 'Not for loan (Added to bundle)' text. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137019|0 |1 is obsolete| | --- Comment #442 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137498&action=edit Bug 28854: (follow-up) Link to 'In bundle' on OPAC This patch adds the 'In bundle: Link' to the OPAC to mirror what we have on the staff client. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137020|0 |1 is obsolete| | --- Comment #443 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137499&action=edit Bug 28854: (follow-up) Add handling for part_numbers/names This patch adds part number/name handling to the new biblio-format js include. This will add such details to bundle management tables. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137021|0 |1 is obsolete| | --- Comment #444 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137500&action=edit Bug 28854: (QA follow-up) Add missing TT filters Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137022|0 |1 is obsolete| | --- Comment #445 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137501&action=edit Bug 28854: (follow-up) Remove fields from from bundle items This patch removes the itemtype and collection code fields from the bundle items table. We will add the itemtype back in at a later date with a new bug as the display code needs some careful consideration and we felt that doing that work inline here would be an unrequired blocker. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #446 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Another rebase, now that itemgroups is in.. I was worried these features might clash more, but the rebase was fairly trivial and they seem to compliment each other nicely in the UI so far in my testing. Ready for QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to create |Add ability to create |bundles of items |bundles of items for | |circulation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #447 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137503&action=edit Bug 28854: Squashed Patch Set for Reading Bug 28854: Database update Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: DBIC Schema Updates Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point and run the database update 1) Configuration: `BundleNotLoanValue` should have been set by the database update and point to a newly added AV value. 2) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 3) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 4) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. 5) The bundles feature can be disabled by unsetting the `BundleNotLoanValue` system preference. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: Highlight bundle rows to clarify UI Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: Drop unique index on issue_id in return claims With the introduction of circulating items within a bundle set, we can now loose multiple items from the bundle from the same issue. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: DBIC Update ReturnClaim Schema Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that it is marked as lost. 4) Navigate to the biblio for the collection and expand the collection item that contains the lost item. Note the item is marked as lost and checkout details are listed. 5) Checkin the lost item * The item should be marked as found and the return_claims line should be marked as resolved. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: Simplified status handling for bundle inventory check Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: Add option to print content list after verification We already allowed the user to view and print an updated content list after a varification showed that items were missing from the bundle. This patch adds the option to view and print the list even if the content has been varified to have not changed. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: Add ordering to checkin validation modal This enhancement adds simple dataTable ordering to the verification modal table at bundle checkin time. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: Improve lost details display for bundle items This patch adds the return claim details to the bundle item status display on the catalogue details page. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: Enable claims return view when BundleLostValue is set This patch adds the alternation of BundleLostValue to enable the return claims functionality when Bundles are enbled. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: Highlight when a scanned item is unexpected Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: Add count of scanned items to verification modal Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: Add 'Remove from bundle' dialogue to details display This patch adds the counterpart of the 'Add to bundle' modal prompt for adding items to bundles from the catalogue details display. It allows for scanning barcodes to remove them from a bundle. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: Add modal after checkin to print missing items list This patch adds a further modal to the post checkin alert to allow the user to print a view and print a list of items that went missing at this checkin to allow for replacements to be picked. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: (follow-up) Only count rows in the body This patch fixes the count to only include table rows in the body, i.e. skip the header row. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: Make barcode comparison case insensative Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: (QA follow-up) Fix QA tool complaints * Typo in code comment * Permissions on atomicupdate * Missing TT filter in template * Spelling in template Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469 Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: Unit test for Koha::Item additions This patch adds unit tests for the new methods added to Koha::Item including: * return_claim * return_claims * is_bundle * in_bundle * bundle_host * bundle_items * add_to_bundle * remove_from_bundle Test plan 1) Run t/db_dependent/Koha/Item.t Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: Unit test for AddReturn addition This patch adds tests for the AddReturn change that adds an 'InBundle' message to the return. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: Unit tests - chargelostitem This patch adds unit tests for the changes to chargelositem to ensure bundle charging works as expected setting the correct issue_id. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: Add default AV and Syspref values This patch adds the new AV and System Preferences to the installer. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: (follow-up) Translations fixes This patch wraps and unwraps strings appropriately for trasnlation. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: (follow-up) Rename column configuration to barcode This patch updates the column configuration from 'external_id' to 'barcode' Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: (follow-up) Move preferences to "Item bundles" Move the preferences into a section under 'Circulation' called 'Item bundles' Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: (follow-up) Fix typo in templates and test plan * aready > already * 61 > 62 Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: (follow-up) Improve error for item not found Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: (follow-up) Use barcodedecode in Koha::REST::V1::Items This removes any leading or trailing whitespace from the external id passed Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: (follow-up) Disable bundle editing for checked out This patch disables the add and remove options under bundle management when the bundled item in question is checked out. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: (follow-up) Link bundle items to thier biblios This patch splits out the title formatting from the bundle item title display into it's own new js-biblio-format include file and adds biblio linking options. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: (follow-up) Restore last seen date formatting We lost the date formatting somewhere along the line with rebases, this patch restores the call to $date for last seen date. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: (follow-up) Add bundle item status to manage button This patch adds the item counts (Present|Lost) to the 'Manage bundle' button in the catalogue details page. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: (follow-up) Make 'Manage bundle' button a 'toggle' This patch adds and removes the 'active' class to the 'Manage bundle' button such that it correctly reflects whether the manage area is expanded or not for the bundle item. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: (follow-up) Restore block styling on bundled span This patch restores a css rule that we lost during rebases that makes the 'bundled' span that appears for bundled items on their respective details pages so that the 'In bundle: ' text in the status field of the table appears beneath the 'Not for loan (Added to bundle)' text. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: (follow-up) Link to 'In bundle' on OPAC This patch adds the 'In bundle: Link' to the OPAC to mirror what we have on the staff client. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: (follow-up) Add handling for part_numbers/names This patch adds part number/name handling to the new biblio-format js include. This will add such details to bundle management tables. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: (QA follow-up) Add missing TT filters Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Bug 28854: (follow-up) Remove fields from from bundle items This patch removes the itemtype and collection code fields from the bundle items table. We will add the itemtype back in at a later date with a new bug as the display code needs some careful consideration and we felt that doing that work inline here would be an unrequired blocker. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137503|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #448 from Kyle M Hall <kyle@bywatersolutions.com> --- Comment on attachment 137503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137503 Bug 28854: Squashed Patch Set for Reading Review of attachment 137503: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=28854&attachment=137503) ----------------------------------------------------------------- ::: C4/Accounts.pm @@ +70,5 @@
sub chargelostitem { my $dbh = C4::Context->dbh(); my ($borrowernumber, $itemnumber, $amount, $description) = @_; + my $item = Koha::Items->find($itemnumber); + my $itype = $item->itemtype;
Why the switch from effective_itemtype() to itemtype()? ::: Koha/Item.pm @@ +1611,5 @@
+ } + elsif ( $_->{msg} =~ +/Incorrect (?<type>\w+) value: '(?<value>.*)' for column \W?(?<property>\S+)/ + ) + { # The optional \W in the regex might be a quote or backtick
There is no \W in the regex. Wish it changed, or maybe the W should be lower case? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #449 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137506&action=edit Bug 28854: (QA follow-up) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31130 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31130 [Bug 31130] Display collection code in bundle management table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #450 from Kyle M Hall <kyle@bywatersolutions.com> --- I'm getting failures from t/db_dependent/Koha/Checkouts/ReturnClaim.t In addition, can you address the two small things from my splinter review? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #451 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Kyle M Hall from comment #448)
Comment on attachment 137503 [details] [review] Bug 28854: Squashed Patch Set for Reading
Review of attachment 137503 [details] [review]: -----------------------------------------------------------------
::: C4/Accounts.pm @@ +70,5 @@
sub chargelostitem { my $dbh = C4::Context->dbh(); my ($borrowernumber, $itemnumber, $amount, $description) = @_; + my $item = Koha::Items->find($itemnumber); + my $itype = $item->itemtype;
Why the switch from effective_itemtype() to itemtype()?
So.. the change here is actually so we can have access to the Item object lower down in the function.. the switch from finding the itemtype object directly to using the Koha::Item level accessor method means we get back the effective_itemtype object directly via the accessor. See Koha::Item->itemtype ;P
::: Koha/Item.pm @@ +1611,5 @@
+ } + elsif ( $_->{msg} =~ +/Incorrect (?<type>\w+) value: '(?<value>.*)' for column \W?(?<property>\S+)/ + ) + { # The optional \W in the regex might be a quote or backtick
There is no \W in the regex. Wish it changed, or maybe the W should be lower case?
Huh.. this is a copy/paste from Koha::Object::store (Yes, I'd like to move it into DBIC at some point, but didn't feel it was appropriate here).. the `\W?` is there.. just after `for column` in the regex.. not sure I follow your question here I'm afraid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #452 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Kyle M Hall from comment #450)
I'm getting failures from t/db_dependent/Koha/Checkouts/ReturnClaim.t In addition, can you address the two small things from my splinter review?
Hmm.. I can't seem to get the test to fail.. did you run the DB update/get any errors when you ran the DB update? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #453 from Kyle M Hall <kyle@bywatersolutions.com> ---
Why the switch from effective_itemtype() to itemtype()?
So.. the change here is actually so we can have access to the Item object lower down in the function.. the switch from finding the itemtype object directly to using the Koha::Item level accessor method means we get back the effective_itemtype object directly via the accessor. See Koha::Item->itemtype ;P
Thanks! I see now! I missed that subroutine when I was looking for it!
Huh.. this is a copy/paste from Koha::Object::store (Yes, I'd like to move it into DBIC at some point, but didn't feel it was appropriate here).. the `\W?` is there.. just after `for column` in the regex.. not sure I follow your question here I'm afraid.
I missed where the \W was by focusing only on the patch and not the surrounding code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #454 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137524&action=edit Bug 28854: (QA follow-up) Remove duplicate key test We now allow duplication of issue_id accross the return claims table (to allow for the case where a bundle item has been loaned and thus multiple claims can result from the same checkout. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #455 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137525&action=edit Bug 28854: (QA follow-up) Fix DB revision for AV's above 10 The authorised_value field is a varchar and so 'MAX' will sort '9' above '10' and cause issues if you have more than 9 AV values already for LOST or NOT_LOAN. This patch adds a 'CAST' to the field so we can use MAX correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137461|0 |1 is obsolete| | Attachment #137462|0 |1 is obsolete| | Attachment #137463|0 |1 is obsolete| | Attachment #137464|0 |1 is obsolete| | Attachment #137465|0 |1 is obsolete| | Attachment #137466|0 |1 is obsolete| | Attachment #137467|0 |1 is obsolete| | Attachment #137468|0 |1 is obsolete| | Attachment #137469|0 |1 is obsolete| | Attachment #137470|0 |1 is obsolete| | Attachment #137471|0 |1 is obsolete| | Attachment #137472|0 |1 is obsolete| | Attachment #137473|0 |1 is obsolete| | Attachment #137474|0 |1 is obsolete| | Attachment #137475|0 |1 is obsolete| | Attachment #137476|0 |1 is obsolete| | Attachment #137477|0 |1 is obsolete| | Attachment #137478|0 |1 is obsolete| | Attachment #137479|0 |1 is obsolete| | Attachment #137480|0 |1 is obsolete| | Attachment #137481|0 |1 is obsolete| | Attachment #137482|0 |1 is obsolete| | Attachment #137483|0 |1 is obsolete| | Attachment #137484|0 |1 is obsolete| | Attachment #137485|0 |1 is obsolete| | Attachment #137486|0 |1 is obsolete| | Attachment #137487|0 |1 is obsolete| | Attachment #137488|0 |1 is obsolete| | Attachment #137489|0 |1 is obsolete| | Attachment #137490|0 |1 is obsolete| | Attachment #137491|0 |1 is obsolete| | Attachment #137492|0 |1 is obsolete| | Attachment #137493|0 |1 is obsolete| | Attachment #137494|0 |1 is obsolete| | Attachment #137495|0 |1 is obsolete| | Attachment #137496|0 |1 is obsolete| | Attachment #137497|0 |1 is obsolete| | Attachment #137498|0 |1 is obsolete| | Attachment #137499|0 |1 is obsolete| | Attachment #137500|0 |1 is obsolete| | Attachment #137501|0 |1 is obsolete| | Attachment #137506|0 |1 is obsolete| | Attachment #137524|0 |1 is obsolete| | Attachment #137525|0 |1 is obsolete| | --- Comment #456 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137527&action=edit Bug 28854: Database update Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #457 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137528&action=edit Bug 28854: DBIC Schema Updates Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #458 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137529&action=edit Bug 28854: Expose functionality to attach items to bundles This patch adds methods the the Koha::Item object for managing item bundling operations and then exposes those methods via the REST API. We include the new `BundleNotLoanValue` preference for setting not for loan values when an item is added to a bundle. Finally, we expose bundle management via the catalogue details page. Test plan: 0) Apply patches up to this point and run the database update 1) Configuration: `BundleNotLoanValue` should have been set by the database update and point to a newly added AV value. 2) Creating a new bundle * Add a new bib record * Mark the bib record as a 'collection' type by setting leader position 7 to 'c' * Add a new item to this bib record * You should see a new 'Manage bundle' button available in the 'Actions' column of the Holdings table. * Clicking 'Manage bundle' should expand the table to include a new row directly beneath this one. * Use the new 'Add to bundle' button that appears in this row to trigger a modal that allows entering the barcode of items you wish to add to the bundle * Upon closing the modal, the bundle content table should reload and contain your newly associated items. * You can subsequently remove an item from a bundle using the new 'Remove' button. 3) Not for loan * Items that have been added into a bundle should now appear as 'Not for loan' from their original biblio record and note which bundle they belong to. 4) Error cases * Try adding an item that already belongs to a bundle to another bundle: Note an error is displayed in the modal form. 5) The bundles feature can be disabled by unsetting the `BundleNotLoanValue` system preference. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #459 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137530&action=edit Bug 28854: Update circulation functionality for bundles This patch updates the circulation system to account for bundle checkins. We add a content verification step to ensure bundle content is all present at checkin and we use this comparison to mark missing items as lost. Test plan 0) Apply patches up to this point 1) Checkin an item that belongs to a bundle * An alert should be triggered noting that the item belongs to a bundle * The option to remove the item from the bundle should be clear * Click remove should result in the alert dissapearing and the item having been removed from the bundle. 2) Checkin an item bundle * A modal confirmation dialog should appear requesting each item barcode be scanned * As items are scanned they should be highlighted in yellow in the bundle content table * Upon submission; * The user will be alerted to any unexpected items that were scanned and told to put them to one side. * The user will be alerted that any missing items in the validation will have been marked as lost. * The bundle item will be marked as checked in. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #460 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137531&action=edit Bug 28854: Highlight bundle rows to clarify UI Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #461 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137532&action=edit Bug 28854: Drop unique index on issue_id in return claims With the introduction of circulating items within a bundle set, we can now loose multiple items from the bundle from the same issue. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #462 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137533&action=edit Bug 28854: DBIC Update ReturnClaim Schema Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #463 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137534&action=edit Bug 28854: Record and display who lost the item This patch records the bundle issue from which an item is marked as lost so that we may use that to infer who lost the item (for later charges and display). Test plan 0) Apply all patches up to this point 1) Checkout a bundle to a user 2) Checkin the bundle and do not scan one of the barcodes at confirmation * Note that the item not scanned is marked as lost 3) Navigate to the biblio for the lost item and note that it is marked as lost. 4) Navigate to the biblio for the collection and expand the collection item that contains the lost item. Note the item is marked as lost and checkout details are listed. 5) Checkin the lost item * The item should be marked as found and the return_claims line should be marked as resolved. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #464 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137535&action=edit Bug 28854: Simplified status handling for bundle inventory check Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #465 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137536&action=edit Bug 28854: Add option to print content list after verification We already allowed the user to view and print an updated content list after a varification showed that items were missing from the bundle. This patch adds the option to view and print the list even if the content has been varified to have not changed. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #466 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137537&action=edit Bug 28854: Add ordering to checkin validation modal This enhancement adds simple dataTable ordering to the verification modal table at bundle checkin time. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #467 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137538&action=edit Bug 28854: Improve lost details display for bundle items This patch adds the return claim details to the bundle item status display on the catalogue details page. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #468 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137540&action=edit Bug 28854: Enable claims return view when BundleLostValue is set This patch adds the alternation of BundleLostValue to enable the return claims functionality when Bundles are enbled. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #469 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137541&action=edit Bug 28854: Highlight when a scanned item is unexpected Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #470 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137542&action=edit Bug 28854: Add count of scanned items to verification modal Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #471 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137543&action=edit Bug 28854: Add 'Remove from bundle' dialogue to details display This patch adds the counterpart of the 'Add to bundle' modal prompt for adding items to bundles from the catalogue details display. It allows for scanning barcodes to remove them from a bundle. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #472 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137544&action=edit Bug 28854: Add modal after checkin to print missing items list This patch adds a further modal to the post checkin alert to allow the user to print a view and print a list of items that went missing at this checkin to allow for replacements to be picked. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #473 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137545&action=edit Bug 28854: (follow-up) Only count rows in the body This patch fixes the count to only include table rows in the body, i.e. skip the header row. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #474 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137546&action=edit Bug 28854: Make barcode comparison case insensative Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #475 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137547&action=edit Bug 28854: (QA follow-up) Fix QA tool complaints * Typo in code comment * Permissions on atomicupdate * Missing TT filter in template * Spelling in template Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #476 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137548&action=edit Bug 28854: (follow-up) Use Koha::Item->itemtype introduced with bug 20469 Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #477 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137549&action=edit Bug 28854: Unit test for Koha::Item additions This patch adds unit tests for the new methods added to Koha::Item including: * return_claim * return_claims * is_bundle * in_bundle * bundle_host * bundle_items * add_to_bundle * remove_from_bundle Test plan 1) Run t/db_dependent/Koha/Item.t Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #478 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137550&action=edit Bug 28854: Unit test for AddReturn addition This patch adds tests for the AddReturn change that adds an 'InBundle' message to the return. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #479 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137551&action=edit Bug 28854: Unit tests - chargelostitem This patch adds unit tests for the changes to chargelositem to ensure bundle charging works as expected setting the correct issue_id. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #480 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137552&action=edit Bug 28854: Add default AV and Syspref values This patch adds the new AV and System Preferences to the installer. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #481 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137553&action=edit Bug 28854: (follow-up) Translations fixes This patch wraps and unwraps strings appropriately for trasnlation. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #482 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137554&action=edit Bug 28854: (follow-up) Rename column configuration to barcode This patch updates the column configuration from 'external_id' to 'barcode' Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #483 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137555&action=edit Bug 28854: (follow-up) Move preferences to "Item bundles" Move the preferences into a section under 'Circulation' called 'Item bundles' Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #484 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137556&action=edit Bug 28854: (follow-up) Fix typo in templates and test plan * aready > already * 61 > 62 Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #485 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137557&action=edit Bug 28854: (follow-up) Improve error for item not found Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #486 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137558&action=edit Bug 28854: (follow-up) Use barcodedecode in Koha::REST::V1::Items This removes any leading or trailing whitespace from the external id passed Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #487 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137559&action=edit Bug 28854: (follow-up) Disable bundle editing for checked out This patch disables the add and remove options under bundle management when the bundled item in question is checked out. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #488 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137560&action=edit Bug 28854: (follow-up) Link bundle items to thier biblios This patch splits out the title formatting from the bundle item title display into it's own new js-biblio-format include file and adds biblio linking options. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #489 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137561&action=edit Bug 28854: (follow-up) Restore last seen date formatting We lost the date formatting somewhere along the line with rebases, this patch restores the call to $date for last seen date. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #490 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137562&action=edit Bug 28854: (follow-up) Add bundle item status to manage button This patch adds the item counts (Present|Lost) to the 'Manage bundle' button in the catalogue details page. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #491 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137563&action=edit Bug 28854: (follow-up) Make 'Manage bundle' button a 'toggle' This patch adds and removes the 'active' class to the 'Manage bundle' button such that it correctly reflects whether the manage area is expanded or not for the bundle item. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #492 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137564&action=edit Bug 28854: (follow-up) Restore block styling on bundled span This patch restores a css rule that we lost during rebases that makes the 'bundled' span that appears for bundled items on their respective details pages so that the 'In bundle: ' text in the status field of the table appears beneath the 'Not for loan (Added to bundle)' text. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #493 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137565&action=edit Bug 28854: (follow-up) Link to 'In bundle' on OPAC This patch adds the 'In bundle: Link' to the OPAC to mirror what we have on the staff client. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #494 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137566&action=edit Bug 28854: (follow-up) Add handling for part_numbers/names This patch adds part number/name handling to the new biblio-format js include. This will add such details to bundle management tables. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #495 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137567&action=edit Bug 28854: (QA follow-up) Add missing TT filters Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #496 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137568&action=edit Bug 28854: (follow-up) Remove fields from from bundle items This patch removes the itemtype and collection code fields from the bundle items table. We will add the itemtype back in at a later date with a new bug as the display code needs some careful consideration and we felt that doing that work inline here would be an unrequired blocker. Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #497 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137569&action=edit Bug 28854: (QA follow-up) Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #498 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137570&action=edit Bug 28854: (QA follow-up) Remove duplicate key test We now allow duplication of issue_id accross the return claims table (to allow for the case where a bundle item has been loaned and thus multiple claims can result from the same checkout. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #499 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137571&action=edit Bug 28854: (QA follow-up) Fix DB revision for AV's above 10 The authorised_value field is a varchar and so 'MAX' will sort '9' above '10' and cause issues if you have more than 9 AV values already for LOST or NOT_LOAN. This patch adds a 'CAST' to the field so we can use MAX correctly. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #500 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #501 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137684&action=edit Bug 28854: (follow-up) Replace unique constraint in return claims This patch fixes the failing test for the return claims api. We add a new unique constraint to replace the one we removed earlier in the patchset. One should not be able to create a duplicate return claim for the same issue of an item. Test plan 1) Run the database update 2) Confirm that t/db_dependent/api/v1/return_claims.t now passes 3) Confirm that t/db_dependent/api/v1/items.t continues to pass 4) Bonus points, confirm that bundle checkin still works when items are missing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #502 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Follow-up attached to fix the failing introduced here on master. Not sure why I didn't think about this constraint replacement in the first place, it's a nice improvement over the simple removal I did before and shouldn't have any negative side effects on the feature introduced here. The follow-up includes an atomic update and the kohaschema change but does not include the dbic schema build ;P -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137684|0 |1 is obsolete| | --- Comment #503 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 137685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137685&action=edit Bug 28854: (follow-up) Replace unique constraint in return claims This patch fixes the failing test for the return claims api. We add a new unique constraint to replace the one we removed earlier in the patchset. One should not be able to create a duplicate return claim for the same issue of an item. Test plan 1) Run the database update 2) Confirm that t/db_dependent/api/v1/return_claims.t now passes 3) Confirm that t/db_dependent/api/v1/items.t continues to pass 4) Bonus points, confirm that bundle checkin still works when items are missing Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31192 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31192 [Bug 31192] Checking in an unkown barcode causes error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #504 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- New error/warning in test output t/db_dependent/Koha/Item.t .. 5/25 DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Duplicate entry '987-988' for key 'PRIMARY' at /kohadevbox/koha/Koha/Item.pm line 1601 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Bug 28854 depends on bug 31087, which changed state. Bug 31087 Summary: Undefined notes in returns claims get stringified to 'null' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31087 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Bug 28854 depends on bug 31085, which changed state. Bug 31085 Summary: The return claims table no longer reloads on resolution https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31085 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #505 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Oops, I'll work on this today.. apologies I missed it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #506 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 139347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139347&action=edit Bug 28854: (follow-up) Remove errant warning Oops, I left in a bare warn from debugging.. this simply removes it; it is unrequired. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #507 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Follow-up pushed to master. Thanks for addressing it promptly, Martin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |Needs documenting Documentation| |Martin Renvoize contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31615 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31615 [Bug 31615] Allow checkin of items bundles without verifying their contents -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #508 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I notice a lot of nice additions to this are hiding in the 'Blocks' list here! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32121 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32121 [Bug 32121] Show an alert when adding a checked out item to an item bundle -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #509 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Documentation converted from google doc and merged. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32134 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32134 [Bug 32134] Show the bundle size when checked out -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This new feature adds the |This new feature adds the release notes|ability to create item |ability to create item |bundles for loans. |bundles for loans. | | |One can |One can |create a new collection |create a new collection |level biblio record and add |level biblio record and add |items to it as normal. |items to it as normal. |Those items can then be |Those items can then be |converted to bundles by |converted to bundles by |adding existing items to |adding existing items to |them using their barcodes. |them using their barcodes. |The items will be marked as |The items will be marked as |'not for loan' in their |'not for loan' in their |original parent records. |original parent records. | | |Bundle items follow normal |Bundle items follow normal |circulation rules for |circulation rules for |checkout. Upon check-in a |checkout. Upon check-in a |new verification step is |new verification step is |added where by the |added where by the |librarian is expected to |librarian is expected to |scan each constituent item |scan each constituent item |to varify it's presence in |to varify it's presence in |the bundle. If an item is |the bundle. If an item is |missing from the bundle it |missing from the bundle it |is marked as lost with a |is marked as lost with a |new lost - Missing from |new lost - Missing from |bundle value. If an item |bundle value. If an item |is found that is not |is found that is not |expected to be in the |expected to be in the |bundle it it highlighted to |bundle it it highlighted to |the librarian after |the librarian after |check-in so it can be |check-in so it can be |placed to one side. |placed to one side. | | | |**Sponsored by** *PTFS | |Europe* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #510 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- All that bundle JS code in detail.tt could have been moved to a dedicated js file to keep the template under 2k lines :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #511 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #510)
All that bundle JS code in detail.tt could have been moved to a dedicated js file to keep the template under 2k lines :D
True.. it grew and grew and grew. I'll create a follow-up bug and handle that -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #512 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bug 32802 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33035 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33035 [Bug 33035] Add volume column in the item bundle table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #513 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- CREATE TABLE `item_bundles` ( `item` int(11) NOT NULL, Why didnt we call that itemnumber? And why not an autoincrement id here too btw? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #514 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Few observations while testing a dependent report: [1] When I have a bundle with 2 items, checkout and checkin (only one barcode), I see the following on opac-detail for the missing item: Missing from bundle Added to bundle In bundle: Learning Perl / This message is not very clear (at the least). Should we replace this by Missing from bundle X ? [2] Similarly, the other item says: Added to bundle In bundle: Learning Perl / Could it be clearer to say just the latter here (In bundle X) ? [3] Furthermore, I note that the parent biblo record that contains the host item, does not show that this item is a bundle. Should we somehow indicate that ? [4] Things can get even more confusing when we add two host items to one parent record. If those two items contain various items, they are all referenced by the same name (biblio title of parent record). But these are different bundles. [5] Elaborating on point 5: If you have two bundles on same biblio record, the normal display on intranet of the biblio record crashes on the second bundle: GET /api/v1/items/2525/bundled_items: unhandled exception (Mojo::Exception)<<Can't call method "to_api" on an undefined value at /usr/share/koha/Koha/Biblio.pm line 1209.>> NOTE: This was the case with the patches of 29099 but also WITHOUT ! I have the impression that this area needs more attention still. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33817 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 [Bug 33817] Composition or an item bundle can be changed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|31082 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31082 [Bug 31082] Add tooltip to buttons when item bundles cannot be changed while checked out -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #515 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Martin Renvoize from comment #269)
(In reply to Katrin Fischer from comment #224)
d) Should we be able to change contents of a bundle while it is checked out? At the moment it's possible. Maybe a 'safety question'? (question/suggestion)
Fixed in follow-up.
This is not working, there is some code in the template to disable the buttons but it does not work. I have a patch to fix it, but I am wondering if it is correct to disable the edition of a bundle item that is checked out. There is no code server-side to prevent that (and so it's currently possible). Should we fix or remove this restriction? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #516 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #515)
(In reply to Martin Renvoize from comment #269)
(In reply to Katrin Fischer from comment #224)
d) Should we be able to change contents of a bundle while it is checked out? At the moment it's possible. Maybe a 'safety question'? (question/suggestion)
Fixed in follow-up.
This is not working, there is some code in the template to disable the buttons but it does not work. I have a patch to fix it, but I am wondering if it is correct to disable the edition of a bundle item that is checked out.
There is no code server-side to prevent that (and so it's currently possible).
Should we fix or remove this restriction?
See bug 33817. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33827 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33827 [Bug 33827] The option to skip bundle verification at checkin should be syspref driven -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|33827 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33827 [Bug 33827] The option to skip bundle verification at checkin should be syspref driven -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #517 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 28602 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #518 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Martin, should the dbrev be changed as follows: diff --git a/installer/data/mysql/db_revs/220600015.pl b/installer/data/mysql/db_revs/220600015.pl index 89dc2d628b..11298b6860 100755 --- a/installer/data/mysql/db_revs/220600015.pl +++ b/installer/data/mysql/db_revs/220600015.pl @@ -26,7 +26,7 @@ return { $lost_val++; $dbh->do(qq{ - INSERT INTO authorised_values (category,authorised_value,lib) VALUES ('LOST',$lost_val,'Missing from bundle') + INSERT IGNORE INTO authorised_values (category,authorised_value,lib) VALUES ('LOST',$lost_val,'Missing from bundle') }); say $out "Missing from bundle LOST AV added"; @@ -34,7 +34,7 @@ return { $nfl_val++; $dbh->do(qq{ - INSERT INTO authorised_values (category,authorised_value,lib) VALUES ('NOT_LOAN',$nfl_val,'Added to bundle') + INSERT IGNORE INTO authorised_values (category,authorised_value,lib) VALUES ('NOT_LOAN',$nfl_val,'Added to bundle') }); say $out "Added to bundle NOT_LOAN AV added"; The dbrev crashes on a FK constraint when run twice in the context of bug 34683 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #519 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #518)
Martin, should the dbrev be changed as follows:
diff --git a/installer/data/mysql/db_revs/220600015.pl b/installer/data/mysql/db_revs/220600015.pl index 89dc2d628b..11298b6860 100755 --- a/installer/data/mysql/db_revs/220600015.pl +++ b/installer/data/mysql/db_revs/220600015.pl @@ -26,7 +26,7 @@ return { $lost_val++;
$dbh->do(qq{ - INSERT INTO authorised_values (category,authorised_value,lib) VALUES ('LOST',$lost_val,'Missing from bundle') + INSERT IGNORE INTO authorised_values (category,authorised_value,lib) VALUES ('LOST',$lost_val,'Missing from bundle') }); say $out "Missing from bundle LOST AV added";
@@ -34,7 +34,7 @@ return { $nfl_val++;
$dbh->do(qq{ - INSERT INTO authorised_values (category,authorised_value,lib) VALUES ('NOT_LOAN',$nfl_val,'Added to bundle') + INSERT IGNORE INTO authorised_values (category,authorised_value,lib) VALUES ('NOT_LOAN',$nfl_val,'Added to bundle') }); say $out "Added to bundle NOT_LOAN AV added";
The dbrev crashes on a FK constraint when run twice in the context of bug 34683
Note that's not the problem. We should not add the AV if one exists for "Missing from bundle", the IGNORE won't work here, and we will keep add one other "Missing from bundle". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #520 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #519)
Note that's not the problem. We should not add the AV if one exists for "Missing from bundle", the IGNORE won't work here, and we will keep add one other "Missing from bundle".
Agreed. IGNORE just ignores :) We could do better. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34881 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34881 [Bug 34881] Database update for bug 28854 isn't fully idempotent -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 --- Comment #521 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Marcel de Rooy from comment #520)
(In reply to Jonathan Druart from comment #519)
Note that's not the problem. We should not add the AV if one exists for "Missing from bundle", the IGNORE won't work here, and we will keep add one other "Missing from bundle".
Agreed. IGNORE just ignores :) We could do better.
Bug 34881 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35963 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35963 [Bug 35963] Problem using some filters in the bundled items table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28854 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36458 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36458 [Bug 36458] Koha::Item->return_claim method name is not correct -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org