[Bug 41178] New: SIP2 module does not notify that linked accounts are deleted when deleting an institution
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 Bug ID: 41178 Summary: SIP2 module does not notify that linked accounts are deleted when deleting an institution Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k Depends on| |37893 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37893 [Bug 37893] Migrate some SIP configuration into the staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 --- Comment #1 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189034&action=edit Bug 41178: Fix accounts.getAll API client to be used for searching -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 --- Comment #2 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189035&action=edit Bug 41178: (VueJS framework): Add beforeDoResourceDelete method -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 --- Comment #3 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 189036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189036&action=edit Bug 41178: (VueJS framework): Add i18n.deleteConfirmationBody Otherwise, we're unable to override the contents of the delete dialog This and the previous patch allow fetching related accounts on the fly when attempting to delete an institutions. This allows to provide a message stating how many (or which) accounts will be deleted if the selected institution is deleted. The way its implemented applies for both deleting the resource from the list or from the 'show' page. If the institution does not have any associated accounts, the delete dialog's behavior is the same as it was before. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |dcook@prosentient.com.au, | |kyle@bywatersolutions.com, | |martin.renvoize@openfifth.c | |o.uk Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- The patch still applies. Happy to test if you could add a test plan 8-). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189034|0 |1 is obsolete| | --- Comment #5 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 194323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194323&action=edit Bug 41178: Fix accounts.getAll API client to be used for searching -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189035|0 |1 is obsolete| | --- Comment #6 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 194324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194324&action=edit Bug 41178: (VueJS framework): Add beforeDoResourceDelete method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189036|0 |1 is obsolete| | --- Comment #7 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 194325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194325&action=edit Bug 41178: (VueJS framework): Add i18n.deleteConfirmationBody Otherwise, we're unable to override the contents of the delete dialog This and the previous patch allow fetching related accounts on the fly when attempting to delete an institutions. This allows to provide a message stating how many (or which) accounts will be deleted if the selected institution is deleted. The way its implemented applies for both deleting the resource from the list or from the 'show' page. If the institution does not have any associated accounts, the delete dialog's behavior is the same as it was before. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 --- Comment #8 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 194326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194326&action=edit Bug 41178: Add cypress test Run: cypress run --spec t/cypress/integration/SIP2/Institutions.ts Test plan: 1) Create a SIP institution, visit: http://localhost:8081/cgi-bin/koha/sip2/institutions/add 2) Create a SIP account linked to the institution from 1): http://localhost:8081/cgi-bin/koha/sip2/accounts/add 3) Go back to institutions: http://localhost:8081/cgi-bin/koha/sip2/institutions 4) Click 'delete'. Confirm the delete confirmation message contains: 'It has 1 associated accounts...' 5) Confirm that, notice the institution (and linked account) were deleted as expected and alerted 6) Repeat the test plan for the 'view' page instead of 'list' page: http://localhost:8081/cgi-bin/koha/sip2/institutions/<id_here> 7) Repeat the test plan but using an institution without any linked accounts. Confirm the 'regular' delete message is shown, which contains only the institution name in the modal body. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 --- Comment #9 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to David Nind from comment #4)
The patch still applies.
Happy to test if you could add a test plan 8-).
Hi David, thank you as always for being available here. I've updated one of the patches (slight typo) and added a cypress test patch with the UI test plan included. Thanks again! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194323|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194324|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194325|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194326|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 194349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194349&action=edit Bug 41178: Fix accounts.getAll API client to be used for searching Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 194350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194350&action=edit Bug 41178: (VueJS framework): Add beforeDoResourceDelete method Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 --- Comment #12 from David Nind <david@davidnind.com> --- Created attachment 194351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194351&action=edit Bug 41178: (VueJS framework): Add i18n.deleteConfirmationBody Otherwise, we're unable to override the contents of the delete dialog This and the previous patch allow fetching related accounts on the fly when attempting to delete an institutions. This allows to provide a message stating how many (or which) accounts will be deleted if the selected institution is deleted. The way its implemented applies for both deleting the resource from the list or from the 'show' page. If the institution does not have any associated accounts, the delete dialog's behavior is the same as it was before. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 194352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194352&action=edit Bug 41178: Add cypress test Run: cypress run --spec t/cypress/integration/SIP2/Institutions.ts Test plan: 1) Create a SIP institution, visit: http://localhost:8081/cgi-bin/koha/sip2/institutions/add 2) Create a SIP account linked to the institution from 1): http://localhost:8081/cgi-bin/koha/sip2/accounts/add 3) Go back to institutions: http://localhost:8081/cgi-bin/koha/sip2/institutions 4) Click 'delete'. Confirm the delete confirmation message contains: 'It has 1 associated accounts...' 5) Confirm that, notice the institution (and linked account) were deleted as expected and alerted 6) Repeat the test plan for the 'view' page instead of 'list' page: http://localhost:8081/cgi-bin/koha/sip2/institutions/<id_here> 7) Repeat the test plan but using an institution without any linked accounts. Confirm the 'regular' delete message is shown, which contains only the institution name in the modal body. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds release notes| |information about linked | |SIP accounts to the message | |when deleting an | |institution (Administration | |> Patrons and circulation > | |Self-service circulation | |(SIP2)). | | | |Previously, there was no | |information about linked | |accounts, and the linked | |accounts were automatically | |deleted. --- Comment #14 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. After applying the patch, yarn install and restart_all -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194349|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194350|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194351|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194352|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 --- Comment #15 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198877&action=edit Bug 41178: Fix accounts.getAll API client to be used for searching Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 --- Comment #16 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198878&action=edit Bug 41178: (VueJS framework): Add beforeDoResourceDelete method Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 --- Comment #17 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198879&action=edit Bug 41178: (VueJS framework): Add i18n.deleteConfirmationBody Otherwise, we're unable to override the contents of the delete dialog This and the previous patch allow fetching related accounts on the fly when attempting to delete an institutions. This allows to provide a message stating how many (or which) accounts will be deleted if the selected institution is deleted. The way its implemented applies for both deleting the resource from the list or from the 'show' page. If the institution does not have any associated accounts, the delete dialog's behavior is the same as it was before. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 --- Comment #18 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198880&action=edit Bug 41178: Add cypress test Run: cypress run --spec t/cypress/integration/SIP2/Institutions.ts Test plan: 1) Create a SIP institution, visit: http://localhost:8081/cgi-bin/koha/sip2/institutions/add 2) Create a SIP account linked to the institution from 1): http://localhost:8081/cgi-bin/koha/sip2/accounts/add 3) Go back to institutions: http://localhost:8081/cgi-bin/koha/sip2/institutions 4) Click 'delete'. Confirm the delete confirmation message contains: 'It has 1 associated accounts...' 5) Confirm that, notice the institution (and linked account) were deleted as expected and alerted 6) Repeat the test plan for the 'view' page instead of 'list' page: http://localhost:8081/cgi-bin/koha/sip2/institutions/<id_here> 7) Repeat the test plan but using an institution without any linked accounts. Confirm the 'regular' delete message is shown, which contains only the institution name in the modal body. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41178 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #19 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Upon looking at the code, something appears off here. after_delete_callback is never declared i.e. it'll always be undef. I think this was meant to be a variable renaming but was abandoned. Failing QA to come back here with the proper fix and testing. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org