[Bug 16338] New: Remove the use of "onclick" from the lists template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16338 Bug ID: 16338 Summary: Remove the use of "onclick" from the lists template Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/virtualshelves/shelves.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Lists Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, m.de.rooy@rijksmuseum.nl, testopia@bugs.koha-community.org, veron@veron.ch This is one instance of "onclick" in the lists template. It should be removed in favor of defining the event in the script. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16338 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16338 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50641&action=edit Bug 16338 - Remove the use of "onclick" from the lists template This patch removes the use of "onclick" from the list delete button, moving the event definition into the script. Also changed: Removed some unnecessary link markup; Added some whitespace around the action buttons. To test, apply the patch and go to Lists. Click the "Delete" button next to any list. You should be prompted to confirm the deletion. Verify that both confirming and canceling the deletion works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16338 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16338 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50641|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 50687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50687&action=edit [SIGNED-OFF] Bug 16338 - Remove the use of "onclick" from the lists template This patch removes the use of "onclick" from the list delete button, moving the event definition into the script. Also changed: Removed some unnecessary link markup; Added some whitespace around the action buttons. To test, apply the patch and go to Lists. Click the "Delete" button next to any list. You should be prompted to confirm the deletion. Verify that both confirming and canceling the deletion works correctly. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16338 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16338 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50687|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50788&action=edit [PASSED QA] Bug 16338 - Remove the use of "onclick" from the lists template This patch removes the use of "onclick" from the list delete button, moving the event definition into the script. Also changed: Removed some unnecessary link markup; Added some whitespace around the action buttons. To test, apply the patch and go to Lists. Click the "Delete" button next to any list. You should be prompted to confirm the deletion. Verify that both confirming and canceling the deletion works correctly. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16338 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for the 16.05 release. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org