[Bug 32074] New: Edit vendor has a floating toolbar, but still an additional save button at the bottom
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32074 Bug ID: 32074 Summary: Edit vendor has a floating toolbar, but still an additional save button at the bottom Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org That's a small inconsistency with other forms having the floating toolbar. On the edit vendor form, there is also another save button at the bottom. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32074 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 144395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144395&action=edit Bug 32074: Edit vendor has two save buttons When editing a vendor there is a floating toolbar with options to save and cancel. There is also an additional save and cancel button set at the bottom of the page and this is superfluous. This has now been removed to leave the floating toolbar as the only toolbar. Test plan: 1) Navigate to Acquisitions and select a Vendor. 2) Click edit vendor 3) Scroll down the page and observe that there is a floating save/cancel toolbar as well as the buttons to save/cancel at the bottom of the page 4) Apply patch 5) Observe that the duplicate buttons at the bottom of the page are now gone -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32074 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32074 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32074 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144395|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 144396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144396&action=edit Bug 32074: Edit vendor has two save buttons When editing a vendor there is a floating toolbar with options to save and cancel. There is also an additional save and cancel button set at the bottom of the page and this is superfluous. This has now been removed to leave the floating toolbar as the only toolbar. Test plan: 1) Navigate to Acquisitions and select a Vendor. 2) Click edit vendor 3) Scroll down the page and observe that there is a floating save/cancel toolbar as well as the buttons to save/cancel at the bottom of the page 4) Apply patch 5) Observe that the duplicate buttons at the bottom of the page are now gone Signed-off-by: Owen <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32074 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |matt.blenkinsop@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32074 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Straightforward template fix, QA script is happy. Thanks Matt! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32074 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32074 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144396|0 |1 is obsolete| | --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 144454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144454&action=edit Bug 32074: Edit vendor has two save buttons When editing a vendor there is a floating toolbar with options to save and cancel. There is also an additional save and cancel button set at the bottom of the page and this is superfluous. This has now been removed to leave the floating toolbar as the only toolbar. Test plan: 1) Navigate to Acquisitions and select a Vendor. 2) Click edit vendor 3) Scroll down the page and observe that there is a floating save/cancel toolbar as well as the buttons to save/cancel at the bottom of the page 4) Apply patch 5) Observe that the duplicate buttons at the bottom of the page are now gone Signed-off-by: Owen <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32074 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32074 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32074 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.00 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32074 --- Comment #6 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32074 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.00 |23.05.00,22.11.01 released in| | CC| |jacob.omara@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32074 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org