[Bug 39593] New: Show branch hours in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39593 Bug ID: 39593 Summary: Show branch hours in OPAC Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org It would be great if there were a way to display the library hours defined in libraries on the OPAC library listing. Preferably in the desired format (24hr or 12hr). I am not finding any information about whether this is possible yet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39593 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39593 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show branch hours in OPAC |Show library hours in OPAC --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Bug 39593: Show branch hours in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39593 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39593 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 180765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180765&action=edit Bug 39593: Show library hours in OPAC This patch adds library hours to the information display on the OPAC's libraries page. To test, apply the patch and add hours to one or more libraries if necessary (Administration -> Libraries). - In the OPAC, go to the Libraries page. - The libraries you added hours for should show a table of days with opening and closing times. - If both opening and closing times on a day are empty the table shows "Closed". - Libraries without hours should not show the table of hours. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39593 --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- This works, but are you able to address the option of time format mentioned in the bug? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39593 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39593 Alexander Wagner <alexander.wagner@desy.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexander.wagner@desy.de --- Comment #4 from Alexander Wagner <alexander.wagner@desy.de> --- Works on my end and I'd almost be ready to sign it off. Opening hours are defined with the library. They display just fine. (Except for the format issue outlined by Christopher. We could live with that.) Closing days, holidays etc however, defined via Tools / Calendar are not (yet?) taken into account. I think those would be quite relevant for the user. Shouldn't they end up here as well? Say, the regular opening hours for Friday is 09:00 .. 14:00, and they show on the libraries page. But just this week Friday, April 18th the library is closed due to a public holiday in my region. PS: It is a bit strange from the Koha admin UI, that those two, IMHO closely related things live so far apart. But that's a different story. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39593 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu --- Comment #5 from Michaela Sieber <michaela.sieber@kit.edu> --- (In reply to Alexander Wagner from comment #4)
Works on my end and I'd almost be ready to sign it off.
Opening hours are defined with the library. They display just fine. (Except for the format issue outlined by Christopher. We could live with that.)
Closing days, holidays etc however, defined via Tools / Calendar are not (yet?) taken into account.
I think those would be quite relevant for the user. Shouldn't they end up here as well?
Say, the regular opening hours for Friday is 09:00 .. 14:00, and they show on the libraries page. But just this week Friday, April 18th the library is closed due to a public holiday in my region.
PS: It is a bit strange from the Koha admin UI, that those two, IMHO closely related things live so far apart. But that's a different story.
Hi Alexander, the calender in the tools is relevant for calculating due dates, overdue notices and fines. Although our library is open 24/7 on 365 days per year we have holidays in our calender because we don't want to have due dates on weekends or to send out overdue letters on christmas ;-) But thats why we would not display them in the opac, they have nothing to do with our opening hours. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39593 --- Comment #6 from Alexander Wagner <alexander.wagner@desy.de> ---
the calender in the tools is relevant for calculating due dates, overdue notices and fines.
Sure. I understood that as well. (Still I wonder why the two are so far away from each other.) I was mainly wondering if for the implementation done here it was a conscious decision to hook up with the per library opening hours only, or if the holiday calendar was just missed out. If holidays should be neglected in this display I'd work myself through the sign-off ASAP. :)
our library is open 24/7 on 365 days per year
Same here as well. However, you will not find any library staff on the major holidays. It might be quite helpful for the patron to hint on this fact. One may also argue that "we are open 24/7" does not require any opening hours and their display in the first place ;) BTW: I intend give our opening hours as the staffed hours. Not as "in principle the building is not locked" hours. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39593 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Christopher Brannon from comment #3)
This works, but are you able to address the option of time format mentioned in the bug?
In my testing the time format was correct according to the system preference. Can you describe what you're seeing? (In reply to Alexander Wagner from comment #4)
Closing days, holidays etc however, defined via Tools / Calendar are not (yet?) taken into account.
The patch re-uses code which is used in the staff interface for displaying library hours in library administration. That view doesn't take holidays into account. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39593 --- Comment #8 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Owen Leonard from comment #7)
(In reply to Christopher Brannon from comment #3)
This works, but are you able to address the option of time format mentioned in the bug?
In my testing the time format was correct according to the system preference. Can you describe what you're seeing?
Well, how about that. I didn't even know there was a setting for that. Is it supposed to show 12 hour time with a leading zero?
(In reply to Alexander Wagner from comment #4)
Closing days, holidays etc however, defined via Tools / Calendar are not (yet?) taken into account.
The patch re-uses code which is used in the staff interface for displaying library hours in library administration. That view doesn't take holidays into account.
I do think at some time the calendars need to be folded into the branches, and holidays need to be considered for showing on page, even if in a separate holiday table. But that is for another bug. I also think that there needs to be some marriage between the hours and the calendar. It is weird to define the hours one place, then having to define closed days somewhere else. It is redundant. We should be able to define regular hours, and then define holiday exceptions. Its all a bit muddy and needs cleaning up. But again, that is for another bug. I will sign off on this. Thanks for your help on this! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39593 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180765|0 |1 is obsolete| | --- Comment #9 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 180974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180974&action=edit Bug 39593: Show library hours in OPAC This patch adds library hours to the information display on the OPAC's libraries page. To test, apply the patch and add hours to one or more libraries if necessary (Administration -> Libraries). - In the OPAC, go to the Libraries page. - The libraries you added hours for should show a table of days with opening and closing times. - If both opening and closing times on a day are empty the table shows "Closed". - Libraries without hours should not show the table of hours. Sponsored-by: Athens County Public Libraries Signed-off-by: Christopher <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39593 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Christopher Brannon <cbrannon@cdalibrary.org> --- Works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39593 Alexander Wagner <alexander.wagner@desy.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180974|0 |1 is obsolete| | --- Comment #11 from Alexander Wagner <alexander.wagner@desy.de> --- Created attachment 180976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180976&action=edit Bug 39593: Show library hours in OPAC This patch adds library hours to the information display on the OPAC's libraries page. To test, apply the patch and add hours to one or more libraries if necessary (Administration -> Libraries). - In the OPAC, go to the Libraries page. - The libraries you added hours for should show a table of days with opening and closing times. - If both opening and closing times on a day are empty the table shows "Closed". - Libraries without hours should not show the table of hours. Sponsored-by: Athens County Public Libraries Signed-off-by: Christopher <cbrannon@cdalibrary.org> Signed-off-by: Alexander Wagner <alexander.wagner@desy.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39593 --- Comment #12 from Alexander Wagner <alexander.wagner@desy.de> --- Note: the diff shows some "magics" that might pose a miss-handling in non-english OPAC displays. IOW I am unsure if the literal `Sunday` gets translated, or a literal `Opening time`. (I don't know enough of the tt-handling yet, especially wrt NLS.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39593 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Alexander, I have checked the patch - everything in there is translatable. Our tools parse the HTML for strings. Constructs like <span>Sunday</span> etc. will be picked up by the tools. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39593 --- Comment #14 from Alexander Wagner <alexander.wagner@desy.de> --- (In reply to Katrin Fischer from comment #13)
Our tools parse the HTML for strings. Constructs like <span>Sunday</span> etc. will be picked up by the tools.
Good to know :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39593 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39593 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180976|0 |1 is obsolete| | --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 181142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=181142&action=edit Bug 39593: Show library hours in OPAC This patch adds library hours to the information display on the OPAC's libraries page. To test, apply the patch and add hours to one or more libraries if necessary (Administration -> Libraries). - In the OPAC, go to the Libraries page. - The libraries you added hours for should show a table of days with opening and closing times. - If both opening and closing times on a day are empty the table shows "Closed". - Libraries without hours should not show the table of hours. Sponsored-by: Athens County Public Libraries Signed-off-by: Christopher <cbrannon@cdalibrary.org> Signed-off-by: Alexander Wagner <alexander.wagner@desy.de> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39593 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39593 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA Keywords| |rel_25_05_candidate --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I really like the idea of this, but I think we should have a switch for libraries to turn off the opening hours tables if they want. Reasons: A lot of libraries have more complex opening hours than we can currently reflect in the library settings. They might have closed during a period in the middle of the day or they might have set up the hours in a certain way to accomodate overnight loans, but it doesn't reflect the time the library is actually open... they might want to distinguish between self service and library staff present opening times... We had some push back when the Libraries page appeared in the OPAC and there is now a switch to turn it off even. I believe we'd be safer to make this not a surprise appearance for libraries updating. I believe the nicest way to achieve this might be a little checkbox on the libraries table, but I'd accept a global pref too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39593 --- Comment #17 from Christopher Brannon <cbrannon@cdalibrary.org> --- +1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39593 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_25_05_candidate | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, we have run out of time for this in 25.05. Removing keyword. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39593 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|lucas@bywatersolutions.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39593 Michael Adamyk <michael.adamyk@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.adamyk@bywatersolut | |ions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org