[Bug 27619] New: Remove de-DE installer data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Bug ID: 27619 Summary: Remove de-DE installer data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: bgkriegel@gmail.com, gmcharlt@gmail.com, jonathan.druart@bugs.koha-community.org, katrin.fischer@bsz-bw.de, lucas@bywatersolutions.com, martin.renvoize@ptfs-europe.com, testopia@bugs.koha-community.org, victor@tuxayo.net Depends on: 24972, 24973, 24871 +++ This bug was initially created as a clone of Bug #24897 +++ Now we can translate all installer data, then the fr-FR directory is no longer needed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24871 [Bug 24871] Add new *-installer-*.po translation files https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24972 [Bug 24972] Remove de-DE installer data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24973 [Bug 24973] Allow to localize and translate system preferences with new yaml based installer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27620 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27620 [Bug 27620] Remove fr-CA installer data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27621 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27621 [Bug 27621] Remove it-IT installer data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove de-DE installer data |Remove fr-FR installer data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24972 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24972 [Bug 24972] Remove de-DE installer data -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|27620 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27620 [Bug 27620] Remove fr-CA installer data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|27621 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27621 [Bug 27621] Remove it-IT installer data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27829 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27829 [Bug 27829] [OMNIBUS] Remove specific LANG installer data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 121625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121625&action=edit Bug 27619: FA for UNIMARC and custom for fr-FR -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29538 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30373 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373 [Bug 30373] Rewrite UNIMARC installer data to YAML -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This did not move recently. On bug 2222 I want to remove auth_subfield_structure.frameworkcode. That gives a lot of changes in especially the fr-FR SQL files. Would you support doing that first ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Marcel de Rooy from comment #2)
This did not move recently. On bug 2222 I want to remove auth_subfield_structure.frameworkcode. That gives a lot of changes in especially the fr-FR SQL files. Would you support doing that first ?
Hi Marcel, easy to miss, but there is actually some very recent movement here: This was waiting for the new UNIMARC frameworks (dependency bug 30373). The patches were provided just in time before the hackfest and tests have begun. Once this is solved, it should be relatively easy to resolve this bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #2)
This did not move recently. On bug 2222 I want to remove auth_subfield_structure.frameworkcode. That gives a lot of changes in especially the fr-FR SQL files. Would you support doing that first ?
I cant remove that field. Scratch this remark. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Keywords| |rel_22_05_candidate -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Severity|minor |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121625|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134213&action=edit Bug 27619: Add custom for fr-FR -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|ASSIGNED |Needs Signoff --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Patches pushed to https://gitlab.com/joubu/Koha/-/commits/bug_27619 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Jonathan Druart from comment #5)
Created attachment 134213 [details] [review] Bug 27619: Add custom for fr-FR
Hi Jonathan, may be a "DELETE FROM `z3950servers`;" is needed before inserting the BNF server, just in case the sample z3950 servers were selected at install time; or just an "INSERT IGNORE", the BNF server is now present in that archive. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134213|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Bernardo Gonzalez Kriegel from comment #7)
(In reply to Jonathan Druart from comment #5)
Created attachment 134213 [details] [review] [review] Bug 27619: Add custom for fr-FR
Hi Jonathan, may be a "DELETE FROM `z3950servers`;" is needed before inserting the BNF server, just in case the sample z3950 servers were selected at install time; or just an "INSERT IGNORE", the BNF server is now present in that archive.
Indeed, thanks! I adjusted the remote branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Bug 27619 depends on bug 30373, which changed state. Bug 30373 Summary: Rewrite UNIMARC installer data to YAML https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30373 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com --- Comment #9 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Hello, I've just test that one, I can say it works up to some point. After installing translation files and refresh (Clear database) the framework is indeed translated to French. However, it stays in french whatever language I choose for the staff interface. Is this the expected behaviour? (fine for me). If it is then I'm happy to signoff :) Arthur -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 --- Comment #10 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Can be tested here : https://staff-bz27619.sandboxes.biblibre.eu/cgi-bin/koha/mainpage.pl credentials : koha / XW73vWQpBTN2jVh -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Arthur Suzuki from comment #9)
Hello, I've just test that one, I can say it works up to some point. After installing translation files and refresh (Clear database) the framework is indeed translated to French. However, it stays in french whatever language I choose for the staff interface. Is this the expected behaviour? (fine for me). If it is then I'm happy to signoff :) Arthur
Yes, it's totally expected. The installer files are picked according to the language you choose, so if you run the installer in French, the database will be filled with French data. :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 --- Comment #12 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 134553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134553&action=edit Bug 27619: Add custom for fr-FR Signed-off-by: liliputech <arthur.suzuki@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134553|0 |1 is obsolete| | --- Comment #13 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 134554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134554&action=edit Bug 27619: Add custom for fr-FR Signed-off-by: liliputech <arthur.suzuki@biblibre.com> Signed-off-by: liliputech <arthur.suzuki@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #14 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- This one has been tested OK! Changing status to SO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Added Arthur's signed-off-by lines to the remote branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134554|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.com/joubu/Ko | |ha/-/commits/bug_27619 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This all works as expected to me, but I'm not the target audience in terms of the actual translation workflows.. I'm more the target in terms of streamlining work for devs ;P Feel free to add my SO line on top of Arthurs.. and lets be brave and go for it on this one. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Jonathan and I were keen to see this in and watch the test suit/start responding to any issues that present... So, whilst I grabbed the branch to add my QA stamp and went bold and pushed this as an RM Assistant. Thanks to everyone involved, Pushed to Master for 22.05.00! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 134861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134861&action=edit Bug 27619: (QA follow-up) Remove xt/sample_notices.t Now that we've remove the last of the translated .sql files, we can just drop this test entirely.. translation is now handled on pootle for all languages. Woopie! :) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 30413 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27619 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |tomascohen@gmail.com Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org