[Bug 17249] New: Koha:: AuthorisedValues - Remove GetKohaAuthorisedValuesFromField
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 Bug ID: 17249 Summary: Koha::AuthorisedValues - Remove GetKohaAuthorisedValuesFromField Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15799 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15799 [Bug 15799] Move authorised values related code into Koha::AuthorisedValues - part 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17216, 17248 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 [Bug 17216] Add a new table to store authorized value categories https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17248 [Bug 17248] Koha::AuthorisedValues - Remove GetKohaAuthorisedValueLib -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55176&action=edit Bug 17249: Remove GetKohaAuthorisedValuesFromField - Add classes MarcSubfieldStructure[s] This patch adds the 2 Koha::Object based classes for the marc_subfield_structure table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55177&action=edit Bug 17249: Remove GetKohaAuthorisedValuesFromField - add tests This patch adds a few tests to C4::Record::marcrecord2csv The subroutine was not covered enough to validate that this patch set won't add regressions. Note that the patch set will fix an issue: If 2 subfields of a field are linked to AVs and you want to display them in a CSV, they won't be replaced with their descriptions. Test plan: Apply the patch, and make a copy of t/db_dependent/Record/marcrecord2csv.t Checkout master and prove marcrecord2csv.t Tests should fail Checkout the branch with the whole patch set applied The tests should pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55178&action=edit Bug 17249: Remove GetKohaAuthorisedValuesFromField - Add search_by_marc_field This patch adds a new Koha::AuthorisedValues->search_by_marc_field method. It will permit to replace several subroutine from C4::Koha dealing with authorised values. It also uses this new methods to replace an occurrence of GetKohaAuthorisedValuesFromField in C4::Record::marcrecord2csv Test plan: prove t/db_dependent/AuthorisedValues.t should return green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55179&action=edit Bug 17249: Remove GetKohaAuthorisedValuesFromField - inventory This patch deals with the inventory files calling GetKohaAuthorisedValuesFromField. Test plan: prove t/db_dependent/Items/GetItemsForInventory.t should still return green Use the inventory tool, on the result page the AV descriptions should correctly replace the codes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55180&action=edit Bug 17249: Remove GetKohaAuthorisedValuesFromField - (follow-up) inventory Before this patch set, the tests in t/db_dependent/Items/GetItemsForInventory.t were executed in 4s. But with the previous patch, it was in 45sec(!) To make sure decrease this execution time to what it was before, this patch introduces a local to avoid the same query to be executed several times. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55181&action=edit Bug 17249: Remove GetKohaAuthorisedValuesFromField Remove the subroutine, it's no longer in used. Test plan: git grep GetKohaAuthorisedValuesFromField should not return any occurrences. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 55182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55182&action=edit Bug 17249: GetKohaAuthorisedValuesFromField - rm GetAuthValCodeFromField The subroutine GetAuthValCodeFromField was only used from GetKohaAuthorisedValuesFromField. Test plan: git grep GetAuthValCodeFromField should not return any occurrences. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17250 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17250 [Bug 17250] Koha::AuthorisedValues - Remove GetAuthValCode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17094 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17094 [Bug 17094] Methods of Koha::Object[s]-based classed should not return DBIx::Class objects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #5)
Created attachment 55180 [details] [review] To make sure decrease this execution time to what it was before, this patch introduces a local to avoid the same query to be executed several times.
That does not mean anything... Read: To decrease this execution time to what it was before, this patch introduces a local cache not to execute the same query several times. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17216 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216 [Bug 17216] Add a new table to store authorized value categories -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely@hotmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Claire Gravely <claire_gravely@hotmail.com> --- patch does not apply CONFLICT (content): Merge conflict in t/db_dependent/AuthorisedValues.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55176|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 55428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55428&action=edit [SIGNED-OFF] Bug 17249: Remove GetKohaAuthorisedValuesFromField - Add classes MarcSubfieldStructure[s] This patch adds the 2 Koha::Object based classes for the marc_subfield_structure table Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55177|0 |1 is obsolete| | --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 55429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55429&action=edit [SIGNED-OFF] Bug 17249: Remove GetKohaAuthorisedValuesFromField - add tests This patch adds a few tests to C4::Record::marcrecord2csv The subroutine was not covered enough to validate that this patch set won't add regressions. Note that the patch set will fix an issue: If 2 subfields of a field are linked to AVs and you want to display them in a CSV, they won't be replaced with their descriptions. Test plan: Apply the patch, and make a copy of t/db_dependent/Record/marcrecord2csv.t Checkout master and prove marcrecord2csv.t Tests should fail Checkout the branch with the whole patch set applied The tests should pass Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55178|0 |1 is obsolete| | --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 55430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55430&action=edit [SIGNED-OFF] Bug 17249: Remove GetKohaAuthorisedValuesFromField - Add search_by_marc_field This patch adds a new Koha::AuthorisedValues->search_by_marc_field method. It will permit to replace several subroutine from C4::Koha dealing with authorised values. It also uses this new methods to replace an occurrence of GetKohaAuthorisedValuesFromField in C4::Record::marcrecord2csv Test plan: prove t/db_dependent/AuthorisedValues.t should return green Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55179|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 55431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55431&action=edit [SIGNED-OFF] Bug 17249: Remove GetKohaAuthorisedValuesFromField - inventory This patch deals with the inventory files calling GetKohaAuthorisedValuesFromField. Test plan: prove t/db_dependent/Items/GetItemsForInventory.t should still return green Use the inventory tool, on the result page the AV descriptions should correctly replace the codes Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55180|0 |1 is obsolete| | --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 55432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55432&action=edit [SIGNED-OFF] Bug 17249: Remove GetKohaAuthorisedValuesFromField - (follow-up) inventory Before this patch set, the tests in t/db_dependent/Items/GetItemsForInventory.t were executed in 4s. But with the previous patch, it was in 45sec(!) To make sure decrease this execution time to what it was before, this patch introduces a local to avoid the same query to be executed several times. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55181|0 |1 is obsolete| | --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 55433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55433&action=edit [SIGNED-OFF] Bug 17249: Remove GetKohaAuthorisedValuesFromField Remove the subroutine, it's no longer in used. Test plan: git grep GetKohaAuthorisedValuesFromField should not return any occurrences. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55182|0 |1 is obsolete| | --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 55434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55434&action=edit [SIGNED-OFF] Bug 17249: GetKohaAuthorisedValuesFromField - rm GetAuthValCodeFromField The subroutine GetAuthValCodeFromField was only used from GetKohaAuthorisedValuesFromField. Test plan: git grep GetAuthValCodeFromField should not return any occurrences. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Everything tested correctly according to the test plans. The only issue I had was that GetItemsForInventory.t was still very slow. I don't know if that was a problem with the patch or a problem with my slow VM. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55428|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 56380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56380&action=edit [PASSED QA] Bug 17249: Remove GetKohaAuthorisedValuesFromField - Add classes MarcSubfieldStructure[s] This patch adds the 2 Koha::Object based classes for the marc_subfield_structure table Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 56381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56381&action=edit [PASSED QA] Bug 17249: Remove GetKohaAuthorisedValuesFromField - add tests This patch adds a few tests to C4::Record::marcrecord2csv The subroutine was not covered enough to validate that this patch set won't add regressions. Note that the patch set will fix an issue: If 2 subfields of a field are linked to AVs and you want to display them in a CSV, they won't be replaced with their descriptions. Test plan: Apply the patch, and make a copy of t/db_dependent/Record/marcrecord2csv.t Checkout master and prove marcrecord2csv.t Tests should fail Checkout the branch with the whole patch set applied The tests should pass Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 56382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56382&action=edit [PASSED QA] Bug 17249: Remove GetKohaAuthorisedValuesFromField - Add search_by_marc_field This patch adds a new Koha::AuthorisedValues->search_by_marc_field method. It will permit to replace several subroutine from C4::Koha dealing with authorised values. It also uses this new methods to replace an occurrence of GetKohaAuthorisedValuesFromField in C4::Record::marcrecord2csv Test plan: prove t/db_dependent/AuthorisedValues.t should return green Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 56383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56383&action=edit [PASSED QA] Bug 17249: Remove GetKohaAuthorisedValuesFromField - inventory This patch deals with the inventory files calling GetKohaAuthorisedValuesFromField. Test plan: prove t/db_dependent/Items/GetItemsForInventory.t should still return green Use the inventory tool, on the result page the AV descriptions should correctly replace the codes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 56384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56384&action=edit [PASSED QA] Bug 17249: Remove GetKohaAuthorisedValuesFromField - (follow-up) inventory Before this patch set, the tests in t/db_dependent/Items/GetItemsForInventory.t were executed in 4s. But with the previous patch, it was in 45sec(!) To make sure decrease this execution time to what it was before, this patch introduces a local to avoid the same query to be executed several times. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 56385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56385&action=edit [PASSED QA] Bug 17249: Remove GetKohaAuthorisedValuesFromField Remove the subroutine, it's no longer in used. Test plan: git grep GetKohaAuthorisedValuesFromField should not return any occurrences. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 56386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56386&action=edit [PASSED QA] Bug 17249: GetKohaAuthorisedValuesFromField - rm GetAuthValCodeFromField The subroutine GetAuthValCodeFromField was only used from GetKohaAuthorisedValuesFromField. Test plan: git grep GetAuthValCodeFromField should not return any occurrences. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55434|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55433|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55432|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55431|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55430|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55429|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good clear refactoring, much clearer code. Thanks Jonathan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18748 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17249 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19023 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19023 [Bug 19023] inventory tool performance -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org