[Bug 22579] New: Add syspref to toggle expanding Actions dropdown menu in Z39.50 search to decrease clicks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Bug ID: 22579 Summary: Add syspref to toggle expanding Actions dropdown menu in Z39.50 search to decrease clicks Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: hayleymapley@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Target Milestone: --- An enhancement included in master from Bug 15952 moved the Actions in the Cataloging Z39.50 search results into a dropdown. We have a library who uses the Card preview and MARC preview from this search to quickly ascertain whether a record is the one they were looking for, and would like to decrease the number of clicks it takes to execute this option from 2 to 1. We propose to allow the user to switch these options from a dropdown to expanded links within the action column, toggleable via a system preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |hayleymapley@catalyst.net.n |ity.org |z Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 --- Comment #1 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 86997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86997&action=edit Bug 22579: Add syspref to toggle dropdown/links in Z39.50 search results This patch reduces the number of clicks to use 'Card preview' functionality without removing the work done to condense the three links into a menu in Bug 19939 which is displayed by default (and when the syspref is disabled). Test plan: 1) Apply the patch 2) In Cataloging click the New from Z39.50/SRU button and search for a term that will produce results 3) In the results window, note that the actions column contains a dropdown for each row which contains three links. 4) Change the Replacez3950CatalogingActionMenuWithLinks to 'Do' 5) Complete step 2 again, and instead note that the actions column now contains three links, Card preview, MARC preview, Import 6) Verify that each of the links work as expected 7) Sign off! Sponsored-by: Horowhenua Library Trust -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz | |, | |hayleymapley@catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Do they know they can click anywhere in the row to trigger the menu? A system preference seems like overkill to me, but that's certainly an opinion informed by a different workflow. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 --- Comment #3 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- (In reply to Owen Leonard from comment #2)
Do they know they can click anywhere in the row to trigger the menu? A system preference seems like overkill to me, but that's certainly an opinion informed by a different workflow.
I think the problem is less with the placement of the menu, rather the fact that they now have to trigger it before they can access their most commonly used option when they didn't have to before. We didn't want to revert the change that was made, so we decided that a system preference would be the easiest way to include this fix, and make life easier for the library. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Could we use a split button with import being the default? (like receive in the subscription search list) I also share the feeling that a pref might be a little overkill here when it seems more like a usability issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 --- Comment #5 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #4)
Could we use a split button with import being the default? (like receive in the subscription search list)
I also share the feeling that a pref might be a little overkill here when it seems more like a usability issue.
A split button could work, but the library are wanting Card Preview to be the easiest to access. Would it be acceptable to have Card Preview as the main option, and MARC preview and import be in the dropdown part? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com --- Comment #6 from Michal Denar <black23@gmail.com> --- Hi, this patch on latest master make z39.50 broken. Explain video is here: http://recordit.co/zgDQVntvhg -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 --- Comment #7 from Michal Denar <black23@gmail.com> --- Sorry folks, my fault. Nothing broken. It's between chair nad keyboard :-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 --- Comment #8 from Michal Denar <black23@gmail.com> --- Patch works. Can I set it as SO? Or some more folow-ups coming? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #9 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- (In reply to Michal Denar from comment #8)
Patch works. Can I set it as SO? Or some more folow-ups coming?
Hi Michal, I think I need to change some things to align with the comments I've received first. Thanks for taking a look! Setting to assigned -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #10 from Liz Rea <wizzyrea@gmail.com> --- I have a couple of suggestions for how we could fix this. Split button, with import being the main action AND make the title clickable, to the card or marc preview in a modal like it does now - whichever your client prefers since presumably they are the ones paying for the dev. In this case, I don't think we'd need a syspref. If someone in the future wants to change what the title links to there, they can add the syspref. :) Ping me if you have questions. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86997|0 |1 is obsolete| | --- Comment #11 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 101783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101783&action=edit Bug 22579: Split actions in z3950 search results into a split button Where 'Import' is the main button and the two card previews are in the dropdown Also show Card preview when clicking on title of record To test: 1) Go to Cataloguing -> New from Z39.50/SRU 2) Search for a term that will produce results 3) Once results are shown, notice the split button 4) Click anywhere on results rows. Confirm the dropdown menu still shows when you click anywhere, as normal 5) Confirm clicking the title pops up the Card preview 6) Confirm Import is the main button in the actions and still works as expected Sponsored-by: Horowhenua Library Trust -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add syspref to toggle |Split actions in z3950 |expanding Actions dropdown |search results so Import is |menu in Z39.50 search to |the main action and make |decrease clicks |clicking title pop up Card | |Preview Change sponsored?|--- |Sponsored CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 --- Comment #12 from Aleisha Amohia <aleisha@catalyst.net.nz> --- This is almost ready, but I am struggling to get rid of the whitespace showing between the two buttons in the button group. If anyone knows what I'm doing wrong here please let me know! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Aleisha Amohia from comment #12)
This is almost ready, but I am struggling to get rid of the whitespace showing between the two buttons in the button group. If anyone knows what I'm doing wrong here please let me know!
Sneakily adding Owen for advice....please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101783|0 |1 is obsolete| | --- Comment #14 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 104998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104998&action=edit Bug 22579: Split actions in z3950 search results into a split button Where 'Import' is the main button and the two card previews are in the dropdown Also show Card preview when clicking on title of record To test: 1) Go to Cataloguing -> New from Z39.50/SRU 2) Search for a term that will produce results 3) Once results are shown, notice the split button 4) Click anywhere on results rows. Confirm the dropdown menu still shows when you click anywhere, as normal 5) Confirm clicking the title pops up the Card preview 6) Confirm Import is the main button in the actions and still works as expected Sponsored-by: Horowhenua Library Trust -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 --- Comment #15 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Rebased, but still super stuck on that whitespace! Owen, any ideas? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 --- Comment #16 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Aleisha Amohia from comment #15)
still super stuck on that whitespace!
I have no idea why the whitespace is an issue here when it doesn't seem to be a problem elsewhere. But removing the whitespace fixes it so let's do that! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 --- Comment #17 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Owen Leonard from comment #16)
(In reply to Aleisha Amohia from comment #15)
still super stuck on that whitespace!
I have no idea why the whitespace is an issue here when it doesn't seem to be a problem elsewhere. But removing the whitespace fixes it so let's do that!
That's precisely the problem :) I can't seem the remove the whitespace. It's not in the HTML or the JS so I don't know what's adding it between the Import button and the dropdown button. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 105054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105054&action=edit Bug 22579: (follow-up) Remove problematic whitespace This patch removes some whitespace from the template which was causing display problems with the "Import" split button. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- Aleisha, does this patch work for you? It looks good to me in Firefox and Chromium on OSX -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104998|0 |1 is obsolete| | --- Comment #20 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 105055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105055&action=edit Bug 22579: Split actions in z3950 search results into a split button Where 'Import' is the main button and the two card previews are in the dropdown Also show Card preview when clicking on title of record To test: 1) Go to Cataloguing -> New from Z39.50/SRU 2) Search for a term that will produce results 3) Once results are shown, notice the split button 4) Click anywhere on results rows. Confirm the dropdown menu still shows when you click anywhere, as normal 5) Confirm clicking the title pops up the Card preview 6) Confirm Import is the main button in the actions and still works as expected Sponsored-by: Horowhenua Library Trust -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105054|0 |1 is obsolete| | --- Comment #21 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 105056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105056&action=edit Bug 22579: (follow-up) Remove problematic whitespace This patch removes some whitespace from the template which was causing display problems with the "Import" split button. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 --- Comment #22 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Owen Leonard from comment #19)
Aleisha, does this patch work for you? It looks good to me in Firefox and Chromium on OSX
Ahh of course, such an annoyingly simple fix! Thanks Owen. Have amended the first patch because there was some weird stuff happening with opening and closing the dropdown. This is now ready for testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105055|0 |1 is obsolete| | --- Comment #23 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 113206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113206&action=edit Bug 22579: Split actions in z3950 search results into a split button Where 'Import' is the main button and the two card previews are in the dropdown Also show Card preview when clicking on title of record To test: 1) Go to Cataloguing -> New from Z39.50/SRU 2) Search for a term that will produce results 3) Once results are shown, notice the split button 4) Click anywhere on results rows. Confirm the dropdown menu still shows when you click anywhere, as normal 5) Confirm clicking the title pops up the Card preview 6) Confirm Import is the main button in the actions and still works as expected Sponsored-by: Horowhenua Library Trust -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105056|0 |1 is obsolete| | --- Comment #24 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 113207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113207&action=edit Bug 22579: (follow-up) Remove problematic whitespace This patch removes some whitespace from the template which was causing display problems with the "Import" split button. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Did you see bug 23302 ? We are working on the same thing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 --- Comment #26 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Marcel de Rooy from comment #25)
Did you see bug 23302 ? We are working on the same thing.
Hi Marcel, this bug was reported and had a patch earlier than Bug 23302, so I think Bug 23302 is the duplicate and should be closed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #27 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Looks like my comment was ignored and Bug 23302 has been pushed through, so we can close this one :) *** This bug has been marked as a duplicate of bug 23302 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org