[Bug 39319] New: xt/author/podcorrectness.t only test POD for perl files within C4 and Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 Bug ID: 39319 Summary: xt/author/podcorrectness.t only test POD for perl files within C4 and Koha Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org It should also test controllers and tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179237&action=edit Bug 39319: Make podcorrectness.t test controller and test perl files It only tested files within C4 and Koha directories. Now we test all the perl files that are in the git index. Test plan: 0. Do not apply those patches 1. prove xt/author/podcorrectness.t Notice "Tests=1208" meaning that 1208 files are tested 2. Apply this patch (not the second one) It fails, and more files are being tested (3254) xt/author/podcorrectness.t .. 1994/3254 xt/author/podcorrectness.t .. 2726/3254 # Looks like you failed 1 test of 3254. 3. Apply the second patch => It passes! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179238&action=edit Bug 39319: Fix POD for misc/migration_tools/koha-svc.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39324 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39324 [Bug 39324] [OMNIBUS] All QA tests should pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179274&action=edit Bug 39319: Add test using Pod::Checker podchecker is used by the QA script and catch more than Test::Pod -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179275&action=edit Bug 39319: Fixes for Pod::Checker -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179237|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 179370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179370&action=edit Bug 39319: Make podcorrectness.t test controller and test perl files It only tested files within C4 and Koha directories. Now we test all the perl files that are in the git index. Test plan: 0. Do not apply those patches 1. prove xt/author/podcorrectness.t Notice "Tests=1208" meaning that 1208 files are tested 2. Apply this patch (not the second one) It fails, and more files are being tested (3254) xt/author/podcorrectness.t .. 1994/3254 xt/author/podcorrectness.t .. 2726/3254 # Looks like you failed 1 test of 3254. 3. Apply the second patch => It passes! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179238|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 179371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179371&action=edit Bug 39319: Fix POD for misc/migration_tools/koha-svc.pl Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179274|0 |1 is obsolete| | --- Comment #7 from David Nind <david@davidnind.com> --- Created attachment 179372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179372&action=edit Bug 39319: Add test using Pod::Checker podchecker is used by the QA script and catch more than Test::Pod Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179275|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 179373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179373&action=edit Bug 39319: Fixes for Pod::Checker Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 179450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179450&action=edit Bug 39319: Improve pod_checker.t It was not failing when warnings were found -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39367 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39367 [Bug 39367] Add POD to all subroutines/methods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39325 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39325 [Bug 39325] Run codespell successfully on the whole codebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179370|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179664&action=edit Bug 39319: Make podcorrectness.t test controller and test perl files It only tested files within C4 and Koha directories. Now we test all the perl files that are in the git index. Test plan: 0. Do not apply those patches 1. prove xt/author/podcorrectness.t Notice "Tests=1208" meaning that 1208 files are tested 2. Apply this patch (not the second one) It fails, and more files are being tested (3254) xt/author/podcorrectness.t .. 1994/3254 xt/author/podcorrectness.t .. 2726/3254 # Looks like you failed 1 test of 3254. 3. Apply the second patch => It passes! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179371|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179665&action=edit Bug 39319: Fix POD for misc/migration_tools/koha-svc.pl Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179372|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179666&action=edit Bug 39319: Add test using Pod::Checker podchecker is used by the QA script and catch more than Test::Pod Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179373|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179667&action=edit Bug 39319: Fixes for Pod::Checker Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179450|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179668&action=edit Bug 39319: Improve pod_checker.t It was not failing when warnings were found Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #17 from David Nind <david@davidnind.com> --- Test suite changes, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39319 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43503 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43503 [Bug 43503] xt/author/podcorrectness.t no longer needed -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org