http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7951 --- Comment #1 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9179&action=edit Bug 7951 - Suspending holds needs a system preference Adds system preferences SuspendHoldsIntranet and SuspendHoldsOpac. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7951 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, thx for implementing the system preferences. I tried testing your patch but have a conflict I can't resolve: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 7951 - Suspending holds needs a system preference /home/katrin/kohaclone/.git/rebase-apply/patch:207: trailing whitespace. $template->param( /home/katrin/kohaclone/.git/rebase-apply/patch:223: trailing whitespace. $template->param( fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 7951 - Suspending holds needs a system preference When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Could you please check what's going wrong and resubmit? Thx! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7951 kyle.m.hall@gmail.com <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7951 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9179|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9563&action=edit Bug 7951 - Suspending holds needs a system preference Adds system preferences SuspendHoldsIntranet and SuspendHoldsOpac. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7951 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9563|0 |1 is obsolete| | --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 9900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9900&action=edit Bug 7951 - Suspending holds needs a system preference Adds system preferences SuspendHoldsIntranet and SuspendHoldsOpac. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7951 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * small patch that improves a recently added feature * does that in the most logical way * nothing to say from coding guidelines POV passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7951 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- The suspend holds functionality is already in 3.8.x but no way to turn it on our off, this implements that. So I am counting more as a bug fix. Pushed to 3.8.x will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes.