[Bug 27405] New: Update intranet-tmpl/prog/en/modules/pos/register.tt for ACC2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27405 Bug ID: 27405 Summary: Update intranet-tmpl/prog/en/modules/pos/register.tt for ACC2 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com We need to replace number type inputs in intranet-tmpl/prog/en/modules/pos/register.tt as per ACC2 guidelines. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27405 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26926 Keywords| |Academy Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26926 [Bug 26926] Update all occurrences of <input type="number"> to apply ACC2 coding guideline -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27405 Catherine <catherinem2003@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |catherinem2003@gmail.com |ity.org | CC| |catherinem2003@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27405 Catherine <catherinem2003@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27405 --- Comment #1 from Catherine <catherinem2003@gmail.com> --- Created attachment 115378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115378&action=edit Bug 27405: update file for ACC2 Form has been edited in intranet-tmpl/prog/en/modules/pos/register.tt Test plan: Check that pages work as normal Sponsored by Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27405 Catherine <catherinem2003@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115378|0 |1 is obsolete| | --- Comment #2 from Catherine <catherinem2003@gmail.com> --- Created attachment 115463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115463&action=edit Bug 27405: update file for ACC2 Form has been edited in intranet-tmpl/prog/en/modules/pos/register.tt Test plan: Check that pages work as normal Sponsored by Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27405 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 117119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117119&action=edit Bug 27405: Update koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt for ACC2 This replaces the number type input in intranet-tmpl/prog/en/modules/pos/register.tt so that it is consistent with ACC2 guidelines. Test plan: 1. Enable the EnablePointOfSale (set to Enable) and UseCashRegisters (set to Use) system preferences. 2. Add a new cash register for a library (Home > Point of sale > Create a new cash register) 3. Add some sample items for sale (Home > Point of sale > Configure items for purchase) 4. Add some sales (Home > Point of sale > Add some items, enter a payment and sleect Confirm) 5. Issue a refund (Home > Point of sale > Register details > select Issue refund for an item) 6. Try to enter text, numbers with several decimal places, and , or multiple . 7. Apply the patch. 8. Repeat steps 4-6 - should continue to function as expected, with appropriate warning messages for invalid entries. 9. Search koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt for input type="number" - there should be no occurences. 10. Sign off! Sponsored by Catalyst IT Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27405 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 117120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117120&action=edit Bug 27405: (follow up) Updates to accommodate currency entry This patch makes two modifications to allow the entry of currency strings (for example, 1.25) so that it is consistent with other payment entry forms. - Inputmode changed to "decimal" - Regex pattern changed to "^\d+(\.\d{2})?$" as found in admin/debit_types.tt To test, apply the patch and test entry of various strings in the manual invoice "amount" field. Confirm that the field only accepts digits or digits followed by a decimal and two digits. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27405 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #115463|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Comment on attachment 115463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115463 Bug 27405: update file for ACC2 I've: - Added steps to the test plan so you can test register.tt - Updated the title in the commit message so that it matches guidelines (Bug XXXX: Commit title). - Added a follow up to match other similar bugs - Bug 27408 and Bug 27410. Have left as requiring sign off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27405 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27405 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117119|0 |1 is obsolete| | Attachment #117120|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 117195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117195&action=edit Bug 27405: Update koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt for ACC2 This replaces the number type input in intranet-tmpl/prog/en/modules/pos/register.tt so that it is consistent with ACC2 guidelines. Test plan: 1. Enable the EnablePointOfSale (set to Enable) and UseCashRegisters (set to Use) system preferences. 2. Add a new cash register for a library (Home > Point of sale > Create a new cash register) 3. Add some sample items for sale (Home > Point of sale > Configure items for purchase) 4. Add some sales (Home > Point of sale > Add some items, enter a payment and sleect Confirm) 5. Issue a refund (Home > Point of sale > Register details > select Issue refund for an item) 6. Try to enter text, numbers with several decimal places, and , or multiple . 7. Apply the patch. 8. Repeat steps 4-6 - should continue to function as expected, with appropriate warning messages for invalid entries. 9. Search koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt for input type="number" - there should be no occurences. 10. Sign off! Sponsored by Catalyst IT Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27405 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 117196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117196&action=edit Bug 27405: (follow up) Updates to accommodate currency entry This patch makes two modifications to allow the entry of currency strings (for example, 1.25) so that it is consistent with other payment entry forms. - Inputmode changed to "decimal" - Regex pattern changed to "^\d+(\.\d{2})?$" as found in admin/debit_types.tt To test, apply the patch and test entry of various strings in the manual invoice "amount" field. Confirm that the field only accepts digits or digits followed by a decimal and two digits. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27405 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27405 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117195|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117740&action=edit Bug 27405: Update koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt for ACC2 This replaces the number type input in intranet-tmpl/prog/en/modules/pos/register.tt so that it is consistent with ACC2 guidelines. Test plan: 1. Enable the EnablePointOfSale (set to Enable) and UseCashRegisters (set to Use) system preferences. 2. Add a new cash register for a library (Home > Point of sale > Create a new cash register) 3. Add some sample items for sale (Home > Point of sale > Configure items for purchase) 4. Add some sales (Home > Point of sale > Add some items, enter a payment and sleect Confirm) 5. Issue a refund (Home > Point of sale > Register details > select Issue refund for an item) 6. Try to enter text, numbers with several decimal places, and , or multiple . 7. Apply the patch. 8. Repeat steps 4-6 - should continue to function as expected, with appropriate warning messages for invalid entries. 9. Search koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt for input type="number" - there should be no occurences. 10. Sign off! Sponsored by Catalyst IT Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27405 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117196|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117741&action=edit Bug 27405: (follow up) Updates to accommodate currency entry This patch makes two modifications to allow the entry of currency strings (for example, 1.25) so that it is consistent with other payment entry forms. - Inputmode changed to "decimal" - Regex pattern changed to "^\d+(\.\d{2})?$" as found in admin/debit_types.tt Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27405 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch updates release notes| |occurrences of input | |type="number" in | |intranet-tmpl/prog/en/modul | |es/pos/register.tt to use | |<input type="text" | |inputmode="numeric" | |pattern="^\d+(\.\d{2})?$"> | |as per the accessibility | |coding guideline ACC2. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27405 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27405 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27405 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch updates |This patch updates release notes|occurrences of input |occurrences of input |type="number" in |type="number" in |intranet-tmpl/prog/en/modul |intranet-tmpl/prog/en/modul |es/pos/register.tt to use |es/pos/register.tt to use |<input type="text" |'input type="text" |inputmode="numeric" |inputmode="numeric" |pattern="^\d+(\.\d{2})?$"> |pattern="^\d+(\.\d{2})?$"' |as per the accessibility |as per the accessibility |coding guideline ACC2. |coding guideline ACC2. CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org