https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17243 --- Comment #1 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 55145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55145&action=edit Bug 17243 - git ignore swagger.min.json This patch adds *.min.json to .gitignore in swagger dir. To remove tracking of swagger.min.json run git update-index --assume-unchanged swagger.min.json Or just ignore uncommitted changes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17243 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |z.tajoli@cineca.it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17243 --- Comment #4 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Thinking more of it, I would recommend the plack build solution. Something in the line of adding a sub to plack.psgi: sub minifySwagger { use Swagger2; my $swagger = Swagger2->new('/usr/share/koha/api/v1/swagger/swagger.json'); $swagger = $swagger->expand; #Fetch all JSON-Schema references my $data = $swagger->api_spec->data; delete($data->{id}); # delete non-valid "/id" open(SWOUT, ">:encoding(UTF-8)", '/usr/share/koha/api/v1/swagger/swagger.min.json') print SWOUT $swagger->to_string(); close(SWOUT); } and calling it inside the build method of the api. Obviously with some error-handling and relative paths. Thoughts? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17243 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #6 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Actually, bug 17102 discusses the alternatives. This patch simply removes the minified swagger from source control, which I think is important. Setting back to need signoff and urge the discussion to move forward in 17102 ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17243 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We could imagine an "environment" pref (or in the config) with 2 values "dev" or "prod" (default "prod"). If "prod", the minified files are used (otherwise the non-minified). This could work for the css and swaggger min files. The RM(aints) will have to regenerated the min fils before each releases (automatically), but nothing to do for devs (no need to regenerated them) nor for testers (no conflict). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17243 --- Comment #10 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- (In reply to Jonathan Druart from comment #8)

We could imagine an "environment" pref (or in the config) with 2 values "dev" or "prod" (default "prod"). If "prod", the minified files are used (otherwise the non-minified). This could work for the css and swaggger min files. The RM(aints) will have to regenerated the min fils before each releases (automatically), but nothing to do for devs (no need to regenerated them) nor for testers (no conflict).

That is a very sensible suggestion! Also since it is a general solution that can be used any other place where compilation/minifying/regeneration would be neccessary in the future. Especially in the javascript world and the coming of ES6 this would make sense, as it would cover the need of browser shims and transpilation to code that works across browsers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.