[Bug 41646] New: Self-checkin displaying too much whitespace due to incorrect HTML
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 Bug ID: 41646 Summary: Self-checkin displaying too much whitespace due to incorrect HTML Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Self checkout Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org There's some incorrect HTML which is causing a lot of whitespace to appear on http://localhost:8080/cgi-bin/koha/sci/sci-main.pl which looks very broken -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41144 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 [Bug 41144] Fix markup errors in self checkout and self checkin templates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 191541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191541&action=edit Bug 41646: Fix HTML display for self-checkin This change moves the wrapper so that the web page display correctly Test plan: 0. Apply the patch 1. Enable the SelfCheckInModule system preference 2. Go to http://localhost:8080/cgi-bin/koha/sci/sci-main.pl 3. Note that there isn't a lot of whitespace between the word "koha" and "Self check-in" 4. Celebrate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41647 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41647 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41647 [Bug 41647] Make self-checkin use responsive CSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191541|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 191543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191543&action=edit Bug 41646: Fix HTML display for self-checkin This change moves the wrapper so that the web page display correctly Test plan: 0. Apply the patch 1. Enable the SelfCheckInModule system preference 2. Go to http://localhost:8080/cgi-bin/koha/sci/sci-main.pl 3. Note that there isn't a lot of whitespace between the word "koha" and "Self check-in" 4. Celebrate Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This removes a large release notes| |section of white space | |between the page header and | |the actual form on the OPAC | |self check-in page, which | |is positioned near the | |bottom of the page. --- Comment #3 from David Nind <david@davidnind.com> --- I'm sure I signed off a similar bug sometime in the last month or two, but for the life of me I can't find it! 8-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to David Nind from comment #3)
I'm sure I signed off a similar bug sometime in the last month or two, but for the life of me I can't find it! 8-)
It might've been bug 41144 but I think it has some errors in it. (This one technically might too but it is a very simple fix for a very obvious problem.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 --- Comment #5 from David Nind <david@davidnind.com> --- I think that was it! Thanks for finding it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191543|0 |1 is obsolete| | --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 191790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191790&action=edit Bug 41646: Fix HTML display for self-checkin This change moves the wrapper so that the web page display correctly Test plan: 0. Apply the patch 1. Enable the SelfCheckInModule system preference 2. Go to http://localhost:8080/cgi-bin/koha/sci/sci-main.pl 3. Note that there isn't a lot of whitespace between the word "koha" and "Self check-in" 4. Celebrate Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This removes a large |This removes a large release notes|section of white space |section of white space |between the page header and |between the page header and |the actual form on the OPAC |the actual form on the OPAC |self check-in page, which |self check-in page, which |is positioned near the |was positioned near the |bottom of the page. |bottom of the page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 --- Comment #8 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Strange, there is </body> But this is also in INCLUDE 'opac-bottom.inc'. Is this on purpose ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- May this come from tidy ? I struggle to enabled SCI feature to verify -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 --- Comment #11 from David Cook <dcook@prosentient.com.au> --- (In reply to Fridolin Somers from comment #9)
Strange, there is </body> But this is also in INCLUDE 'opac-bottom.inc'. Is this on purpose ?
It looks like it's probably an old mistake as it's in the before and after. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 --- Comment #12 from David Cook <dcook@prosentient.com.au> --- (In reply to Fridolin Somers from comment #10)
May this come from tidy ? I struggle to enabled SCI feature to verify
I don't think so. What problem are you having enabling the feature? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 --- Comment #13 from David Cook <dcook@prosentient.com.au> --- @Frido it doesn't look like this one is needed for 24.11.x It would be great to see bug 41647 and bug 41645 in 24.11.x. I think this might just block bug 41647 for master. If you need help rebasing 41647 for 24.11.x, I can have a crack at it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to David Cook from comment #13)
@Frido it doesn't look like this one is needed for 24.11.x
It would be great to see bug 41647 and bug 41645 in 24.11.x. I think this might just block bug 41647 for master.
If you need help rebasing 41647 for 24.11.x, I can have a crack at it.
Thanks a lot for testing. OK we will follow those reports. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00,25.11.02 |26.05.00,25.11.02,25.05.12 released in| | Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #15 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Applied to 25.05 or 25.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #16 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41646 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|41144 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41144 [Bug 41144] Fix markup errors in self checkout and self checkin templates -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org