https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 --- Comment #1 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 51249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51249&action=edit Bug 16456: Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation Add Font Awesome Icons to section Patrons and circulation in Tools module (Save, Upload, Filter, Import) To test goto: -Patron lists -> New patron List -> Save -Patron list -> my_list_saved -> Add patrons -> Remove selected patrons, Clear all, Select all -Comments -> Approve, delete and, unapprove -Import patrons -> Import -Overdue notice/status triggers -> Save changes -Batch patron modification -> Save, Select all and Clear all -Upload patron images -> Upload -Tags -> Apply filter(s), Test, Approved, Reject, Select all, Clear all, Select all pending. Set TagsModeration to Require. -Verify that all tools work as expected NOTE: The Tag and Comments tools has been revised to fit with others interfaces in Koha. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 51251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51251&action=edit New look for tags tool -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51249|0 |1 is obsolete| | --- Comment #4 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 51258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51258&action=edit Bug 16456: Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation Add Font Awesome Icons to section Patrons and circulation in Tools module (Save, Upload, Filter, Import) To test goto: -Patron lists -> New patron List -> Save -Patron list -> my_list_saved -> Add patrons -> Remove selected patrons, Clear all, Select all -Comments -> Approve, delete and, unapprove -Import patrons -> Import -Overdue notice/status triggers -> Save changes -Batch patron modification -> Save, Select all and Clear all -Upload patron images -> Upload -Tags -> Apply filter(s), Test, Approved, Reject, Select all, Clear all, Select all pending. Set TagsModeration to Require. -Verify that all tools work as expected NOTE: The Tag and Comments tools has been revised to fit with others interfaces in Koha. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51258|0 |1 is obsolete| | --- Comment #6 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 51497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51497&action=edit Bug 16456: Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation Add Font Awesome Icons to section Patrons and circulation in Tools module To test goto: -Patron list -> my_list_saved -> Add patrons -> Remove selected patrons, Clear all, Select all -Comments -> Approve, delete and, unapprove -Tags -> Apply filter(s), Test, Approved, Reject, Select all, Clear all, Select all pending. Set TagsModeration to Require. -Verify that all tools work as expected NOTE: The Tag and Comments tools has been revised to fit with others interfaces in Koha. Bug ammended according with QA comment 5 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 --- Comment #7 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 51498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51498&action=edit Add patrons tools -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |oleonard@myacpl.org --- Comment #9 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Patch changed according with comment #5 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 --- Comment #11 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 51501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51501&action=edit Bug 16456: Add Font Awesome icons to tag result To test goto: -Tags -> and click in a tag with multiple titles -A table with titles tagged with the term is presented -See the new button 'Remove' -Verify if you can remove tags from a selected title. -- You are receiving this mail because: You are watching all bug changes.

Regarding Patrons list the "Select all" and "Clear all" icons are not the same as the "Remove selected patrons" or "Remove selected". That was intentionally did it since comment 5 about that I can cite "There is currently some confusion in how we indicate remove or cancel (See Bug 16005). I

Regarding comments "delete and" icon is not there (of course there are no comments in the test page and this may be the reason). Perhaps I did not write well the test plan "delete and" icon really does not exist, I was refering only to three buttons: "Approve", "Delete", "Unapprove",

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion CC| |katrin.fischer@bsz-bw.de --- Comment #13 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- (In reply to Aliki Pavlidou from comment #12) Hi Aliki thank your for testing think the "trash" icon should be the standard for delete or remove." So I can't use the same trash icon for clear button. those buttons shown in two tabs "Approved comments" and "Comments awaiting moderation".

regarding "Tags", "Test" and "Apply filter(s)" have the same shiny icon! There are no "Clear all" and "Set TagsModeration to Require", buttons. In this point the interface was little changed to reflect the same look as other parts in Koha. If you see before apply patch the leyend for this is "Select: All Pending None" and after is shown like in attach <https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51499> Respect to "Set TagsModeration to Require" again I did not explain well, I was refering to set the syspref "TagsModeration" to "Require"

The "The Approved", "Rejected", "Pending, and "Total" buttons in the right box are not icons. Citing again the comment 5 "The links under "Terms summary" should not have icons. Icons are attached to controls which trigger actions. These links are for different views of the data." So I did not put icons in this right box. Look an obsolete image attached <https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51251>

At this point I would like to know the opinion of Owen or another QA like Katrin. Regards -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51500|0 |1 is obsolete| | --- Comment #16 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 52091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52091&action=edit Bug 16456: Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation Add Font Awesome Icons to section Patrons and circulation in Tools module To test goto: -Patron list -> my_list_saved -> Add patrons -> Remove selected patrons, Clear all, Select all -Comments -> Approve, Delete, Unapprove -Tags -> Apply filter(s), Test, Approved, Reject, Select all, Clear all, Select all pending. Set syspref TagsModeration to Require. -Verify that all tools work as expected NOTE: The Tag and Comments tools has been revised to fit with others interfaces in Koha. Bug ammended according with QA comment 5 Bug rebased because bug 16005 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff Depends on| |16005 --- Comment #18 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Hi Aliki and Jonathan Bug rebased because commit ed449a5b5be4da03443d214de5806f4a0273227b in bug 16005 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16005 [Bug 16005] Standardize use of icons for delete and cancel operations -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Héctor Eduardo Castro Avalos from comment #19)

I don't know if I can keep the signed-off, Jonathan?

Depends whether the signoff was intentional or not :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 --- Comment #22 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- (In reply to Aliki Pavlidou from comment #21)

Sorry guys for the confusion, which status do do you recommend to choose?

Hi Aliki, the status you used before is the right one. More info about it is at <https://wiki.koha-community.org/wiki/Development_workflow> If you are using one of the Sandboxes, you need to read the step 4 of wiki page at <https://wiki.koha-community.org/wiki/Sandboxes#Step_4_:_login> If you are using git you need to read <https://wiki.koha-community.org/wiki/Git_bz_configuration>, notice that this bug has more than one patch attached to it <https://wiki.koha-community.org/wiki/Git_bz_configuration#Bugs_with_more_than_one_patch> Regards -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ah, I think Jonathan was referring to Aliki's comment#12 - where it sounds a bit like this might need some more work.

From the screenshot in Hector's response the only one I don't understand is the clock for 'select all pending'?

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 --- Comment #24 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- (In reply to Katrin Fischer from comment #23) Hi Katrin

Ah, I think Jonathan was referring to Aliki's comment#12 - where it sounds a bit like this might need some more work.

What part needs more work? Please guide me, I can improve it.

From the screenshot in Hector's response the only one I don't understand is the clock for 'select all pending'?

Owen stated in another bug that if there is not another icon that represent the link, we can leave it without icon, or Do you suggest another icon to represent all pending to approval? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 --- Comment #25 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 52159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52159&action=edit Bug 16456: Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation Add Font Awesome Icons to section Patrons and circulation in Tools module. Also correct a error dialog in JQuery functions To test: -Apply patch -Goto Tools -> Patron list -> my_list_saved -> Add patrons -> Remove selected patrons, Clear all, Select all. -Add new patron list and add some patrons, notice about the trash icon. -Make some comments in some bib records and goto Tools->Comments you will presented with two tabs "Approved comments" and "Comments awaiting moderation". See the three new buttons: Approve, Delete, Unapprove. -Set syspref TagsModeration to Require. This will show all pending tags to review. -Make some tags in bib records and goto Tools -> Tags. -Notice about the new look. -In the new screen look the icons in buttons "Apply filter(s)", "Test", "Approved", "Reject". Notice about the new header bar above the DataTable with options: Select all, Clear all, Select all pending. -Play with filters; Check if terms exist or not in appoved/rejected lists -Play with Terms summary and see if DataTable is working as expected -Click in some term tag with multiple titles -A table with titles tagged with the term is presented -See the new button 'Remove' -Verify if you can remove tag from a selected title. -Verify that all tools work as expected NOTE: The Tag and Comments tools has been revised to fit with others interfaces in Koha. Bug ammended according with QA comment 5 Bug rebased because bug 16005 Test plan amended for clarity Clock icon for "Select all pending" removed (QA comment 23). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52092|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 --- Comment #27 from Aliki Pavlidou <pavlidoualiki@gmail.com> --- "Tag tool without clock in Select all pending option Hi Aliki Please re-test and tell me if is Ok, or, I need to improve something else" Hi Hector, to sum it up, you want me to re-test everything on comment no25, or just the "Tag tool"? Best regards Aliki -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 Aliki Pavlidou <pavlidoualiki@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #29 from Aliki Pavlidou <pavlidoualiki@gmail.com> --- Dear Hector, I've checked out as many things as I could. Here is what I've noted: "-Make some comments in some bib records and goto Tools->Comments you will presented with two tabs "Approved comments" and "Comments awaiting moderation". See the three new buttons: Approve, Delete, Unapprove" "COMMENTS" tab was not enabled on the bib records, so I’ve changed the: ADMINISTRATION=>SYSTEM PREFERENCE=>OPAC=>reviewson to Allow After that I’ve noticed that the "UNAPPROVE" button is missing. "-Set syspref TagsModeration to Require This will show all pending tags to review." GLOBAL SYSTEM PREFERENCE=> ENHANCED CONTENT=>TAGGING I’ve chenged "TAGSENABLED" to Allow but the "TAGS" button was still missing. Next I’ve changed "TAGSINPUTONDETAIL" to Allow, but again there was no "TAGS" BUTTON on the OPAC bib record. In both cases there was a "Tag cloud" button at the top, next to the "Advanced search" button, but there were no results after clicking on it. "-Make some tags in bib records and goto Tools -> Tags." SEE ABOVE "-In the new screen look the icons in buttons "Apply filter(s)", "Test", "Approved", "Reject". Notice about the new header bar above the DataTable with options: Select all, Clear all, Select all pending." "Apply filter(s)", "Test" => Look the same (SUBMIT BUTTONS) "Approved","Reject" => “Approved”, "Rejected” are colored blue, they both are in the "Terms summary" box, along with “Pending” and “Total” buttons. "-Play with filters; Check if terms exist or not in appoved/rejected lists" "-Play with Terms summary and see if DataTable is working as expected" "-Click in some term tag with multiple titles" "-A table with titles tagged with the term is presented" "-See the new button 'Remove'" "-Verify if you can remove tag from a selected title." NO DATA SEE ABOVE I hope that these are all understandable. Regards Aliki -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 --- Comment #31 from Aliki Pavlidou <pavlidoualiki@gmail.com> --- Hi Hector, Everything looks great! Nice job! Regards Aliki -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52247|0 |1 is obsolete| | --- Comment #33 from Marc Véron <veron@veron.ch> --- Created attachment 52251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52251&action=edit Bug 16456: Add Font Awesome icons to some buttons in Tools module, section Patrons and circulation Add Font Awesome Icons to section Patrons and circulation in Tools module. Also correct a error dialog in JQuery functions To test: -Apply patch -Goto Tools -> Patron list -> my_list_saved -> Add patrons -> Remove selected patrons, Clear all, Select all. -Add new patron list and add some patrons, notice about the trash icon. -Make some comments in some bib records and goto Tools->Comments you will presented with two tabs "Approved comments" and "Comments awaiting moderation". See the three new buttons: Approve, Delete, Unapprove. -Set syspref TagsModeration to Require. This will show all pending tags to review. -Make some tags in bib records and goto Tools -> Tags. -Notice about the new look. -In the new screen look the icons in buttons "Apply filter(s)", "Test", "Approved", "Reject". Notice about the new header bar above the DataTable with options: Select all, Clear all, Select all pending. -Play with filters; Check if terms exist or not in appoved/rejected lists -Play with Terms summary and see if DataTable is working as expected -Click in some term tag with multiple titles -A table with titles tagged with the term is presented -See the new button 'Remove' -Verify if you can remove tag from a selected title. -Verify that all tools work as expected NOTE: The Tag and Comments tools has been revised to fit with others interfaces in Koha. Bug ammended according with QA comment 5 Bug rebased because bug 16005 Test plan amended for clarity Clock icon for "Select all pending" removed (QA comment 23). Fix some forbidden patterns (tab char) in review.tt according by IRC comment by Marc Veron Followed test plan, looks and works as expected Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52362&action=edit Bug 16456: Reintroduce wording "Delete tag" "Delete tag" seems more appropriate than "Delete" on this tag, but I may be wrong. This patch also removes an extra space. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16456 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #37 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.01. -- You are receiving this mail because: You are watching all bug changes.