[Bug 41042] New: Table setting 'default sort order' not available for existing installations
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41042 Bug ID: 41042 Summary: Table setting 'default sort order' not available for existing installations Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff interface Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com If a row exists in DB for a given table, default_sort_order will be NULL in DB which will replace the flag from the YAML file: the feature won't be available. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41042 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30633 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41042 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30633 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30633 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30633 [Bug 30633] Move OPACHoldingsDefaultSortField to table settings configuration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41042 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41042 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 188048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188048&action=edit Bug 41042: Simplify tests No change here. Test plan: Apply only this patch and confirm that the tests are still passing. The previous code was dynamic but complicated to adjust. The next patch needs more complex and specific comparisons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41042 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 188049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188049&action=edit Bug 41042: Make 'default sort order' available to new installations If a row exists in DB for a given table, default_sort_order will be NULL in DB which will replace the flag from the YAML file: the feature won't be available. Test plan: 0. checkout main (we don't want bug 30633) 1. Go to http://localhost:8081/cgi-bin/koha/admin/columns_settings.pl#biblio-detail%7... => Notice that "Default sort order" is not available for 'holdingst' (it's added by bug 30633) 2. Save 3. Verify what you have in DB: select * from tables_settings where module="opac" and tablename="holdingst"; 4. Apply 30633, restart_all 5. Go to http://localhost:8081/cgi-bin/koha/admin/columns_settings.pl#biblio-detail%7... => Notice that "Default sort order" is not available for 'holdingst' (not ok) 6. Save 7. Verify what you have in DB: select * from tables_settings where module="opac" and tablename="holdingst"; 8. Apply this patch set 9. Go to http://localhost:8081/cgi-bin/koha/admin/columns_settings.pl#biblio-detail%7... => Notice that "Default sort order" is available for 'holdingst'! 10. Save, verify what you have in DB. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41042 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu Status|Needs Signoff |Signed Off --- Comment #3 from Michaela Sieber <michaela.sieber@kit.edu> --- Tested with Bug 30633 in Sandbox and additionally with ktd following the testplan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41042 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188048|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188159&action=edit Bug 41042: Simplify tests No change here. Test plan: Apply only this patch and confirm that the tests are still passing. The previous code was dynamic but complicated to adjust. The next patch needs more complex and specific comparisons. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41042 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188049|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188160&action=edit Bug 41042: Make 'default sort order' available to new installations If a row exists in DB for a given table, default_sort_order will be NULL in DB which will replace the flag from the YAML file: the feature won't be available. Test plan: 0. checkout main (we don't want bug 30633) 1. Go to http://localhost:8081/cgi-bin/koha/admin/columns_settings.pl#biblio-detail%7... => Notice that "Default sort order" is not available for 'holdingst' (it's added by bug 30633) 2. Save 3. Verify what you have in DB: select * from tables_settings where module="opac" and tablename="holdingst"; 4. Apply 30633, restart_all 5. Go to http://localhost:8081/cgi-bin/koha/admin/columns_settings.pl#biblio-detail%7... => Notice that "Default sort order" is not available for 'holdingst' (not ok) 6. Save 7. Verify what you have in DB: select * from tables_settings where module="opac" and tablename="holdingst"; 8. Apply this patch set 9. Go to http://localhost:8081/cgi-bin/koha/admin/columns_settings.pl#biblio-detail%7... => Notice that "Default sort order" is available for 'holdingst'! 10. Save, verify what you have in DB. Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41042 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41042 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks Jonathan, nice clean solution even if a little difficult to initially understand. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41042 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41042 --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41042 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41042 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 188304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188304&action=edit Bug 41042: default_save_state is enabled by default If 'default_save_state' is not in the yaml file then the feature is enabled by default. Caught by the following failure: t/db_dependent/selenium/patrons_search.t .. # Failed test 'Search works when category of patrons is limited to a library we are not signed in at' # at t/db_dependent/selenium/patrons_search.t line 471. # got: 'Showing 1 to 5 of 26 entries (filtered from 82 total entries)' # expected: 'Showing 1 to 15 of 26 entries (filtered from 82 total entries)' # Looks like you failed 1 test of 1. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41042 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-up pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41042 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41042 --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41042 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Patches are hard to apply on 24.11.x Please provide a dedicated patch if possible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41042 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baptiste.wojtkowski@biblibr | |e.com Status|Pushed to stable |Needs documenting --- Comment #12 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Not backported: depends on Bug 30633 not backported -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org