[Bug 9692] New: Add a checkbox to display statistical fields in basket.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9692 Bug ID: 9692 Summary: Add a checkbox to display statistical fields in basket.tt Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: mathieu.saby@univ-rennes2.fr On the page displaying orders in a basket, there is a a checkbox to show "all details". In fact, checking the box don't show all details, but only all prices. It could be useful for librarians to see statistical fields on this page. M. Saby Rennes 2 University -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9692 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9692 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mathieu.saby@univ-rennes2.f |ity.org |r -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9692 --- Comment #1 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 15609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15609&action=edit Add a checkbox to display statistical fields in basket.tt This patch adds a checkbox in basket.tt to display the 2 statistical fields, and rename the "Show all details" checkbox to "Show all prices" To test : 1. open a basket, with some orders comprising some values in statistical fields 2. check/uncheck the 2 boxes "Show all prices" and "Show statistical fields" M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9692 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9692 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |koha@univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9692 --- Comment #2 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- ok, I can see statistical fields when "Show statistical fields" is checked and all the prices when "Show all prices" is checked and both if the 2 boxes are checked -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9692 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> --- Patch tested with a sandbox, by Pierre Angot <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9692 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15609|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9692 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 16265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16265&action=edit Bug 9692: Add a checkbox to display statistical fields in basket.tt This patch adds a checkbox in basket.tt to display the 2 statistical fields, and rename the "Show all details" checkbox to "Show all prices" To test : 1. open a basket, with some orders comprising some values in statistical fields 2. check/uncheck the 2 boxes "Show all prices" and "Show statistical fields" Signed-off-by: Pierre Angot <tredok.pierre@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9692 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Small patch --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: There are 3 issues: 1/ The columns does not hide if I unselect the new checkbox + [% IF ( listincgst ) %] + $("table .statistics").hide(); + [% ELSE %] + $("table .statistics").hide(); + [% END %] 2/ If these fields (sort1 and sort2) are linked to an authorized value, the description should be displayed, not the code. 3/ 2 withespaces: * koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt FAIL forbidden patterns FAIL The patch introduces a forbidden pattern: withespace character (43) The patch introduces a forbidden pattern: withespace character (35) Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9692 --- Comment #6 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Thank you, I will look after that tomorrow. M. Saby -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org