[Bug 7113] New: Standardize vendor id name in templates and scripts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Bug #: 7113 Summary: Standardize vendor id name in templates and scripts Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: ASSIGNED Severity: normal Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: oleonard@myacpl.org QAContact: koha-bugs@lists.koha-community.org Acquisitions scripts use three different variable names for vendor id on different pages: booksellerid, supplierid, and id. In order to make the code more consistent and to allow us better global navigation in acquisitions I propose that we standardize on booksellerid. This one is most commonly used. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|henridamien@koha-fr.org |oleonard@myacpl.org -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-10-28 20:13:12 UTC --- Created attachment 6106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6106 Proposed fix -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-29 14:11:28 UTC --- Hi Owen, thank you for your work on this! I started testing and found some small issues: Save changes to contract 1) Add contract > redirect to vendor broken 2) Edit contract > redirect to vendor broken 3) Delete contract > rediret to vendor broken URL still has supplierid: http://localhost:8080/cgi-bin/koha/acqui/supplier.pl?supplierid=6 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-29 14:37:24 UTC --- Saving changes to vendor 1) Edit existing vendor 2) Save vendor URL: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl?id=3 Unrelated to bug: Edit vendor link from toolbar on basketgroups page Page: http://localhost:8080/cgi-bin/koha/acqui/basketgroup.pl?booksellerid=3 URL: http://localhost:8080/cgi-bin/koha/acqui/booksellers.pl?booksellerid=3 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-29 14:41:40 UTC --- Deleting an order from receive page redirects to wrong page Delete Order & Delete order and catalog record Page: http://localhost:8080/cgi-bin/koha/acqui/parcel.pl?invoice=test&booksellerid=3&gst=0&datereceived=2011-10-29 URL: http://localhost:8080/cgi-bin/koha/acqui/basket.pl?basketno= -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6106|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-29 14:48:17 UTC --- Created attachment 6114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6114 [SIGNED-OFF] Fix for Bug 7113 - Standardize vendor id name in templates and scripts Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Signed off this patch, but before it can go into master a follow up is needed to fix the found issues marked as 'BROKEN' in the test plan. This patch touches a lot of links in acquisitions. Tested: Vendor result list (booksellers) - link to vendor summary page - link to receive shipment - new basket Vendor summary (supplier) - links to contract summary - BROKEN: Edit vendor: redirect after saving - edit vendor > cancel - BROKEN: redirect after saving/editing/adding contract - contracts list from toolbar - new basket Basketgroups (basketgroup) - breadcrumbs: link to vendor - link back to vendor summary - edit basketgroup > save - delete basketgroup - link to vendor from toolbar - (BROKEN) edit vendor from toolbar - does not open edit page - uncertain prices Uncertain prices (uncertainprice) - breadcrumbs: link to vendor - link to vendor summary - link to edit vendor - here it works - edit po line - changing price and submitting Basket header (basketheader) - breadcrumbs: link back to vendor - link for saving New basket (basket) - breadcrumbs: link back to vendor - delete basket (redirects to search list, ok) - export as csv - close basket - cancel order - modify order Order from existing record (neworderempty) - breadcrumbs: link back to vendor - order Order from suggestion (newordersuggestion) - breadcrumbs: link back to vendor - order - cancel Order from external source (z3950_search) - breadcrumbs: link to vendor - order - after ordering: neworderenry > edit record Order new (neworderentry) - breadcrumbs: link to vendor - save - cancel Receive shiptment (parcels) - breadcrumbs: link to vendor - cancel Order receive (parcel) - Finish receiving - Cancel receiving - link to order line - receive - BROKEN: delete order redirects to wrong page - BROKEN: delete order and catalog record redirects to wrong page Late orders (lateorders) - filter on specific vendor -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> 2011-10-30 21:40:40 UTC --- (In reply to comment #5)
- BROKEN: delete order redirects to wrong page - BROKEN: delete order and catalog record redirects to wrong page
These two at least are bugs in master. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> 2011-10-31 14:30:08 UTC --- Created attachment 6124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6124 Follow-up fix Fixes: - Edit vendor: redirect after saving - redirect after saving/editing/adding contract - edit vendor from toolbar - does not open edit page Since the first patch has a sign-off I kept these changes as a separate one which must be applied on top of the first. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> 2011-10-31 14:41:18 UTC --- (In reply to comment #5)
- BROKEN: delete order redirects to wrong page - BROKEN: delete order and catalog record redirects to wrong page
This is now Bug 7120 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6124|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-04 09:39:30 UTC --- Created attachment 6189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6189 Follow-up fixes for Bug 7113, Standardize vendor id name in templates and scripts Fixed: - Edit vendor: redirect after saving - redirect after saving/editing/adding contract - edit vendor from toolbar - does not open edit page Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> 1) redirect after editing vendor is ok 2) saving and deleting contract is perfect, one little improvement: The cancel link takes you back to the list of contracts, not to the vendor detail page. I think it would be a little better if save and cancel redirected to the same page. 3) editing vendor from basket group toolbar works now -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-04 09:40:15 UTC --- Thx Owen! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Failed QA --- Comment #11 from Ian Walls <ian.walls@bywatersolutions.com> 2011-11-06 09:41:01 UTC --- aqcontract.tt still passes supplierid param, even though it's being populated with the booksellerid value. Serials doesn't seem to be making this change, particularly in claims.tt. Is it outside the scope of this report? What about variables in C4 modules? Have to mark this as Failed QA due to the first paragraph... please fix, and clarify the scope for this report -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> 2011-11-21 14:22:28 UTC --- Created attachment 6369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6369 Follow-up fix Fix for a missed instance of the wrong variable name In terms of scope: I undertook the changes in this bug in order to lay the groundwork for an overhaul of navigation in the Acquisitions section. Standardizing the variable names was necessary in order to be able to have navigation includes use a consistent variable name. Changes to C4 and serials pages are outside the scope of my initial effort because of the practical reason for making the changes. Getting this initial batch of changes approved will let me move forward in other work. Getting the other sections brought in line could happen separately. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6114|0 |1 is obsolete| | Attachment #6189|0 |1 is obsolete| | Attachment #6369|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-27 17:13:27 UTC --- Created attachment 6437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6437 [SIGNED-OFF] Fix for Bug 7113 - Standardize vendor id name in templates and scripts Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Update: Fixed conflict in basket.tt Signed off this patch, but before it can go into master a follow up is needed to fix the found issues marked as 'BROKEN' in the test plan. This patch touches a lot of links in acquisitions. Tested: Vendor result list (booksellers) - link to vendor summary page - link to receive shipment - new basket Vendor summary (supplier) - links to contract summary - BROKEN: Edit vendor: redirect after saving - edit vendor > cancel - BROKEN: redirect after saving/editing/adding contract - contracts list from toolbar - new basket Basketgroups (basketgroup) - breadcrumbs: link to vendor - link back to vendor summary - edit basketgroup > save - delete basketgroup - link to vendor from toolbar - (BROKEN) edit vendor from toolbar - does not open edit page - uncertain prices Uncertain prices (uncertainprice) - breadcrumbs: link to vendor - link to vendor summary - link to edit vendor - here it works - edit po line - changing price and submitting Basket header (basketheader) - breadcrumbs: link back to vendor - link for saving New basket (basket) - breadcrumbs: link back to vendor - delete basket (redirects to search list, ok) - export as csv - close basket - cancel order - modify order Order from existing record (neworderempty) - breadcrumbs: link back to vendor - order Order from suggestion (newordersuggestion) - breadcrumbs: link back to vendor - order - cancel Order from external source (z3950_search) - breadcrumbs: link to vendor - order - after ordering: neworderenry > edit record Order new (neworderentry) - breadcrumbs: link to vendor - save - cancel Receive shiptment (parcels) - breadcrumbs: link to vendor - cancel Order receive (parcel) - Finish receiving - Cancel receiving - link to order line - receive - BROKEN: delete order redirects to wrong page - BROKEN: delete order and catalog record redirects to wrong page Late orders (lateorders) - filter on specific vendor Follow-up fixes for Bug 7113, Standardize vendor id name in templates and scripts Fixed: - Edit vendor: redirect after saving - redirect after saving/editing/adding contract - edit vendor from toolbar - does not open edit page Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> 1) redirect after editing vendor is ok 2) saving and deleting contract is perfect, one little improvement: The cancel link takes you back to the list of contracts, not to the vendor detail page. I think it would be a little better if save and cancel redirected to the same page. 3) editing vendor from basket group toolbar works now [SIGNED-OFF] Bug 7113 Fix for a missed instance of the wrong variable name Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Link back to vendor in breadcrumbs of contract page works now too. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-27 17:14:20 UTC --- Tested the 3rd patch on top of the 2 others and sqashed them into one. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6437|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-14 06:05:22 UTC --- Created attachment 6767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6767 Fix for Bug 7113 - Standardize vendor id name in templates and scripts Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Update: Fixed conflict in basket.tt Update 2011-12-14: Fixed conflict in basketgroup.tt Signed off this patch, but before it can go into master a follow up is needed to fix the found issues marked as 'BROKEN' in the test plan. This patch touches a lot of links in acquisitions. Tested: Vendor result list (booksellers) - link to vendor summary page - link to receive shipment - new basket Vendor summary (supplier) - links to contract summary - BROKEN: Edit vendor: redirect after saving - edit vendor > cancel - BROKEN: redirect after saving/editing/adding contract - contracts list from toolbar - new basket Basketgroups (basketgroup) - breadcrumbs: link to vendor - link back to vendor summary - edit basketgroup > save - delete basketgroup - link to vendor from toolbar - (BROKEN) edit vendor from toolbar - does not open edit page - uncertain prices Uncertain prices (uncertainprice) - breadcrumbs: link to vendor - link to vendor summary - link to edit vendor - here it works - edit po line - changing price and submitting Basket header (basketheader) - breadcrumbs: link back to vendor - link for saving New basket (basket) - breadcrumbs: link back to vendor - delete basket (redirects to search list, ok) - export as csv - close basket - cancel order - modify order Order from existing record (neworderempty) - breadcrumbs: link back to vendor - order Order from suggestion (newordersuggestion) - breadcrumbs: link back to vendor - order - cancel Order from external source (z3950_search) - breadcrumbs: link to vendor - order - after ordering: neworderenry > edit record Order new (neworderentry) - breadcrumbs: link to vendor - save - cancel Receive shiptment (parcels) - breadcrumbs: link to vendor - cancel Order receive (parcel) - Finish receiving - Cancel receiving - link to order line - receive - BROKEN: delete order redirects to wrong page - BROKEN: delete order and catalog record redirects to wrong page Late orders (lateorders) - filter on specific vendor Follow-up fixes for Bug 7113, Standardize vendor id name in templates and scripts Fixed: - Edit vendor: redirect after saving - redirect after saving/editing/adding contract - edit vendor from toolbar - does not open edit page Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> 1) redirect after editing vendor is ok 2) saving and deleting contract is perfect, one little improvement: The cancel link takes you back to the list of contracts, not to the vendor detail page. I think it would be a little better if save and cancel redirected to the same page. 3) editing vendor from basket group toolbar works now [SIGNED-OFF] Bug 7113 Fix for a missed instance of the wrong variable name Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Link back to vendor in breadcrumbs of contract page works now too. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart@biblibre.co | |m --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> 2012-01-19 11:07:30 UTC --- This patch doesn't apply, conflict in z3950_search.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt ps: I think occurrences in C4/Acquisition.pm can be replaced easily. For example: if (defined $supplierid) { $from .= ' AND aqbasket.booksellerid = ? '; push @query_params, $supplierid; } -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6767|0 |1 is obsolete| | --- Comment #17 from Owen Leonard <oleonard@myacpl.org> 2012-01-20 17:31:38 UTC --- Created attachment 7261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7261 Revised for current master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|Patch doesn't apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-01-22 20:50:26 UTC --- Hi Owen, the patch does not apply any longer - I took a look at the problems but was not completely sure how to fix. Could you resubmit? I will try to test again as soon as poosible. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7261|0 |1 is obsolete| | --- Comment #19 from Owen Leonard <oleonard@myacpl.org> 2012-01-26 14:37:54 UTC --- Created attachment 7337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7337 Bug 7113 [REVISED] Standardize vendor id name in templates and scripts New revision updates for current master and cleans up new instances introduced by recent commits. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7337|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-01-27 07:34:36 UTC --- Created attachment 7345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7345 [SIGNED-OFF] Bug 7113: Standardize vendor id name in templates and scripts New revision updates for current master and cleans up new instances introduced by recent commits. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> 2 problems found, fixing those in follo up patches: - late orders don't allow more than 1 order to be selected - basketgroups: 'Edit vendor' does the same as 'Manage orders' -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-01-27 07:34:51 UTC --- Created attachment 7346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7346 Bug 7113: Fix 'Edit vendor' link on basketgroup page 'Edit vendor' didn't open the vendor page for editing. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-01-27 07:34:58 UTC --- Created attachment 7347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7347 Bug 7133: Late orders don't allow to select more than one order To test: 1) Make sure you have at least 2 late orders each for 2 different vendors 2) Filter list to show only late orders of one vendor 3) Use Check all/Uncheck all 4) Select more than 1 order manually 5) Remove filter on vendor, show all late orders 6) When checking an order from one vendor, checkboxes for other vendors get blocked 7) Check you can select all late orders for one vendor -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7347|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2012-01-27 07:51:44 UTC --- Created attachment 7348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7348 Bug 7133: Late orders don't allow to select more than one order To test: Fix selection of orders from vendors 1) Make sure you have at least 2 late orders each for 2 different vendors 2) Filter list to show only late orders of one vendor 3) Use Check all/Uncheck all 4) Select more than 1 order manually 5) Remove filter on vendor, show all late orders 6) When checking an order from one vendor, checkboxes for other vendors get blocked 7) Check you can select all late orders for one vendor Display fix: show vendor id in first column instead of () 1) Veryfy first column of table looks something like: (2) 19/01/2012 (8 days) and has no empty () -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7346|0 |1 is obsolete| | --- Comment #24 from Owen Leonard <oleonard@myacpl.org> 2012-01-27 15:28:26 UTC --- Created attachment 7355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7355 [SIGNED-OFF] Bug 7113: Fix 'Edit vendor' link on basketgroup page -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7348|0 |1 is obsolete| | --- Comment #25 from Owen Leonard <oleonard@myacpl.org> 2012-01-27 16:05:54 UTC --- Created attachment 7356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7356 [SIGNED-OFF] Bug 7133: Late orders don't allow to select more than one order All tests listed in the patch description pass for me. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |rel_3_8 Severity|normal |enhancement --- Comment #26 from Paul Poulain <paul.poulain@biblibre.com> 2012-02-17 18:21:30 UTC --- QA comment: * I agree that this could be considered as a bug, but it changes a lot of things in the API, so setting it for 3.8 * code is OK. * I made a lot of tests, and could not find any problem. The late orders don't show anything, but on master it doesn't either, it must be my test database. passed QA, will push -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7606 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7113 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Works in master. Not to be pushed to 3.6 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org