[Bug 24808] New: Untranslatable strings in results.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24808 Bug ID: 24808 Summary: Untranslatable strings in results.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Untranslatable "No cover image available" twice in koha-tmpl/intranet-tmpl/prog/js/pages/results.js: $(this).parent().html('<span class="no-image">No cover image available</span>'); -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24808 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23885 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23885 [Bug 23885] Move staff client search results JavaScript into separate file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24808 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 103891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103891&action=edit Bug 24808: enable translation on results.js String sorrounded by "__()" To test: 1) create translation files for a language (cd misc/translator; ./translate create xx-YY) 2) Check string egrep -l "No cover image available" misc/translator/po/xx-YY-* present in 2 files, opac-bootstrap and staf-prog 3) Apply patch 4) Create files again (cd misc/translator; rm -f po/xx-YY*; ./translate create xx-YY) 5) Check again egrep -l "No cover image available" misc/translator/po/xx-YY-* present in 3 files, new in messages-js -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24808 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | Patch complexity|--- |Trivial patch CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24808 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24808 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24808 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103891|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 103932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103932&action=edit Bug 24808: enable translation on results.js String sorrounded by "__()" To test: 1) create translation files for a language (cd misc/translator; ./translate create xx-YY) 2) Check string egrep -l "No cover image available" misc/translator/po/xx-YY-* present in 2 files, opac-bootstrap and staf-prog 3) Apply patch 4) Create files again (cd misc/translator; rm -f po/xx-YY*; ./translate create xx-YY) 5) Check again egrep -l "No cover image available" misc/translator/po/xx-YY-* present in 3 files, new in messages-js Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24808 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24808 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103932|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 104141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104141&action=edit Bug 24808: enable translation on results.js String sorrounded by "__()" To test: 1) create translation files for a language (cd misc/translator; ./translate create xx-YY) 2) Check string egrep -l "No cover image available" misc/translator/po/xx-YY-* present in 2 files, opac-bootstrap and staf-prog 3) Apply patch 4) Create files again (cd misc/translator; rm -f po/xx-YY*; ./translate create xx-YY) 5) Check again egrep -l "No cover image available" misc/translator/po/xx-YY-* present in 3 files, new in messages-js Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24808 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24808 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24808 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Keywords|rel_20_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24808 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #5 from Joy Nelson <joy@bywatersolutions.com> --- koha-tmpl/intranet-tmpl/prog/js/pages/results.js does not exist in 19.11 patch not applicable to 19.11 not backported -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org