[Bug 33340] New: Correct formatting of English 1-page order PDF when the basket group covers multiple pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 Bug ID: 33340 Summary: Correct formatting of English 1-page order PDF when the basket group covers multiple pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: alexbuckley@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Created attachment 148731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148731&action=edit English 1-page order PDF covering multiple pages with page number obscured and table starting halfway down second page Currently, when a basket group contains a lot of ordered items (more than be listed on one page) the following happens: - The page numbers at the bottom of the first page are obscured. - The table on the second page starts halfway down the page. See the attachment as an example. We would like the page numbers on the first page to be visible, and the table to start near the top of the second (and all subsequent pages). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31257 Change sponsored?|--- |Sponsored Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |alexbuckley@catalyst.net.nz |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31257 [Bug 31257] Add a new English 1 page layout to export a basket as PDF -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 148732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148732&action=edit Bug 33340: Correct formatting of English 1-page order PDF when it covers multiple pages If a basket group contains many ordered items then this patchset will ensure: - The page number at the bottom of the first page is not obscured - The table of ordered items does not start half way down the second page Test plan: 1) Go to Koha Administration -> Libraries. Ensure Library A has an address, phone and fax. 2) Go to Koha Administration -> System preferences. Search for OrderPdfFormat. Set this to English 1-page layout option. 3) Go to Acquisitions. Use an existing vendor or create a new one. Ensure the vendor has a postal address, phone, fax and accout number. 4) Create a basket for this vendor. Add many orders to this basket, for example 25 items (this is to make the Order PDF cover multiple pages). 5) Close the basket and add it to a basket group of the same name. 6) Edit the basket group. Add an address in the delivery place, and a delivery comment. Check the box to close the basket group and Save. 7) Click the button to Export as PDF. 8) View the exported PDF. Confirm the PDF is multiple pages long. If it is not then re-open the basketgroup and add more orders to the basket and repeat steps 5, 6, 7 and 8 9) If the PDF is multiple pages long then confirm: - The page numbers at the bottom of the first page are not obscured by the order table. - That the order table starts near the top of the second page, and not half way down. 10) Reopen the basketgroup. Edit the details and remove the delivery place text. Re-close the basketgroup. 10) Repeat steps 7 and 8. Sponsored-by: Pymble Ladies' College -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 148733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148733&action=edit English 1-page order PDF covering multiple pages with formatting fixed - The page numbers at the bottom of the first page not obscured - The table starts near the top of the second page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Ready for testing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148732|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 148764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148764&action=edit Bug 33340: Correct formatting of English 1-page order PDF when it covers multiple pages If a basket group contains many ordered items then this patchset will ensure: - The page number at the bottom of the first page is not obscured - The table of ordered items does not start half way down the second page Test plan: 1) Go to Koha Administration -> Libraries. Ensure Library A has an address, phone and fax. 2) Go to Koha Administration -> System preferences. Search for OrderPdfFormat. Set this to English 1-page layout option. 3) Go to Acquisitions. Use an existing vendor or create a new one. Ensure the vendor has a postal address, phone, fax and accout number. 4) Create a basket for this vendor. Add many orders to this basket, for example 25 items (this is to make the Order PDF cover multiple pages). 5) Close the basket and add it to a basket group of the same name. 6) Edit the basket group. Add an address in the delivery place, and a delivery comment. Check the box to close the basket group and Save. 7) Click the button to Export as PDF. 8) View the exported PDF. Confirm the PDF is multiple pages long. If it is not then re-open the basketgroup and add more orders to the basket and repeat steps 5, 6, 7 and 8 9) If the PDF is multiple pages long then confirm: - The page numbers at the bottom of the first page are not obscured by the order table. - That the order table starts near the top of the second page, and not half way down. 10) Reopen the basketgroup. Edit the details and remove the delivery place text. Re-close the basketgroup. 10) Repeat steps 7 and 8. Sponsored-by: Pymble Ladies' College Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33393 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33393 [Bug 33393] Modify sentence above the order table in English 1-page order PDF -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148764|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 150384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150384&action=edit Bug 33340: Correct formatting of English 1-page order PDF when it covers multiple pages If a basket group contains many ordered items then this patchset will ensure: - The page number at the bottom of the first page is not obscured - The table of ordered items does not start half way down the second page Test plan: 1) Go to Koha Administration -> Libraries. Ensure Library A has an address, phone and fax. 2) Go to Koha Administration -> System preferences. Search for OrderPdfFormat. Set this to English 1-page layout option. 3) Go to Acquisitions. Use an existing vendor or create a new one. Ensure the vendor has a postal address, phone, fax and accout number. 4) Create a basket for this vendor. Add many orders to this basket, for example 25 items (this is to make the Order PDF cover multiple pages). 5) Close the basket and add it to a basket group of the same name. 6) Edit the basket group. Add an address in the delivery place, and a delivery comment. Check the box to close the basket group and Save. 7) Click the button to Export as PDF. 8) View the exported PDF. Confirm the PDF is multiple pages long. If it is not then re-open the basketgroup and add more orders to the basket and repeat steps 5, 6, 7 and 8 9) If the PDF is multiple pages long then confirm: - The page numbers at the bottom of the first page are not obscured by the order table. - That the order table starts near the top of the second page, and not half way down. 10) Reopen the basketgroup. Edit the details and remove the delivery place text. Re-close the basketgroup. 10) Repeat steps 7 and 8. Sponsored-by: Pymble Ladies' College Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 --- Comment #7 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Thank you Tomás! Could we please request that this enhancement be backported to 22.11.x? Our client who sponsored the enhancement would love to benefit from having it sooner than their next major upgrade in Jan-March next year. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |If a basket group contains release notes| |many order lines, this will | |ensure: | | * The page number | |at the bottom of the first | |page is not obscured. | | * | |The table of ordered items | |does not start half way | |down the second page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.07 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 --- Comment #8 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33340 --- Comment #9 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Thank you very much indeed for backporting this to 22.11.x. It is hugely appreciated by us and the client who sponsored it. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org