[Bug 9236] New: deleting an order when receiving redirects to closed basket
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 Bug ID: 9236 Summary: deleting an order when receiving redirects to closed basket Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.8 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nengard@gmail.com When you're receiving if you click 'Delete' to the right of an order line it redirects you to the closed basket not back to the receiving page where you were. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 13995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13995&action=edit Bug 9236: FIX delete order when receiving Before this patch the "delete order" links were broken on the receiving page (parcel.pl) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #2 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- I tested the patch : it works, "Delete order" suppress the command line, and "Delete order and catalog record" suppress the command line and the record. But one point can be improved : After deletion, we are redirected to basket page. I think we should stay in receipt page. It would be much more convenient for staff receiving parcels. M. Saby Rennes 2 University -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Mathieu, Thanks for testing. It is not the goal of this patch. The only ambition of this patch is to fix a bug and not to change the previous behaviour. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hum... You are right, it is the subject of the ticket :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 --- Comment #5 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- I was about to sign it off... But I realized the problem was described in slighlty different way in this BZ and in Biblibre Mantis. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14039&action=edit Bug 9236 : Redirect to the parcel page after deleting an item/order -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 --- Comment #7 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- I applied the 2 patches. It does not work : I am still redirected to the basket and not to the Receipt Summary. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #7)
I applied the 2 patches. It does not work : I am still redirected to the basket and not to the Receipt Summary.
M. Saby
Could you confirm me that you are on the acqui/parcel.pl?invoiceid=XXX, you click on the link "Delete order" or "Delete order and catalog record", you confirm the message and you are redirected on acqui/basket.pl?basketno=YYY ? If yes, could you add a console.log with the string ("addorder.pl?ordernumber="+ordernumber+"&basketno="+basketno+"&quantity=0&biblionumber="+biblionumber+"&invoiceid=[% invoiceid %]") just before the window.location (parcel.tt l.83). Do you test on a sandbox ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 --- Comment #9 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- I am on my own VM, rebased to master, but maybe did something wrong... I am on the page acqui/parcel.pl?invoiceid=8 "Receipt summary for fournisseur1 [ qq ] on 12/12/2012 "... I have 1 command line (same thing with 2 command lines...): basket 7 order line 10 summary q qty 1 unit cost 18 order cost 18 fund bu-1-2 I click on "delete order" for this command line. ("addorder.pl?ordernumber="+ordernumber+"&basketno="+basketno+"&quantity=0&biblionumber="+biblionumber+"&invoiceid=[% invoiceid %]") = addorder.pl?ordernumber=10&basketno=7&quantity=0&biblionumber=6014&invoiceid=8 And after validation, I arrive on this page : acqui/basket.pl?basketno=7 M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14039|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14045&action=edit Bug 9236 : Redirect to the parcel page after deleting an item/order -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- Ooops! I forgot to add a file to the patch, sorry! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13995|0 |1 is obsolete| | --- Comment #12 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 14047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14047&action=edit [PATCH] Bug 9236: FIX delete order when receiving Before applying the patch, when recieving a parcel, if you delete an order line, Koha tries to open the page of the basket linked to that order, but can not find it. Koha displays "Vendor not found". With the patch, Koha finds the right basket. I Sign off this patch, to be applied with the other patch ("Redirect to the parcel page after deleting an item/order") M. Saby Rennes 2 University -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14045|0 |1 is obsolete| | --- Comment #13 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 14048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14048&action=edit [PATCH] Bug 9236 : Redirect to the parcel page after deleting an item/order Before this patch, when receiving a parcel, after deleting an orderline, Koha tries to open the basket linked to this order. With this patch applied, Koha redirect to the reception page. Works with "Delete order" and "Deleter order and record" I sign off. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |3.10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |3.8 --- Comment #14 from Nicole C. Engard <nengard@gmail.com> --- Thanks for this, but the bug I reported was in version 3.8.5 ... and the version has been changed on this. Is this patch just for 3.10? Changing the version back to 3.8. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 --- Comment #15 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- I am not sure for the version. We have 2 problems in 3.10, resolved by the 2 patches. But maybe in 3.8 we have only the pbm resolved by this one : [PATCH] Bug 9236 : Redirect to the parcel page after deleting an item/order M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14047|0 |1 is obsolete| | Attachment #14048|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 14729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14729&action=edit [SIGNED-OFF] Bug 9236: FIX delete order when receiving Before this patch the "delete order" links were broken on the receiving page (parcel.pl) Signed-off-by: mathieu saby <mathieu.saby@univ-rennes2.fr> Before applying the patch, when recieving a parcel, if you delete an order line, Koha tries to open the page of the basket linked to that order, but can not find it. Koha displays "Vendor not found". With the patch, Koha finds the right basket. I Sign off this patch, to be applied with the other patch ("Redirect to the parcel page after deleting an item/order") Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 14730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14730&action=edit [SIGNED-OFF] Bug 9236 : Redirect to the parcel page after deleting an item/order Signed-off-by: mathieu saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> 1) Receive shipment for a previously created basket with multiple order lines 2) Verify 'Delete order' links only have 2 parameters and when you delete an order, you are not redirected to the basket. 3) Verify the same is true for 'Delete order and catalog record'. 4) Apply both patches from Bug 9236. 5) Redo tests and verify page redirects correctly now. Links now also show the basket number as third parameter. Also: make sure orders/items and records are deleted correctly. Passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9236 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #19 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.3 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org