[Bug 31404] New: Update circulation sidebar to match circulation start page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31404 Bug ID: 31404 Summary: Update circulation sidebar to match circulation start page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org There are some discrepancies between the circuation sidebar (activated by CircSidebar) and the circulation start page: * Headings don't match up: Holds, transfers and overdues are missing * Transfer needs to be moved under transfers heading * Transfers to send is missing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31404 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Assignee|oleonard@myacpl.org |isobel.graham09@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31404 --- Comment #1 from Isobel Graham <isobel.graham09@gmail.com> --- Created attachment 140006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140006&action=edit Bug 31404: Sync Circulation sidebar with Circulation home This patch syncs the content of the circulation sidebar navigation with the content of the circulation homepage Test plan 1. Enable the `CircSidebar` system preference 2. Compare the sidebar navigation on circulation pages with the content of the circulation homepage. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31404 Isobel Graham <isobel.graham09@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31404 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31404 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140006|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 140167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140167&action=edit Bug 31404: Sync Circulation sidebar with Circulation home This patch syncs the content of the circulation sidebar navigation with the content of the circulation homepage Test plan 1. Enable the `CircSidebar` system preference 2. Compare the sidebar navigation on circulation pages with the content of the circulation homepage. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31404 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31404 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31404 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140167|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 140278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140278&action=edit Bug 31404: Sync Circulation sidebar with Circulation home This patch syncs the content of the circulation sidebar navigation with the content of the circulation homepage Test plan 1. Enable the `CircSidebar` system preference 2. Compare the sidebar navigation on circulation pages with the content of the circulation homepage. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31404 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 140279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140279&action=edit Bug 31404: (QA follow-up) Mostly whitespace fixes * Removed the leading space from the new entries as this could lead to another string to translate and they are not needed * Removed some doubled up whitespaces from the <a> tags and a stray - * Removed title from Article requests since it was the same text as the link itself, not adding information Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31404 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Nice clean-up, thx Isobel! I have provided a small follow-up fixing some whitespace issues. I know spaces don't seem so important, but in programming one character often can make a big difference. In this case I was worried it might affect translations. We have to translate every string in Koha and often the only difference between 'the same' string might be a leading or trailing space, capitalization etc. Please keep the patches coming! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31404 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31404 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31404 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to master |RESOLVED --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply cleanly to 22.05.x so it will not be included in the 22.05.x series -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org