[Bug 8844] New: UNIMARC_sync_date_created_with_marc_biblio.pl creates a modification log
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8844 Priority: P5 - low Change sponsored?: --- Bug ID: 8844 Assignee: gmcharlt@gmail.com Summary: UNIMARC_sync_date_created_with_marc_biblio.pl creates a modification log Severity: normal Classification: Unclassified OS: All Reporter: fridolyn.somers@biblibre.com Hardware: All Status: NEW Version: master Component: Command-line Utilities Product: Koha When using UNIMARC_sync_date_created_with_marc_biblio.pl script with CataloguingLog on, you get a modification log on all catalog. Script should not call ModBiblio() when dates are already synchronized. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8844 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 12598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12598&action=edit Proposed patch Proposed patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8844 --- Comment #2 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Script now does not call ModBiblio() when dates are already synchronized. And many more : + help usage with -h + verbose option to print several infos (count biblios, which biblio has been modified, ...) + manages DEBUG env var to print even more + 'where' option to limit process to some biblios (usefull to test and to run incremental modifications) + 099$c and 099$d are default values but you can specify what fields you use for date created and date last modified (works with control fields < 010) + test mode : if 'run' option is missing, script still shows which biblio would have been modified -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8844 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12598|0 |1 is obsolete| | --- Comment #3 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 13016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13016&action=edit Proposed patch (revised) Patch revised. Control fields (<10) where not created if missing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8844 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #4 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- I made some tests with a standard and non-standard unimarc configuration. It is working properly (the right fields and subfields are edited in the records). Ex for a non-standard configuration: UNIMARC_sync_date_created_with_marc_biblio.pl -v -run -c 099b -m 099c I also tested the where option. It is working too (if the SQL limitation contains several words, you need to put into " ") Ex : UNIMARC_sync_date_created_with_marc_biblio.pl -v --where "biblionumber between 1 and 4" => "Number of concerned biblios: 4" So I sign off. Mathieu Saby Rennes 2 University -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8844 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #5 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #4)
So I sign off.
Mathieu Saby Rennes 2 University
Mathieu, will you please add you sign-off to the patch? i might have to pass on this QA, i no not have a UNIMARC koha configured Marcel, could you QA this one? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8844 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13016|0 |1 is obsolete| | --- Comment #6 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 13339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13339&action=edit Proposed patch (revised) Is it ok for you ? (This is my first sign off in BZ...) Mathieu Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8844 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #6)
Created attachment 13339 [details] Proposed patch (revised)
Is it ok for you ? (This is my first sign off in BZ...) Yes, the signoff is OK
(and, to answer here the PM you sent me = you should really use git-bz, it's a wonderful tool. Really !) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8844 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * no string changes * passes koha-qa.pl (the script reports forbidden patterns FAIL The patch introduces a forbidden pattern: merge marker (=======) (49) that is wrong, the ==== are included in a warn, and perfectly valid. Will report the problem to QA team * UNIMARC only script & maintainance only script, no side effect risk passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8844 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13339|0 |1 is obsolete| | --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 13548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13548&action=edit Bug 8844: UNIMARC_sync_date_created_with_marc_biblio.pl creates a modification log Signed-off by : Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8844 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.10 QA Contact| |paul.poulain@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8844 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |jcamins@cpbibliography.com --- Comment #10 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. I did not test it personally because I did not have an explanation of what the script does. Since it is a UNIMARC-only script that has been tested by several UNIMARC users, I decided to push it anyway so that it was available for inclusion in 3.10, per Paul's request. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8844 --- Comment #11 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #8)
* passes koha-qa.pl (the script reports forbidden patterns FAIL The patch introduces a forbidden pattern: merge marker (=======) (49) I will remember this point for future patches. I agree that merge markers should be avoided, even in a warn.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8844 --- Comment #12 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #10)
This patch has been pushed to master. I did not test it personally because I did not have an explanation of what the script does. Since it is a UNIMARC-only script that has been tested by several UNIMARC users, I decided to push it anyway so that it was available for inclusion in 3.10, per Paul's request.
Thanks Jared. The purpose of this script in a few words : When creating/saving a biblio, fields datecreated and timestamp will be completed by database engine with current date/timestamp. In UNIMARC, we want MARC datas 090$c and 090$d to be synchronized with biblio.datecreated and biblio.timestamp. But this synchronization does only exist form MARC to database. This script synchronizes database to MARC for biblio.datecreated and biblio.timestamp. It is usually configured in a daily cron. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8844 --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to branch 3.10.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8844 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9192 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8844 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org