[Bug 18138] New: Use MARC modification template when adding/ updating bibliographic records
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Bug ID: 18138 Summary: Use MARC modification template when adding/updating bibliographic records Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: stefan.berndtsson@ub.gu.se QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl When importing records, MARC modification templates can be used to silently remove unwanted tags among other thing. The same thing could be useful when adding/updating bibliographic records from within Koha. I therefor propose an addition of a SysPref to set a default template to use in AddBiblio and ModBiblio before TransformMarcToKoha is called. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 --- Comment #1 from David Gustafsson <glasklas@gmail.com> --- Created attachment 61442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61442&action=edit Bug 18138: Use MARC modification template when adding/updating bibliographic records Add a preference that enables a specific marc modification template to be applied on bibliographic records saved using simple or advanced MARC editor or the HTTP API. To test: 1) Create a MARC modification template containg one or more actions. 2) Under "Global system preferences" and "Cataloging" set the "EditBiblioMarcModificationTemplate" prefernce to the name of the previously created template. 3) Edit (or create) a bibliographic record using either simple or advanced MARC editor. 4) Save the record. 5) Verify that the action(s) have been applied. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61442|0 |1 is obsolete| | --- Comment #2 from David Gustafsson <glasklas@gmail.com> --- Created attachment 61443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61443&action=edit Bug 18138: Use MARC modification template when adding/updating bibliographic records Add a preference that enables a specific marc modification template to be applied on bibliographic records saved using simple or advanced MARC editor or the HTTP API. To test: 1) Create a MARC modification template containg one or more actions. 2) Under "Global system preferences" and "Cataloging" set the "EditBiblioMarcModificationTemplate" preference to the name of the previously created template. 3) Edit (or create) a bibliographic record using either the simple or advanced MARC editor. 4) Save the record. 5) Verify that the action(s) have been applied. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61443|0 |1 is obsolete| | --- Comment #3 from David Gustafsson <glasklas@gmail.com> --- Created attachment 61734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61734&action=edit Bug 18138: Use MARC modification template when adding/updating bibliographic records Add a preference that enables a specific marc modification template to be applied on bibliographic records saved using simple or advanced MARC editor or the HTTP API. To test: 1) Create a MARC modification template containg one or more actions. 2) Under "Global system preferences" and "Cataloging" set the "EditBiblioMarcModificationTemplate" preference to the name of the previously created template. 3) Edit (or create) a bibliographic record using either the simple or advanced MARC editor. 4) Save the record. 5) Verify that the action(s) have been applied. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |glasklas@gmail.com --- Comment #4 from David Gustafsson <glasklas@gmail.com> --- Added some tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Frank Hansen <frank.hansen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frank.hansen@ub.lu.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Hugh Rundle <hughr@brimbank.vic.gov.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hughr@brimbank.vic.gov.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Andreas Roussos <arouss1980@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arouss1980@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61734|0 |1 is obsolete| | --- Comment #5 from David Gustafsson <glasklas@gmail.com> --- Created attachment 82783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82783&action=edit Bug 18138: Use MARC modification template when adding/updating bibliographic records Add a preference that enables a specific marc modification template to be applied on bibliographic records saved using simple or advanced MARC editor or the HTTP API. To test: 1) Create a MARC modification template containg one or more actions. 2) Under "Global system preferences" and "Cataloging" set the "EditBiblioMarcModificationTemplate" preference to the name of the previously created template. 3) Edit (or create) a bibliographic record using either the simple or advanced MARC editor. 4) Save the record. 5) Verify that the action(s) have been applied. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #6 from David Gustafsson <glasklas@gmail.com> --- Rebase against master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82783|0 |1 is obsolete| | --- Comment #7 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 86617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86617&action=edit Bug 18138: Use MARC modification template when adding/updating bibliographic records Add a preference that enables a specific marc modification template to be applied on bibliographic records saved using simple or advanced MARC editor or the HTTP API. To test: 1) Create a MARC modification template containg one or more actions. 2) Under "Global system preferences" and "Cataloging" set the "EditBiblioMarcModificationTemplate" preference to the name of the previously created template. 3) Edit (or create) a bibliographic record using either the simple or advanced MARC editor. 4) Save the record. 5) Verify that the action(s) have been applied. Sponsored-by: Gothenburg University Library Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Frank Hansen <frank.hansen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Frank Hansen <frank.hansen@ub.lu.se> --- Signed off after testing that it works for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|gmcharlt@gmail.com |glasklas@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, but there are some issues: 1) The new preference needs to be added to sysprefs.sql 2) The QA script fails (easy fix): FAIL t/db_dependent/www/EditBiblioMarcModificationTemplatePreference.t OK critic FAIL forbidden patterns forbidden pattern: tab char (line 47) forbidden pattern: tab char (line 49) forbidden pattern: tab char (line 75) forbidden pattern: tab char (line 76) forbidden pattern: tab char (line 77) forbidden pattern: tab char (line 78) forbidden pattern: tab char (line 79) forbidden pattern: tab char (line 81) forbidden pattern: tab char (line 82) 3) The tests fail: # Subtest: Templates applied using simple and advanced MARC Editor 1..13 ok 1 - MARC modification template successfully created ok 2 - MARC modification template action successfully created # Looks like you planned 13 tests but ran 2. not ok 1 - Templates applied using simple and advanced MARC Editor # Failed test 'Templates applied using simple and advanced MARC Editor' # at t/db_dependent/www/EditBiblioMarcModificationTemplatePreference.t line 154. Can't use string ("444") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/C4/Biblio.pm line 1162. # Looks like your test exited with 255 just after 1. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/1 subtests 4) I think maybe we should remove "Edit" from the preference name if it also applies on saving. Maybe: UseMarcModificationTemplate or DefaultMarcModificationTemplate? Native speakers might have other ideas. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- For future use it might be nice to have a setting on framework level too and some note on saving that that modifications have been made. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86617|0 |1 is obsolete| | --- Comment #11 from David Gustafsson <glasklas@gmail.com> --- Created attachment 110266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110266&action=edit Bug 18138: Use MARC modification template when adding/updating bibliographic records Add a preference that enables a specific marc modification template to be applied on bibliographic records saved using simple or advanced MARC editor or the HTTP API. To test: 1) Create a MARC modification template containg one or more actions. 2) Under "Global system preferences" and "Cataloging" set the "EditBiblioMarcModificationTemplate" preference to the name of the previously created template. 3) Edit (or create) a bibliographic record using either the simple or advanced MARC editor. 4) Save the record. 5) Verify that the action(s) have been applied. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 --- Comment #12 from David Gustafsson <glasklas@gmail.com> --- Created attachment 110269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110269&action=edit Bug 18138: Rename system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 --- Comment #13 from David Gustafsson <glasklas@gmail.com> --- Created attachment 110270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110270&action=edit Bug 18138: Add system preference to sysprefs.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 --- Comment #14 from David Gustafsson <glasklas@gmail.com> --- Created attachment 110272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110272&action=edit Bug 18138: Fix tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 --- Comment #15 from David Gustafsson <glasklas@gmail.com> --- @Katrin Fischer Thank you for taking the time for review and feedback. The issues should now be addressed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #16 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Hi, nice work. I see : my $template = firstval { $_->{'name'} eq $marc_modification_template_name } GetModificationTemplates(); Looks odd to me. Indeed marc modification template name is not unique. I think this can be buggy. I suggest add unique constraint to marc modification template name or store marc modification template id for this feature. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- Setting to "Failed QA" based on Comment 16. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simon.hohl@dainst.org --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- *** Bug 24836 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27978 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110266|0 |1 is obsolete| | --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 118439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118439&action=edit Bug 18138: Use MARC modification template when adding/updating bibliographic records Add a preference that enables a specific marc modification template to be applied on bibliographic records saved using simple or advanced MARC editor or the HTTP API. To test: 1) Create a MARC modification template containg one or more actions. 2) Under "Global system preferences" and "Cataloging" set the "EditBiblioMarcModificationTemplate" preference to the name of the previously created template. 3) Edit (or create) a bibliographic record using either the simple or advanced MARC editor. 4) Save the record. 5) Verify that the action(s) have been applied. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110269|0 |1 is obsolete| | --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 118440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118440&action=edit Bug 18138: Rename system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110270|0 |1 is obsolete| | --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 118441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118441&action=edit Bug 18138: Add system preference to sysprefs.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110272|0 |1 is obsolete| | --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 118442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118442&action=edit Bug 18138: Fix tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 118443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118443&action=edit Bug 18138: (follow-up) Add Objects for MarcModificationTemplates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 --- Comment #24 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 118444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118444&action=edit Bug 18138: (follow-up) Adjust the system preference editor to allow choosing a modification template Rather than expecting the librarian to add an ID or a name we should provide a dropdown To test: 1 - Apply all patches 2 - Search for sytem preference 'SaveBiblioMarcModificationTemplate' 3 - Note it list all defined Marc modification templates 4 - Select one 5 - confirm value in DB is the template id -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Frank Hansen <frank.hansen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Frank Hansen <frank.hansen@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118444|0 |1 is obsolete| | --- Comment #25 from Frank Hansen <frank.hansen@ub.lu.se> --- Created attachment 118824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118824&action=edit Bug 18138: (follow-up) Adjust the system preference editor to allow choosing a modification template Rather than expecting the librarian to add an ID or a name we should provide a dropdown To test: 1 - Apply all patches 2 - Search for sytem preference 'SaveBiblioMarcModificationTemplate' 3 - Note it list all defined Marc modification templates 4 - Select one 5 - confirm value in DB is the template id Works fine for me Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- prove t/db_dependent/www/EditBiblioMarcModificationTemplatePreference.t t/db_dependent/www/EditBiblioMarcModificationTemplatePreference.t .. Warning: <retrieval> element has non-unique value in 'name' key attribute: F at t/db_dependent/www/EditBiblioMarcModificationTemplatePreference.t line 36. Warning: <retrieval> element has non-unique value in 'name' key attribute: B at t/db_dependent/www/EditBiblioMarcModificationTemplatePreference.t line 36. GetMarcBiblio called with undefined biblionumber at t/db_dependent/www/EditBiblioMarcModificationTemplatePreference.t line 85. # Looks like you planned 13 tests but ran 2. t/db_dependent/www/EditBiblioMarcModificationTemplatePreference.t .. 1/1 # Failed test 'Templates applied using simple and advanced MARC Editor' # at t/db_dependent/www/EditBiblioMarcModificationTemplatePreference.t line 154. Can't call method "field" on an undefined value at t/db_dependent/www/EditBiblioMarcModificationTemplatePreference.t line 86. # Looks like your test exited with 255 just after 1. t/db_dependent/www/EditBiblioMarcModificationTemplatePreference.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/1 subtests Test Summary Report ------------------- t/db_dependent/www/EditBiblioMarcModificationTemplatePreference.t (Wstat: 65280 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 255 Files=1, Tests=1, 4 wallclock secs ( 0.02 usr 0.00 sys + 1.79 cusr 0.27 csys = 2.08 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 120709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120709&action=edit Bug 18138: (QA follow-up) Fix QA script issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118824|0 |1 is obsolete| | --- Comment #28 from David Gustafsson <glasklas@gmail.com> --- Created attachment 123125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123125&action=edit Bug 18138: (follow-up) Adjust the system preference editor to allow choosing a modification template Rather than expecting the librarian to add an ID or a name we should provide a dropdown To test: 1 - Apply all patches 2 - Search for sytem preference 'SaveBiblioMarcModificationTemplate' 3 - Note it list all defined Marc modification templates 4 - Select one 5 - confirm value in DB is the template id Works fine for me Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118439|0 |1 is obsolete| | --- Comment #29 from David Gustafsson <glasklas@gmail.com> --- Created attachment 123127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123127&action=edit Bug 18138: Use MARC modification template when adding/updating bibliographic records Add a preference that enables a specific marc modification template to be applied on bibliographic records saved using simple or advanced MARC editor or the HTTP API. To test: 1) Create a MARC modification template containg one or more actions. 2) Under "Global system preferences" and "Cataloging" set the "EditBiblioMarcModificationTemplate" preference to the name of the previously created template. 3) Edit (or create) a bibliographic record using either the simple or advanced MARC editor. 4) Save the record. 5) Verify that the action(s) have been applied. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118440|0 |1 is obsolete| | --- Comment #30 from David Gustafsson <glasklas@gmail.com> --- Created attachment 123128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123128&action=edit Bug 18138: Rename system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118441|0 |1 is obsolete| | --- Comment #31 from David Gustafsson <glasklas@gmail.com> --- Created attachment 123129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123129&action=edit Bug 18138: Add system preference to sysprefs.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118442|0 |1 is obsolete| | --- Comment #32 from David Gustafsson <glasklas@gmail.com> --- Created attachment 123130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123130&action=edit Bug 18138: Fix tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118443|0 |1 is obsolete| | --- Comment #33 from David Gustafsson <glasklas@gmail.com> --- Created attachment 123131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123131&action=edit Bug 18138: (follow-up) Add Objects for MarcModificationTemplates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120709|0 |1 is obsolete| | --- Comment #34 from David Gustafsson <glasklas@gmail.com> --- Created attachment 123132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123132&action=edit Bug 18138: (QA follow-up) Fix QA script issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123125|0 |1 is obsolete| | --- Comment #35 from David Gustafsson <glasklas@gmail.com> --- Created attachment 123133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123133&action=edit Bug 18138: (follow-up) Adjust the system preference editor to allow choosing a modification template Rather than expecting the librarian to add an ID or a name we should provide a dropdown To test: 1 - Apply all patches 2 - Search for sytem preference 'SaveBiblioMarcModificationTemplate' 3 - Note it list all defined Marc modification templates 4 - Select one 5 - confirm value in DB is the template id Works fine for me Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123133|0 |1 is obsolete| | --- Comment #36 from David Gustafsson <glasklas@gmail.com> --- Created attachment 123137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123137&action=edit Bug 18138: (follow-up) Adjust the system preference editor to allow choosing a modification template Rather than expecting the librarian to add an ID or a name we should provide a dropdown To test: 1 - Apply all patches 2 - Search for sytem preference 'SaveBiblioMarcModificationTemplate' 3 - Note it list all defined Marc modification templates 4 - Select one 5 - confirm value in DB is the template id Works fine for me Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123128|0 |1 is obsolete| | --- Comment #37 from David Gustafsson <glasklas@gmail.com> --- Created attachment 124466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124466&action=edit Bug 18138: Rename system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123129|0 |1 is obsolete| | --- Comment #38 from David Gustafsson <glasklas@gmail.com> --- Created attachment 124467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124467&action=edit Bug 18138: Add system preference to sysprefs.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123130|0 |1 is obsolete| | --- Comment #39 from David Gustafsson <glasklas@gmail.com> --- Created attachment 124468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124468&action=edit Bug 18138: Fix tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123131|0 |1 is obsolete| | --- Comment #40 from David Gustafsson <glasklas@gmail.com> --- Created attachment 124469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124469&action=edit Bug 18138: (follow-up) Add Objects for MarcModificationTemplates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123132|0 |1 is obsolete| | --- Comment #41 from David Gustafsson <glasklas@gmail.com> --- Created attachment 124470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124470&action=edit Bug 18138: (QA follow-up) Fix QA script issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123137|0 |1 is obsolete| | --- Comment #42 from David Gustafsson <glasklas@gmail.com> --- Created attachment 124471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124471&action=edit Bug 18138: (follow-up) Adjust the system preference editor to allow choosing a modification template Rather than expecting the librarian to add an ID or a name we should provide a dropdown To test: 1 - Apply all patches 2 - Search for sytem preference 'SaveBiblioMarcModificationTemplate' 3 - Note it list all defined Marc modification templates 4 - Select one 5 - confirm value in DB is the template id Works fine for me Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123127|0 |1 is obsolete| | --- Comment #43 from David Gustafsson <glasklas@gmail.com> --- Created attachment 124472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124472&action=edit Bug 18138: Use MARC modification template when adding/updating bibliographic records Add a preference that enables a specific marc modification template to be applied on bibliographic records saved using simple or advanced MARC editor or the HTTP API. To test: 1) Create a MARC modification template containg one or more actions. 2) Under "Global system preferences" and "Cataloging" set the "EditBiblioMarcModificationTemplate" preference to the name of the previously created template. 3) Edit (or create) a bibliographic record using either the simple or advanced MARC editor. 4) Save the record. 5) Verify that the action(s) have been applied. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124466|0 |1 is obsolete| | --- Comment #44 from David Gustafsson <glasklas@gmail.com> --- Created attachment 124473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124473&action=edit Bug 18138: Rename system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124467|0 |1 is obsolete| | --- Comment #45 from David Gustafsson <glasklas@gmail.com> --- Created attachment 124474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124474&action=edit Bug 18138: Add system preference to sysprefs.sql -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124468|0 |1 is obsolete| | --- Comment #46 from David Gustafsson <glasklas@gmail.com> --- Created attachment 124475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124475&action=edit Bug 18138: Fix tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124469|0 |1 is obsolete| | --- Comment #47 from David Gustafsson <glasklas@gmail.com> --- Created attachment 124476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124476&action=edit Bug 18138: (follow-up) Add Objects for MarcModificationTemplates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124470|0 |1 is obsolete| | --- Comment #48 from David Gustafsson <glasklas@gmail.com> --- Created attachment 124477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124477&action=edit Bug 18138: (QA follow-up) Fix QA script issues -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124471|0 |1 is obsolete| | --- Comment #49 from David Gustafsson <glasklas@gmail.com> --- Created attachment 124478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124478&action=edit Bug 18138: (follow-up) Adjust the system preference editor to allow choosing a modification template Rather than expecting the librarian to add an ID or a name we should provide a dropdown To test: 1 - Apply all patches 2 - Search for sytem preference 'SaveBiblioMarcModificationTemplate' 3 - Note it list all defined Marc modification templates 4 - Select one 5 - confirm value in DB is the template id Works fine for me Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #50 from David Gustafsson <glasklas@gmail.com> --- Rebased against master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124472|0 |1 is obsolete| | Attachment #124473|0 |1 is obsolete| | Attachment #124474|0 |1 is obsolete| | Attachment #124475|0 |1 is obsolete| | --- Comment #51 from David Gustafsson <glasklas@gmail.com> --- Created attachment 124484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124484&action=edit Bug 18138: Use MARC modification template when adding/updating bibliographic records Add a preference that enables a specific marc modification template to be applied on bibliographic records saved using simple or advanced MARC editor or the HTTP API. To test: 1) Create a MARC modification template containg one or more actions. 2) Under "Global system preferences" and "Cataloging" set the "EditBiblioMarcModificationTemplate" preference to the name of the previously created template. 3) Edit (or create) a bibliographic record using either the simple or advanced MARC editor. 4) Save the record. 5) Verify that the action(s) have been applied. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124478|0 |1 is obsolete| | --- Comment #52 from David Gustafsson <glasklas@gmail.com> --- Created attachment 124485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124485&action=edit Bug 18138: (follow-up) Adjust the system preference editor to allow choosing a modification template Rather than expecting the librarian to add an ID or a name we should provide a dropdown To test: 1 - Apply all patches 2 - Search for sytem preference 'SaveBiblioMarcModificationTemplate' 3 - Note it list all defined Marc modification templates 4 - Select one 5 - confirm value in DB is the template id Works fine for me Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124476|0 |1 is obsolete| | --- Comment #53 from David Gustafsson <glasklas@gmail.com> --- Created attachment 124486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124486&action=edit Bug 18138: (follow-up) Add Objects for MarcModificationTemplates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124477|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124486|0 |1 is obsolete| | --- Comment #54 from David Gustafsson <glasklas@gmail.com> --- Created attachment 124492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124492&action=edit Bug 18138: (follow-up) Add Objects for MarcModificationTemplates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124485|0 |1 is obsolete| | --- Comment #55 from David Gustafsson <glasklas@gmail.com> --- Created attachment 124493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124493&action=edit Bug 18138: (follow-up) Adjust the system preference editor to allow choosing a modification template Rather than expecting the librarian to add an ID or a name we should provide a dropdown To test: 1 - Apply all patches 2 - Search for sytem preference 'SaveBiblioMarcModificationTemplate' 3 - Note it list all defined Marc modification templates 4 - Select one 5 - confirm value in DB is the template id Works fine for me Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 --- Comment #56 from David Gustafsson <glasklas@gmail.com> --- Did some squashing to clean things up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 --- Comment #57 from Phil Ringnalda <phil@chetcolibrary.org> --- Fails for me in koha-testing-docker startup, with koha_1 | C4::Installer::load_sql returned the following errors while attempting to load /kohadevbox/koha/installer/data/mysql/mandatory/sysprefs.sql: koha_1 | DBD::mysql::st execute failed: Data too long for column 'type' at row 588 at /usr/share/perl5/DBIx/RunSQL.pm line 278, <$args{...}> line 1. koha_1 | Something went wrong loading file /kohadevbox/koha/installer/data/mysql/mandatory/sysprefs.sql ([SQL ERROR]: INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES Looks like at 22 characters, modification-templates doesn't quite fit in a 20 character column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 --- Comment #58 from David Gustafsson <glasklas@gmail.com> --- Created attachment 124991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124991&action=edit Bug 18138: Refactor after using template id instead of name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 --- Comment #59 from David Gustafsson <glasklas@gmail.com> --- (In reply to Phil Ringnalda from comment #57)
Fails for me in koha-testing-docker startup, with
koha_1 | C4::Installer::load_sql returned the following errors while attempting to load /kohadevbox/koha/installer/data/mysql/mandatory/sysprefs.sql: koha_1 | DBD::mysql::st execute failed: Data too long for column 'type' at row 588 at /usr/share/perl5/DBIx/RunSQL.pm line 278, <$args{...}> line 1. koha_1 | Something went wrong loading file /kohadevbox/koha/installer/data/mysql/mandatory/sysprefs.sql ([SQL ERROR]: INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES
Looks like at 22 characters, modification-templates doesn't quite fit in a 20 character column.
That column has length 50 for me, and also in kohastructure.sql. Don't know if you created this table using a different version of Koha. If this can be reproduced will address the issue. Some things in the patch needed adjustment after changing to using template ids instead of name. There is a problem with Elasticsearch in my devbox for recent version of Koha which had not had time to fix, so was not able to properly test the code. Meanwhile submitting and hoping for the best, will get back to properly testing this once this issue has been sorted out. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 --- Comment #60 from Phil Ringnalda <phil@chetcolibrary.org> --- https://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/my... - type is 20, no? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 --- Comment #61 from David Gustafsson <glasklas@gmail.com> --- Created attachment 125157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125157&action=edit Bug 18138: fix atomic update and system preference type -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 --- Comment #62 from David Gustafsson <glasklas@gmail.com> --- (In reply to Phil Ringnalda from comment #60)
https://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/ mysql/kohastructure.sql;h=02cf864ddd7f0f2ca6a921ae2a9045a18e1375f6; hb=HEAD#l4987 - type is 20, no?
Hi! Yes, sorry. I misunderstood. The reason it seamed to work for me and I did not get the crash was (probably) the patch using an old koha format for patch database updates (atomicupdate). My guess is you tried the patch out with a slightly older version of Koha where the old format worked and got the error, and for me it simply did not run (nor produce any errors) and the syspref had been previously added before the type change. I fixed the atomicupdate to use perl-script instead, and shortened the type name. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #63 from Phil Ringnalda <phil@chetcolibrary.org> --- Oof, and then nobody else looked at it for 18 months? Unsurprisingly, patches no longer apply. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 --- Comment #64 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Phil Ringnalda from comment #63)
Oof, and then nobody else looked at it for 18 months?
Unsurprisingly, patches no longer apply.
We are in need for more testers, always. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124484|0 |1 is obsolete| | --- Comment #65 from David Gustafsson <glasklas@gmail.com> --- Created attachment 148004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148004&action=edit Bug 18138: Use MARC modification template when adding/updating bibliographic records Add a preference that enables a specific marc modification template to be applied on bibliographic records saved using simple or advanced MARC editor or the HTTP API. To test: 1) Create a MARC modification template containg one or more actions. 2) Under "Global system preferences" and "Cataloging" set the "EditBiblioMarcModificationTemplate" preference to the name of the previously created template. 3) Edit (or create) a bibliographic record using either the simple or advanced MARC editor. 4) Save the record. 5) Verify that the action(s) have been applied. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124492|0 |1 is obsolete| | --- Comment #66 from David Gustafsson <glasklas@gmail.com> --- Created attachment 148005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148005&action=edit Bug 18138: (follow-up) Add Objects for MarcModificationTemplates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124493|0 |1 is obsolete| | --- Comment #67 from David Gustafsson <glasklas@gmail.com> --- Created attachment 148006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148006&action=edit Bug 18138: (follow-up) Adjust the system preference editor to allow choosing a modification template Rather than expecting the librarian to add an ID or a name we should provide a dropdown To test: 1 - Apply all patches 2 - Search for sytem preference 'SaveBiblioMarcModificationTemplate' 3 - Note it list all defined Marc modification templates 4 - Select one 5 - confirm value in DB is the template id Works fine for me Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124991|0 |1 is obsolete| | --- Comment #68 from David Gustafsson <glasklas@gmail.com> --- Created attachment 148007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148007&action=edit Bug 18138: Refactor after using template id instead of name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125157|0 |1 is obsolete| | --- Comment #69 from David Gustafsson <glasklas@gmail.com> --- Created attachment 148008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148008&action=edit Bug 18138: fix atomic update and system preference type -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 --- Comment #70 from David Gustafsson <glasklas@gmail.com> --- Created attachment 148009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148009&action=edit Bug 18138: Fix variable name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #71 from David Gustafsson <glasklas@gmail.com> --- Thanks for the feedback, have now rebased against master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #72 from Phil Ringnalda <phil@chetcolibrary.org> --- Something's gone wrong with the bit to select a template from a list of template names for the pref: I get no list, though if I enter the id of a template, it seems to be applied just fine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #73 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Phil Ringnalda from comment #72)
Something's gone wrong with the bit to select a template from a list of template names for the pref: I get no list, though if I enter the id of a template, it seems to be applied just fine.
I believe this should have been set to Failed QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148004|0 |1 is obsolete| | --- Comment #74 from David Gustafsson <glasklas@gmail.com> --- Created attachment 157183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157183&action=edit Bug 18138: Use MARC modification template when adding/updating bibliographic records Add a preference that enables a specific marc modification template to be applied on bibliographic records saved using simple or advanced MARC editor or the HTTP API. To test: 1) Create a MARC modification template containg one or more actions. 2) Under "Global system preferences" and "Cataloging" set the "EditBiblioMarcModificationTemplate" preference to the name of the previously created template. 3) Edit (or create) a bibliographic record using either the simple or advanced MARC editor. 4) Save the record. 5) Verify that the action(s) have been applied. Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148005|0 |1 is obsolete| | --- Comment #75 from David Gustafsson <glasklas@gmail.com> --- Created attachment 157184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157184&action=edit Bug 18138: (follow-up) Add Objects for MarcModificationTemplates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148006|0 |1 is obsolete| | --- Comment #76 from David Gustafsson <glasklas@gmail.com> --- Created attachment 157185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157185&action=edit Bug 18138: (follow-up) Adjust the system preference editor to allow choosing a modification template Rather than expecting the librarian to add an ID or a name we should provide a dropdown To test: 1 - Apply all patches 2 - Search for sytem preference 'SaveBiblioMarcModificationTemplate' 3 - Note it list all defined Marc modification templates 4 - Select one 5 - confirm value in DB is the template id Works fine for me Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148007|0 |1 is obsolete| | --- Comment #77 from David Gustafsson <glasklas@gmail.com> --- Created attachment 157186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157186&action=edit Bug 18138: Refactor after using template id instead of name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148008|0 |1 is obsolete| | --- Comment #78 from David Gustafsson <glasklas@gmail.com> --- Created attachment 157187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157187&action=edit Bug 18138: fix atomic update and system preference type -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148009|0 |1 is obsolete| | --- Comment #79 from David Gustafsson <glasklas@gmail.com> --- Created attachment 157188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157188&action=edit Bug 18138: Fix variable name -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 --- Comment #80 from David Gustafsson <glasklas@gmail.com> --- Created attachment 157189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157189&action=edit Bug 18138: Fix tests, system preference specification and options -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157189|0 |1 is obsolete| | --- Comment #81 from David Gustafsson <glasklas@gmail.com> --- Created attachment 157190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157190&action=edit Bug 18138: Fix tests, system preference specification and options -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 --- Comment #82 from David Gustafsson <glasklas@gmail.com> --- Rebased and fixed the issue where templates dropdown for syspref does not appear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157183|0 |1 is obsolete| | --- Comment #83 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 157485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157485&action=edit Bug 18138: Use MARC modification template when adding/updating bibliographic records Add a preference that enables a specific marc modification template to be applied on bibliographic records saved using simple or advanced MARC editor or the HTTP API. To test: 1) Create a MARC modification template containg one or more actions. 2) Under "Global system preferences" and "Cataloging" set the "EditBiblioMarcModificationTemplate" preference to the name of the previously created template. 3) Edit (or create) a bibliographic record using either the simple or advanced MARC editor. 4) Save the record. 5) Verify that the action(s) have been applied. Sponsored-by: Gothenburg University Library Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157184|0 |1 is obsolete| | --- Comment #84 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 157486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157486&action=edit Bug 18138: (follow-up) Add Objects for MarcModificationTemplates Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157185|0 |1 is obsolete| | --- Comment #85 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 157487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157487&action=edit Bug 18138: (follow-up) Adjust the system preference editor to allow choosing a modification template Rather than expecting the librarian to add an ID or a name we should provide a dropdown To test: 1 - Apply all patches 2 - Search for sytem preference 'SaveBiblioMarcModificationTemplate' 3 - Note it list all defined Marc modification templates 4 - Select one 5 - confirm value in DB is the template id Works fine for me Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157186|0 |1 is obsolete| | --- Comment #86 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 157488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157488&action=edit Bug 18138: Refactor after using template id instead of name Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157187|0 |1 is obsolete| | --- Comment #87 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 157489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157489&action=edit Bug 18138: fix atomic update and system preference type Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157188|0 |1 is obsolete| | --- Comment #88 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 157490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157490&action=edit Bug 18138: Fix variable name Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157190|0 |1 is obsolete| | --- Comment #89 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 157491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157491&action=edit Bug 18138: Fix tests, system preference specification and options Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157485|0 |1 is obsolete| | --- Comment #90 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158414&action=edit Bug 18138: Use MARC modification template when adding/updating bibliographic records Add a preference that enables a specific marc modification template to be applied on bibliographic records saved using simple or advanced MARC editor or the HTTP API. To test: 1) Create a MARC modification template containg one or more actions. 2) Under "Global system preferences" and "Cataloging" set the "EditBiblioMarcModificationTemplate" preference to the name of the previously created template. 3) Edit (or create) a bibliographic record using either the simple or advanced MARC editor. 4) Save the record. 5) Verify that the action(s) have been applied. Sponsored-by: Gothenburg University Library Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157486|0 |1 is obsolete| | --- Comment #91 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158415&action=edit Bug 18138: (follow-up) Add Objects for MarcModificationTemplates Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157487|0 |1 is obsolete| | --- Comment #92 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158416&action=edit Bug 18138: (follow-up) Adjust the system preference editor to allow choosing a modification template Rather than expecting the librarian to add an ID or a name we should provide a dropdown To test: 1 - Apply all patches 2 - Search for sytem preference 'SaveBiblioMarcModificationTemplate' 3 - Note it list all defined Marc modification templates 4 - Select one 5 - confirm value in DB is the template id Works fine for me Signed-off-by: Frank Hansen <frank.hansen@ub.lu.se> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157488|0 |1 is obsolete| | --- Comment #93 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158417&action=edit Bug 18138: Refactor after using template id instead of name Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157489|0 |1 is obsolete| | --- Comment #94 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158418&action=edit Bug 18138: fix atomic update and system preference type Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157490|0 |1 is obsolete| | --- Comment #95 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158419&action=edit Bug 18138: Fix variable name Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #157491|0 |1 is obsolete| | --- Comment #96 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158420&action=edit Bug 18138: Fix tests, system preference specification and options Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 --- Comment #97 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158421&action=edit Bug 18138: (QA follow-up) Perltidy and 'staff client' * Perltidies files * Fix atomic update (description and success message) * Fix atomic update file permissions * Update 'staff client' to 'staff interface' Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #98 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) This one feels a little strange as it includes the advanced MARC editor and the old svc/HTTP API, but not the rest API. I can't test that API so I don't feel comfortable to pass QA here and would like to hand over to someone who can. 2) Are they really both needed? +use C4::MarcModificationTemplates; +use Koha::MarcModificationTemplates; 3) QA test tools I got them mostly to pass with my follow-ups, but _please_ don't rely on the QA team for those fixes, usually there is no time for such things. This seems a false positive, the file is new and I perltidied it, but this remains: WARN t/db_dependent/www/EditBiblioMarcModificationTemplatePreference.t WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 1) 4) Deleting the template breaks editors * Advanced editor no longer let's you save a record with an unspecific error message Logs: Carp::croak('No MARC modification template exists with id "13"') called at /kohadevbox/koha/svc/bib line 137 * Normal editor explodes into an error: No MARC modification template exists with id "13" at /usr/share/perl5/CGI/Compile.pm line 151. at /usr/lib/x86_64-linux-gnu/perl-base/Carp.pm line 289 I feel we need to handle this more gracefully. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158421|0 |1 is obsolete| | --- Comment #99 from David Gustafsson <glasklas@gmail.com> --- Created attachment 162612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162612&action=edit Bug 18138: (QA follow-up) Perltidy and 'staff client' * Perltidies files * Fix atomic update (description and success message) * Fix atomic update file permissions * Update 'staff client' to 'staff interface' Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 --- Comment #100 from David Gustafsson <glasklas@gmail.com> --- Created attachment 162613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162613&action=edit Bug 18138: Display error when template missing in advanced editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 --- Comment #101 from David Gustafsson <glasklas@gmail.com> --- Fixed 4), regarding 2), yes both are needed. Now when I had a look at this also discovered that modification templates are not applied when saving new biblio using the advanced editor. Easy to fix, but I am also beginning to reconsider whether this whole feature is a good idea to begin with. Also kind of wonder why did not decided to apply the template withing ModBibioMarc as that would simplify the code. The downside I guess is that templates would even be applied, even in cases where biblios are saved internally where it does perhaps do not make sense to do so. Also the error handling and user feedback would be harder to implement since AddBibio/ModBibio would either have to throw an error or return some error code and such a major change in behavior could have unforeseen consequences if not handles correctly in the entire code base. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org