[Bug 15916] New: Holds to pull table sorting broken by JavaScript error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15916 Bug ID: 15916 Summary: Holds to pull table sorting broken by JavaScript error Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/circ/pendingreserves.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org There is a JavaScript error on the holds to pull page which breaks table sorting. git blames Bug 15285, "Update common files." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15916 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15916 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- The same issue affects: circ/waitingreserves.pl circ/reserveratios.pl patron_lists/lists.pl virtualshelves/shelves.pl acqui/invoices.pl ...and presumably more. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15916 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Holds to pull table sorting |Regression: Many tables' |broken by JavaScript error |sorting broken by | |JavaScript error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15916 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Broken js on patron_lists/list.pl prevents patrons from being searched and thus prevents them from being added to a patron list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15916 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15925 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15925 [Bug 15925] Correct some markup issues with patron lists pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15916 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15916 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15481 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15916 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15916 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48431&action=edit Bug 15916: Datatables - buttons area should be defined Commit 243b797dd11bc0ac1f475195ab765ffbf2220f8b Bug 15285: Update common files Set 'B' to the default dom of Datatable constructor. This cannot work if there is no button defined. This patch defined an empty 'buttons' param for this constructor, DT does not raised an error anymore when initialising. Test plan: Confirm that the tables on the following tables are not broken: - circ/waitingreserves.pl - circ/reserveratios.pl - patron_lists/lists.pl - virtualshelves/shelves.pl - acqui/invoices.pl And with datatables: - circ/circulation.pl - admin/currency.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15916 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15916 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48431|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 48432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48432&action=edit Bug 15916: Datatables - buttons area should be defined Commit 243b797dd11bc0ac1f475195ab765ffbf2220f8b Bug 15285: Update common files Set 'B' to the default dom of Datatable constructor. This cannot work if there is no button defined. This patch defined an empty 'buttons' param for this constructor, DT does not raised an error anymore when initialising. Test plan: Confirm that the tables on the following tables are not broken: - circ/waitingreserves.pl - circ/reserveratios.pl - patron_lists/lists.pl - virtualshelves/shelves.pl - acqui/invoices.pl And with datatables: - circ/circulation.pl - admin/currency.pl Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15916 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15916 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48432|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 48479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48479&action=edit [PASSED QA] Bug 15916: Datatables - buttons area should be defined Commit 243b797dd11bc0ac1f475195ab765ffbf2220f8b Bug 15285: Update common files Set 'B' to the default dom of Datatable constructor. This cannot work if there is no button defined. This patch defined an empty 'buttons' param for this constructor, DT does not raised an error anymore when initialising. Test plan: Confirm that the tables on the following tables are not broken: - circ/waitingreserves.pl - circ/reserveratios.pl - patron_lists/lists.pl - virtualshelves/shelves.pl - acqui/invoices.pl And with datatables: - circ/circulation.pl - admin/currency.pl Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15916 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #6 from Brendan Gallagher <brendan@bywatersolutions.com> --- pushed to master - should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15916 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |julian.maurice@biblibre.com --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Does not concern stable versions, status changed to RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15916 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe.croullebois@bibl | |ibre.com --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 15915 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org