[Bug 24059] New: Remove unused Greybox assets from detail.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24059 Bug ID: 24059 Summary: Remove unused Greybox assets from detail.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: dcook@prosentient.com.au, josef.moravec@gmail.com, katrin.fischer@bsz-bw.de Blocks: 8290 The Greybox library is included on the bibliographic detail page in the staff client but doesn't seem to be required for anything. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 [Bug 8290] Replace usage of Greybox modals with Bootstrap modals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24059 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24059 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 95522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95522&action=edit Bug 24059: Remove unused Greybox assets from detail.tt This patch removes reference to the Greybox include file because it is unused. To test, apply the patch and view the bibliographic details page. Test various JavaScript-driven interactions to make sure no functionality has been broken: Menus, tabs, table filters, MARC Preview, etc. Searching for "gb-" or "GB_" should return no results in any files related to the details page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24059 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Depends on| |21891 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Usage removed by bug 21891. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21891 [Bug 21891] Remove non-XSLT detail view in the staff client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24059 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24059 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95522|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 96043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96043&action=edit Bug 24059: Remove unused Greybox assets from detail.tt This patch removes reference to the Greybox include file because it is unused. To test, apply the patch and view the bibliographic details page. Test various JavaScript-driven interactions to make sure no functionality has been broken: Menus, tabs, table filters, MARC Preview, etc. Searching for "gb-" or "GB_" should return no results in any files related to the details page. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24059 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24059 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96043|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 96584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96584&action=edit Bug 24059: Remove unused Greybox assets from detail.tt This patch removes reference to the Greybox include file because it is unused. To test, apply the patch and view the bibliographic details page. Test various JavaScript-driven interactions to make sure no functionality has been broken: Menus, tabs, table filters, MARC Preview, etc. Searching for "gb-" or "GB_" should return no results in any files related to the details page. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24059 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24059 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24059 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24059 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |joy@bywatersolutions.com --- Comment #6 from Joy Nelson <joy@bywatersolutions.com> --- not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org