https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16469 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 51298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51298&action=edit Bug 16469 - Remove the use of "onclick" from some catalog pages This patch removes the use of "onclick" attributes from two catalog-related templates: The local cover image viewer and the search results page. Events are now defined in JavaScript. To test: On the search results page: - Perform a catalog search which will return multiple results. - On the search results page, confirm that the "Select all" and "Clear all" links at the top of the results table work correctly. In the local cover image viewer: - The LocalCoverImages and AllowMultipleCovers system preferences must enabled, and at least one catalog record must have at least two local cover images attached. - Locate that record in the catalog and view the detail page for it. - Click the cover image in the "Images" tab to go to the image viewer page. - Clicking each local cover image thumnail should correctly display the larger version of each image. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16469 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@ptfs-europe.com Status|Needs Signoff |Signed Off --- Comment #3 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Patch tested with a sandbox, by Nikos Chatzakis, Afrodite Malliari <nchatzakis@datascouting.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16469 --- Comment #4 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 51978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51978&action=edit Bug 16469 - Remove the use of "onclick" from some catalog pages This patch removes the use of "onclick" attributes from two catalog-related templates: The local cover image viewer and the search results page. Events are now defined in JavaScript. To test: On the search results page: - Perform a catalog search which will return multiple results. - On the search results page, confirm that the "Select all" and "Clear all" links at the top of the results table work correctly. In the local cover image viewer: - The LocalCoverImages and AllowMultipleCovers system preferences must enabled, and at least one catalog record must have at least two local cover images attached. - Locate that record in the catalog and view the detail page for it. - Click the cover image in the "Images" tab to go to the image viewer page. - Clicking each local cover image thumnail should correctly display the larger version of each image. https://bugs.koha-community.org/show_bug.cgi?id=16249 Signed-off-by: Nikos Chatzakis, Afrodite Malliari <nchatzakis@datascouting.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16469 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16469 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for Koha 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16469 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.