http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14553 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 41114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41114&action=edit Bug 14553: Silencing warn triggered when clearing item rating on OPAC To test: 1) Go to any item and clear the star rating (don't have to set a rating first) 2) Notice the warn 3) Apply patch and reload page 4) Clear star rating 5) Notice no warn 6) Click a star to add a rating 7) Make sure your rating, the average rating and amount of votes are all correct 8) Could be beneficial to log in as another user and try to add a rating on the same item from their account. Check the average rating is cacalculated and amount of votes increases 9) Confirm still no warns -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14553 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14553 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41114|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 44748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44748&action=edit Bug 14553: Silencing warn triggered when clearing item rating on OPAC To test: 1) Go to any item and clear the star rating (don't have to set a rating first) 2) Notice the warn 3) Apply patch and reload page 4) Clear star rating 5) Notice no warn 6) Click a star to add a rating 7) Make sure your rating, the average rating and amount of votes are all correct 8) Could be beneficial to log in as another user and try to add a rating on the same item from their account. Check the average rating is cacalculated and amount of votes increases 9) Confirm still no warns Signed-off-by: Frederic Demians <f.demians@tamil.fr> Can see the warning in logs, and its disappearance with this patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14553 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44748|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44759&action=edit Bug 14553: Silencing warn triggered when clearing item rating on OPAC To test: 1) Go to any item and clear the star rating (don't have to set a rating first) 2) Notice the warn 3) Apply patch and reload page 4) Clear star rating 5) Notice no warn 6) Click a star to add a rating 7) Make sure your rating, the average rating and amount of votes are all correct 8) Could be beneficial to log in as another user and try to add a rating on the same item from their account. Check the average rating is cacalculated and amount of votes increases 9) Confirm still no warns Signed-off-by: Frederic Demians <f.demians@tamil.fr> Can see the warning in logs, and its disappearance with this patch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14553 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14553 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz Status|Pushed to Master |Pushed to Stable --- Comment #6 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.13, and released. -- You are receiving this mail because: You are watching all bug changes.