https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 64767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64767&action=edit Bug 18888 - Currency defined in new onboardingstep6.tt after installation Test plan: 1. Restart memcached and drop and recreate your database 2. Go through the Koha web installer making sure to install all data except the currencies 3. Run through the onboarding tool noticing that after creating the circulation rule the complete page appears and you can click to log into Koha with the superlibrarian user you have created in the onboarding tool 4. Apply patch 5. Repeat step 1, and 2 6. Run through the onboarding tool and notice that after creating the circulation rule, a screen appears for you to define a currency 7. Write in the currency name and symbol (notice: you cannot edit the exchange rate of 1) and submit the form 8. Notice the complete screen appears and you can log in with the superlibrarian account created in the onboarding tool 9. Go to Administration->Currencies and exchange rates and notice that the currency you created in the onboarding tool is displayed as active 10. Repeat step 1 11. Go through the Koha web installer making sure to install all data including currencies 12. Run through the onboarding tool and notice that after creating the circulation rule then the complete screen appears and click to log into Koha with your superlibrarian account 13. Run qa tool and all tests should be successful 14. Sign off Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64767|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 64771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64771&action=edit Bug 18888 - Currency defined in new onboardingstep6.tt after installation Test plan: 1. Restart memcached and drop and recreate your database 2. Go through the Koha web installer making sure to install all data except the currencies 3. Run through the onboarding tool noticing that after creating the circulation rule the complete page appears and you can click to log into Koha with the superlibrarian user you have created in the onboarding tool 4. Apply patch 5. Repeat step 1, and 2 6. Run through the onboarding tool and notice that after creating the circulation rule, a screen appears for you to define a currency 7. Write in the currency name and symbol (notice: you cannot edit the exchange rate of 1) and submit the form 8. Notice the complete screen appears and you can log in with the superlibrarian account created in the onboarding tool 9. Go to Administration->Currencies and exchange rates and notice that the currency you created in the onboarding tool is displayed as active 10. Repeat step 1 11. Go through the Koha web installer making sure to install all data including currencies 12. Run through the onboarding tool and notice that after creating the circulation rule then the complete screen appears and click to log into Koha with your superlibrarian account 13. Run qa tool and all tests should be successful 14. Sign off Sponsored-by: Catalyst IT Folloewe test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Version|17.05 |master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_17_11_candidate | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=3578 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community |https://bugs.koha-community |.org/bugzilla3/show_bug.cgi |.org/bugzilla3/show_bug.cgi |?id=3578 |?id=3758 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As 4078 is now PQA, I agree with Jonathan. Alex, can you please take a look? Sorry! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #6 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- (In reply to Jonathan Druart from comment #3)

Maybe this patch should take into account the new fields that will be added by bug 4078.

Hello, please can you outline exactly what is needed to move this patch forward? a column needs to be added to the currency table? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 --- Comment #8 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 86709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86709&action=edit Bug 18888: (follow-up) Updated Currency onboarding step to match DB Between the time that this patch was originally created and now, a field has been added to the currency table which allows the user to specify whether the currency should appear with a space between the symbol and value. This patch updates the onboarding tool to accommodate that option, as well as cleans up some issues with script tags and duplicate entries to the DB. Test plan: 1) Drop and recreate your database, then restart_all 2) Go through the web installer and install all data except the currencies 3) Go through the onboarding tool and note that when you get to the currency page that there is no option for setting there to be a space between symbol and value 4) Apply the patch, and repeat step 1 and 2 5) Go through the onboarding tool again and this time note that on the currency page there is an option to set there to be a space between symbol and value - check this box. 6) Continue on to Koha 7) Apply a fine to a patron, log in as that patron, and verify that the currency is displayed with a space between the symbol and the value in the OPAC 8) Also verify that there is only one currency (the one you created) in the currency table in your database Note: This patch may fail the QA tools due to Asset not working with the installer. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 --- Comment #9 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 86710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86710&action=edit Bug 18888: (follow-up) Fixed script tag for QA tools Removed type reference in the script tag in onboardingstep6.tt - Note: the QA tools will still fail this tag for using a full path rather than Asset. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18308 --- Comment #10 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- This bug should depend on Bug 18308 as it is part of the onboarding tool. I will fix it to reflect this. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 [Bug 18308] Default value of minPasswordLength should be increased -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com Status|Needs Signoff |Failed QA --- Comment #12 from Liz Rea <wizzyrea@gmail.com> --- Hi, At step 7, I've got Template process failed: file error - /home/vagrant/kohaclone/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep7.tt : not found at /home/vagrant/kohaclone/C4/Templates.pm line 122 After clicking "submit" on the define a currency page. Something I had not noticed before in the onboarder, is that the "next" buttons all say Submit on them. I think I'd rather they say something like "save and continue" or "Next" instead, as Submit is a developer word for what the button is/does. That doesn't need to be fixed here, but I may file another bug for it. Thanks for having another look, Liz -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21265 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21265 [Bug 21265] Additional step at end of onboarder to enable HEA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87574|0 |1 is obsolete| | Attachment #87687|0 |1 is obsolete| | --- Comment #15 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 87691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87691&action=edit Bug 18888: Updated Currency onboarding step to match DB Between the time that the original patch was created and now, a field has been added to the currency table which allows the user to specify whether the currency should appear with a space between the symbol and value. This patch updates the onboarding tool to accommodate that option, as well as cleans up some issues with script tags and duplicate entries to the DB. This patch depends on Bug 18308, building on the steps that have been rearranged. Test plan: 0) Apply patch 18308. 1) Drop and recreate your database, then restart_all 2) Go through the onboarding tool, noting that the order matches the following: 1 Create a library 2 Create patron category 3 Set minPasswordLength 4 Create Koha administrator 5 Create item type 6 Define currency (see step 3!) 7 Circulation rule/Complete 3) Note that when you get to the currency page that there is no option for setting there to be a space between symbol and value 4) Apply this patch, and repeat step 1 - 3 5) Go through the onboarding tool again and this time note that on the currency page there is an option to set there to be a space between symbol and value - check this box. 6) Continue on to Koha 7) Apply a fine to a patron, log in as that patron, and verify that the currency is displayed with a space between the symbol and the value in the OPAC 8) Also verify that there is only one currency (the one you created) in the currency table in your database Note: This patch may fail the QA tools due to Asset not working with the installer. Sponsored-by: Catalyst IT Signed-off-by: Liz Rea <wizzyrea@gmail.com> I confirm that the QA tool has a false positive for Asset. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22681 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22681 [Bug 22681] Onboarder: buttons should say "next" instead of "submit" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22655 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22655 [Bug 22655] Onboarding tool should offer to add Hold rule in addition to Circulation rule -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Patch doesn't apply CC| |victor@tuxayo.net --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Dependency not blocking anymore but rebase needed -- You are receiving this mail because: You are watching all bug changes.