[Bug 22761] New: Move "Fee reciept" from template to a slip
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Bug ID: 22761 Summary: Move "Fee reciept" from template to a slip Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Target Milestone: --- Some libraries would like to be able to customize the "Fee receipt". It makes sense to move the content of members/printfeercpt.pl to a the print section of the ACCOUNT_PAYMENT slip. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 10708 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've chosen to mark the other bug a duplicate in this case to have a fresh start. Making this the print version of the ACCOUNT_PAYMENT slip makes sense on first glance, but I wonder how best to deal with libraries that want to have the print on demand but not activate the email functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe a different slip template would work better? And leave the print on ACCOUNT_PAYMENT for a letter? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move "Fee reciept" from |Move "Fee receipt" from |template to a slip |template to a slip -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 88552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88552&action=edit Bug 22761: Add ability to use print version of ACCOUNT_PAYMENT/ACCOUNT_WRITEOFF" slip -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 88553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88553&action=edit Bug 22761: Add notice based on existing template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 88554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88554&action=edit Bug 22761: Remove hard coded version from template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Claudio <costalc@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |costalc@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88552|0 |1 is obsolete| | Attachment #88553|0 |1 is obsolete| | Attachment #88554|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 88557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88557&action=edit Bug 22761: Add ability to use print version of ACCOUNT_PAYMENT/ACCOUNT_WRITEOFF" slip -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 88558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88558&action=edit Bug 22761: Add notice based on existing template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 88559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88559&action=edit Bug 22761: Remove hard coded version from template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #3)
Maybe a different slip template would work better? And leave the print on ACCOUNT_PAYMENT for a letter?
Good thinking. I've updated the patch set. Once it has passed qa, I'll add the additional translated versions of the slip in a followup! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #11 from Claudio <costalc@gmail.com> --- Great! It would be nice to be able to customize members/printinvoice.pl too (see image attached) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #12 from Claudio <costalc@gmail.com> --- Created attachment 88560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88560&action=edit printinvoice.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com --- Comment #13 from Michal Denar <black23@gmail.com> --- Hi Kyle, any test plan? Than you. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Test Plan: 1) Apply this patch set 2) Restart all the things 3) Use the "print" button beside a *payment* 4) You should not see any difference from before the patches were applied -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Claudio from comment #11)
Great! It would be nice to be able to customize members/printinvoice.pl too (see image attached)
I'm planning on submitting another patch set on another bug for printinvoice.pl ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #16 from Claudio <costalc@gmail.com> --- (In reply to Kyle M Hall from comment #15)
(In reply to Claudio from comment #11)
Great! It would be nice to be able to customize members/printinvoice.pl too (see image attached)
I'm planning on submitting another patch set on another bug for printinvoice.pl ;)
Thanks Kyle! (in spanish: Respiro aliviado!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #17 from Michal Denar <black23@gmail.com> --- Hi kyle, thank you for test plan. I've found problem. Print button on "red" paymets works well. But on "green" files open blank page. Please see video: http://g.recordit.co/shRFPo3XB9.gif -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Michal Denar from comment #17)
Hi kyle, thank you for test plan. I've found problem. Print button on "red" paymets works well. But on "green" files open blank page. Please see video: http://g.recordit.co/shRFPo3XB9.gif
I'm completely unable to reproduce this. Can you test this latest version of the patch set? If you are still seeing this can you provide specific steps to reproduce what you are seeing? Thanks! Kyle -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Michal Denar from comment #17)
Hi kyle, thank you for test plan. I've found problem. Print button on "red" paymets works well. But on "green" files open blank page. Please see video: http://g.recordit.co/shRFPo3XB9.gif
On further review of your gif, it seems pretty clear that you don't have the slip configured. I think there was an sql error in the old patch set that has been corrected in this new one! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88560|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88557|0 |1 is obsolete| | Attachment #88558|0 |1 is obsolete| | Attachment #88559|0 |1 is obsolete| | --- Comment #20 from Michal Denar <black23@gmail.com> --- Created attachment 88622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88622&action=edit Bug 22761: Add ability to use print version of ACCOUNT_PAYMENT/ACCOUNT_WRITEOFF" slip Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #21 from Michal Denar <black23@gmail.com> --- Created attachment 88623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88623&action=edit Bug 22761: Add notice based on existing template Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #22 from Michal Denar <black23@gmail.com> --- Created attachment 88624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88624&action=edit Bug 22761: Remove hard coded version from template Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88622|0 |1 is obsolete| | Attachment #88623|0 |1 is obsolete| | Attachment #88624|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 88629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88629&action=edit Bug 22761: Add ability to use print version of ACCOUNT_CREDIT slip Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 88630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88630&action=edit Bug 22761: Add notice based on existing template Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 88631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88631&action=edit Bug 22761: Remove hard coded version from template Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Forgot to update the patch title when I changed the letter code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 88629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88629 Bug 22761: Add ability to use print version of ACCOUNT_CREDIT slip Review of attachment 88629: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22761&attachment=88629) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt @@ +19,5 @@
<div id="receipt"> + +[% IF letter %] + [% letter.content | evaltt %]
evaltt? ::: members/printfeercpt.pl @@ +83,2 @@
$template->param(
There are more parameters than before, I would expect less. Is that correct? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize@ptfs-europe |testopia@bugs.koha-communit |.com |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #27)
Comment on attachment 88629 [details] [review] Bug 22761: Add ability to use print version of ACCOUNT_CREDIT slip
Review of attachment 88629 [details] [review]: -----------------------------------------------------------------
::: koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt @@ +19,5 @@
<div id="receipt"> + +[% IF letter %] + [% letter.content | evaltt %]
evaltt?
I've found this: http://www.template-toolkit.org/docs/manual/Filters.html#section_eval_evaltt I assume that letter.content contains TT markup in that case?
::: members/printfeercpt.pl @@ +83,2 @@
$template->param(
There are more parameters than before, I would expect less. Is that correct?
Should we move this to failed QA to get a quick answer from Kyle or can we continue here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #28)
(In reply to Jonathan Druart from comment #27)
Comment on attachment 88629 [details] [review] [review] Bug 22761: Add ability to use print version of ACCOUNT_CREDIT slip
Review of attachment 88629 [details] [review] [review]: -----------------------------------------------------------------
::: koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt @@ +19,5 @@
<div id="receipt"> + +[% IF letter %] + [% letter.content | evaltt %]
evaltt?
I've found this: http://www.template-toolkit.org/docs/manual/Filters.html#section_eval_evaltt
I assume that letter.content contains TT markup in that case?
::: members/printfeercpt.pl @@ +83,2 @@
$template->param(
There are more parameters than before, I would expect less. Is that correct?
Should we move this to failed QA to get a quick answer from Kyle or can we continue here?
There are more parameters because I made the slip compatible with the existing syntax for the ACCOUNT_PAYMENT/ACCOUNT_WRITEOFF slips. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com, | |kyle.m.hall@gmail.com Component|Cataloging |Circulation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> ---
I've found this: http://www.template-toolkit.org/docs/manual/Filters.html#section_eval_evaltt
I assume that letter.content contains TT markup in that case?
You are correct! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22809 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22809 [Bug 22809] Move "INVOICE" from template to a slip -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88629|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89222&action=edit Bug 22761: Add ability to use print version of ACCOUNT_CREDIT slip Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88630|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89223&action=edit Bug 22761: Add notice based on existing template Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88631|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89224&action=edit Bug 22761: Remove hard coded version from template Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89225&action=edit Bug 22761: (QA follow-up) Add notice translations Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works well for me, no regressions found and the changes all make sense. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 89227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89227&action=edit Bug 22761: (QA follow-up) Add description to DB update Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #37 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Some notes about this: 1. The TT content has been moved but without being adjusted. For instance: - Should not we use library.branchname instead of LibraryName (otherwise we will have to pass 'LibraryName' to all our templates)? - Branches.GetName( patron.branchcode ), should not we prefer patron.library.branchname? If we do not know what is sent/used in the template, it will be a nightmare to provide backward compatibility in next versions. 2. About evaltt, I really do not understand why we need it, the template has been parsed already, we should not need to parse it again, I think the content must be displayed with $raw 3. + library => C4::Context::mybranch, so library will be the branchcode, whereas we are expecting a Koha::Library object (In reply to Kyle M Hall from comment #29)
::: members/printfeercpt.pl @@ +83,2 @@
$template->param(
There are more parameters than before, I would expect less. Is that correct? There are more parameters because I made the slip compatible with the existing syntax for the ACCOUNT_PAYMENT/ACCOUNT_WRITEOFF slips.
I am sorry but I still do not understand that part. The variable we do not see in the template will not be used, so for instance 'credit' is useless. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- GetPreparedLetter is actually not called, hence the confusion. Is there a good reason not to? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rbit@rbit.cz --- Comment #40 from Michal Denar <black23@gmail.com> --- *** Bug 17551 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Version(s)| |19.05.00 released in| | Status|Pushed to Master |RESOLVED --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement allows the release notes| |'Fee receipt' to be | |configurable by the library | |in the Tools->Notices and | |slips page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 23325 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23325 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23325 [Bug 23325] Print receipt from staff client should be a choice of slip type -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|23325 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23325 [Bug 23325] Print receipt from staff client should be a choice of slip type -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24381 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 [Bug 24381] ACCOUNT_CREDIT slip not printing information about paid fines/fees -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24381 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24381 [Bug 24381] ACCOUNT_CREDIT and ACCOUNT_DEBIT slip not printing information about paid fines/fees -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org